From: Joe Perches <joe@perches.com>
To: Vlastimil Babka <vbabka@suse.cz>,
Christoph Hellwig <hch@infradead.org>,
Lorenzo Stoakes <lstoakes@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] mm/filemap: clarify filemap_fault() comments for not uptodate case
Date: Mon, 02 Oct 2023 02:43:41 -0700 [thread overview]
Message-ID: <6fb3fa0fe3e53d6e31c8ab6f96a9549da1d659f0.camel@perches.com> (raw)
In-Reply-To: <a610eab7-4651-27e0-7283-b7ac4ea34cf3@suse.cz>
On Mon, 2023-10-02 at 08:39 +0200, Vlastimil Babka wrote:
> On 10/2/23 08:26, Christoph Hellwig wrote:
> > > + * If the invalidate lock is not held, the folio was in cache and
> > > + * uptodate and now it is not. Strange but possible since we
> >
> > Please don't spill block comments ôver the 80 charater limit, that makes
> > them impossible to read nicely.
>
> Joe, can we revert the default to 80 to avoid everyone having to alias
> --max-line-length=80 locally?
Given the current --max-line-length default is 100,
and that was Linus' preference, I think not.
https://lore.kernel.org/lkml/CAHk-=wj3iGQqjpvc+gf6+C29Jo4COj6OQQFzdY0h5qvYKTdCow@mail.gmail.com/
and
https://lore.kernel.org/lkml/CAHk-=wjR0H3+2ba0UUWwoYzYBH0GX9yTf5dj2MZyo0xvyzvJnA@mail.gmail.com/
next prev parent reply other threads:[~2023-10-02 9:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 23:10 Lorenzo Stoakes
2023-10-02 6:26 ` Christoph Hellwig
2023-10-02 6:39 ` Vlastimil Babka
2023-10-02 9:43 ` Joe Perches [this message]
2023-10-02 6:47 ` Lorenzo Stoakes
2023-10-02 6:50 ` Christoph Hellwig
2023-10-02 9:55 ` Jan Kara
2023-10-02 16:02 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fb3fa0fe3e53d6e31c8ab6f96a9549da1d659f0.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lstoakes@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox