From: David Hildenbrand <david@redhat.com>
To: Qian Cai <cai@lca.pw>
Cc: akpm@linux-foundation.org, mhocko@kernel.org,
sergey.senozhatsky.work@gmail.com, pmladek@suse.com,
rostedt@goodmis.org, peterz@infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH -next v4] mm/hotplug: silence a lockdep splat with printk()
Date: Fri, 17 Jan 2020 13:53:17 +0100 [thread overview]
Message-ID: <6f924bf7-835b-0176-1b12-aff4f1f4be0e@redhat.com> (raw)
In-Reply-To: <6BED7E12-CC3B-4AED-ACC8-F3533D3F3C70@lca.pw>
On 17.01.20 13:40, Qian Cai wrote:
>
>
>> On Jan 17, 2020, at 3:51 AM, David Hildenbrand <david@redhat.com> wrote:
>>
>> -> you are accessing the pageblock without the zone lock. It could
>> change to "isolate" again in the meantime if I am not wrong!
>
> Since we are just dumping the state for debugging, it should be fine to accept a bit inaccuracy here due to racing. I could put a bit comments over there.
>
Can't we just use the zone_idx() stored in the memmap instead?
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-01-17 12:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 2:21 Qian Cai
2020-01-17 2:49 ` Sergey Senozhatsky
2020-01-17 8:51 ` David Hildenbrand
2020-01-17 8:59 ` Michal Hocko
2020-01-17 9:25 ` David Hildenbrand
2020-01-17 9:40 ` Michal Hocko
2020-01-17 9:42 ` David Hildenbrand
2020-01-17 10:17 ` Michal Hocko
2020-01-17 10:18 ` David Hildenbrand
2020-01-17 12:40 ` Qian Cai
2020-01-17 12:53 ` David Hildenbrand [this message]
2020-01-17 13:30 ` Qian Cai
2020-01-17 13:42 ` David Hildenbrand
2020-01-17 14:42 ` Michal Hocko
2020-01-17 14:43 ` David Hildenbrand
2020-01-17 15:26 ` Michal Hocko
2020-01-17 8:59 ` Michal Hocko
2020-01-17 12:32 ` Qian Cai
2020-01-17 14:39 ` Michal Hocko
2020-01-17 15:05 ` Qian Cai
2020-01-17 15:46 ` Michal Hocko
2020-01-17 18:49 ` Qian Cai
2020-01-17 19:15 ` David Hildenbrand
2020-01-17 19:42 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f924bf7-835b-0176-1b12-aff4f1f4be0e@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox