linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@linux.ibm.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
	Ignacio Moreno Gonzalez <Ignacio.MorenoGonzalez@kuka.com>,
	kernel test robot <lkp@intel.com>,
	oe-kbuild-all@lists.linux.dev,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	Yang Shi <yang@os.amperecomputing.com>,
	Janosch Frank <frankja@linux.ibm.com>,
	David Hildenbrand <david@redhat.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Sven Schnelle <svens@linux.ibm.com>,
	kvm@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-kernel@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [akpm-mm:mm-new 320/331] arch/s390/kvm/gaccess.c:321:2: error: expected identifier
Date: Wed, 14 May 2025 16:52:18 +0200	[thread overview]
Message-ID: <6f8f3780-902b-49d4-a766-ea2e1a8f85ea@linux.ibm.com> (raw)
In-Reply-To: <20250514164822.4b44dc5c@p-imbrenda>



Am 14.05.25 um 16:48 schrieb Claudio Imbrenda:

>>>>> A possible fix for this would be to rename PROT_NONE in the enum to PROT_TYPE_NONE.
>>>
>>> please write a patch to rename PROT_NONE in our enum to
>>> PROT_TYPE_DUMMY, I can review it quickly.
>>>
>>> if Paolo has no objections, I'm fine with having the patch go through
>>> the mm tree
>>
>> Yes, lets do a quick fix and I can also do
>> Acked-by: Christian Borntraeger <borntraeger@linux.ibm.com>
>>
>> for a s/PROT_NONE/PROT_TYPE_NONE/g
>> patch.
> 
> I'd rather have PROT_TYPE_DUMMY, since it's a dummy value and not
> something that indicates "no protection"

makes sense.


  reply	other threads:[~2025-05-14 14:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-14  1:05 kernel test robot
2025-05-14 13:28 ` Ignacio Moreno Gonzalez
2025-05-14 13:48   ` Lorenzo Stoakes
2025-05-14 14:27     ` Claudio Imbrenda
2025-05-14 14:39       ` Christian Borntraeger
2025-05-14 14:48         ` Claudio Imbrenda
2025-05-14 14:52           ` Christian Borntraeger [this message]
2025-05-14 16:01             ` Lorenzo Stoakes
2025-05-14 16:10               ` Claudio Imbrenda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6f8f3780-902b-49d4-a766-ea2e1a8f85ea@linux.ibm.com \
    --to=borntraeger@linux.ibm.com \
    --cc=Ignacio.MorenoGonzalez@kuka.com \
    --cc=agordeev@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=pbonzini@redhat.com \
    --cc=svens@linux.ibm.com \
    --cc=yang@os.amperecomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox