From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19C1EC369D9 for ; Wed, 30 Apr 2025 21:49:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 463396B000A; Wed, 30 Apr 2025 17:49:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 412026B00AF; Wed, 30 Apr 2025 17:49:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 263796B00B5; Wed, 30 Apr 2025 17:49:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 04C5B6B000A for ; Wed, 30 Apr 2025 17:49:04 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EF1C2140E89 for ; Wed, 30 Apr 2025 21:49:04 +0000 (UTC) X-FDA: 83392051008.27.B76F4D3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 58E644000C for ; Wed, 30 Apr 2025 21:49:02 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XKpLgFYo; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746049742; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H93od5gfQiZ9os9QHpxGC4NNrVZwvxbInacKsWRyTJI=; b=Wn+jvu6S2UPLzOoAggkSnMHSx20/3E3LqiJyYHwoNaxd2rTfs2IMYwl0GS+f7NBL23wdl0 LHT6xcmKJF2OFDa4r1BBXpShggIgm7SBUbyTLD2JdojUZ1dY087/3Zi8FKItXKKUSkg2ji YwR916Cjlrbb18wC9I3pCqjjPdUII4o= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XKpLgFYo; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746049742; a=rsa-sha256; cv=none; b=wmlrGgZ4pi5uZ/1w4SOQoPpdCScUVRvjmGs+kKZnwp9lFlFQAsJNe5IheuD6xfGY5S/Azf WYN/ISXcs+F5HJ9040EwlltDk245nPjGE0hfud4CTXhv51dbKGjpMrS7m8BsFSLKjkViPe +40iOZ9CqUMpU/3E6E9+vPf6dDfIzXM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746049741; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=H93od5gfQiZ9os9QHpxGC4NNrVZwvxbInacKsWRyTJI=; b=XKpLgFYo3nfsFf+GysfVpQCaU8hZrlmTnTG2TD2+ez5ENAEBrJfI9P7oASkLU+BsiJXTWa ZHK0FM8JCY0QOlo4VJAqmrX31h61ciFZ/K9JMChcW5Aj7qH9Cn0KBAbaGpdJLZ6wtzTE4u oELPUPgXxflI/hnKttddiMDjOdpydXs= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-133-WU4gIjYwNtaV9j6QjpLC8w-1; Wed, 30 Apr 2025 17:49:00 -0400 X-MC-Unique: WU4gIjYwNtaV9j6QjpLC8w-1 X-Mimecast-MFC-AGG-ID: WU4gIjYwNtaV9j6QjpLC8w_1746049739 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43941ad86d4so1019535e9.2 for ; Wed, 30 Apr 2025 14:49:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746049739; x=1746654539; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=H93od5gfQiZ9os9QHpxGC4NNrVZwvxbInacKsWRyTJI=; b=F0klOnV014mLTWgGU0l6uRrrQM1HGGvHIDKxPIkcB75Gy6PggD6/Z3l9ZAccJCE6Ni jDUxpak58VcCNmmi0XGIVM6bAfHXKIaFqnPxUWl78ERC+GWBz++3V8ekf9gXHMRfCxbK 8kZvjrHaX6OkCZpkCviBZyF+51WuXdLDSZepk6T5bIlb0IdIpRO7IWu35r1gg/UoJ3TB 4k4ZkylyapGloS9hdTPTW9+QtkhXe+72e4FgiM+QAKDcSoR5kNYrVFiHxUay2plsub18 At0UFYpeHX/9j0bHeIh7/uMxweHQAyFNZ2EstIt8o2NJry6d9YhbHm+01T4zs0fENNuo aAUw== X-Forwarded-Encrypted: i=1; AJvYcCU+RqmTEIDMnxtwaFpSz26nRId+U52yfnB3MJ4uWYP1jcA7s+uRqtrPZr1MOuXYp83Wmnp/yyLNsA==@kvack.org X-Gm-Message-State: AOJu0Ywu+B7ej1d0BDx6Xc3B0hfQ9ETG01vt7sjSmTqVIeKXN/0+0Fj8 pfKRiIjBJzHjhbY2dVWsL42ajN/+P9lnq2kwgHd9ogNmN10FlTLCvvbpa10vLRnJU5ErdcBiBD7 heP5YhSiHlI+zdoBJVY8gGM3JDe6wIQT270CRYO/AHl4u5c0r X-Gm-Gg: ASbGncu/bIC2SY3Kudz+aCr1mpFLbekyY3MIO8+APzpz2NbU+gW45UeTU3Yp8gGs+AL lkrzt/bLe9VC3MQjfqxu0b66ETS3VpJlCp0VlA+64TVY4GiBzSrjFJcrlOX/pdazCH9lLkHAu9k gNpKFGVmxeUv0xPVyWoHyIRRmqUikTEjO2crPPegPDt3ymqJQeyVMYtuNQLw+5JBSEvFClitdet CUBEGu+KBZ/FWx4AeVMg/JtgmBj/mWnNE0F45lqc2DRzmcjx/TvF4+Dc4Ac53YGNrmRmcvHymaX jhleZIE61mk9o/xUQbXqArfSLUeOPyo4PMWLOy1C1jMBgXXI7noRccgrzM6X3EYhZQdMvjgT3qv 3ULgW1f7hmI7YO1TZbzLK2meKmuJmpQK7sd4lQ/k= X-Received: by 2002:a05:6000:2481:b0:391:300f:7474 with SMTP id ffacd0b85a97d-3a093035869mr528909f8f.18.1746049739310; Wed, 30 Apr 2025 14:48:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEVJi2ui4UnXOF9lPFE13tViuULg5owU8+pUpdLTPlnCxCSH8706nAUMXYCmV24wEs5UzNWkA== X-Received: by 2002:a05:6000:2481:b0:391:300f:7474 with SMTP id ffacd0b85a97d-3a093035869mr528899f8f.18.1746049738997; Wed, 30 Apr 2025 14:48:58 -0700 (PDT) Received: from ?IPV6:2003:cb:c745:a500:7f54:d66b:cf40:8ee9? (p200300cbc745a5007f54d66bcf408ee9.dip0.t-ipconnect.de. [2003:cb:c745:a500:7f54:d66b:cf40:8ee9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b2bbc62bsm37599585e9.32.2025.04.30.14.48.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Apr 2025 14:48:58 -0700 (PDT) Message-ID: <6f75ef86-29fd-41a1-95ba-f42f7c3bd6ce@redhat.com> Date: Wed, 30 Apr 2025 23:48:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm/gup: Remove unnecessary check in memfd_pin_folios() To: "Vishal Moola (Oracle)" , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Vivek Kasireddy , Andrew Morton References: <20250430010059.892632-1-vishal.moola@gmail.com> <20250430010059.892632-2-vishal.moola@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250430010059.892632-2-vishal.moola@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: s-uojHZ-0iFgU1h7pw7exB7AkYyrFXFxoIG_7iyNiaI_1746049739 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 58E644000C X-Stat-Signature: 1wkos9u5wioipuihkx385pc98smocsgh X-HE-Tag: 1746049742-320142 X-HE-Meta: U2FsdGVkX19qftAlUCze534rQ75HKaEZ0DdAha2nTNUQoIdr5oCSe85llwG56hzTWp/KW/eSygth7ksoDxalOQAikgVRn43caiONr7hQH9RhKBwgPXoQUHuvyvVFBg2ERFzyIXdFnh1Z2QxHEcActJCato7endfZlBBFOqGAlV2DyCsCoJz1zfzMJ2WRF668d4sj/vv+4kbWMVIoyjbCMTc/kjFRfzdLgtxLk2Ae50OPD4GtLDahLHc8HRL1ddYEok//yQi2h1O3vrdQBcTxN8aE/x2ia9ptY/d9t7rC+OdZuNuHh16YMaaLQ2eQTaQ6rIccDZXgyXBObISmQztAybeRPnwknhrHHJoscFu2I8yScvTL35juKi8WyptuRkqTh349t1ev4NFhte3+KtECfLiCdgiwELBtLdMBSYmp3JkQEYxSpcGUviwBUPJzxlPAFX6UEz4TOIKgH6pjpSPyJyIWFSZKl42eVZQOJxZiSvBkWbz1AubnfJkTxLI4w8cU7pfjLuOjjsZZ61oSBWxJjEwiW+EM2F5K3YdBIJgetpA4Mdoh+cBymwgqM9PnYv7+7SmucU03Tofs3+LQoBTjwhz435Dne2P6EfbKUbaBkyu6BKxdZX356IyUZKGmaSUe0azNyq+SlI9DsjYujwhDQ2Bhv5MJt/h++8ymEperGaCXDt7UYheSxcKDpqk0RgQ4/O5vBA+7ctQpovqepeWre8l1WxNJ7Ly7k6fUrlwyemPgM9wkV572ioY5rI8eoc4Op3I1DFZnXQql/7ddMYMNBZSYQNUBpDLnorXec0KXaMKPUsKETYBQstM4/cvGevXgbzqLPIHwic73tRRcGNjrJD0OWsyM/u+HgOheJX1xSippWpVhSsSCvTsFCpg5XjWG/m5xROT4IGHVcGcAwvB9XnwItbvBVz1lyzG9xJQBV2dvOsyZ7Dg8ijMjjcxP7VC96lAn4GTUbqbkvDkgFnc puOtHX2n o2BOopQTU2afbo4Ll2IqybrL7/z/EURwxyl/l+RMNHZDZEogEMqCajOEAaVSx8/e19NC+SHJMjaSAxlTRjYicMyVNsxv6f7u8uFnESQTQyMB9xjfYuD4Owp11vsa3uO3uB2Q3XGgnIN6UMFw9cffmfz7348Rwtc/ecxbeNWyTaPbKmAZ8lQrr+8fgH/1xXKpqKYhquM0/F+Ej/3QJ2irvR4EJCZL9JwnX6T9m/pG3i1KzFZdXDKs/e4VrKvV+E0990slvfN3/7Ved7fXmOCa366IPpLxgqCo8xU4X/3GlgdaR0lRBpAgzUHYTRL9yKdFdqZihz/0yqMV1CJ1HRIilgibg6afnazWV1DNFTUxrLgbZPXDlXvuylNxY2vlPJQx24PUOITg1mjuU9/zp0yra8pVNbN483vRIfq/YCQ3Wa5AxcqqEi8k8+vzNDZaZLKbrPo58C4ukEVdP4F21GGen8h1UB4eWsvpk259s9OPADETqPcuGHUUFnkS+HqTGA+rHRzK2cDD+FzN9A9r/2OlAZkkSpmMTWhfP3SxYjCdK5QvZYUO1uTjXqOn3rU214LEDoabW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.04.25 03:00, Vishal Moola (Oracle) wrote: > Commit 89c1905d9c14 ("mm/gup: introduce memfd_pin_folios() for pinning memfd folios") > checks if filemap_get_folios_contig() returned duplicate folios to > prevent multiple attempts at pinning the same folio. > > Commit 8ab1b1602396 ("mm: fix filemap_get_folios_contig returning batches of identical folios") > ensures that filemap_get_folios_contig() returns a batch of distinct folios. > > We can remove the duplicate folio check to simplify the code and save > 58 bytes of text. > > Signed-off-by: Vishal Moola (Oracle) > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb