From: David Hildenbrand <david@redhat.com>
To: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>, linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org,
Vivek Kasireddy <vivek.kasireddy@intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] mm/gup: Remove unnecessary check in memfd_pin_folios()
Date: Wed, 30 Apr 2025 23:48:57 +0200 [thread overview]
Message-ID: <6f75ef86-29fd-41a1-95ba-f42f7c3bd6ce@redhat.com> (raw)
In-Reply-To: <20250430010059.892632-2-vishal.moola@gmail.com>
On 30.04.25 03:00, Vishal Moola (Oracle) wrote:
> Commit 89c1905d9c14 ("mm/gup: introduce memfd_pin_folios() for pinning memfd folios")
> checks if filemap_get_folios_contig() returned duplicate folios to
> prevent multiple attempts at pinning the same folio.
>
> Commit 8ab1b1602396 ("mm: fix filemap_get_folios_contig returning batches of identical folios")
> ensures that filemap_get_folios_contig() returns a batch of distinct folios.
>
> We can remove the duplicate folio check to simplify the code and save
> 58 bytes of text.
>
> Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
> ---
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-04-30 21:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 1:00 [PATCH 0/2] mm/gup: Cleanup memfd_pin_folios() Vishal Moola (Oracle)
2025-04-30 1:00 ` [PATCH 1/2] mm/gup: Remove unnecessary check in memfd_pin_folios() Vishal Moola (Oracle)
2025-04-30 21:48 ` David Hildenbrand [this message]
2025-05-01 21:23 ` Kasireddy, Vivek
2025-04-30 1:00 ` [PATCH 2/2] mm/gup: Remove page_folio() " Vishal Moola (Oracle)
2025-04-30 21:49 ` David Hildenbrand
2025-05-01 21:23 ` Kasireddy, Vivek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f75ef86-29fd-41a1-95ba-f42f7c3bd6ce@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vishal.moola@gmail.com \
--cc=vivek.kasireddy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox