From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F391CC5B543 for ; Fri, 30 May 2025 13:08:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63E776B011B; Fri, 30 May 2025 09:08:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EE996B011C; Fri, 30 May 2025 09:08:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B6EE6B011D; Fri, 30 May 2025 09:08:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 27E9C6B011B for ; Fri, 30 May 2025 09:08:15 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A91E3160823 for ; Fri, 30 May 2025 13:08:14 +0000 (UTC) X-FDA: 83499602508.16.8838F08 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 36F75180011 for ; Fri, 30 May 2025 13:08:12 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MG6l3D10; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748610492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5jfF9ono9G2mSAv9W1nWU8naZPviQnOurLCxmwQeGwk=; b=GZCt2OK6/rIwhvu5KX3RpCwrGIt2KU2y9qVh1o9QBzIJWSCHL44UsqDR+gKqlP7/a2tcfr LC+FPsowjPRZpvDFAFqFhXcRT8KNpxQ5Z6WeS7Xi6HZpGGdRM1r3eJ2KdZXKrxD0ec6Nvk +oE+KEXUwAagXc7u1chTnHtImb5Htfw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MG6l3D10; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748610492; a=rsa-sha256; cv=none; b=N+ueWmWyDLP80vTVRFOvl26+MgVcweLBX424diiPYbRO80OkeJ1r2tDk1yxCQ37wfqAsex rub2SB2THArXwTB6a136uYy2yfAibwxVsK2GZHaBjBmLWFogwTMIGLbTUjhdlOXPR8CUX/ 0c62fTvNA2Sz6meNaITmm2Ku+GfC62Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748610491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5jfF9ono9G2mSAv9W1nWU8naZPviQnOurLCxmwQeGwk=; b=MG6l3D1022n/pegQ3CXpZ3zjdur/CqPSLJRyapnGdrmGN3ksPpMqJxfMa7qDHLzJ937nMU PCAU8na3OFx22CZZwOplyCXZkO7hzesRp7exURiUIL9vzYETZK4h+tFNxhuIryNpw3VFjK qqsuNIO7738CNEoIqWAkIwzWlSuuOSQ= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-214--eV0hoJMN9COiPT8QPpNIw-1; Fri, 30 May 2025 09:08:10 -0400 X-MC-Unique: -eV0hoJMN9COiPT8QPpNIw-1 X-Mimecast-MFC-AGG-ID: -eV0hoJMN9COiPT8QPpNIw_1748610489 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a367b3bb78so1291568f8f.1 for ; Fri, 30 May 2025 06:08:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748610489; x=1749215289; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=5jfF9ono9G2mSAv9W1nWU8naZPviQnOurLCxmwQeGwk=; b=f01GibQe3wgNLjSZSfnk8A2VyFGM7z/koDO+6SCbCUPTfTOVJLZrtnUzyNiD0nSdhx 5dwn7kn9JY6R3B2/TFl9oAjg0A6QVOCbCWdRrzTJWcHVzNyBOzZtrMrv37pLfvUr85xE sXAK4cwE0ARc6K9p2hLsARBBtEa9QO7wrAwmmqTx2r7BAUlq8/DXpm4RZJ8lM+atrCZA az+nhrpNooZaICKcw7BsoVZg4m91ARnFUqGNRQ2bUfsTKUGFSDqtwkEeNLJ8fBDws0LQ LVIqIXeMLw5saadMTrRi6RoYnrsuxKPslvo2UBdWRb86wRXA+dF1rbyFHrFg5enXaXZ/ +CxQ== X-Forwarded-Encrypted: i=1; AJvYcCXLZzDYf2DbuV5wC3sx9dwcDNHVcWsjHCWPyFQmPi9dvW40WOoyryu/USxP2bnX51+M4F3w474N1A==@kvack.org X-Gm-Message-State: AOJu0YxRmU8DDNem/9ocZsNfD7EGm+yBOXV2zk8cYd9d+/buhIZdcCRA rK6bTtcA+EwHoejSsj3rU7e+qVz1VRkc9FRqjmghPlJUiius599YpwXdK2s3/Z+E0yLaB5mAozD WJu5Pf+ZjxeT6Hp7HelskmcpDGvYRdjp9NIrkApkLqW+0W4IuJ7Hd X-Gm-Gg: ASbGncuLpBk1x7nFP6zbGFXyB+wNKIWRvWDcUN0oALqnfC63RY8auwpiZLafN87nrYg x777j+JoR+I5BM+riD2PZuj4BsfwshBl805hK4E7Jl0TOzwuXhlJgFGbF0QgDnXiK0uZiBb1/+z tZwA582bxh4lpofY9wnS7pCVoiSCQCK7zCzpOSofCpFobKE13tW+l+5MGk7WL8H6F2s6sa9qrEz +a4n+KeWFi6XP/yH2rp08g2abW1d5ufLkWZ5i2vubayLMkfywzhK6gBAddWi18WsZCZ7TM3q2Hu WK7BZs+ntEPp7GsQ6bYG1tjFcPnKGNuaXSudvxhZQ4Vrtn1SJ1glC9Pu0wpY+fYyFMzXQtw5/6N +05F5uv8mG68NScqFp5+AoBxIqgC3YsMzfB9CcEKVqUBO1kG/6w== X-Received: by 2002:a05:6000:4009:b0:3a4:dfa5:325e with SMTP id ffacd0b85a97d-3a4f7a438e5mr2790822f8f.10.1748610488696; Fri, 30 May 2025 06:08:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHbviQCHa0UNiUhuilYuPoe2IGjSQgU5eYBMfG7pUzDgRk9JNWZvMBCEgKX8+hVlySgX1pw0Q== X-Received: by 2002:a05:6000:4009:b0:3a4:dfa5:325e with SMTP id ffacd0b85a97d-3a4f7a438e5mr2790746f8f.10.1748610488076; Fri, 30 May 2025 06:08:08 -0700 (PDT) Received: from ?IPV6:2003:d8:2f03:5b00:f549:a879:b2d3:73ee? (p200300d82f035b00f549a879b2d373ee.dip0.t-ipconnect.de. [2003:d8:2f03:5b00:f549:a879:b2d3:73ee]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4f009fd7csm4736738f8f.88.2025.05.30.06.08.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 May 2025 06:08:07 -0700 (PDT) Message-ID: <6f5e3238-9750-40db-8fe1-88d28655a988@redhat.com> Date: Fri, 30 May 2025 15:08:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gup: optimize longterm pin_user_pages() for large folio To: lizhe.67@bytedance.com Cc: akpm@linux-foundation.org, jgg@ziepe.ca, jhubbard@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, muchun.song@linux.dev, peterx@redhat.com References: <20250530122003.44555-1-lizhe.67@bytedance.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250530122003.44555-1-lizhe.67@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: lizZcwzL2iPH5EKoIXN8UlP07wPf4Y4KhoPvQUfkEr0_1748610489 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 36F75180011 X-Rspamd-Server: rspam09 X-Stat-Signature: zk33dewahjrjuxsekakrjpiyc84tbttt X-HE-Tag: 1748610492-524978 X-HE-Meta: U2FsdGVkX19QAUkwy6gTWW9E4RaKYxPWgZ5JAcXXRxmW6HpbX+SlK6OWiY7QqI5g9MkKqLxrUqCspdpTXrb4c/39EYiOA+uEfHByfgs8yHvD1NaEZ6JJaeamjD0B8qYn2GaqmchYn+DVd5vwloIB2PwEwrggS1V+njc5vrjJygc3pu0F8Ip7hG8fEEHngG5LxSR5PK+E3NBfgEAtZTvneYv77lOAtkzTqZFUAbgCUgO/Hy/z+SERkJ+2vX+968EA+gZqwYJc7+Jx4dgW1xZ97jii338L9kax5yf+F6jLTStcuxuDVwq3nNqOaI3lH5klTWPBH1c7b5+K10zNmv1fY5N3BOi3bzGNEh/Ob6TWRGjobpsx3Zp7B1niKZ0YkDGuq2UenZqf/YqYfyNt9fJuxlsQnYWEMmrTpf6+HXWKVogBxsvgfNRhLZcZPqduf0Uejr2kyfJDx5qyvvrsHf/bgrYO7sYHe7IiSQVrrJ4sC2uBpOC3mgZIWvYc3gMOC16d/KFFysiljXZkgM5YF2yFf+/K3pdzTLM7ZipUxIpZUVrVYC5o6CceimJXUpDWTMRzg2pmxIm13h+epqx9O5yBvEoV8HRe/feroDHb5UyLUSsGU6IkxXt+DlR8Q/ek5RGoIqjjidpfOlGChu41L7LZZOCty7SB8Gicz+FPpqbHxI5yTPVs3AEkEV82Ywo3V5N/TVs9iyO3MyHULpaY9QYC1CkYpUeAOBupULNAU/R3OoAd+42QyLvemIHPkISVhGTawGDVM1NKM0VghkCy5Ni4ggRdOoBqbfNOpqMY4R4AS9oZvZGLtxdcOxZyayO7W9TTlIi+m4gAcdQi0Q2wevlP0H9VpYezNhPv1vekNZm5C4/W9rALgTam0j1RRDI+21NDhCOCA6q79sVRgeob1U4ltBJb81H3mtGvnKI3ifBKhDoD5zvpJby5g/9+Bsa+HMxwsaQP8wI+0phId6EcGYE x2sBsdC+ U+MoHo5U8cQWyDJIJPvt8vG25kYYpMkRZV07zrd0wdkTVnNDesL4ZirvQJAHLbU4iCbbGjYqKmp1wBSVzQAJxAno5csJ9fV59fZyhbsDuSFsYuYawLhatOHzLrN2x+hb+okh7GYnXga8fuHSFhzb63trzmpAKiPQU+UfPmFdNsYZVBB1pM4RMWLIeN0n/qyjONl7NLm7D+4ugf7F3oj9nneQuyqsE52hys+Bwz0P2I5Nf1bHznUAqk3we6AByiv/vEkG9SCHeRuH7ZJWqP8Y0mXfYsGXTRxS2krWBvaxtZDJqj1jOnhddP2WJ3zPGmOWm64VQGwUYiK7oeoezEQ+ZH5GyBYgQwxx2JSHvZuXHzL5U009VkoXsIxhUOBldfE2Qc70wOVYrWZUpywJ6tJx9XKKZw4Fag7GXX1Q/39FaAK6sjqEfED9859tTJ9XTOaigNo8FZr2l2OsqB7xEXQA+HhzcpibKfJh4Tm3tlunVKHp7wOd3S7YPfhNNz6rUnxj/8QEIEpbmhEzhXeU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.05.25 14:20, lizhe.67@bytedance.com wrote: > On Fri, 30 May 2025 13:31:26 +0200, david@redhat.com wrote: > >> On 30.05.25 11:23, lizhe.67@bytedance.com wrote: >>> From: Li Zhe >>> >>> In the current implementation of the longterm pin_user_pages() function, >>> we invoke the collect_longterm_unpinnable_folios() function. This function >>> iterates through the list to check whether each folio belongs to the >>> "longterm_unpinnabled" category. The folios in this list essentially >>> correspond to a contiguous region of user-space addresses, with each folio >>> representing a physical address in increments of PAGESIZE. If this >>> user-space address range is mapped with large folio, we can optimize the >>> performance of function pin_user_pages() by reducing the number of if-else >>> branches and the frequency of memory accesses using READ_ONCE. This patch >>> leverages this approach to achieve performance improvements. >>> >>> The performance test results obtained through the gup_test tool from the >>> kernel source tree are as follows. We achieve an improvement of over 75% >>> for large folio with pagesize=2M. For normal page, we have only observed >>> a very slight degradation in performance. >>> >>> Without this patch: >>> >>> [root@localhost ~] ./gup_test -HL -m 8192 -n 512 >>> TAP version 13 >>> 1..1 >>> # PIN_LONGTERM_BENCHMARK: Time: get:13623 put:10799 us# >>> ok 1 ioctl status 0 >>> # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0 >>> [root@localhost ~]# ./gup_test -LT -m 8192 -n 512 >>> TAP version 13 >>> 1..1 >>> # PIN_LONGTERM_BENCHMARK: Time: get:129733 put:31753 us# >>> ok 1 ioctl status 0 >>> # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0 >>> >>> With this patch: >>> >>> [root@localhost ~] ./gup_test -HL -m 8192 -n 512 >>> TAP version 13 >>> 1..1 >>> # PIN_LONGTERM_BENCHMARK: Time: get:3386 put:10844 us# >>> ok 1 ioctl status 0 >>> # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0 >>> [root@localhost ~]# ./gup_test -LT -m 8192 -n 512 >>> TAP version 13 >>> 1..1 >>> # PIN_LONGTERM_BENCHMARK: Time: get:131652 put:31393 us# >>> ok 1 ioctl status 0 >>> # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0 >>> >>> Signed-off-by: Li Zhe >>> --- >>> mm/gup.c | 31 +++++++++++++++++++++++-------- >>> 1 file changed, 23 insertions(+), 8 deletions(-) >>> >>> diff --git a/mm/gup.c b/mm/gup.c >>> index 84461d384ae2..8c11418036e2 100644 >>> --- a/mm/gup.c >>> +++ b/mm/gup.c >>> @@ -2317,6 +2317,25 @@ static void pofs_unpin(struct pages_or_folios *pofs) >>> unpin_user_pages(pofs->pages, pofs->nr_entries); >>> } >>> >>> +static struct folio *pofs_next_folio(struct folio *folio, >>> + struct pages_or_folios *pofs, long *index_ptr) >>> +{ >>> + long i = *index_ptr + 1; >>> + unsigned long nr_pages = folio_nr_pages(folio); >>> + >>> + if (!pofs->has_folios) >>> + while ((i < pofs->nr_entries) && >>> + /* Is this page part of this folio? */ >>> + (folio_page_idx(folio, pofs->pages[i]) < nr_pages)) >> >> passing in a page that does not belong to the folio looks shaky and not >> future proof. >> >> folio_page() == folio >> >> is cleaner > > Yes, this approach is cleaner. However, when obtaining a folio > corresponding to a page through the page_folio() interface, Right, I meant page_folio(). > READ_ONCE() is used internally to read from memory, which results > in the performance of pin_user_pages() being worse than before. See contig_pages in [1] how it can be done using folio_page(). [1] https://lore.kernel.org/all/20250529064947.38433-1-lizhe.67@bytedance.com/T/#u -- Cheers, David / dhildenb