From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EAC5C282D0 for ; Tue, 4 Mar 2025 09:17:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CEBE6B0083; Tue, 4 Mar 2025 04:17:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 657BE6B0085; Tue, 4 Mar 2025 04:17:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AA766B0088; Tue, 4 Mar 2025 04:17:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 298F26B0083 for ; Tue, 4 Mar 2025 04:17:53 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C1B4FC1947 for ; Tue, 4 Mar 2025 09:17:52 +0000 (UTC) X-FDA: 83183316384.13.9575C55 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf26.hostedemail.com (Postfix) with ESMTP id A1E29140006 for ; Tue, 4 Mar 2025 09:17:50 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=dKvy8CG2; spf=pass (imf26.hostedemail.com: domain of wqu@suse.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=wqu@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741079870; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U7nVbwpLU0+lp6Hc0ee6jvbH0Pu/dJ0Otg1V1qw972I=; b=pX4LLsPh3SQypgjJW4GSc5HKOPg7IQadNl57atldh1QOO4MYLTVkyYbsFcgvD1YyfI0WxA bM9PPAYcOl8yvYAXNavyl3hrXxg014ET/f57zEFqxaSMNOqsMpJz+x05BgfVrspBJ3r0vc Efr5qDrwusN6ztMng1MH3M8o8/GpqGc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=dKvy8CG2; spf=pass (imf26.hostedemail.com: domain of wqu@suse.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=wqu@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741079870; a=rsa-sha256; cv=none; b=bGqu10OExHwgVA9wp2MSiZRR7bm9n9ntkgwZdXyLUfmiRLDfV7XmzPPuYnmgvKk8wWLua/ J1cSV0hx3uCkxJnTj+2LgpMffOyXDxniXFu9oRuqlUc8i/uCxtml6pqN2fSpxrFypL2Zmd cZOgBByIaDwvgic8tAJNwfS+Qepo56s= Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5e4c0c12bccso9533822a12.1 for ; Tue, 04 Mar 2025 01:17:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1741079869; x=1741684669; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=U7nVbwpLU0+lp6Hc0ee6jvbH0Pu/dJ0Otg1V1qw972I=; b=dKvy8CG2mSqMSV8WwrQ7z/Ksxb/1eOh6EQDOaneLDvk5Okyr41GdxoHQb1bAYISCOY nE5FIvUBYYzCDMBFaUH/1wCR95VrbewwqKxRcDSZ47bMdeR4JgnVI1RV9ZxK80qdFsuz VOtPy+cKKd4jDl6iUv9a9Kw9gVSWBP1Wjctzs2Hjx5N+CIhWVTu05sv0w4LfgUPmzz7q IJF+s+cIRNDGFUhnllMLwPea5G36gSZZ85/F3n8NrfBS9qy8HrCPiyuPLwUKa4w8j5ws VbZjbnYm9JDP2LEA+0+vIHjbioQvPwqhs5qGPkwznahc9oL2mY/reXcZ4QA3LS71NqGD fHRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741079869; x=1741684669; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U7nVbwpLU0+lp6Hc0ee6jvbH0Pu/dJ0Otg1V1qw972I=; b=T8Agb2cCII2/UjynSjpJwq6ZBQSH+uJqAeNfIWL8wmrEGdEqHbUPEIneStpitZGiki /DHDpncOooCWWj89kgI24phcd4p+SlscQq0oU2u5MM/PbwRESihhxducN3pq7rDfBL5K Sjta93oEHgSNJRuMgXxz6mATwLadV20fJq5jrCbT+hljS8wrhGKXF2oUg+8fJ9bSdvAb RmdCfX0ZMRawh8pIM3NcYsG8Z8m24YCEkD8JPucfUriTHgAFMxK/GqjJ+c8pEfBGKnyX 8ouKtmM7MhzV8I0lvyiKPwe5h+WIMmif8l00/AoioycbbRKK6TTSctpqFjAM62jUT1ZL i4Tw== X-Forwarded-Encrypted: i=1; AJvYcCVXW2uYcXb5Se+J+BuiCd0kq/j57W3B0A7pb9eK5MqBlxBhmDC+KsF8dlg2PgdvqLluADHY/zdEEw==@kvack.org X-Gm-Message-State: AOJu0YyhG8mHt3S7P3bPUMzYEl5Mj07WvX85VzopBkGK21Ey6DqqaXXt Xo4iaMmhW2lBhGE8ZZ5FwZ1KJhlsS/v7c0NsRsCyBxUwjUQQIXyHWC3JCxZjrD4= X-Gm-Gg: ASbGncsbz5rofdB63iLcBDm6ZJlONqNgWlZMR/WZnL+Ktkd67RTuOt1+cAot2Kbw9a2 ByA7dMfimni3WmGNEJNuYw4LiXdYdKMhVwiGOe1W1dOj7WZx0b1XZ2CTtwnSmkbGlwrGNnGbwIo 3caDy31pK4m+JI80KqyXfcf5/fmXRkZXHIsvdQF0RL60gXebynlOL7JmHoPdCbbsIy2JButpVWr U+zLJO0VWJ674qtuqAhvxLxGmlBjZhlyGrmfQEQtOolp3x4ilBQ+vDzkxpiJqgmqmSg13msYFeW O/nrmtBh92OYTIFVsrkjmFlTFQ5S1CXlBVvBuicZbRbI9nrb+bQsVkjTXGYoBFNzcwrnKUo3 X-Google-Smtp-Source: AGHT+IFEBbxQyaP0/2DWYOKB8ElC0B8gdpp7QbNW8c37nqwtwNfKPMEljUeKpMeGoOykV8PZYEcmVQ== X-Received: by 2002:a05:6402:2789:b0:5e0:52df:d569 with SMTP id 4fb4d7f45d1cf-5e4d6b852d0mr16127811a12.28.1741079868692; Tue, 04 Mar 2025 01:17:48 -0800 (PST) Received: from ?IPV6:2403:580d:fda1::299? (2403-580d-fda1--299.ip6.aussiebb.net. [2403:580d:fda1::299]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-223501f9dd8sm90968655ad.57.2025.03.04.01.17.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Mar 2025 01:17:48 -0800 (PST) Message-ID: <6f4017dc-2b3d-4b1a-b819-423acb42d999@suse.com> Date: Tue, 4 Mar 2025 19:47:34 +1030 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: alloc_pages_bulk: remove assumption of populating only NULL elements To: Yunsheng Lin , Yishai Hadas , Jason Gunthorpe , Shameer Kolothum , Kevin Tian , Alex Williamson , Chris Mason , Josef Bacik , David Sterba , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Carlos Maiolino , "Darrick J. Wong" , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey Cc: Luiz Capitulino , Mel Gorman , Dave Chinner , kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-nfs@vger.kernel.org References: <20250228094424.757465-1-linyunsheng@huawei.com> Content-Language: en-US From: Qu Wenruo Autocrypt: addr=wqu@suse.com; keydata= xsBNBFnVga8BCACyhFP3ExcTIuB73jDIBA/vSoYcTyysFQzPvez64TUSCv1SgXEByR7fju3o 8RfaWuHCnkkea5luuTZMqfgTXrun2dqNVYDNOV6RIVrc4YuG20yhC1epnV55fJCThqij0MRL 1NxPKXIlEdHvN0Kov3CtWA+R1iNN0RCeVun7rmOrrjBK573aWC5sgP7YsBOLK79H3tmUtz6b 9Imuj0ZyEsa76Xg9PX9Hn2myKj1hfWGS+5og9Va4hrwQC8ipjXik6NKR5GDV+hOZkktU81G5 gkQtGB9jOAYRs86QG/b7PtIlbd3+pppT0gaS+wvwMs8cuNG+Pu6KO1oC4jgdseFLu7NpABEB AAHNGFF1IFdlbnJ1byA8d3F1QHN1c2UuY29tPsLAlAQTAQgAPgIbAwULCQgHAgYVCAkKCwIE FgIDAQIeAQIXgBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXVgBQkQ/lqxAAoJEMI9kfOh Jf6o+jIH/2KhFmyOw4XWAYbnnijuYqb/obGae8HhcJO2KIGcxbsinK+KQFTSZnkFxnbsQ+VY fvtWBHGt8WfHcNmfjdejmy9si2jyy8smQV2jiB60a8iqQXGmsrkuR+AM2V360oEbMF3gVvim 2VSX2IiW9KERuhifjseNV1HLk0SHw5NnXiWh1THTqtvFFY+CwnLN2GqiMaSLF6gATW05/sEd V17MdI1z4+WSk7D57FlLjp50F3ow2WJtXwG8yG8d6S40dytZpH9iFuk12Sbg7lrtQxPPOIEU rpmZLfCNJJoZj603613w/M8EiZw6MohzikTWcFc55RLYJPBWQ+9puZtx1DopW2jOwE0EWdWB rwEIAKpT62HgSzL9zwGe+WIUCMB+nOEjXAfvoUPUwk+YCEDcOdfkkM5FyBoJs8TCEuPXGXBO Cl5P5B8OYYnkHkGWutAVlUTV8KESOIm/KJIA7jJA+Ss9VhMjtePfgWexw+P8itFRSRrrwyUf E+0WcAevblUi45LjWWZgpg3A80tHP0iToOZ5MbdYk7YFBE29cDSleskfV80ZKxFv6koQocq0 vXzTfHvXNDELAuH7Ms/WJcdUzmPyBf3Oq6mKBBH8J6XZc9LjjNZwNbyvsHSrV5bgmu/THX2n g/3be+iqf6OggCiy3I1NSMJ5KtR0q2H2Nx2Vqb1fYPOID8McMV9Ll6rh8S8AEQEAAcLAfAQY AQgAJgIbDBYhBC3fcuWlpVuonapC4cI9kfOhJf6oBQJnEXWBBQkQ/lrSAAoJEMI9kfOhJf6o cakH+QHwDszsoYvmrNq36MFGgvAHRjdlrHRBa4A1V1kzd4kOUokongcrOOgHY9yfglcvZqlJ qfa4l+1oxs1BvCi29psteQTtw+memmcGruKi+YHD7793zNCMtAtYidDmQ2pWaLfqSaryjlzR /3tBWMyvIeWZKURnZbBzWRREB7iWxEbZ014B3gICqZPDRwwitHpH8Om3eZr7ygZck6bBa4MU o1XgbZcspyCGqu1xF/bMAY2iCDcq6ULKQceuKkbeQ8qxvt9hVxJC2W3lHq8dlK1pkHPDg9wO JoAXek8MF37R8gpLoGWl41FIUb3hFiu3zhDDvslYM4BmzI18QgQTQnotJH8= In-Reply-To: <20250228094424.757465-1-linyunsheng@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: 7pjbg7f4quwcpk1s576i8rjtiwd1ru3b X-Rspamd-Queue-Id: A1E29140006 X-Rspamd-Server: rspam07 X-HE-Tag: 1741079870-590279 X-HE-Meta: U2FsdGVkX18UubKfHWAiexNaxF5QtERtw2QKLS+U58U/4+uPIuf/KMuXjDDvvCxNyK4t44ecr0xH2eqJ6SqogNj5QA5zqBVObknRgQpI7X6UbcR2VZIxuctZKDQXB2kNTfgk/Ly8cm2XX/OyW6wNuHYtvwthHnsDUUxtMkSCG6g4O9haCWi4k3dDg2skJsGeL7d/q9HGpPf43y7IcnwDXcDiLbU72RbpsmvLUcOfZ6gwGdcjDGdP+GvLSSbbxRbWBgMvbzkC+OSC5sbYXunRusQhsg8Bpz4R0mKRsdiyQYk6jvpsxushxQh8xcDkI7nvBLY1KlX3Q57QXLe0/qJDh6JuUlqqGbg7I2lXpW+iy/fJ9wO8dtr+WK9N+t4GDZIIfjG16Kry2rdqs+PMWvbVzm5okTKW+ieN6jgBjkV5ZPWMj2P8A4X8aFiPhCL3XJd+3hkd7DZNBL1K+WXmPFTZK8E9oDbA8X+QoLtSEaoj3PXmVRxEbnGKqPL0btP28mGAsDwNO2wZaJCcmnGmtZ7zK/Y/SK6/L+MKOU36UiFgbfhD/g+zY81zDJb/d5kUM5e/11PZUmSDlOcE2jEoQpb1jAQGQIpl5P7b90wuJtTdk2r+lmuuVeDQndnF2m1pULRu2ISxk7xYborvF4pEWaaCY3Lf5ZGvGWhuMyTYoqWYZ2iB0NncJBJGf2rw8azThRY4L6rmQkBn7Vhm4jOp8yLWHqsAwDpDoUAVrO4MLG2CDVWARsAs/r9zixUrkgNyaaBK9x1A30wiZLPUkJ5DQymKlATwc0yDbfYiSsEwYfAlP2qYYnDklJX6y9vlfuqVB/9BFp0VBdKwnnsjdZdlyMJ6uQFDEVQ+lUQAxtVtb2fr6YIKfIqcxCKQRpb697zjfjxocfjzqvH3zvJujHggGBP3pcCxRLkk62Dfbqe1NxzMcebylPQwgSCOFhfngSCqI0wyyS4sa1MNgJ7+Aft+Pwy tbe20kan P3BUNN1BA5WOqIvXi01jeImtAQ2Po3jjcWqyYtmXb/GIYHEJIJe1VYKp35tYaKZ8Wta5g9evP4lHmN+UFkFZSjekutseByxeZyqEmCau0aJOIj3bCnZXiypE+n7Vx/vpK5i+2LQfFgDQaMgKJ7Vo4r+hZffbLEw01oSSh7hY9UxSqwSCo5galvUMKXrGiyyndoWDn0txHjtYwSl8do2wUpzttCAwaWC8GsFPsInDa7zTl388frbulLwFMjGx6l40aA+IBLz4YRWy//t5cf4Su4W2/4h4RrjxIVdih3bP0r3aovB+s8axy8WJaq/UmeJfalvst2U993xHR5oy9X97dT8azjFqZ816qIXhvBQNlgdgMx0vgsVSfHH39Lw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/2/28 20:14, Yunsheng Lin 写道: > As mentioned in [1], it seems odd to check NULL elements in > the middle of page bulk allocating, and it seems caller can > do a better job of bulk allocating pages into a whole array > sequentially without checking NULL elements first before > doing the page bulk allocation for most of existing users. > > Through analyzing of bulk allocation API used in fs, it > seems that the callers are depending on the assumption of > populating only NULL elements in fs/btrfs/extent_io.c and > net/sunrpc/svc_xprt.c while erofs and btrfs don't, see: > commit 91d6ac1d62c3 ("btrfs: allocate page arrays using bulk page allocator") If you want to change the btrfs part, please run full fstests with SCRATCH_DEV_POOL populated at least. [...] > diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c > index f0a1da40d641..ef52cedd9873 100644 > --- a/fs/btrfs/extent_io.c > +++ b/fs/btrfs/extent_io.c > @@ -623,13 +623,26 @@ int btrfs_alloc_page_array(unsigned int nr_pages, struct page **page_array, > bool nofail) > { > const gfp_t gfp = nofail ? (GFP_NOFS | __GFP_NOFAIL) : GFP_NOFS; > - unsigned int allocated; > + unsigned int allocated, ret; > > - for (allocated = 0; allocated < nr_pages;) { > - unsigned int last = allocated; > + /* Defragment page_array so pages can be bulk allocated into remaining > + * NULL elements sequentially. > + */ > + for (allocated = 0, ret = 0; ret < nr_pages; ret++) { > + if (page_array[ret]) { You just prove how bad the design is. All the callers have their page array members to initialized to NULL, or do not care and just want alloc_pages_bulk() to overwrite the uninitialized values. The best example here is btrfs_encoded_read_regular(). Now your code will just crash encoded read. Read the context before doing stupid things. I find it unacceptable that you just change the code, without any testing, nor even just check all the involved callers. > + page_array[allocated] = page_array[ret]; > + if (ret != allocated) > + page_array[ret] = NULL; > + > + allocated++; > + } > + } > > - allocated = alloc_pages_bulk(gfp, nr_pages, page_array); > - if (unlikely(allocated == last)) { > + while (allocated < nr_pages) { > + ret = alloc_pages_bulk(gfp, nr_pages - allocated, > + page_array + allocated); I see the new interface way worse than the existing one. All btrfs usage only wants a simple retry-until-all-fulfilled behavior. NACK for btrfs part, and I find you very unresponsible not even bother running any testsuit and just submit such a mess. Just stop this, no one will ever take you serious anymore. Thanks, Qu