From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22751C3064D for ; Tue, 2 Jul 2024 06:14:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 904A56B0088; Tue, 2 Jul 2024 02:14:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B5756B0089; Tue, 2 Jul 2024 02:14:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77C9F6B008A; Tue, 2 Jul 2024 02:14:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5A6A46B0088 for ; Tue, 2 Jul 2024 02:14:09 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EFD8541FDE for ; Tue, 2 Jul 2024 06:14:08 +0000 (UTC) X-FDA: 82293797376.27.1EC8382 Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by imf22.hostedemail.com (Postfix) with ESMTP id A7094C0011 for ; Tue, 2 Jul 2024 06:14:05 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b="f/skk7WM"; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf22.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719900828; a=rsa-sha256; cv=none; b=5bewLezUv8pZr/JOHUzwBzLUgfmr+5Z49Oi3CUg5vedjqaEpWGFOKmJ+6lZ9VSktwfKmFm UYix5e4N7MScb5WeAUsx3DhW5Da/LbV8EBCpiywF054ttsDyzCHZosMcb2H7LNJBV9bslL Wq16e5hHGPB4tMHorZZF2FK4y6VKN7E= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b="f/skk7WM"; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf22.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719900828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=erDT9J5j1rBE4ZxSrWgpupITXKbScrM2e64G+CfHvXQ=; b=gjwppOC8Dw9W6KhlB2V6GJ/WxggcQ0kJqgJvvC4wQrVYeifpxUpxuxu+7oMe6IfTnSZEhf yKD9qMJUU39jxYHTT2DEl/wzyTIDvZjCeflbHrxfJy3+Euz1FSEQQGBab+YIcozIfurq2y CZii2HV6ja9cMQzmQAcEbZO4CTB/j4o= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1719900842; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=erDT9J5j1rBE4ZxSrWgpupITXKbScrM2e64G+CfHvXQ=; b=f/skk7WMvpbB07XJ+yUBwRNBdiifrKVOeoIVQ3USukC23PECfuUELNleyhHhhV26pZ5xUAUMnq5Y7PaulgMYBLmVOuFfLDz9ec2HigKr8C8sAsSHNbkZ6T0MGSQ91jYPxPVC4Rbky2bC4cDsmxn1EkWhkv7DH2ot2/JmutsxBYo= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R141e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033068173054;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0W9hWdSb_1719900840; Received: from 30.97.56.72(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W9hWdSb_1719900840) by smtp.aliyun-inc.com; Tue, 02 Jul 2024 14:14:01 +0800 Message-ID: <6f383c8c-b125-4374-bf21-67b6cc3edcbe@linux.alibaba.com> Date: Tue, 2 Jul 2024 14:14:00 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: thp: support "THPeligible" semantics for mTHP with anonymous shmem To: Bang Li , ughd@google.com, akpm@linux-foundation.org Cc: david@redhat.com, ryan.roberts@arm.com, wangkefeng.wang@huawei.com, ioworker0@gmail.com, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240702023401.41553-1-libang.li@antgroup.com> From: Baolin Wang In-Reply-To: <20240702023401.41553-1-libang.li@antgroup.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A7094C0011 X-Stat-Signature: p9bupcycysg9nzf6wd9ys34tdfib4ujk X-Rspam-User: X-HE-Tag: 1719900845-301789 X-HE-Meta: U2FsdGVkX1/EOU7biww7/jDDM46I3sVUwP+GhCjxBjsDi/wqy/JnDCnmooxggAKovx9dnR69z6Gx0ynPy7OvL6FCBP+AZWWfL/myMhsozb/vBlb5HQet6xmhxnyEJg4GO0YJniEbH8w2luGf8ppKKteslHk/aD1TQ0SIP5e7BZ5JyNRqwvwup3WlDT+FZph6CKpSzMx73SlhX1fhgpDACH6lKq82I+8IZ8kHEBx/vi+bA4II4UJ1R2oZ5SbTna/rfNPkWnU2Tx12IJpsJDksldClmyBg6EmgD/1NYynDKLbX5FeyZI4yBLSuS9vLdRtAakAohqc58S+f0UrbGKYacUhDvc5a+Ja9WD/2X2ZX7Ky2ohkIStPLFmGS5qEjKnktEj0UslCvoHmscJGUqKDnqswZhMXMoSu4N8i/7hhMnFcEKSqRFkXvNTq+1fkdZyX+ActQj8CTYdm5wzeguI8b/Sl4iU79EddbrV1Nk7hpnAksakmarJvaiw+0kSC+obiMYDWhU95dDmaUoO90KA41yDHxTTvdxJCryERrNXpDWaPqYYno3N+vRvjpQavHCxPJmlvRFX9wLf6T94tBpZgSbIlL7WGimbi67gjG48anEyTMFwJsn/JXevxTckSrMhGpAux/4kS+Ii9l+qsByyO9wJ2TDscTD2Ak5B25zUmZNFCGFOyYEkrRlCXQ9nzI+8x2pXqQEqaehz+6x1OMqF+rJ2VIbYZkoZ2LLYSbzo9eE3Kl4X3yPud2xV+ShNpFaXCoOWqaRkIR7qJeYgt6aF/cAjQDMxt68NOi/eqx0jdCHP3CTr4aCHK1fAhbF1yMtWoNA9Y4W5XTEThrQkAC4QDqzSUEdLAc2SZ/Eos/em9L9g0aLLEXnNby6eUfedj8z6RLRiqpGpWIALdTYZejelEgIt4Xx0uptx5ZOXd12Rw9KBQqLxJsmGHw1lmHGp8UbbXVxnLtyPVuOzyKEJ3chZ0 m/EYEME+ zN4jTnYpO8zOb6PJ0voMuFhqCIJUzsdIH0VEi1oyfkCocqQZRbsgCqXFgtMSDgdmOi+vHxxAxngQx+gHTgt+U0bFMsJC92oX7xAVtsxi+yBYFaIrSm39uYu7kYScaO6BGSHBisRKmuVn/CBBlNpER3Eeb2xNQsmUZHqDLzhCqH3L+Q/0gu2nOPzgvYY1nWmAMg7vOK6tOgIZ7uhUqkTeuywUoVav1E1PB9JHeAg69xPOZ8YVTSgEVenurw4Ax+ac4H+1+mtiAnnyHsEX25xyRBVYaY6jrKlahZ6/rlo4fYWuZ9tBDeVBbS/m7Ji9kBBZqcGt1I1JocGyVj0epLRBLm6YC4F2fdLZMRvDxUtvd8Ad3O6ncUSjepbpD70sTNElqWsMMAyPd+5QLFO1GxuEnYbxmT3JLpRIo9SRRXJxA/wrd6uiSyNfr9bWfUtIgfXV/Cdtb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/2 10:34, Bang Li wrote: > After the commit 7fb1b252afb5 ("mm: shmem: add mTHP support for > anonymous shmem"), we can configure different policies through > the multi-size THP sysfs interface for anonymous shmem. But > currently "THPeligible" indicates only whether the mapping is > eligible for allocating THP-pages as well as the THP is PMD > mappable or not for anonymous shmem, we need to support semantics > for mTHP with anonymous shmem similar to those for mTHP with > anonymous memory. > > Signed-off-by: Bang Li > --- > Changes since v1 [1]: > - Put anonymous shmem mthp related logic into > thp_vma_allowable_orders() (per David) > > [1] https://lore.kernel.org/linux-mm/20240628104926.34209-1-libang.li@antgroup.com/ > --- > include/linux/huge_mm.h | 11 +++++++++++ > mm/huge_memory.c | 13 +++++++++---- > mm/shmem.c | 9 +-------- > 3 files changed, 21 insertions(+), 12 deletions(-) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index 212cca384d7e..f87136f38aa1 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -267,6 +267,10 @@ unsigned long thp_vma_allowable_orders(struct vm_area_struct *vma, > return __thp_vma_allowable_orders(vma, vm_flags, tva_flags, orders); > } > > +unsigned long shmem_allowable_huge_orders(struct inode *inode, > + struct vm_area_struct *vma, pgoff_t index, > + bool global_huge); > + > struct thpsize { > struct kobject kobj; > struct list_head node; > @@ -460,6 +464,13 @@ static inline unsigned long thp_vma_allowable_orders(struct vm_area_struct *vma, > return 0; > } > > +static inline unsigned long shmem_allowable_huge_orders(struct inode *inode, > + struct vm_area_struct *vma, pgoff_t index, > + bool global_huge) > +{ > + return 0; > +} This function should be placed in the ‘shmem_fs.h’ header file, just like shmem_is_huge().