From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 384F1C5321E for ; Mon, 26 Aug 2024 17:03:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C97A76B008C; Mon, 26 Aug 2024 13:03:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C46CF6B0092; Mon, 26 Aug 2024 13:03:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0EE56B0093; Mon, 26 Aug 2024 13:03:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 92F396B008C for ; Mon, 26 Aug 2024 13:03:53 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EEAB21A1212 for ; Mon, 26 Aug 2024 17:03:52 +0000 (UTC) X-FDA: 82495018704.08.8681B11 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 9D49DA001D for ; Mon, 26 Aug 2024 17:03:49 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SGD6WwKX; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724691743; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kFsu14f4i4LlQVERSc8Pt6nldSMLT5wVXv/WD9oSBYc=; b=wz47CQ4o9Dqzr7jfjPCuMxcWiIQLiXCQNXvuyJmhnfxGkkRjhm2ElYfurGX5ADAvbm0Sm3 2631JxXoYC6pKqZai1nBVJQA+N8r0CRJmg5ZVMrGNJwtqK1y9mZxN/ofgJAkUA4vpZ4grm V6F98kcHspVJwmC4vTQWkaFjjXbgUpw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724691743; a=rsa-sha256; cv=none; b=qGwH4nAaLtyEqSgghM2JnpHbu1M7AcPstFehcL4mOJinYczAojaMFA+yjz6UAtI7YOkUiV i0oi6XuSnO3EPN7GTOI3Iz9kg0b+wnk6k80BtuODATpsjiRkhBvnNtHdiIQ6wIJ6+zmfMa jF0R2DJAVWuGYHgPizq3pJqPWjW2YNk= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SGD6WwKX; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724691828; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kFsu14f4i4LlQVERSc8Pt6nldSMLT5wVXv/WD9oSBYc=; b=SGD6WwKXyQVlHILRcn+pzevL/QS0PyOtmeF8cXNjT6y9iKcbyFOXLk689Xz7pfE04T1Ls0 9ALtW+Dgwa11PBeKWmvl8uC3lKkLASVXDmEuzsv1OoFyQw2mQsXhJwm+JpYpFxS1eEwR+e VX9auUNYJjMneKKrFgiiZdowBpYoY6I= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-217-xU6lh64wO-mDiDlGgPADqw-1; Mon, 26 Aug 2024 13:03:47 -0400 X-MC-Unique: xU6lh64wO-mDiDlGgPADqw-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4280ec5200cso41729965e9.0 for ; Mon, 26 Aug 2024 10:03:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724691826; x=1725296626; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=kFsu14f4i4LlQVERSc8Pt6nldSMLT5wVXv/WD9oSBYc=; b=jtrTTvQlxH6r9+S2MTOI/+qCYiyQiXctI0ESC4ChJcIXdf84IfT/oa+iL2+ZIdiqAd eLUXMuBA90vf/eechDl6Tume3U0dw9/iXshHCTchDQ3HxXEPE/uYllzRe65Qn8H6bvYr rA7yDqGOMffKaCXF8tytTyA2uHHZQayYxNuTTmEO36piJQASdsz9zQwDxoXwZoMiMOUK hg6ZCELNdBZSZixJ2vq7alM85HsAyKLEsID6UfFOk0T8LsF3/HDImyqFjdr1X2XkHkl6 GtdZZwzXUr6fjIJANryC6kxN6VrqgLoyBdj3elOJhJ1m4Q+Yktwki28w2zADWMYxEWOv ePgw== X-Forwarded-Encrypted: i=1; AJvYcCXkF+fCfvrqHzuWCjc4ZpfNOtP5wDYqA8yaJnIe4dt9M6aRD37eu1iN1CQJiLbpPLdIy5wf/meyHw==@kvack.org X-Gm-Message-State: AOJu0YysOV0FVdD7LSTQhHuGEkmirGwRfbQraL3kbORyJAn9c8OdOvNT Q+1fJ2l/clHT2OkK9Mu32puxunfVT4M1BH8VctgB33zbE4RZLM0lqRaukwFH8dyiMAUNGrw83Oc YcLXHCjO1UOBigrttQltR6mDG07wUQaWd/HEtwA+iYDfcP7i9 X-Received: by 2002:a05:600c:4ec6:b0:426:6153:5318 with SMTP id 5b1f17b1804b1-42acc8dd87amr70862425e9.19.1724691826453; Mon, 26 Aug 2024 10:03:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFw0uS9vEu6BBNlQmGLpFGxf9J44mEDsF3d6bu7BGQEnYzWfUlzaaAKoGAE30FgbsvLO6D+9g== X-Received: by 2002:a05:600c:4ec6:b0:426:6153:5318 with SMTP id 5b1f17b1804b1-42acc8dd87amr70862145e9.19.1724691825621; Mon, 26 Aug 2024 10:03:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c737:1900:16b0:8dc:77e:31af? (p200300cbc737190016b008dc077e31af.dip0.t-ipconnect.de. [2003:cb:c737:1900:16b0:8dc:77e:31af]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42b8a351d3asm100411805e9.13.2024.08.26.10.03.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Aug 2024 10:03:45 -0700 (PDT) Message-ID: <6f3020e7-f7e8-4d40-b9ce-32a02932a656@redhat.com> Date: Mon, 26 Aug 2024 19:03:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] vma remove the unneeded avc bound with non-CoWed folio To: Lorenzo Stoakes , zhiguojiang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, oe-lkp@lists.linux.dev, lkp@intel.com, opensource.kernel@vivo.com References: <20240823150206.565-1-justinjiang@vivo.com> <73ad9540-3fb8-4154-9a4f-30a0a2b03d41@lucifer.local> <4dd13a4c-e968-4a3a-98e5-97f28036deff@vivo.com> <1109aeab-fd4a-4c83-a110-04d01177d72d@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <1109aeab-fd4a-4c83-a110-04d01177d72d@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: 6bxa6t4c68yaydom5y78bxroysf6xwf8 X-Rspamd-Queue-Id: 9D49DA001D X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1724691829-375724 X-HE-Meta: U2FsdGVkX1/LrpDZOmmSnL3Z3Y3ENw2SKBXUvdVdf7B/EGDReT4k8cc8cPDygFNRDeiiW9EFSAcjD9BRpjv5k66Chjwq/iJ79GW1YgMYtFkdrKmpWGpcz3eJaSqC02tPQPoCacaO8M0LP/RpFZ7GMgv5QjDgw2sU7Vxz7JoSZ7/6PmImd/lYhfoy52V65JXcssVEVYO1SPINde/jGLrdsXQB1HWLsqOH0qORQBLaxcKLkbrmjDBXO0oAU9QBTnJG/CFI7jD65GTKJDVXEJnzwB2IwLa6I8FDd7017tTCABE6Mwk+n+eFcaCY5QM+ix3JM8LFoiaPrA2Zqx2caz0r3SFyiuYar9Nj0Xvl9QU2bxsHhF6HWELtbGsjXztAIupbE5C6mphexRgkXzwl/yoZajHTmWQOnYd8l5gXORoMNBCfr4j2U6DIqhVhjrGO1QXDsm5T5iEZh1nZWJPQZT7obMz1ZeJSLEHyFz3+jQAHBFx0vbk4N4GFksH1N8vejOBIa6TPK1rJuCIVBht4Coas+dM78yGhfVGMU0iA+YtCEKHu5lX/M0JQ9Z/YqJJeF3jFCTdD3f6C9SZcNEcivctWGJHe1cGDUXv9NWG3WTv1fdaHIXcKiFroq8vgcnqyyT+fupy2zNF9RDnOoYjeMihCUNpuCYQ4UFkwmyhZ0U24UFMuUkFp5HtluVs0+zW/+xs9A6HlcTVE0SsGDZ+BqTm+QRY0p8MBlIEfdYgzFnrQPCfQq+VbBr3CWuj66ZlrvvhxzWB9z3MWiAxGfm38qXMGFlnNhg0kVXxMe5JZDQVV37mqa1t3DEEhvgVxEvODvJhSV6HttX4clNWXih2KXK4nEgTlk9Yg+cOoBqAsXD7f2BVXtq5LPUPWeqkXu6KWemRzaRJnSlM7ZMrgDOlAM+asKKuaRhK1+THF8DWIX2esol3GKiTSy8FPR9s8xXOXbBWjS2UlI8Z2MwCbOHPGK1I 8ZY4Wwde pRI9LztHoeDXuM+1YNNsE9vc9ouYzU068YB3RsbMogomBuNEPA/EE4ZmQAfnUL2br9YISUpm+tUoR2dvwuAhT7evXox1K6khPCLJeVsjMgb+V8e59jXvYh8uIl6hkxHVJ7iCFV0rA1Byt/aAOEv9qGKirS7ZJ6uy7rmlpYBQNl0kMLFws1Zut+AnHMouAEY3zsqmO/aZSwqk3JfQPwrv62oMA3m8NboKRycxGKyWKHQVXmi9Cg7bfCuPvM5366GxrI8Af1znGu1cba6Hgzc92Yzmp6cmErInbUblXyFArPQaftoEpEa1dCkXLi2a2tQpMJuc0osx3sB33Q8dOJkZHLeO8aYQhazutgEC6wl1Oq5E6N+xVvAM2qE31Th2o89MBbBcTbsjm0c9sN/RzBY7t3xSC4d1v0qo6CZTfEEB/67DZr8/oYeXRcU8yOWVrzNqRaBB7a82500pBgAAncrmYDShaClxaXWxTP+VpR/ETwqyTOPodD/MfEBmajFr9ou5UbeojG/gh8O4wLT9thbv9UXwX9oPLvmLnuGYj X-Bogosity: Ham, tests=bogofilter, spamicity=0.003541, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.08.24 08:42, Lorenzo Stoakes wrote: > On Sun, Aug 25, 2024 at 01:06:40PM GMT, zhiguojiang wrote: >> >> >> 在 2024/8/25 0:26, Lorenzo Stoakes 写道: >>> [Some people who received this message don't often get email from lorenzo.stoakes@oracle.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] >>> >>> On Fri, Aug 23, 2024 at 11:02:06PM GMT, Zhiguo Jiang wrote: >>>> After CoWed by do_wp_page, the vma established a new mapping relationship >>>> with the CoWed folio instead of the non-CoWed folio. However, regarding >>>> the situation where vma->anon_vma and the non-CoWed folio's anon_vma are >>>> not same, the avc binding relationship between them will no longer be >>>> needed, so it is issue for the avc binding relationship still existing >>>> between them. >>>> >>>> This patch will remove the avc binding relationship between vma and the >>>> non-CoWed folio's anon_vma, which each has their own independent >>>> anon_vma. It can also alleviates rmap overhead simultaneously. >>>> >>>> Signed-off-by: Zhiguo Jiang >>> >>> NACK (until fixed). This is broken (see below). >>> >> Hi Lorenzo Stoakes, >> >> Thank you for your comments. >>> I'm not seeing any numbers to back anything up here as to why we want to >>> make changes to this incredibly sensitive code? >> I added a debug trace log (as follows) in wp_page_copy() and observed >> that a large number of these orphan avc-objects still exist. I believe >> this will have a certain redundant overhead impact on anonymous folios' >> rmap avcs, so I want to remove it, which is also the most essential >> value of this patch. > > Sorry nack to that idea unless you can provide actual _data_ to demonstrate > an overhead. Agreed. -- Cheers, David / dhildenb