From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18741C282EC for ; Fri, 14 Mar 2025 21:21:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08A4C28000B; Fri, 14 Mar 2025 17:21:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 039C928000A; Fri, 14 Mar 2025 17:21:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E452528000B; Fri, 14 Mar 2025 17:21:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C7F8428000A for ; Fri, 14 Mar 2025 17:21:04 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 316F6C13DB for ; Fri, 14 Mar 2025 21:21:06 +0000 (UTC) X-FDA: 83221426932.26.F70E09A Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by imf29.hostedemail.com (Postfix) with ESMTP id 2099F120006 for ; Fri, 14 Mar 2025 21:21:02 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=AnZ4JmaD; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf29.hostedemail.com: domain of tim.c.chen@linux.intel.com has no SPF policy when checking 192.198.163.13) smtp.mailfrom=tim.c.chen@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741987263; a=rsa-sha256; cv=none; b=AHZ1/7+OmCm576O6LzzqgBgVeXj4VEH462QqwdxhipomMv5H2y/XXLBqdDLmnPfCiTEa9K bZj/RATVz+jJB4ypHqXL3k7AyXlwF2XT+2cyag+YwlNMH8LOoMEbCABV0L2lgXpT0VEOLN 0RNbPoUcTW9LQPOV6Cp/xOpIMNafq5Q= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=AnZ4JmaD; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf29.hostedemail.com: domain of tim.c.chen@linux.intel.com has no SPF policy when checking 192.198.163.13) smtp.mailfrom=tim.c.chen@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741987263; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W2yw2EGyASk2vqtGTj2n3UanueM3Rp7PkMFX87ndn6E=; b=hK6JanHfIakZM8e56gvtBO0r9hA47z5hWgQ4aCEhBTnrepvyPsZ4dJtVAfjrTrEvEjVvJf 1gKBx57miPWC1+rWlc/AwMWE/h2rHWIsDYMAqmmGkn3v3I5uqID6nSxWkq3alVU/H8anjK jcQQUPiJtOxpuqOR0qS1/6N6deeazsQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741987263; x=1773523263; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=MNyKA6CVe4652u3rl1RWaJVTyW3eZ/bc4ttjJnAlW0g=; b=AnZ4JmaD2kWgCpjuqj5EJLP8YqxjhLDG/RkAbWWynpbKf8q2SFK2iYMY UI9KAgXhcb23TXENC4G0Czqy/jw5U5E1sYUfkllXXr4ZotXsi0UMhaGrF pJSYxwoqCbYnjMdYvHNcTqXeY50I81bU2dlLKol3CmlEBbm22HTFFtnsS xY+SpFH4EdU5lhbteaEf+lQOh4FlUCmERkJ/9K5x+5U4Gqi711cI+Q4Ky S5oRMuGPBTMz9wCVdvL4IfE/O9ybwqwlyGQ2Hh8MH3tNXSAPKdi57Ksi1 o11d5qKVsemCoM6DE7jaCe1OS74+Sr9JGqe3eBmqVi6Z5upkPrmL15QOK A==; X-CSE-ConnectionGUID: BCFz/e4RRjGY2bTpNWZCdA== X-CSE-MsgGUID: 0YxV7t81QHig2WTgmTDzEA== X-IronPort-AV: E=McAfee;i="6700,10204,11373"; a="45918110" X-IronPort-AV: E=Sophos;i="6.14,246,1736841600"; d="scan'208";a="45918110" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2025 14:21:02 -0700 X-CSE-ConnectionGUID: VSzYWg7BSh6Bqm91MWzeSA== X-CSE-MsgGUID: 4XmfRL0lSgCAIYi7iY2/MQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,246,1736841600"; d="scan'208";a="158539339" Received: from dnelso2-mobl.amr.corp.intel.com (HELO [10.125.108.212]) ([10.125.108.212]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2025 14:21:01 -0700 Message-ID: <6f2fc7279849e626f9150d0a14d544d1d641675e.camel@linux.intel.com> Subject: Re: [PATCH 5/9] mm: swap: use swap_entries_free() drop last 1 flag in swap_entries_put_nr() From: Tim Chen To: Kemeng Shi , akpm@linux-foundation.org Cc: kasong@tencent.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Fri, 14 Mar 2025 14:21:01 -0700 In-Reply-To: <20250313210515.9920-6-shikemeng@huaweicloud.com> References: <20250313210515.9920-1-shikemeng@huaweicloud.com> <20250313210515.9920-6-shikemeng@huaweicloud.com> Autocrypt: addr=tim.c.chen@linux.intel.com; prefer-encrypt=mutual; keydata=mQENBE6N6zwBCADFoM9QBP6fLqfYine5oPRtaUK2xQavcYT34CBnjTlhbvEVMTPlNNzE5v04Kagcvg5wYcGwr3gO8PcEKieftO+XrzAmR1t3PKxlMT1bsQdTOhKeziZxh23N+kmA7sO/jnu/X2AnfSBBw89VGLN5fw9DpjvU4681lTCjcMgY9KuqaC/6sMbAp8uzdlue7KEl3/D3mzsSl85S9Mk8KTLMLb01ILVisM6z4Ns/X0BajqdD0IEQ8vLdHODHuDMwV3veAfnK5G7zPYbQUsK4+te32ruooQFWd/iqRf815j6/sFXNVP/GY4EWT08UB129Kzcxgj2TEixe675Nr/hKTUVKM/NrABEBAAGJAS4EIAECABgFAk6ONYoRHQFLZXkgaXMgcmVwbGFjZWQACgkQHH3vaoxLv2UmbAgAsqa+EKk2yrDc1dEXbZBBGeCiVPXkP7iajI/FiMVZHFQpme4vpntWhg0BIKnF0OSyv0wgn3wzBWx0Zh3cve/PICIj268QvXkb0ykVcIoRnWwBeavO4dd304Mzhz5fBzJwjYx06oabgUmeGawVCEq7UfXy+PsdQdoTabsuD1jq0MbOL/4sB6CZc4V2mQbW4+Js670/sAZSMj0SQzK9CQyQdg6Wivz8GgTBjWwWsfMt4g2u0s6rtBo8NUZG/yw6fNdaoDaT/OCHuBopGmsmFXInigwOXsjyp15Yqs/de3S2Nu5NdjJUwmN1Qd1bXEc/ItvnrFB0RgoNt2gzf25aPifLabQlVGltIENoZW4gPHRpbS5jLmNoZW5AbGludXguaW50ZWwuY29tPokBOAQTAQIAIgUCTo3rPAIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQHH3vaoxLv2XYdAf8DgRO4eIAtWZy4zLv0EZHWiJ35GYAQ5fPFWBoNURE0+vICrvLyfCKTlUTFxFxTiAWHUO7JM+uBHQSJVsE+ ERmTPsiU O1m7SxZakGy9U2WOEiWMZMRp7HZE8vPUY5AM1OD0b38WBeUD3FPx5WRlQ0z6izF9aIHxoQhci0/WtmGLOPw3HUlCy1c4DDl6cInpy/JqUPcYlvsp+bWbdm7R5b33WW2CNVVr1eLj+1UP0Iow4jlLzNLW+jOpivLDs3G/bNC1Uu/SAzTvbaDBRRO9ToX5rlg3Zi8PmOUXWzEfO6N+L1gFCAdYEB4oSOghSbk2xCC4DRlUTlYoTJCRsjusXEy4bkBDQROjes8AQgAzuAQ5rF4/ZYaklzSXjXERiX0y1zBYmcYd2xVOKf50gh8IYv8allShkQ8mAalwIwyxTY+1k72GNCZIRVILSsuQY6fLmPUciuCk/X1y4oLNsF/Np8M9xxwYwqUibUwRdWwpSG2V0bcqjtUH1akaoY758wLONUmXrlfVonCfENd0aiP+ZLxYE1d1CRPv4KbAZ6z6seQCEQrappE4YXIC9yJUqT076DD1RhPmwNbNTTAauuwG+vX+jWsc5hUaHbKsAf/Rsw13+RA3dzWekbeIxO9qvQoQ26oqKEA31mxWhwNDnkTeo07+e2EGC2BV6s+sU1/m/lup5Bj34JLP7qYtd6EswARAQABiQEeBBgBAgAJBQJOjes8AhsMAAoJEBx972qMS79lYmQH+I4qdFm8wlkh/ZVWNJMSpfUfupuLPZ0g0hxNr3l2ZltEskVl5w+wJV+hBZ7zMmSxMYvMjJ+5aBDSZOfzhnK6+ETl4e/heDYiBLPYCtvU88cMRFb3jKcVxSfSzbBawEr7OFfCny3UtmYQ0PJmHFT6p+wlEHSyKxtyDDlLS/uPPR/llK94fOhvQlX8dir9b8r7JGuFTjtG2YbsTuapi3sFDmBhFZwYcNMt80FSIXGQjJzrsl1ZVSIwmqlF2191+F/Gr0Ld92dz1oEOjwKH1oRb/0MTsNU7udZv7L8iGKWCjHnA0dIoXKilf8EJyXGQ0wjQE3WBAdMecb vSKDRA7k 9a75kCDQROjjboARAAtXPJWkNkK3s22BXrcK8w9L/Kzqmp4+V9Y5MkkK94Zv66lXAybnXH3UjL9ATQgo7dnaHxcVX0S9BvHkEeKqEoMwxg86Bb2tzY0yf9+E5SvTDKLi2O1+cd7F3Wba1eM4Shr90bdqLHwEXR90A6E1B7o4UMZXD5O3MI013uKN2hyBW3CAVJsYaj2s9wDH3Qqm4Xe7lnvTAGV+zPb5Oj26MjuD4GUQLOZVkaA+GX0TrUlYl+PShJDuwQwpWnFbDgyE6YmlrWVQ8ZGFF/w/TsRgJMZqqwsWccWRw0KLNUp0tPGig9ECE5vy1kLcMdctD+BhjF0ZSAEBOKyuvQQ780miweOaaTsADu5MPGkd3rv7FvKdNencd+G1BRU8GyCyRb2s6b0SJnY5mRnE3L0XfEIJoTVeSDchsLXwPLJy+Fdd2mTWQPXlnforgfKmX6BYsgHhzVsy1/zKIvIQey8RbhBp728WAckUvN47MYx9gXePW04lzrAGP2Mho+oJfCpI0myjpI9CEctvJy4rBXRgb4HkK72i2gNOlXsabZqy46dULcnrMOsyCXj6B1CJiZbYz4xb8n5LiD31SAfO5LpKQe/G4UkQOZgt+uS7C0Zfp61+0mrhKPG+zF9Km1vaYNH8LIsggitIqE05uCFi9sIgwez3oiUrFYgTkTSqMQNPdweNgVhSUAEQEAAbQ0VGltIENoZW4gKHdvcmsgcmVsYXRlZCkgPHRpbS5jLmNoZW5AbGludXguaW50ZWwuY29tPokCVQQTAQgAPwIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQTRofI2lb24ozcpAhyiZ7WKota4SQUCYjOVvwUJF2fF1wAKCRCiZ7WKota4SeetD/4hztE+L/Z6oqIYlJJGgS9gjV7c08YH/jOsiX99yEmZC/BApyEpqCIs+RUYl12hwVUJc++sOm/p3d31iXvgddXGYxim00+ DIhIu6sJ aDzohXRm8vuB/+M/Hulv+hTjSTLreAZ9w9eYyqffre5AlEk/hczLIsAsYRsqyYZgjfXLk5JN0L7ixsoDRQ5syZaY11zvo3LZJX9lTw0VPWlGeCxbjpoQK91CRXe9dx/xH/F/9F203ww3Ggt4VlV6ZNdl14YWGfhsiJU2rbeJ930sUDbMPJqV60aitI93LickNG8TOLG5QbN9FzrOkMyWcWW7FoXwTzxRYNcMqNVQbWjRMqUnN6PXCIvutFLjLF6FBe1jpk7ITlkS1FvA2rcDroRTU/FZRnM1k0K4GYYYPj11Zt3ZBcPoI0J3Jz6P5h6fJioqlhvZiaNhYneMmfvZAWJ0yv+2c5tp2aBmKsjmnWecqvHL5r/bXeziKRdcWyXqrEEj6OaJr3S4C0MIgGLteARvbMH+3tNTDIqFuyqdzHLKwEHuvKxHzYFyV7I5ZEQ2HGH5ZRZ2lRpVjSIlnD4L1PS6Bes+ALDrWqksbEuuk+ixFKKFyIsntIM+qsjkXseuMSIG5ADYfTla9Pc5fVpWBKX/j0MXxdQsxT6tiwE7P+osbOMwQ6Ja5Qi57hj8jBRF1znDjDZkBDQRcCwpgAQgAl12VXmQ1X9VBCMC+eTaB0EYZlzDFrW0GVmi1ii4UWLzPo0LqIMYksB23v5EHjPvLvW/su4HRqgSXgJmNwJbD4bm1olBeecIxXp6/S6VhD7jOfi4HACih6lnswXXwatzl13OrmK6i82bufaXFFIPmd7x7oz5Fuf9OQlLOnhbKXB/bBSHXRrMCzKUJKRia7XQx4gGe+AT6JxEj6YSvRT6Ik/RHpS/QpuOXcziNHhcRPD/ZfHqJSEa851yA1J3Qvx1KQK6t5I4hgp7zi3IRE0eiObycHJgT7nf/lrdAEs7wrSOqIx5/mZ5eoKlcaFXiKJ3E0Wox6bwiBQXrAQ/2yxBxVwARAQABtCVUaW0gQ2hlbiA8dGltLmMuY2hlbkBsaW51eC5pbnRl bC5jb20+ iQFUBBMBCAA+FiEEEsKdz9s94XWwiuG96lQbuGeTCYsFAlwLCmACGwMFCQHhM4AFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQ6lQbuGeTCYuQiQf9G2lkrkRdLjXehwCl+k5zBkn8MfUPi2ItU2QDcBit/YyaZpNlSuh8h30gihp5Dlb9BnqBVKxooeIVKSKC1HFeG0AE28TvgCgEK8qP/LXaSzGvnudek2zxWtcsomqUftUWKvoDRi1AAWrPQmviNGZ4caMd4itKWf1sxzuH1qF5+me6eFaqhbIg4k+6C5fk3oDBhg0zr0gLm5GRxK/lJtTNGpwsSwIJLtTI3zEdmNjW8bb/XKszf1ufy19maGXB3h6tA9TTHOFnktmDoWJCq9/OgQS0s2D7W7f/Pw3sKQghazRy9NqeMbRfHrLq27+Eb3Nt5PyiQuTE8JeAima7w98quQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) MIME-Version: 1.0 X-Rspamd-Server: rspam07 X-Rspam-User: X-Stat-Signature: t88gw4kis7g6aug31y3w7ofbt6yja6jh X-Rspamd-Queue-Id: 2099F120006 X-HE-Tag: 1741987262-976044 X-HE-Meta: U2FsdGVkX1+cb368XZt4K+Kjp13bm9Ek0FRuYivSdS0bfPFCUBMDm4R/Im9KzNVWcl6FmZkQ2aRugJQJPTSd4xyjcRIUltMQbt6zlQBns+dWGJzRdlkrO6CejwwB/lklyzkb6A7sXiyMU2EZefnQq+fXgpcXmrKezTMSJlJ8nRweMxWBJuUIr6shCUkUx/uuamfdgov/BccPWqbHFwWr+osjbJDFzg2l4HzQGFqMQqy8vyxK7OHjhwmCNfvvIzC1v5NPIuzITOwFrZMACXl83r5p6073cu94wCZw0WByuERDOclPdQ9+GQbvhYVkwQd7tZbO3f8bYv6pcinBJWC0Be29imAXeVFjBHXJokocQ+UXBI0s82IGj+HDvRmtSdFQYSp1nnl24WGnjj0kSK4lT2NB+QhcG2lG3Qe95anoC+zN7qpNnTsjtU3h4OMQdvyBJAjxN7c6L49dQiXlqDzPgP6lBTP1furaG6Me8LOuOfCcFZoOYylesOG9KZyr2K7wY9gn0mdJCTGKgfPWvyMcXqlPAFlXx6eErWJIBtFhDLqeK8+5hXYjnpDlkZoyefDjzzlkGHDSSy+8Dsa4Kjyce6qFhIdLFYKBug4oflPbfTpfVijuYJmIjUpxn9MbMec0R5NuRglIi3SjP/UUeCt7qsZHhXWrZ4/HbbkQ32GRRsG8N2iulqSghsLRt9O8i3wSElGj5lKRFLHxWW8FjTKg9A92C4jBXKei0Z844xnqnVZLLImO4354ePOHGHacIEjbj3JFoKBVoiV6VPaWAyw7V8EBgy+7lwa6Qek0sRQ5zjOeZyHNg6ayNjoL/aUjnQwB1YmkW8HASsJxLf8Os5EqW6x7LIV7gPNFMyGtqSIiGxIzZNVTJs5YZ0L+VKcQAnTjHJmHDOdZOUOEzw/LyMm2KrGC1X8xUUf3Kh92V9tZIvmUbHocR1206ioSpF7gd+slVWF5FXQUAMJNIfn76YJ lU20Wasj kc/NS44RQFH+W7fCzlndjzys/iM9hFymSvsGmOt5bgcu8opsgyuUsP2pdHv0/Amrc9OULbMXW+2qZgLI6Z6KC4dhyC3bnvMwpjGmeuJTSulPx0MJDIGJAkb7rKodPLilvLXZTBSA5HFDRf8sGJqT3lILSgGuC9OnxFOCLyPKoKcivXXwPXV5avWZDrOZ+3fEN7p/oJeAfA6kwak0ZwTnylLe1Wg8g9RRzi/8AO+MG80wW+xM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2025-03-14 at 05:05 +0800, Kemeng Shi wrote: > Use swap_entries_free() to drop last 1 flag to eliminate the need to set > slot to the intermediate SWAP_HAS_CACHE state. >=20 Use swap_entries_free() to directly free swap entries when the swap entries are not cached and referenced, without needing to set swap entries to intermediate SWAP_HAS_CACHE state. =20 > Signed-off-by: Kemeng Shi Reviewed-by: Tim Chen > --- > mm/swapfile.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 Use swap_entries_free()=20 > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 14b7b37996ff..0ce0ca08594e 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -1508,10 +1508,11 @@ static bool swap_entries_put_nr(struct swap_info_= struct *si, > unlock_cluster(ci); > goto fallback; > } > - for (i =3D 0; i < nr; i++) > - WRITE_ONCE(si->swap_map[offset + i], SWAP_HAS_CACHE); > if (!has_cache) > swap_entries_free(si, ci, entry, nr); > + else > + for (i =3D 0; i < nr; i++) > + WRITE_ONCE(si->swap_map[offset + i], SWAP_HAS_CACHE); > unlock_cluster(ci); > =20 > return has_cache;