From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A497CC25B74 for ; Mon, 27 May 2024 13:39:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C50E6B00AC; Mon, 27 May 2024 09:39:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 374D06B00AF; Mon, 27 May 2024 09:39:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 23C166B00B1; Mon, 27 May 2024 09:39:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 05A4F6B00AC for ; Mon, 27 May 2024 09:39:36 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AF34D81533 for ; Mon, 27 May 2024 13:39:36 +0000 (UTC) X-FDA: 82164283152.06.DEF986C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 777DFA0006 for ; Mon, 27 May 2024 13:39:34 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hEf6kgG7; spf=pass (imf15.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716817174; a=rsa-sha256; cv=none; b=5hUsE3b4k0ysse5UxUC4HqX40DU3122BsxkPV/6ppcndYkPadxoPJKJKwk2n5bc1mYm6Vv 4SrS8dBfpiYLp/1tD3g2bXMyAR5gEOreaEuRL3PZf+818Zqs+CzYWFz9gCQ4qM3rWjgQoQ Ad1eWrtED5+SnFbKY1CNX6xyLl9sP5U= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hEf6kgG7; spf=pass (imf15.hostedemail.com: domain of dhildenb@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhildenb@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716817174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2eC1AqL9QH4TVSIhzgj/eAmDmIh2MF6QUCJEMwiWIh4=; b=4marCZEjrz9dgh3BZJtoS1FSFIdcyvgMIj1EJ4FvJkP5zvPcYBYXQr9rk2x4NilqaNzMRQ jqU/uf3cCvQnZTRMcJhfKFeNuIdQOsEPAuTqKjSIEK52NFhJ9EMlp1HKBfA2AynzPaNa6g h3iOdBt7asoc62qZbrFON+bDDx4npik= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716817173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2eC1AqL9QH4TVSIhzgj/eAmDmIh2MF6QUCJEMwiWIh4=; b=hEf6kgG7EQWP9OOLF1Barx7+2rADwTNJck3TjD6IqcFK/VexArPDxo7d1yhzBqNGxDF6sW U64i3XodQKDx3Jb2BBb12njLyz+4R+hqwLs8krqGVgP+bD8xxurMQSSr8ia7HZ08QbbEK3 0UgQKETcFoCOZgjVvbF/WJo2tDuH/G0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-37-XRn1eHSoOYStTZJOXXSK5Q-1; Mon, 27 May 2024 09:39:32 -0400 X-MC-Unique: XRn1eHSoOYStTZJOXXSK5Q-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-35502b6f973so1738542f8f.0 for ; Mon, 27 May 2024 06:39:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716817171; x=1717421971; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2eC1AqL9QH4TVSIhzgj/eAmDmIh2MF6QUCJEMwiWIh4=; b=dI2RPXrj6/bNPR9UywyTauJsIA0ULh6D4JqBROlqzDnXoynesyDAymbHGonHFLI2fL XK4jZqBjP0U8OFYulPH6OqkyyhHbRfFPgLgJ0xWtaav6TZJvSrr5P6IcVFuqzQ1Q9Gh+ KpawLJ4Nv1Hn6yOoxLRRK2jCGlfbBzmOee3G0/1pNRhuVa6WCJf+2hDa0e1ghcHyxfsa LqDn0MZVj8wbJRv5J0OiuJB7bvobjnGI82ptfUZLZi454qVjxowxKFwZuAlqPfTJTq93 QJNC8KQ6sUdqSgy+AmqQo+Xx7ta3b+4y0bUJ0RWaxzUxe0Ada8n6i3S4uqQJsWRqB04k +IZQ== X-Gm-Message-State: AOJu0YySFlA5OsMYzw/+4Ez+2tvgPa1oXzPKriiucDIDyK/yEqs6CawD TslJAnep1fVlTj0jy5WMWO9SRsptyEjNNUAmIhXTVC2E0QjhUsChB63RtdipiuFLZa1QD6EXNuS Vosj1BR/e2PNlScDKaD4a6OFYWXrrpWhl0o57+t3gn4riX4Ex X-Received: by 2002:adf:ce91:0:b0:351:dab1:1c72 with SMTP id ffacd0b85a97d-3552fe19370mr5518359f8f.47.1716817171289; Mon, 27 May 2024 06:39:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGJi2vIIxWHVtVaqrk9KpM8qaLYbVgc0Qr6RygT7+fixJZT0bBXLoaHrSAeKoaGf+A5cmf0/Q== X-Received: by 2002:adf:ce91:0:b0:351:dab1:1c72 with SMTP id ffacd0b85a97d-3552fe19370mr5518342f8f.47.1716817170911; Mon, 27 May 2024 06:39:30 -0700 (PDT) Received: from ?IPV6:2003:d8:2f28:4600:d3a7:6c26:54cf:e01e? (p200300d82f284600d3a76c2654cfe01e.dip0.t-ipconnect.de. [2003:d8:2f28:4600:d3a7:6c26:54cf:e01e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3557dcf08basm9271206f8f.108.2024.05.27.06.39.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 May 2024 06:39:30 -0700 (PDT) Message-ID: <6f2da186-be75-44de-bc3a-e7f6d0e23498@redhat.com> Date: Mon, 27 May 2024 15:39:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: hugetlb_madv_vs_map: Avoid test skipping by querying hugepage size at runtime To: Dev Jain , akpm@linux-foundation.org, shuah@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Anshuman.Khandual@arm.com References: <20240509095447.3791573-1-dev.jain@arm.com> From: David Hildenbrand In-Reply-To: <20240509095447.3791573-1-dev.jain@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 777DFA0006 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: f7i8qqdjpbsmrkjesomzpnraspia6cgs X-HE-Tag: 1716817174-125881 X-HE-Meta: U2FsdGVkX1+zfOQ8i8QnwTZt6myIqizQnkGXIUcL+wfk2OuC2l5gY/TJg3PUpyrOJAmF+MZrzrnx6wHnbph00DK2H+ido8tkdUm+3Qwx66wcJKA9tACu9dwcc3dZxA+SNxAaFj7mnWvLVkOQjSib6qbEymB3sBQB2edOS/4BAnaSceIPexd9W1CrE5UD6XELlDEFMtYOOJyLcJayXSUHwuMX7j9CtZ1h+J2fUcyIWmYaVLLd2fI9BdKhJdfXwe9+acCgPkHqQG+su0L1BQlnjCo+6mTfVETVdFpSwVsFPKV8mFPjP8XDo9C9dpyndIwumY3nbd/R6VWXkMCEN+fmJ5LO272s0HUVh4m39ejvVaUcpnw3fHZ5eud1cYeAvq0RCJX0z1hObhDw6EvFrhDSAVO3u0QVUXZ+5kYWmnIzWc5xvKOK8gs+TA7JbLMc+e9dQwJ3DnrwctnLCzehpafGk76OZwzMiKy96q7b/dwGjksbH/Loc0chr9TUZNX/rTmcvfGFI128fVVnY/fJ4z4KY0ECf+KPVzvWl0eUNjKytp8DsCPLKYmPQmPhWeMVzLRLE5Bk/H2LJl0NmwlohdZPXRFHRd0DWK5GIhjlewb/F0tz3z2uET6WCJObNlkl8itBLvTV3jNyXXWBnmLmGFdbSpbRnfKQR7/A2zUyc6ZPzp1aQk0wLF/iU1GRDBHqBVmqAiVBM+GDvqQPo+p9lniTkd16f92eTJ6OU07bWgDa9YkBbajsu+TceO3KMvBsPe3zUtwT/cFNj+6yOZRNZMY5K/HL7V7O1P+D6O+eLbqTHFzCinE6yVnFTQMtCTrI+5RJIO+5RA0m5WupajSiO/HgvoCrO/Gc0XdIdjMWJqBEbPTqFYurQi4YBpgAWQkDoboYmGBZ3bP6kPh1JjWiNTR959CuxZFUB0R+o4WkL6p32f1aGUVw8ld+rQpYAcKFd2En5e1bqXWE7nL2CKd0RvM gnKD91bs vOv57OB9kL6M1oG0NISevmMhYYTFHLxIaDdVp2uIECdUJeHplI8L9A2i7WBJe8JEVlJQFpHdj5ttB+IpU3oyYITShdbA8bsduWOlM4RqyOAgmCz3fN5Zad2DUv12JglQGG7Y+HVILHaBob9eP2QyZJSvkCBBixXM2nPJ2EMHbk1p3ARuUYKhSk8lJSayOHo5rRV5mM9dhBlSSfCMMEibbabo8Y3kAy2bmr5Cd4JDQV/HU6Um2a8TKrN5ZU3RetBNUyOdY5+e04BPGmIxX+l830YV58eCCQEV/d1mjWNGwoa29X+p1iiuHKmVU69S61xZ09l29ALY4zKiyaDr7tyitubSvLiejyPgmgWyYiHmL8Rfw93nUOYxlYNawfEEx88SYG4O9Ao3/UV343tceZ+rvvgHsAB+7X46LY+4uY1DRyobvdnSFPj9IN71TLBPXLp8oQ8hHCFg5IQda5YketMQ/DbwNeeiyGrUPrbyy+w3h/nT/HXGh8NShJ4k2Cif4NUcNZTe58sFz8a6nflwHsbnCc02psPbfytMCIFbjudE/nw8WB8GJxrgmyeWdhw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.151788, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Am 09.05.24 um 11:54 schrieb Dev Jain: > Currently, the size used in mmap() is statically defined, leading to > skipping of the test on a hugepage size other than 2 MB, since munmap() > won't free the hugepage for a size greater than 2 MB. Hence, query the > size at runtime. > > Also, there is no reason why a hugepage allocation should fail, since we > are using a simple mmap() using MAP_HUGETLB; hence, instead of skipping > the test, make it fail. > > Signed-off-by: Dev Jain > --- Likely it would make sense to rewrite that test to try with all available hugetlb sizes (like cow.c does). Acked-by: David Hildenbrand -- Thanks, David / dhildenb