From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5DDCC04A95 for ; Wed, 28 Sep 2022 12:45:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 60C486B0071; Wed, 28 Sep 2022 08:45:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BCCE6B0072; Wed, 28 Sep 2022 08:45:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 483096B0073; Wed, 28 Sep 2022 08:45:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 36ECF6B0071 for ; Wed, 28 Sep 2022 08:45:09 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D5466809CC for ; Wed, 28 Sep 2022 12:45:08 +0000 (UTC) X-FDA: 79961464296.24.BB0DCE9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id DF7631A000F for ; Wed, 28 Sep 2022 12:45:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664369106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uufQYKHlB4NMDLgfrNjl6fs7TYc608vt4M1Drzs/IdQ=; b=EgSsMitTgjGRcjmAMhpxJb53Mx89pVWvUoqi5VIh7JEtc9jGR/l4oLZNDTGoGhvR2Nkxbb xxTvdBUswWTU8QljEnbyY3TnBvbuCbP/MwoPt70eT9ipTv8DkimOrz6uK+dlf0iovhpL9X j+5nUT7lY3KpXDY15z3+FvHzOSbi/UI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-625-T0EnyxF9PQKuCE8FKuu2lg-1; Wed, 28 Sep 2022 08:45:04 -0400 X-MC-Unique: T0EnyxF9PQKuCE8FKuu2lg-1 Received: by mail-wm1-f69.google.com with SMTP id c3-20020a7bc843000000b003b486fc6a40so518894wml.7 for ; Wed, 28 Sep 2022 05:45:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=uufQYKHlB4NMDLgfrNjl6fs7TYc608vt4M1Drzs/IdQ=; b=up+T7ZV+ayGA9ZIHqf/ANGMwfzvr2sWWWzT2QquLeupZ1GGzncseHePRYU3PpG6yz0 Qg561INspkY2+i9E6/dijHNFlQZSttJFoQobQE11cvSgL+vjcJR5LCLUKFXt+wOYdqjJ WDehDZv9XJ9dSZSofYbg7J4+4d29CnkW6IPdT/IU0BrWZCnbzKhFkC3zWfU75Vm1z05P rqtAOoPE48wnpjuwVoef9n7iBVLbU8zofp0zp/LQvrHAZpzovlyLtJ/kB/7Kg4Hi+6pX cf94R6b12IRFE5N6OuxLf/o8qR8U4RQlDZF9Ol6On6i+ZTFJSK/8zkTUtgCbdb6qlxzy vfoA== X-Gm-Message-State: ACrzQf22AStcoPtWw0DRulCmUXMonraXThpqtijxKHrfEGBw1d2ckZkJ HpJpc3Hv43kxk2BD/BsuCMGkGQvemko5BZoNwSIrSAsq18UH1rlpqV3nE8Vw/NAurkv7j/B+plC RX7beA5m8MMs= X-Received: by 2002:a5d:54ce:0:b0:22a:e653:654 with SMTP id x14-20020a5d54ce000000b0022ae6530654mr20853564wrv.134.1664369103796; Wed, 28 Sep 2022 05:45:03 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6DXGXWYtOD1tp72GMv95ymx/s3vXL+wcRLQZFw20ZkjuJBEtRIWnmJ9pGR6pi/ghRFhlc6iA== X-Received: by 2002:a5d:54ce:0:b0:22a:e653:654 with SMTP id x14-20020a5d54ce000000b0022ae6530654mr20853525wrv.134.1664369103389; Wed, 28 Sep 2022 05:45:03 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:1100:add9:5f61:6b94:7540? (p200300cbc7041100add95f616b947540.dip0.t-ipconnect.de. [2003:cb:c704:1100:add9:5f61:6b94:7540]) by smtp.gmail.com with ESMTPSA id p13-20020a05600c1d8d00b003b332a7bf15sm1635047wms.7.2022.09.28.05.45.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Sep 2022 05:45:02 -0700 (PDT) Message-ID: <6f2615f2-27c6-34e5-77f3-166d0e7b6182@redhat.com> Date: Wed, 28 Sep 2022 14:45:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH -next v4 1/3] selftests/memory-hotplug: Add checking after online or offline To: zhaogongyi , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kselftest@vger.kernel.org" Cc: "akinobu.mita@gmail.com" , "corbet@lwn.net" , "osalvador@suse.de" , "shuah@kernel.org" References: From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EgSsMitT; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664369108; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uufQYKHlB4NMDLgfrNjl6fs7TYc608vt4M1Drzs/IdQ=; b=64ZI87CPT9ZP5OR5DIInGvOQe5sqy53tV6ZvcqV0EHgCQfgMhiZUQhyAtxFuKjZhf1LKNk mUCEdojv4eBbXsRNPcJ803syuaWW/zLQPYxOs8x8RHcbvTryqS7OcE7sAWuDAxDIdSRxl9 wex7Qk97HrxOEPUemxZ1ntmDX+FXDtA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664369108; a=rsa-sha256; cv=none; b=mfBWasDCwP/M0eZ/RKMm36o73xApZ9aIyU3QirwfsXYrUD+6M1ycNg5esJs0+8FhmYOdlF tA+yGLJgYd5KzowV6yrCRmFSDlFAnY95ibuYDPk0QeCuAT7FtEd9GotgWS369BHlRqe7Qs ya+nyV00Wg5ZqKGdrHLx+oJG422Vf1E= X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: DF7631A000F X-Stat-Signature: 3qyoduah17xc6m1stht18u9rkrgicwyz Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EgSsMitT; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-HE-Tag: 1664369106-777536 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >> Reviewed-by: David Hildenbrand >> >> >> I am questioning the stability of the offlining test, though. >> Offlining a random memory block can fail easily, because "->removable" is not >> expressive: >> >> # tools/testing/selftests/memory-hotplug/mem-on-off-test.sh >> Test scope: 2% hotplug memory >> online all hot-pluggable memory in offline state: >> SKIPPED - no hot-pluggable memory in offline state >> offline 2% hot-pluggable memory in online state >> trying to offline 2 out of 96 memory block(s): >> online->offline memory0 >> tools/testing/selftests/memory-hotplug/mem-on-off-test.sh: line 78: echo: >> write error: Invalid argument offline_memory_expect_success 0: unexpected >> fail >> online->offline memory10 >> online->offline memory11 >> >> >> I guess this test will almost always fail nowadays. > > Offline some memory node maybe failed as expected, but the error message is a bit annoying. Ah, I see it now. We try offlining two and fail offlining the first one. Can we silence that warning in that case somehow? -- Thanks, David / dhildenb