From: David Hildenbrand <david@redhat.com>
To: zhaogongyi <zhaogongyi@huawei.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>
Cc: "akinobu.mita@gmail.com" <akinobu.mita@gmail.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"osalvador@suse.de" <osalvador@suse.de>,
"shuah@kernel.org" <shuah@kernel.org>
Subject: Re: [PATCH -next v4 1/3] selftests/memory-hotplug: Add checking after online or offline
Date: Wed, 28 Sep 2022 14:45:01 +0200 [thread overview]
Message-ID: <6f2615f2-27c6-34e5-77f3-166d0e7b6182@redhat.com> (raw)
In-Reply-To: <dd8998bcfe0e4b82a617dfd79d93368c@huawei.com>
>> Reviewed-by: David Hildenbrand <david@redhat.com>
>>
>>
>> I am questioning the stability of the offlining test, though.
>> Offlining a random memory block can fail easily, because "->removable" is not
>> expressive:
>>
>> # tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
>> Test scope: 2% hotplug memory
>> online all hot-pluggable memory in offline state:
>> SKIPPED - no hot-pluggable memory in offline state
>> offline 2% hot-pluggable memory in online state
>> trying to offline 2 out of 96 memory block(s):
>> online->offline memory0
>> tools/testing/selftests/memory-hotplug/mem-on-off-test.sh: line 78: echo:
>> write error: Invalid argument offline_memory_expect_success 0: unexpected
>> fail
>> online->offline memory10
>> online->offline memory11
>>
>>
>> I guess this test will almost always fail nowadays.
>
> Offline some memory node maybe failed as expected, but the error message is a bit annoying.
Ah, I see it now. We try offlining two and fail offlining the first one.
Can we silence that warning in that case somehow?
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-09-28 12:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 11:56 zhaogongyi
2022-09-28 12:45 ` David Hildenbrand [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-09-29 12:08 zhaogongyi
2022-09-29 7:39 zhaogongyi
2022-09-29 9:04 ` David Hildenbrand
2022-09-27 3:28 [PATCH -next v4 0/3] Optimize and bugfix for memory-hotplug Zhao Gongyi
2022-09-27 3:28 ` [PATCH -next v4 1/3] selftests/memory-hotplug: Add checking after online or offline Zhao Gongyi
2022-09-27 7:26 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f2615f2-27c6-34e5-77f3-166d0e7b6182@redhat.com \
--to=david@redhat.com \
--cc=akinobu.mita@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=shuah@kernel.org \
--cc=zhaogongyi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox