From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE804C5B549 for ; Fri, 6 Jun 2025 07:58:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57F346B007B; Fri, 6 Jun 2025 03:58:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 557426B0088; Fri, 6 Jun 2025 03:58:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 446DF6B008A; Fri, 6 Jun 2025 03:58:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 251336B007B for ; Fri, 6 Jun 2025 03:58:55 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C0D3D1D6874 for ; Fri, 6 Jun 2025 07:58:54 +0000 (UTC) X-FDA: 83524224588.08.F8278FE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 3E603160011 for ; Fri, 6 Jun 2025 07:58:52 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=etPgg1oP; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749196732; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rT+6EOEZOyjryWL73lnRtwCrh7JgiqBpVgBnHHhLL2M=; b=oHUN0Mp/U55P36ZTUe3jzyY3xLrXb2wRifZOormmHpKTquywutPFZm+uJXmnl9qnUnhIfs s5wjIBZ45TPckJtL3kHxkLY7S+g790uBvw3oToeAhBVH5d73UD10XHWO0U0+ThkEOsr6uD 1gW08LYCZhuYCacXBSDzL8ghVhHsYK8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=etPgg1oP; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749196732; a=rsa-sha256; cv=none; b=0Iva9hBgFlvqb+mJhb4BwJ9j6dTrgNuPquYYKeUG35FMfyjdBOo0zC50ev18V4lGxWEZpm G8g/Ec+cgntf6VrPK7QEbbZselzwDHERhFtp1ievezhu8gUff73fByPAt6Q2RqglXSWi0h YiShu1My9CZvfHGB0gEoVXOBJjZZ0yk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749196731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rT+6EOEZOyjryWL73lnRtwCrh7JgiqBpVgBnHHhLL2M=; b=etPgg1oPE4G9E3rK2S7dAHBPQknS5pdPUnbZzRrcFQrQ9DD8wmFlNSuEapodQG7de8W622 GcQVabZ85u4IqjheBMQnBUtV1BjAEytq50XkVolUMtkiqOz+IilenmksXpdsHLgYZSWOv6 I4h1IYAPTVV74cIUJNoU4d4TstxwnZk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-354-620N7l8PNS2YtNx1bZeBog-1; Fri, 06 Jun 2025 03:58:48 -0400 X-MC-Unique: 620N7l8PNS2YtNx1bZeBog-1 X-Mimecast-MFC-AGG-ID: 620N7l8PNS2YtNx1bZeBog_1749196727 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-450de98b28eso14646775e9.0 for ; Fri, 06 Jun 2025 00:58:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749196727; x=1749801527; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=rT+6EOEZOyjryWL73lnRtwCrh7JgiqBpVgBnHHhLL2M=; b=wys5cCIbUrla8ZbTRxj/SDVIRd5nKn5YzUBfIMKI2M/URHisxRbl+LZpYaFpxhwT4h fBlUAaT2VSScTj3ShWCWUquEw41H3ei+ZTYdnBuQ4wt0xlZvVN99L7e5URtielPDb2wl iFF8JjUcyqLX1h3aSV8TLKwxe+TJg/J44s+xZfUOnFnQCleBjAkda76rMSwzof2DEu4N 0+0TBt1RzmsM4mZRcdGHsCncD0houUxIQ05mIJAbWDgJzTGiGTPpzXVS6FUF5vcQrcNw UErgK4ynDQMmXSO7M0hRvmHrnXlxo14fL5KHCTmNitz6lwdf2xc+ik9Ll20O6FOMphwU 4C9Q== X-Forwarded-Encrypted: i=1; AJvYcCVbD2zzTQy/NA3n9KeKFW2kk1oyEhJNA3toLVxKvCsPK80+3lDGBteJBg/vZDNeYQLYmHZsTQRiPQ==@kvack.org X-Gm-Message-State: AOJu0YxgqhUJhQ/atARSrkpv3Cw6HXDW1SH82f35io/KAZlMil+xZl0+ E49aC5ZPBqoo7ovaexd5SWNjnIzw9tL6XGoUcqmVsD4SblYmucxFhEbqzqv85cjg+XrOrgfyDsy 7u9d9Ehf2al0BNOlXyjK4Julouo3oV1tbfzt9D6fvXRdwTHuf0nytIfM6Uf9F X-Gm-Gg: ASbGncvCWzjxsm4iUDruNl1y3ZXDXXXP2aJKOux0giqxhV8grDhBHSmmtf5q7kd+eM2 M50tfaRWfGz4rolafSwNcnpUd6PwBBr4qR2TNBvuQUV1ZBCUU9sARy7ICMAy4gUlAh6iNGPTHvP guWsS5GFv+s/nsXl+ZjtSrvc9ksuGjItmFwF98tGBXKbJs7zZd3wlCl80GOevzEiKmK3bgSfJml ZhPi4dhxGYlulNAY69wAnKWrKEHHn3vefmbrCK4HWX6cgffIBbwBM69FTLDXoWgz050uOXeA0JP dSFMsGI5d2x5tdv03VMwLKndHVAG7+oLCAJ9TcKImaY= X-Received: by 2002:a05:600c:3513:b0:450:cabc:a6c6 with SMTP id 5b1f17b1804b1-4520159f6fdmr22511185e9.15.1749196727038; Fri, 06 Jun 2025 00:58:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFBpu/aX9JVdtPj2ilODNwEhj9UPbOV+IqXXilwZgYYw6kZ4KLLRjVEysvaRXHTSemDq8Paow== X-Received: by 2002:a05:600c:3513:b0:450:cabc:a6c6 with SMTP id 5b1f17b1804b1-4520159f6fdmr22510995e9.15.1749196726654; Fri, 06 Jun 2025 00:58:46 -0700 (PDT) Received: from [192.168.3.141] (p57a1a6a5.dip0.t-ipconnect.de. [87.161.166.165]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53229de01sm1156559f8f.11.2025.06.06.00.58.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 00:58:46 -0700 (PDT) Message-ID: <6f0ee0d4-60a9-4453-a08e-2353b234dac1@redhat.com> Date: Fri, 6 Jun 2025 09:58:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] gup: optimize longterm pin_user_pages() for large folio To: lizhe.67@bytedance.com Cc: akpm@linux-foundation.org, dev.jain@arm.com, jgg@ziepe.ca, jhubbard@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, muchun.song@linux.dev, peterx@redhat.com References: <8b68e7f0-46b8-4814-99a2-02f0044cda9c@redhat.com> <20250606073727.82993-1-lizhe.67@bytedance.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250606073727.82993-1-lizhe.67@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ex4FLQPc0oVZ0twLwd6WAJKt-ZbCSdJuYm-92BYBXxI_1749196727 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3E603160011 X-Stat-Signature: 86en5doa15seci5efor1pmtp5wckq9u9 X-Rspam-User: X-HE-Tag: 1749196732-276316 X-HE-Meta: U2FsdGVkX18uWcEtRvdg0H8x5un8Ri7J0c61j3U8wC54lugTyw+IYtlqVudIhNN+b+E1Yx5CVgH6YeTMphmAgt/z3JqJRPCbguU8GOHFm9wm07ZcDZoZXajLe0JihdCeXtb+LFcyiaaDNEhegzrYEZ/QMFiGN//DxZjLWKvXoWwhbgvEuPZPyfPYXX8c/V1WAK77spxZDCobGoN9uzIqzbjQlgEffMfILVzFlYfDXbGNOXFBvLodBCiSENYjOixdXFXTSM888/Tm7ddIS1ZDi5lzkJG9y99twbLrtqY5w7nhg0mvc+PcMjW7VWO4mfDI/M1pE8JiigHon/TPLI4busHVAZxfw4p+yzKcvbMtjIRMIaJasS4fYp/D/FCVzIQzBnIRPpMbLttwoLjtN9HyO6Ezq5bnrcF2Qia+/JiUgi8WYfDve3iMtrjc0hoVYtgt9XRLPaFZ+/rZpvP+TzqSA9yV1hQ1Na43InTukD44Tels9ikI6pN2/zoPU4qY57Rbl2xdnoQYop9HnsS6rLpcxxKJshz8ONV/scXFbkkulBnk3FwfDqmsX7q8vcEo4B0CMMkSNSXmCmkncINZ+2I28UwURzKO6ZO+O0rVfqhg+usJgN85INnRHjRvi5ciVCjgbzvZtUeLgVgqeGlUghnZytEVul7pLzZD5EGnv8andTCGTuaPjLsza3NwNFVMceek2o0qfCH+Y63wGUuc42TfKQ0JcnSQB1IGOsJDnxUb8DTZgzrpbLshhgFtbcNL855E7qroOVmo19CnWvrI0KDbCnnzrsqXmQd//V0hfIL9B29JWA+houuinO+kOW/6jXmx5fS1nIexVk18JSJ3t14hJcNnEi6LJaUvOX4IspNlBPQuTbDxNW8wmb/PfZ8YvXoGJaSTUTHkPZ/TML75Kj/IhW4QMRbyhkMovclCDfMGjkyQTjRZV3+wdky3Th3zgjAjAuNxglzMzph+Cx1459r EPEGKuMf E/aiOzpe/hWAREwUP4tiJ9L6I+VE+p8Hhs6dTex8DPyEWExGP4uMPD+QyWd3fhM4RXt6gT447hIHuTQ9obTsJxQzKUGD2NcX0bt3+euZaHLqz276EPgXHjpwfJc0+ds2TMNn4xJHsN0deH3CTN8S2JxTwjI5HhNfafiZm7L2HXnOsSMOm5Xx8TvdYkttzzs3WAr2Pvri4ID/qxxqQ2a1PeXj20VGYGnWZ6ta7Pfu6gmT0grlu0xCMA291lwOg693JpNFAzK0eZNc5TTrhDWKk50VRv6CqP7PKaP4mpKcXIqEJ65BtYXdSwUt/PwM+D0Eaajndur17J0PFem1PYefr0OPMLRxeKCx377HlkMx28+HGOeRYmjpJOgx7dlyF1uSqCW263b0RZkRj0OhszKtUClX/SRQRRSjlfxczJgdsr9HgtlqJ75f/E8bRXnAGI68P4VqA+w2MhCYARXozEbaYXiPnjerIU+bGcS6ERzvyk1o1W7WWJ5G3+oO+IxNjHuVo0J4fBw/skvyKdNwyWGBk1o+DTK52sB7HCEXU60mKSMhtvuSUW9Yw4tnfuA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.06.25 09:37, lizhe.67@bytedance.com wrote: > On Fri, 6 Jun 2025 10:37:42 +0800, david@redhat.com wrote: > >>> * Returns the number of collected folios. Return value is always >= 0. >>> */ >>> @@ -2324,16 +2349,12 @@ static void collect_longterm_unpinnable_folios( >>> struct list_head *movable_folio_list, >>> struct pages_or_folios *pofs) >>> { >>> - struct folio *prev_folio = NULL; >>> bool drain_allow = true; >>> - unsigned long i; >>> - >>> - for (i = 0; i < pofs->nr_entries; i++) { >>> - struct folio *folio = pofs_get_folio(pofs, i); >>> + struct folio *folio; >>> + long i = 0; >>> >>> - if (folio == prev_folio) >>> - continue; >>> - prev_folio = folio; >>> + for (folio = pofs_get_folio(pofs, i); folio; >>> + folio = pofs_next_folio(folio, pofs, &i)) { >> >> Nit: indentation is still off? > > In my editor (vim with ts=4), after applying this patch, the folio on > this line would be positioned directly below the folio on the previous > line. Documentation/process/coding-style.rst "Tabs are 8 characters" :) Good choice on using vim. This is what I have in my .vimrc regarding tabs set tabstop=8 set shiftwidth=8 set noexpandtab set smartindent set cindent -- Cheers, David / dhildenb