From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93ED9EE4993 for ; Wed, 23 Aug 2023 12:15:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 182DF900018; Wed, 23 Aug 2023 08:15:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 10C358E0011; Wed, 23 Aug 2023 08:15:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC7F1900018; Wed, 23 Aug 2023 08:15:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D63FE8E0011 for ; Wed, 23 Aug 2023 08:15:13 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AD1651A0639 for ; Wed, 23 Aug 2023 12:15:13 +0000 (UTC) X-FDA: 81155264106.12.B4FBFD5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 7D9E3100022 for ; Wed, 23 Aug 2023 12:15:11 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WWv6+LkA; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692792911; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TFwWSzRs0xwFrDqvvFOgPgLU8OzIU2Ty0NqzM9qwE2U=; b=DSEYFsXbxW2ljGnu2j/LOlers9W5N6Cv73FoKJV45NkrI4sgFrwnwKUDMw6PYvDWCh4jXn 1DydhkYHv0druNGCSODhpqftvcotrre0kjimR5nMhMAZemZkeRScYXM4Fi8EcJvvVCY4q0 EVIQHf0cFweVkMvwSCt1G3CH4KC5ru0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692792911; a=rsa-sha256; cv=none; b=I1go5xdGfYBRtNVJD25BRH/rwX+n7HBIbnZCPwVboDQiynj7EowzZueVhSyvW1WyiIR/5h FjxeA7UIJCZxlMKxjwijCdsYgLj50RaboLLW++LaycfBYLL3Spgzp/LT+DP8nAk2lOg+GR R3TlfZf2aODIzcee5ZeQp+tygK7WWnA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WWv6+LkA; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692792910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TFwWSzRs0xwFrDqvvFOgPgLU8OzIU2Ty0NqzM9qwE2U=; b=WWv6+LkA+DkM3ithJP2EkGdGwTqjbrO0fTobJ9FpircDB6a8TkFonmf4y1MlUxPukrscZE ztj5wCalNPVJJPHcYjggegNhNPwuhNg4D24Bh4EzqvQu9+lVN2+kQreOm1B3+xbXcEoB6X E5/nMaYYfq/OhBUZXx/OaOUPcWuVlYk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-664-hzw3XgxFPuyE-_3zt9HwLg-1; Wed, 23 Aug 2023 08:15:09 -0400 X-MC-Unique: hzw3XgxFPuyE-_3zt9HwLg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3ff00714328so6041855e9.2 for ; Wed, 23 Aug 2023 05:15:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692792908; x=1693397708; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TFwWSzRs0xwFrDqvvFOgPgLU8OzIU2Ty0NqzM9qwE2U=; b=LTBFNIiotR/iF/s8hzFV8Nque+FaM2zrT8X1bNrpNlZTmeEeFUCCQg4+xZe+cEwYKo fq4Nyo/J0nOoxNxRs88+DASiY9itymqyJMM0xt4qyTge/JcckiuUKf5PTtaS6nKfaiiQ eDdkZqlxNPSJvlJYJ52m4XoKS+UiugHt8gNpM0f5/rCCflw/as1G2Lsy1qpkSnU3VV0R K2roUZuT96PX2qry8PXzIjWjQVydXAgVqkzWXSAd5eS59m6L9zqLV0jPG3KQY+Jkf10p 3k9U5J8400gb2W3vdTakgKkZqT/9aoWXCZWpOknf9Deri6YqfQDD0BgPJv/Pr4VoJWPC 34FA== X-Gm-Message-State: AOJu0YyzI+h1bbLAvxpbzFjCkNyPnD+Rg7G+T/g3wT6FiPiLAf47vWIV +sDeD29cHkAWqaDCEOGshKeqruT7/c+o1NIt93x0/Ny4VTmpV6mz/9TfNWRBD6UtF/IEsWHIPxq kb10rmcIlqkQ= X-Received: by 2002:a7b:c5d2:0:b0:3fe:15e7:c8a1 with SMTP id n18-20020a7bc5d2000000b003fe15e7c8a1mr9728616wmk.16.1692792908352; Wed, 23 Aug 2023 05:15:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG28nStaH2pAlw8WpvCGW2tEuMAfhtZM10vfd40F/qfUC7bXlTCBmTUICuBOgWznLA2QpUulw== X-Received: by 2002:a7b:c5d2:0:b0:3fe:15e7:c8a1 with SMTP id n18-20020a7bc5d2000000b003fe15e7c8a1mr9728594wmk.16.1692792907985; Wed, 23 Aug 2023 05:15:07 -0700 (PDT) Received: from ?IPV6:2003:cb:c70c:e700:4d5c:81e2:253e:e397? (p200300cbc70ce7004d5c81e2253ee397.dip0.t-ipconnect.de. [2003:cb:c70c:e700:4d5c:81e2:253e:e397]) by smtp.gmail.com with ESMTPSA id v6-20020a7bcb46000000b003fbb25da65bsm18776863wmj.30.2023.08.23.05.15.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Aug 2023 05:15:07 -0700 (PDT) Message-ID: <6f0a82a3-6948-20d9-580b-be1dbf415701@redhat.com> Date: Wed, 23 Aug 2023 14:15:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: linux-kernel@vger.kernel.org, Andrew Morton Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, Matthew Wilcox , Peter Xu , Catalin Marinas , Will Deacon , Hugh Dickins , Seth Jennings , Dan Streetman , Vitaly Wool References: <20230821160849.531668-1-david@redhat.com> <20230821160849.531668-2-david@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH mm-unstable v1 1/4] mm/swap: stop using page->private on tail pages for THP_SWAP In-Reply-To: <20230821160849.531668-2-david@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: p4rhe5dqoqohpzfzf1jp61s7djoab7b7 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7D9E3100022 X-Rspam-User: X-HE-Tag: 1692792911-747367 X-HE-Meta: U2FsdGVkX199eG1hfbUvkybxqkroTAL7V4df98nMezumPZIAVPunqGki/Wv8Rd+AoOlWkWZpOoOAKBfkR+AQYVNpP/8GSCaAlY99A13PgLz9l79TLFYmpMPka5Cd2zuBVzngXvH5aHU+b8Y4ihOaufvIzOpuFpREX1UOqFPW8a2nwUHoZ4vneghqISfN42q7QjmFmYCJL7F64eiXZpKZMOSDIdbVdCQD7+GNAdqwDbHXvgFlPGHVMwOvLkETQxGvn/moP+Z/B8jamJAqG7VkoFeGTDD6jPpfoZcBNrCKPiBhIutUn0TLtXwRxrxANDjcLPobIYqpkdVt9iaid11ylvYjGk52JxjRDsuHbJuHm2YFzQyhO5XJvJWlVZo8KOm1UyVccmbPei7x1SulTkLG5npOuqBXV4G5Fe/iUWn+n4mPzbh1Fjdp0eEqcMKDAd0APfhwRKQe31KXtpyBxiNYb0v0GTABL21qf4MlSyj+RfvgOt6UcEkcAkv9RJR8q/KX8x0MmvvSicSVi2kBleLE2aPH4cCbZid8ayl5Qa9UXNIkhazI7h+u9EUyYWz4gi1WA9nc33tD9rUdjUtlCsy+z0Lo3dh2AxO5pqZkObP7auDyzYDtgseKZfRZn1Iq/6qTm0wb9dqv0nq/HBaffSZLlzUPeu31/rGIKf7cxKWKSUrovYdaC+BHrs6EHI8RF8UM1KJuiiCnPLSptFz+wn8ENp866KnP8nPn6wVTkrqvKgNmP1qKGgpsoiC4QHckHMi/XMQc72LKjQ6NuZSbcpa3WTnsiTOlPeFq+/0SYN8BDL1GSAbVK3QWp8giSHHD+iDO/zV2qiAkMWHa13gQ9UEw7kcu8yceZZWqTpLB/jBjLeoXsnKTNN8lGOeYLrG0KL/AE7PScflOW3Z6CY+jNgv0d7STThKKOadxQEatpDYnRpVJs+IH4qEum2gkDpoEQaYx33rnrm6J/ujmNFcnMRB 89XA1WbU 7YOAgnzP1/ZQw7GC2u5/bNEsy07ksmoYutl3+tQBcMFGfyu2OHlnJllA0XHq3CR6fHuR/OKr+6sdAz13wfaG3P+pKkMoXN/w4oazh/IJn9O7cf/JuZnSsprPozZBGJSPaRHsx6HXHxsWJbs7kfwcVx9LTJ7XT2azmfAzwP+u9ZHzwKIuaof6lIRh44h6jpVuZj38UWGCYP0HZ+XccuBJVixyYOhjhORx8eQh4gE6q5W1uZoBfL0MpnT+/qf8I/+hd69Acouop+S1FnfBLih8HM/jOuIMO87UbavFCxfTv+tFmxQLmxRDRwQy9INDYZTaKmQqBLsqpmT4Nak0JwW9adKlO+LLK23VFzc/G35QbCiuxR/kURBM7hUMEmypUkZrgwoZj20Lbbaj2yKVJbH5RVpK4IuxC1si3J8yNQmZlNsDAPr0snnJxNzkwvE3n9JtI2yz+ZmHPaQkQyNo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.08.23 18:08, David Hildenbrand wrote: > Let's stop using page->private on tail pages, making it possible to > just unconditionally reuse that field in the tail pages of large folios. > > The remaining usage of the private field for THP_SWAP is in the THP > splitting code (mm/huge_memory.c), that we'll handle separately later. > > Update the THP_SWAP documentation and sanity checks in mm_types.h and > __split_huge_page_tail(). > > Signed-off-by: David Hildenbrand > --- @Andrew, the following change on top From 2b1fd10ef07c6d47aa9cd0ce10445ab1e1b97361 Mon Sep 17 00:00:00 2001 From: David Hildenbrand Date: Tue, 22 Aug 2023 19:16:55 +0200 Subject: [PATCH] fixup: mm/swap: stop using page->private on tail pages for THP_SWAP Per Yoshry, use folio_page_idx(). It shouldn't make a difference for our (THP) use case, but it's certainly cleaner. Signed-off-by: David Hildenbrand --- include/linux/swap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/swap.h b/include/linux/swap.h index 84fe0e94f5cd..e5cf58a1cf9e 100644 --- a/include/linux/swap.h +++ b/include/linux/swap.h @@ -344,7 +344,7 @@ static inline swp_entry_t page_swap_entry(struct page *page) struct folio *folio = page_folio(page); swp_entry_t entry = folio_swap_entry(folio); - entry.val += page - &folio->page; + entry.val += folio_page_idx(folio, page); return entry; } -- 2.41.0 -- Cheers, David / dhildenb