From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BED27C35FFF for ; Fri, 21 Mar 2025 10:14:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFDE4280005; Fri, 21 Mar 2025 06:14:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAF62280001; Fri, 21 Mar 2025 06:14:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C28EE280005; Fri, 21 Mar 2025 06:14:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A02F6280001 for ; Fri, 21 Mar 2025 06:14:25 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BC18D161E96 for ; Fri, 21 Mar 2025 10:14:25 +0000 (UTC) X-FDA: 83245148490.20.8DD24B6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 53EA340007 for ; Fri, 21 Mar 2025 10:14:23 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FDlAi51U; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742552063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PHlbxQe01vLEiQ3mDcT+HixcFtHLS6rNVTX0kCx8V6E=; b=t12AkUPqaIhztrIWKeA3wzngQOkGNdJ/aJcLZfx1RezGec/MPfL1013sZtzppwEfmrb5LL 2QVa8Vx7I0rSx6W/i40g51F55bWhIRDAL0VicOk1hMIQtSgREgEy/Nbpn0ogjBNPwmpL8X tnT14QuhvAVwtlPhXhUPQqwze1TaKPI= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FDlAi51U; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742552063; a=rsa-sha256; cv=none; b=zHMd4jrAqCfvJP50uMzXVpJqMdLrJyXn76hR7xBlsQa/mYhTsybLEnRLjZttohhMSWbrxC DN2w1zjBXcPuTeTb3UdmK637iotxZBbJJ0AaGr0gRcurXgwdUVsS2sIzuzhEql4xifgA0K NtY/5//2piCmaKHvFDHBfm4KJvAE/tA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742552062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PHlbxQe01vLEiQ3mDcT+HixcFtHLS6rNVTX0kCx8V6E=; b=FDlAi51UHKm6Ae+3Z59obi9SDXkd2H41puBKgeZROd1K93avdYzGZSsrv04bAW0FpCapUx MfNSFGDLWb+bv44MFFRt2fTfzOEVTVq/ShBarEZh6hTgFIU72UTjlqykJTZ6UsYHI+EhZl kiugyEuMouZEOZ6WKCEMLiCOmMD3bUo= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-193-in5yg0V6MAyhD6dcSHMTSg-1; Fri, 21 Mar 2025 06:14:19 -0400 X-MC-Unique: in5yg0V6MAyhD6dcSHMTSg-1 X-Mimecast-MFC-AGG-ID: in5yg0V6MAyhD6dcSHMTSg_1742552058 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43d01024089so13021535e9.1 for ; Fri, 21 Mar 2025 03:14:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742552058; x=1743156858; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=PHlbxQe01vLEiQ3mDcT+HixcFtHLS6rNVTX0kCx8V6E=; b=B8eFBjSuECcPwmaCGSeNiZecY9ZByHLqXwc9V/TFKuz2l1J+UzmKsGSW6jQNB6+/mz zcAyuHZzWLP5oXifUUhJ8WARHDaIhiQo60zAbtbEAy52J3sZfYZleGZOH6fqGMJ+6OZh Eqf5/k9Fu7+XtM/EoI+Vi/FiGHOwBoZl9lrqN3jKJL/7ov/SYSoGAzmAqSHCIck9dlhS T95EEIDmsBNKwTQYdvVizemzgf6Yak+Wnf4hPxXWyg3WFXZSl2qPuNAJKLQoXcRsK/yO 0DUk2hvLIOtqH+u0SYwTehalPl1iaNIHQX7Y9/Ehq305tirK3Dx5QiKucyG9orjiWZzv Q2YA== X-Forwarded-Encrypted: i=1; AJvYcCVKydaELHMotgMvHVighuS0irw/MGKS1fk86v4WUoGsiZsSOnX5tu6iEWU0wajJwjvas4yj9CTGkA==@kvack.org X-Gm-Message-State: AOJu0YwsBl6kDL8HxdHGxj81TWDSVUqAa8ukiEBmPsnPM7DqH4KmW4Za h/Y+H+zEytTaQDUASwYHCXlhK7lU+fpmPU5QXugZLKO+c91JDcKk2uqMV3kslBvwRXFbUXzK2r/ Tt5N43ALqf27ZY454OAHwtqUCc0s6/Uxo5eDad/cLgsLULVi4 X-Gm-Gg: ASbGnctj1SKqMLfgu+LyYtY1Qjmb83H6y51F+lJzWfpYlJPAPTN5bHksxb0XELBwIK8 wB3SxR/hlb7vL4vqHx9NGD9c+Hg0i1bau9kIjVtOiQr2Pw+45B1SSr3fZ3EGpuYYYNfZIrLIcyq kgfeavEmt+nSTS7k5R/UYyUzR/inl5ZxdfKxQMTzfXcq1ws0PibVPQkj7gtsDy1iVh/t0h4oGHF /QHFOkTpuJx9JLZBS7WbOoLUsVOs4+gUVI1p9t1cfp0oxsy2IqjYH45k5EytufElmjO3hl/MOwo d6Oh87kjNaLmdISbzhLDPL7rT5Skqhr9CIbRw1MmfLdFL8UQRwykMo4PR5Lkm/iWh653VfIrmMm EdLgDDC3w37jmmkqzSL92oEaXgWqn/39ayv9mssjlKwk= X-Received: by 2002:a05:600c:3c9e:b0:439:9424:1b70 with SMTP id 5b1f17b1804b1-43d50a4f8camr21606365e9.30.1742552058270; Fri, 21 Mar 2025 03:14:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGscQrhBBTGqOWY5+yPvlI3Utf38x4Ufv/GREG+b4A4kR6+FlCoSQJ/MfUa8u7VSgrtM4+SQA== X-Received: by 2002:a05:600c:3c9e:b0:439:9424:1b70 with SMTP id 5b1f17b1804b1-43d50a4f8camr21606085e9.30.1742552057876; Fri, 21 Mar 2025 03:14:17 -0700 (PDT) Received: from ?IPV6:2003:cb:c72a:9100:23d2:3800:cdcc:90f0? (p200300cbc72a910023d23800cdcc90f0.dip0.t-ipconnect.de. [2003:cb:c72a:9100:23d2:3800:cdcc:90f0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d3ba44e63sm68842565e9.1.2025.03.21.03.14.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Mar 2025 03:14:17 -0700 (PDT) Message-ID: <6ef83b28-5f01-4405-a25e-0bd59e071118@redhat.com> Date: Fri, 21 Mar 2025 11:14:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm/debug: Fix parameter passed to page_mapcount_is_type() To: Gavin Shan , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, willy@infradead.org, vbabka@suse.cz, osalvador@suse.de, gehao@kylinos.cn, shan.gavin@gmail.com References: <20250321053148.1434076-1-gshan@redhat.com> <20250321053148.1434076-3-gshan@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250321053148.1434076-3-gshan@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9uGO51d7tXC4-XbmLArdzOMp0TRwkwh-a0s3qRolyys_1742552058 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 53EA340007 X-Stat-Signature: emx3dbu56wopw7qes7ci5dzfa8r5pn8p X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1742552063-71875 X-HE-Meta: U2FsdGVkX1/2ZDfL2ccLUNDT80N23CZjoa5zPSHl1bYltpczrRf+bsHvzv9mm762ZKp6MAus5H3GEzSAJSuU8wFRt8+oCWKW5lqzag8vRkYHjKL7SIzHtbobduANhqtfc+8lbYXPTK3uaYDvHClI6TWYxNydVrkXJgdPr/hYSluc6iZWk3bQku2mDfvoct5THABpOFzeFCYrLzUusdFkZZS5GDDuy4w3Gdq51egUG5p8QBDN1Lqh2LhIZH6TWIHuedZKwkMb1TtT7TC+bKAVxC0msKB9Gqyf1j1lFDGRQxTWB2QiA5kQNiPqDe8lVplnVRw0aBoIhFsedwPXsJUr6AE+clNyhUiUdMGySZGeUNArRklYfDDoCKHObf8f4uQGBP1ekvfjriZSszsvqKp2AjzUcSLx9arsn3f2zm4gJRuL3N1SHfSuLNxFf1wyyQ6bNB0JzOz7D11H7olWeAntbr26MN8oeuWmZEfz/767K9AGiQqyiT9TswJe8h25FQjk2WeptcpiX/+MljJy9JI0zcZlq59I2IpBl/WPAabOf99CRgc8i18D93SrardWK0kZzrMfCaIeUPnW12FyXqxKMAM0EbfxLF/4JD0PYI3O0XSCm7j9Ebwf/Dnjz/W5lFDYYMrmOLSBV31bdvnGZylbGvJPjHbWI/sY/pLe2tcS9/OE65O3PVsG2Pr8KtLkvRYWIAa4p0i7aMZI1QszEqtFUWHtEl0GEafT09zax8y0ypYb8+2jqw5+OOWRg6ajRJIrZJ8cAQ6wMWYSO60HBbLTrFAZFi3xKfZuCGi9Fh4mAbD4CL2wfZ1K/Iuvdrh3F8d3bB7lkwj86IYWogqWpTJMEEoOIlYWwNnqR0za6Ln/p60ud8ljniWR2CBmzMgJbZRIN5jDIg+cqFRbqUy9Q1zLRvk/oZfsjDNCn1RyFI0Utts2DnWn451d8EHrso5xz7TmpeenypO+XflEAyTNX+m E0sCecqO 4mPUcdR8DQaRdluTrHNc1ovpLFNVGNbqjQV3Zb+BLC1Lke+q77t9LkG6vqOlfzyEZX6u77qKLChys/NeaaRC5JFzofu8HA2iznRDOqwts0Sc2YcEzyh24blZ+BB+Kfsbs9hzBfaeho+5wYkvzzvPS/g991DsVFl6AiJHZ6PFmkNcnm3ES3hChSnxBrJXJa+GZx9uaz6rNQJUvNvar1MlsppjqP6XJBzy8p9YqX7zlXXnK/tySa/EnydZw142c2/669Kv1iYcdBW6JBgrRISbIZ+6fN/Lr5w4H7d11fCkCTnGfL1OhE/FRd1BU9xGICsi/ZpDNjeBAMovXVCaxwqdj8CAb7zzfAsuM9184zY/KfSkMWrxjDVjFCDGBNpFTI5hTQt0FvySM6YeeEFNtwCGYStBVJ4puqXBMpjqv/AuVwZd/CuMEb8mpPvdW9QP3Uokj2DY67JWAhqOU/5r7wH0vz7qHg2gk3z3zzn3HIVDy7O5gnEpeyYHmFtj7mLond/qK8jEYZ2V/ZUSZcU6hxw+sFOHKzwZHvw4DmMb57CjXK2TrgYaorWgHJM9WCmCH4ZzQnSP+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.03.25 06:31, Gavin Shan wrote: > As the comments of page_mapcount_is_type() indicate, the parameter passed > to the function should be one more than page->__mapcount. However, > page->__mapcount is passed to the function by commit 4ffca5a96678 > ("mm: support only one page_type per page") where page_type_has_type() > is replaced by page_mapcount_is_type(), but the parameter isn't adjusted. > > Fix the parameter passed to page_mapcount_is_type() to be (page->__mapcount > + 1). > > Fixes: 4ffca5a96678 ("mm: support only one page_type per page") > Cc: stable@vger.kernel.org # v6.12+ > Signed-off-by: Gavin Shan > --- > mm/debug.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/debug.c b/mm/debug.c > index 8d2acf432385..b6bd9555ec7b 100644 > --- a/mm/debug.c > +++ b/mm/debug.c > @@ -71,10 +71,10 @@ static void __dump_folio(struct folio *folio, struct page *page, > unsigned long pfn, unsigned long idx) > { > struct address_space *mapping = folio_mapping(folio); > - int mapcount = atomic_read(&page->_mapcount); > + int mapcount = atomic_read(&page->_mapcount) + 1; > char *type = ""; > > - mapcount = page_mapcount_is_type(mapcount) ? 0 : mapcount + 1; > + mapcount = page_mapcount_is_type(mapcount) ? 0 : mapcount; > pr_warn("page: refcount:%d mapcount:%d mapping:%p index:%#lx pfn:%#lx\n", > folio_ref_count(folio), mapcount, mapping, > folio->index + idx, pfn); Acked-by: David Hildenbrand -- Cheers, David / dhildenb