From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57BA2C433DB for ; Tue, 12 Jan 2021 22:20:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9FD3E23127 for ; Tue, 12 Jan 2021 22:20:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FD3E23127 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 975C46B00FA; Tue, 12 Jan 2021 17:20:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 925026B00FC; Tue, 12 Jan 2021 17:20:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8134A6B00FD; Tue, 12 Jan 2021 17:20:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by kanga.kvack.org (Postfix) with ESMTP id 68A4F6B00FA for ; Tue, 12 Jan 2021 17:20:15 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 23BCE180AD817 for ; Tue, 12 Jan 2021 22:20:15 +0000 (UTC) X-FDA: 77698542390.05.guide92_2c0b22727519 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 07A8A1802EF1E for ; Tue, 12 Jan 2021 22:20:15 +0000 (UTC) X-HE-Tag: guide92_2c0b22727519 X-Filterd-Recvd-Size: 3015 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Tue, 12 Jan 2021 22:20:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=s+I14tYnxOlyfxHrlO9JYe0T5UDj9LyjfS6FStHPM4c=; b=nLfDVtpl4aEhI+9k8tvCHGFGIL WUoLkJx7AclGbCCkV6bC9lDRuKncLV99etAOe0ireXEKACLePG0cbdqNHY27eJPc4hh8MpZegnwVX jWSAkmF0i7pe8V4eKrt9Qh+wWtvAlBW1S+eEuvrwN61WHiuJVG8ONldkStnwAP3Cz8lghcyaLFxFt Wdmy5t5dZyyVX4V5pEEHySq7QR1M4HktljsJeMqwkf6TPS/AEK6VVRD8Be2I9nRMP77weJX79Yrni hR69k2dEzuSN2Gv9xSuiZEpikGp0KHtAfRpbo62ve8H9bMzXNvyyRFspZfELVRWnDrTyltMN6aJ9z 1uFe+JBQ==; Received: from [2601:1c0:6280:3f0::9abc] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzS1G-0003Ru-OR; Tue, 12 Jan 2021 22:20:07 +0000 Subject: Re: mmotm 2021-01-12-01-57 uploaded (NR_SWAPCACHE in mm/) To: Andrew Morton Cc: broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au, Shakeel Butt References: <20210112095806.I2Z6as5al%akpm@linux-foundation.org> <20210112135010.267508efa85fe98f670ed9e9@linux-foundation.org> From: Randy Dunlap Message-ID: <6ef78ccc-ab9e-5a18-ced7-ed2e993e4fef@infradead.org> Date: Tue, 12 Jan 2021 14:20:00 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20210112135010.267508efa85fe98f670ed9e9@linux-foundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/12/21 1:50 PM, Andrew Morton wrote: >> >> on i386 and x86_64: >> >> when CONFIG_SWAP is not set/enabled: >> >> ../mm/migrate.c: In function =E2=80=98migrate_page_move_mapping=E2=80=99= : >> ../mm/migrate.c:504:35: error: =E2=80=98NR_SWAPCACHE=E2=80=99 undeclar= ed (first use in this function); did you mean =E2=80=98QC_SPACE=E2=80=99? >> __mod_lruvec_state(old_lruvec, NR_SWAPCACHE, -nr); >> ^~~~~~~~~~~~ >> >> ../mm/memcontrol.c:1529:20: error: =E2=80=98NR_SWAPCACHE=E2=80=99 unde= clared here (not in a function); did you mean =E2=80=98SGP_CACHE=E2=80=99= ? >> { "swapcached", NR_SWAPCACHE }, >> ^~~~~~~~~~~~ >=20 > Thanks. I did the below. WorsForMe. Thanks. Acked-by: Randy Dunlap > But we're still emitting "Node %d SwapCached: 0 kB" in sysfs when > CONFIG_SWAP=3Dn, which is probably wrong. Shakeel, can you please have= a > think? --=20 ~Randy You can't do anything without having to do something else first. -- Belefant's Law