From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8E35C31E45 for ; Thu, 13 Jun 2019 06:14:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3BA1920866 for ; Thu, 13 Jun 2019 06:14:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BA1920866 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9E8546B0003; Thu, 13 Jun 2019 02:14:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9982D6B0005; Thu, 13 Jun 2019 02:14:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8625A6B0006; Thu, 13 Jun 2019 02:14:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by kanga.kvack.org (Postfix) with ESMTP id 68B896B0003 for ; Thu, 13 Jun 2019 02:14:15 -0400 (EDT) Received: by mail-qk1-f197.google.com with SMTP id 18so15763967qkl.13 for ; Wed, 12 Jun 2019 23:14:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:to:cc :references:from:openpgp:autocrypt:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5jGj+Tg0eO7r78Q0vqoWEX2AXZd5z4FYkNoY1f0GZKo=; b=CeAV3rc051aSpjqgVnPRcALA8lyg1t+9M4WJGLiWes69gfP84Mzum0h6tDzMpPWvmZ 6oOpGWxWhW1n1IkxrCORKTvOs7uUJtJHANttaJHSiwQbHfYnwBo0G36Ot/hgYxKnj9xI p8bdpxmL24qFAuHfCr6ZztC6+kTDouTLeTLGM69KIOcJuRhLZmBM75Loq5Re33adXF/w MQoocXxBGa2DlVP8elIcGo0V1TTd5fvpwux7uSEGu2jZZazAhi6Jr2IgaWiFBc+IVwkm qklJS0KMIA8IVx+skFahItIctjQSdO45DdRAE3+udlDDHpsxzr6egITlzXIPShQso7Wd FTvQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Gm-Message-State: APjAAAW7y/GAahTuH5I3Pe/o86W3slsQJ1PR3xBZuSurh6VpbMZRO+56 wTVehw5tfi8DqxJ+Ewrts/C6EwSNKV0IYFLCUDcLQoYW6443ySM4Fnhezeeb2MMaXcTHZ3+lYhd goIWbFBzLlFaglPiaQEFu8t+diH4IBq31TJYAZhbBIrjuUz10hPpEp7tH8n4u7E4OWQ== X-Received: by 2002:a0c:b627:: with SMTP id f39mr2033486qve.72.1560406455195; Wed, 12 Jun 2019 23:14:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqzsRWnhoOsqqPaRKkCWUdRgg7CHas3crSYut22SMmBwmkw4eU66frqzK5rcSZE+EdKhdPpa X-Received: by 2002:a0c:b627:: with SMTP id f39mr2033459qve.72.1560406454585; Wed, 12 Jun 2019 23:14:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560406454; cv=none; d=google.com; s=arc-20160816; b=L1r9L0O68TvQdaCIX45N2UOArqHLUGRI+lQzl/9s4n7sWbZN7qxIaLl2ZXJg1++P3L jMSa2LciG2sucM4RAqjLHemf31MM2lBi4WXDyaqVL5F7HhGY3QW6cW+8xzx8oVqZ4/bn o8oi2krykOCB35nqbC6HvhPzZdtolrQO9TP2XRvHdRmGYJUF1iU1GaL1M7klwq+xQyTi o0JOBmaqeVCNA8rojXcIp+4KXAfv0wmLbwvSCVyx/AKbeggBXD90DlEx2fijVvTm52a6 BEFW220O0SYmy5/gMJ+Oyt/sEQ13/KAqPC+fFMPyNgHV4ziRNU/U5i2qEZzhkNENOLvD aFJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:autocrypt:openpgp:from :references:cc:to:subject; bh=5jGj+Tg0eO7r78Q0vqoWEX2AXZd5z4FYkNoY1f0GZKo=; b=mlexw251mkphzpbimTt2458qShkiUoklTQ7C1AL6woFtkJoSvYzjXCp/JKgZeUL+UZ 2QmZyfMW55H5A8g+bpiQB4vYWhorRv1w48THErVs3RpWgbKtO9pdDgjc1acrxE2LtYz9 yCW2CnT3E1otaX90LaQthLQKs6qyCh4hJMU8a/US69zfQ670gU+Gf9blAnWMPOKwv2e0 7DIGMvZ4t5S4y36HX8bskuugJNASyOLuO0p3MKynNYuB40t2vuElOexx7Sf7qdMLYPNP rUwXg7lnfJvXHkyTrzIOllyzaP/abjGtV2KpsjHZ81VGyljHNX6gicN5m6xTXfFmd1Eh WMlQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id y44si1203672qtb.264.2019.06.12.23.14.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jun 2019 23:14:14 -0700 (PDT) Received-SPF: pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8EB6D223898; Thu, 13 Jun 2019 06:14:12 +0000 (UTC) Received: from [10.36.116.187] (ovpn-116-187.ams2.redhat.com [10.36.116.187]) by smtp.corp.redhat.com (Postfix) with ESMTP id A443C27CC3; Thu, 13 Jun 2019 06:14:09 +0000 (UTC) Subject: Re: [PATCH V5 - Rebased] mm/hotplug: Reorder memblock_[free|remove]() calls in try_remove_memory() To: Andrew Morton Cc: Anshuman Khandual , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will.deacon@arm.com, ard.biesheuvel@arm.com, osalvador@suse.de, mhocko@suse.com, mark.rutland@arm.com References: <36e0126f-e2d1-239c-71f3-91125a49e019@redhat.com> <1560252373-3230-1-git-send-email-anshuman.khandual@arm.com> <20190611151908.cdd6b73fd17fda09b1b3b65b@linux-foundation.org> <5b4f1f19-2f8d-9b8f-4240-7b728952b6fe@arm.com> <67f5c5ad-d753-77d8-8746-96cf4746b3e0@redhat.com> <20190612185450.73841b9f5af3a4189de6f910@linux-foundation.org> From: David Hildenbrand Openpgp: preference=signencrypt Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwX4EEwECACgFAljj9eoCGwMFCQlmAYAGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEE3eEPcA/4Na5IIP/3T/FIQMxIfNzZshIq687qgG 8UbspuE/YSUDdv7r5szYTK6KPTlqN8NAcSfheywbuYD9A4ZeSBWD3/NAVUdrCaRP2IvFyELj xoMvfJccbq45BxzgEspg/bVahNbyuBpLBVjVWwRtFCUEXkyazksSv8pdTMAs9IucChvFmmq3 jJ2vlaz9lYt/lxN246fIVceckPMiUveimngvXZw21VOAhfQ+/sofXF8JCFv2mFcBDoa7eYob s0FLpmqFaeNRHAlzMWgSsP80qx5nWWEvRLdKWi533N2vC/EyunN3HcBwVrXH4hxRBMco3jvM m8VKLKao9wKj82qSivUnkPIwsAGNPdFoPbgghCQiBjBe6A75Z2xHFrzo7t1jg7nQfIyNC7ez MZBJ59sqA9EDMEJPlLNIeJmqslXPjmMFnE7Mby/+335WJYDulsRybN+W5rLT5aMvhC6x6POK z55fMNKrMASCzBJum2Fwjf/VnuGRYkhKCqqZ8gJ3OvmR50tInDV2jZ1DQgc3i550T5JDpToh dPBxZocIhzg+MBSRDXcJmHOx/7nQm3iQ6iLuwmXsRC6f5FbFefk9EjuTKcLMvBsEx+2DEx0E UnmJ4hVg7u1PQ+2Oy+Lh/opK/BDiqlQ8Pz2jiXv5xkECvr/3Sv59hlOCZMOaiLTTjtOIU7Tq 7ut6OL64oAq+zsFNBFXLn5EBEADn1959INH2cwYJv0tsxf5MUCghCj/CA/lc/LMthqQ773ga uB9mN+F1rE9cyyXb6jyOGn+GUjMbnq1o121Vm0+neKHUCBtHyseBfDXHA6m4B3mUTWo13nid 0e4AM71r0DS8+KYh6zvweLX/LL5kQS9GQeT+QNroXcC1NzWbitts6TZ+IrPOwT1hfB4WNC+X 2n4AzDqp3+ILiVST2DT4VBc11Gz6jijpC/KI5Al8ZDhRwG47LUiuQmt3yqrmN63V9wzaPhC+ xbwIsNZlLUvuRnmBPkTJwwrFRZvwu5GPHNndBjVpAfaSTOfppyKBTccu2AXJXWAE1Xjh6GOC 8mlFjZwLxWFqdPHR1n2aPVgoiTLk34LR/bXO+e0GpzFXT7enwyvFFFyAS0Nk1q/7EChPcbRb hJqEBpRNZemxmg55zC3GLvgLKd5A09MOM2BrMea+l0FUR+PuTenh2YmnmLRTro6eZ/qYwWkC u8FFIw4pT0OUDMyLgi+GI1aMpVogTZJ70FgV0pUAlpmrzk/bLbRkF3TwgucpyPtcpmQtTkWS gDS50QG9DR/1As3LLLcNkwJBZzBG6PWbvcOyrwMQUF1nl4SSPV0LLH63+BrrHasfJzxKXzqg rW28CTAE2x8qi7e/6M/+XXhrsMYG+uaViM7n2je3qKe7ofum3s4vq7oFCPsOgwARAQABwsFl BBgBAgAPBQJVy5+RAhsMBQkJZgGAAAoJEE3eEPcA/4NagOsP/jPoIBb/iXVbM+fmSHOjEshl KMwEl/m5iLj3iHnHPVLBUWrXPdS7iQijJA/VLxjnFknhaS60hkUNWexDMxVVP/6lbOrs4bDZ NEWDMktAeqJaFtxackPszlcpRVkAs6Msn9tu8hlvB517pyUgvuD7ZS9gGOMmYwFQDyytpepo YApVV00P0u3AaE0Cj/o71STqGJKZxcVhPaZ+LR+UCBZOyKfEyq+ZN311VpOJZ1IvTExf+S/5 lqnciDtbO3I4Wq0ArLX1gs1q1XlXLaVaA3yVqeC8E7kOchDNinD3hJS4OX0e1gdsx/e6COvy qNg5aL5n0Kl4fcVqM0LdIhsubVs4eiNCa5XMSYpXmVi3HAuFyg9dN+x8thSwI836FoMASwOl C7tHsTjnSGufB+D7F7ZBT61BffNBBIm1KdMxcxqLUVXpBQHHlGkbwI+3Ye+nE6HmZH7IwLwV W+Ajl7oYF+jeKaH4DZFtgLYGLtZ1LDwKPjX7VAsa4Yx7S5+EBAaZGxK510MjIx6SGrZWBrrV TEvdV00F2MnQoeXKzD7O4WFbL55hhyGgfWTHwZ457iN9SgYi1JLPqWkZB0JRXIEtjd4JEQcx +8Umfre0Xt4713VxMygW0PnQt5aSQdMD58jHFxTk092mU+yIHj5LeYgvwSgZN4airXk5yRXl SE+xAvmumFBY Organization: Red Hat GmbH Message-ID: <6ed925d3-03bf-14cb-3c3c-aeba6bbe20c7@redhat.com> Date: Thu, 13 Jun 2019 08:14:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190612185450.73841b9f5af3a4189de6f910@linux-foundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 13 Jun 2019 06:14:13 +0000 (UTC) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.06.19 03:54, Andrew Morton wrote: > On Wed, 12 Jun 2019 08:53:33 +0200 David Hildenbrand wrote: > >>>>> ... >>>>> >>>>> >>>>> - Rebased on linux-next (next-20190611) >>>> >>>> Yet the patch you've prepared is designed for 5.3. Was that >>>> deliberate, or should we be targeting earlier kernels? >>> >>> It was deliberate for 5.3 as a preparation for upcoming reworked arm64 hot-remove. >>> >> >> We should probably add to the patch description something like "This is >> a preparation for arm64 memory hotremove. The described issue is not >> relevant on other architectures." > > Please. And is there any reason to merge it separately? Can it be > [patch 1/3] in the "arm64/mm: Enable memory hot remove" series? > Nothing that the patch can be considered a cleanup: " mm/hotplug: Reorder memblock_[free|remove]() calls in try_remove_memory() In add_memory_resource() we have: memblock_add_node(start, size, nid) ... arch_add_memory(nid, start, size, &restrictions); ... create_memory_block_devices(start, size); While in try_remove_memory() we have: memblock_free(start, size); memblock_remove(start, size); ... remove_memory_block_devices(start, size); arch_remove_memory(nid, start, size, NULL); Let's restore the correct order by removing the memblock after arch_remove_memory(). " I think with such a description, we can include it now. Andrew? -- Thanks, David / dhildenb