From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B88E5C433E0 for ; Tue, 9 Mar 2021 07:36:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1CC5965295 for ; Tue, 9 Mar 2021 07:36:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CC5965295 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sf-tec.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1F9498D00B7; Tue, 9 Mar 2021 02:36:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D1398D007F; Tue, 9 Mar 2021 02:36:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0990E8D00B7; Tue, 9 Mar 2021 02:36:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id E5AE08D007F for ; Tue, 9 Mar 2021 02:36:16 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9D1F31E1B for ; Tue, 9 Mar 2021 07:36:16 +0000 (UTC) X-FDA: 77899527552.08.BC6F9CF Received: from mail.sf-mail.de (mail.sf-mail.de [116.202.16.50]) by imf20.hostedemail.com (Postfix) with ESMTP id 49A2DE6 for ; Tue, 9 Mar 2021 07:36:12 +0000 (UTC) Received: (qmail 20754 invoked from network); 9 Mar 2021 07:35:49 -0000 Received: from mail.sf-mail.de ([2a01:4f8:1c17:6fae:616d:6c69:616d:6c69]:45468 HELO webmail.sf-mail.de) (auth=eike@sf-mail.de) by mail.sf-mail.de (Qsmtpd 0.37dev) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPSA for ; Tue, 09 Mar 2021 08:35:49 +0100 MIME-Version: 1.0 Date: Tue, 09 Mar 2021 08:35:44 +0100 From: Rolf Eike Beer To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Arnd Bergmann , Michal Hocko , Oscar Salvador , Matthew Wilcox , Andrea Arcangeli , Minchan Kim , Jann Horn , Jason Gunthorpe , Dave Hansen , Hugh Dickins , Rik van Riel , "Michael S . Tsirkin" , "Kirill A . Shutemov" , Vlastimil Babka , Richard Henderson , Ivan Kokshaysky , Matt Turner , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Chris Zankel , Max Filippov , Mike Kravetz , Peter Xu , linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-arch@vger.kernel.org, Linux API Subject: Re: [PATCH RFCv2] mm/madvise: introduce MADV_POPULATE_(READ|WRITE) to prefault/prealloc memory In-Reply-To: <20210308164520.18323-1-david@redhat.com> References: <20210308164520.18323-1-david@redhat.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <6ecd754406fffe851be6543025203b6b@sf-tec.de> X-Sender: eike-kernel@sf-tec.de Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: okg1an34miww3bqge36e6eqy6g7y56o9 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 49A2DE6 Received-SPF: none (sf-tec.de>: No applicable sender policy available) receiver=imf20; identity=mailfrom; envelope-from=""; helo=mail.sf-mail.de; client-ip=116.202.16.50 X-HE-DKIM-Result: none/none X-HE-Tag: 1615275372-466038 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > diff --git a/mm/internal.h b/mm/internal.h > index 9902648f2206..a5c4ed23b1db 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -340,6 +340,9 @@ void __vma_unlink_list(struct mm_struct *mm, > struct vm_area_struct *vma); > #ifdef CONFIG_MMU > extern long populate_vma_page_range(struct vm_area_struct *vma, > unsigned long start, unsigned long end, int *nonblocking); > +extern long faultin_vma_page_range(struct vm_area_struct *vma, > + unsigned long start, unsigned long end, > + bool write, int *nonblocking); > extern void munlock_vma_pages_range(struct vm_area_struct *vma, > unsigned long start, unsigned long end); > static inline void munlock_vma_pages_all(struct vm_area_struct *vma) The parameter name does not match the one in the implementation. Otherwise the implementation looks fine AFAICT. Eike