From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BA0BEED617 for ; Thu, 12 Sep 2024 16:53:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC1B26B0083; Thu, 12 Sep 2024 12:53:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A71446B0085; Thu, 12 Sep 2024 12:53:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 938666B0088; Thu, 12 Sep 2024 12:53:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 725786B0083 for ; Thu, 12 Sep 2024 12:53:31 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1D133A1157 for ; Thu, 12 Sep 2024 16:53:31 +0000 (UTC) X-FDA: 82556682222.05.E85A820 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf07.hostedemail.com (Postfix) with ESMTP id 1A85D40013 for ; Thu, 12 Sep 2024 16:53:28 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EXbtOlgT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=asml.silence@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726159931; a=rsa-sha256; cv=none; b=5zqjx5+0lvJANcRDHgjqW/H+8BFbpIF5tv0PZS6AbtJMBWxpRb5J0kJJDhgFzJVSo9Rad7 raJOSanJRz4f6+M3+T60zQXfio2eto56h36aumt/SGEIkQ8Gem6X7KjLcVIXeeJds70k0U /XK8/4s2DH3qIwp2EeEcTnSxLyIKTyA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EXbtOlgT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=asml.silence@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726159931; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3+TMXkLYIBdYwWS5zoZpThaARY3AGh3Sj0RZ+lAi4Vo=; b=nsnMrtNHxwOrUj/RkOLSm7vlj4IjCb0KQ1Ao8gLIz/tLOp0aCvB8tPeU7QggXHS4XvSwDU /wt9KXWHMWAf/hdvn05BImIqXO5++qDLVh3KLDnSqesseDH+G+RFqNfoeh+nFT2yVhkX0T JFzr7gGiWRv0E50HS1wcB7r9DXp6Lic= Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-374bfc395a5so738441f8f.0 for ; Thu, 12 Sep 2024 09:53:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726160007; x=1726764807; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3+TMXkLYIBdYwWS5zoZpThaARY3AGh3Sj0RZ+lAi4Vo=; b=EXbtOlgTy5RhDeImqXuQHFluxoB4m58gB8i0w2a+CAxX682hEqrb6Fw8wc2/i0YBcG Ef8T+IMIiFhX90R9kwMoenP7mt7N58kUOwn/MVKMTZujM07ivcqyGi3UAaBcXeYhSJ8v o2G7fmd+LqBXgY4u13UtKLNQpZOheEYTCFz+rl59/FXB4wr6TVF6SBCTheTBeuMZKgXZ Y+4tUjA1Nq8QIs/a1R3mFiQrzYKYmbz+7yiRdaX3fUKpiUglCqB6cCwT6U3gzKFvpSvc 3AzUjZ2ZqAdNYSzTi+awo5LeEgjoGOlIH1pg1drkafPUYk/vr++ctlb6dWHXbAdzzl0v jutg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726160007; x=1726764807; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3+TMXkLYIBdYwWS5zoZpThaARY3AGh3Sj0RZ+lAi4Vo=; b=T62it+eP5RINLz4FDY+uznKvw57PMUU1kjtbW/yQna6CjA1qDi4PidODsH5mEKbDaE AT7k9CVdXwMHZkT+YYJUTPUmLT4D9mzEZBV8gSDB1LHzyJB4PJgbPk4SQ7cyfIxuLzYv uBw/64+S7Xqg2R70/CK+b4fxPj7wAFIdJ6KxduJNzy6mGgHV8QzVBS9siGCYV3hnW200 ZOEF6ouvS4wEHeV+v7KTmRuXJf7TKqrOraFlVnGZvYdrO7OQL6buM95cLvjHTVOwoaPE BqBBJWne+YxOgcgT5Bd5J4hDDkNS2jEfaPY1/moshddskb/p5EhDtN47KSQ5CE1Zsq3z +RAQ== X-Forwarded-Encrypted: i=1; AJvYcCW402TgjG5X3/JcOJVE1TC7f1HD5ote8qJqWeFX7NC7Eh9fOvtjYOCCTUCseQQdbs4zN69vtrZo4A==@kvack.org X-Gm-Message-State: AOJu0Yx0+z9sblmtNSnMo7EdBHQBwplx1WFaDHswUmPaC+Hf1hJjN5gK KtRP7sQRVzQSsiRSAaF0tZrkQArCNoROT2t5oUSMtLe10l+c+5Hzqt3U1sxN X-Google-Smtp-Source: AGHT+IE+AMRIpg84NLhwoIlIbcdIuZUksArwuCENkLvlqgMXldebEjOlPoaTirqhVKaafnrFIVJOoQ== X-Received: by 2002:a5d:6e54:0:b0:374:cd15:c46c with SMTP id ffacd0b85a97d-378a8a1dac8mr6891748f8f.15.1726160007346; Thu, 12 Sep 2024 09:53:27 -0700 (PDT) Received: from [192.168.42.65] ([148.252.141.246]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378956650f2sm14771777f8f.26.2024.09.12.09.53.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Sep 2024 09:53:26 -0700 (PDT) Message-ID: <6ecd3129-e039-4b86-9e67-03a7a519266e@gmail.com> Date: Thu, 12 Sep 2024 17:53:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 6/8] block: implement write zeroes io_uring cmd To: Jens Axboe , Christoph Hellwig Cc: io-uring@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, Conrad Meyer References: <8e7975e44504d8371d716167face2bc8e248f7a4.1726072086.git.asml.silence@gmail.com> <707bc959-53f0-45c9-9898-59b0ccbf216a@gmail.com> <38a79cd5-2534-4614-bead-e77a087fefb2@kernel.dk> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <38a79cd5-2534-4614-bead-e77a087fefb2@kernel.dk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1A85D40013 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: re69ub7hn8fwaj3b78t3i1jbho17n45s X-HE-Tag: 1726160008-915813 X-HE-Meta: U2FsdGVkX195lg2XjhxsqMkjYb8ETM029WQL0hl82DchZV65GO4QHkLszimD6/cCvOTsE1QMazzbrMHqWTlOzKM8W8OVswYHPDu7UbY8nYZhChYQ7TiTWxtercLZYZIOYcD7jcKmHnOEJ6zjzquMMtiKoXC6Flza3VPTEZsRqBheODi1gjEwQec5pJbv625LTiG1UcQvmfVisL6AaPVHnWhX95eLZMKmbRJ/HdvbvTiTYp8voZglrYmcN9gzVPdN90bHB/2yfNCaKp1kn2r2FKXOUGVXQ1W2113wtN7faT/HLJh+MEOe/fg69xJ8tUDu/dZJRZ61q3A0no7XcXoBvLGnQS0YCmpRmbhOBpviOLrLkxcRwDndT/3Ak9IgjRAetLwsFhNfWglwk78GyCBrSCw98wYmwmGQofP89y2OpMLnmDLi7eWdi1eEycV0vQz6rpz8HbCj0TP4BeMUfBkojiW9t8tk+rtXDZ5PjPZXZntu0nLso509k8NgbL6TopxR/FAfILxgJWruyFmL4F/Oob/sUGzk42t7hoehqbL71jMCFOZkamJAdlYX+93J+eZea7DEcgy+jE/o/w00wPNeo23whMsvslparqH1z3Aim9gBSTZpnPkGpd1hQYYlQipUPqCv57B/gs0fO3vc+lLs6X/vkKZbmCtB7FCeYXP5W3VHsVuwX/A4SDJOL2zKmVtaCsvQX0eua63vjkwwPTEC/IVPHmbFhkYo2w/QNk2bcRDWIpFpd4CfMx9U7BBiB7tOFMnTajHjN4HPBT9AWskgXGdyOknalXXCIHVW6Uii6Y3res4+Fa01RQzCfgRREbMKaT3U9Jkm3VXmuWjfgsI/tyPxPQ5QdOf7I19HGZW2K7WwKqQXkQomcTesHsjqm3G+iQlYwZhKYxgC/jvKmHwxbga++2ZTeQKb6ND08MIWR4RGN2D4L2ehj3kLAtic6paYnvGHHdCIGWm3AHVJmjo /mI33Ivl Tm0s1kc5fQuS3mal+Xi+ponnoakNjU6TAzZfCkfWS+0GmAoF4/LExY9Jxi8+cfx2k7kxBQE6wjxVS/lY/kVI/Ux/G2o+6bZrScRW+syo8PgWPN11b0ZzR6JYLEeeEO/rI+F7qlTOjesA+dMG/baG10xxCuKtg02w6pHe1ogtFXbhXA5wbLRhE6WaIude+sJH2oWW0HeQ79lymOUX8ZrkRrHPLAqU1gSDT+gCbmMYQIPLdpedm1CNrVFLmCbcS8KQYR+CJvN7pnG53GzffbsfNxxSfWxfTuR3O/LSsTbsWLLJoz4GxlryedhU4nGawDNXPNaYajLQGWV46En9NpJcWD+CzRx07hZRXva4krLdtbzpYklY3lvTWtBMJPmXAsg8PYHH7HzVtB5zioDiFouNy1ACGqGHBi39a4TZBifJ94xWIMejZ4Gl5OjW81Re9xcgKZwycfQttwfvrpY6YKZfYFnhwp/wkJB76A6Et X-Bogosity: Ham, tests=bogofilter, spamicity=0.004391, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/12/24 17:32, Jens Axboe wrote: > On 9/12/24 10:25 AM, Pavel Begunkov wrote: >>> an entirely different command leading to applications breaking when >>> just using the command and the hardware doesn't support it. >>> >>> Nacked-by: Christoph Hellwig >>> >>> to this incomplete API that will just create incompatbilities. >> >> That's fine, I'd rather take your nack than humouring the idea >> of having a worse api than it could be. > > How about we just drop 6-8 for now, and just focus on getting the actual > main discard operation in? That's (by far) the most important anyway, > and we can always add the write-zeroes bit later. That's surely an option, and it's naturally up to you. But to be clear, unless there are some new good arguments, I don't buy those requested changes for 6-8 and refuse to go with it, that's just creating a mess of flags cancelling each other down the line. -- Pavel Begunkov