From: Mike Kravetz <mike.kravetz@oracle.com>
To: Yosry Ahmed <yosryahmed@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>
Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mina Almasry <almasrymina@google.com>
Subject: Re: [PATCH] mm, hugepages: fix size in hugetlb mremap() test
Date: Tue, 23 Nov 2021 17:08:02 -0800 [thread overview]
Message-ID: <6ebcffe2-9513-cbea-a206-15ba927416c7@oracle.com> (raw)
In-Reply-To: <20211123204644.3458700-1-yosryahmed@google.com>
On 11/23/21 12:46, Yosry Ahmed wrote:
> The hugetlb vma mremap() test mentions in the header comment that it
> uses 10MB worth of huge pages, when it actually uses 1GB. This causes
> the test to fail on devices with smaller memories.
>
> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
> ---
> tools/testing/selftests/vm/hugepage-mremap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I'll let Mina comment, but I think I know what happened.
The original version of the test did indeed use 10MB. However, the mremap
code must 'unshare' and shared pmd mappings before remapping. Since sharing
requires mappings of at least 1GB, the size was changed to make sure unsharing
worked.
In the end, I believe I suggested adding hugepage-mremap to run_vmtests.sh.
The script does not try to configure a GB worth of huge pages. And, I think
it is somewhat unreasonable to suggest users gave a spare GB to run the test.
I'm OK with restoring the original value.
Acked-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
next prev parent reply other threads:[~2021-11-24 1:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 20:46 Yosry Ahmed
2021-11-24 1:08 ` Mike Kravetz [this message]
2021-11-24 2:19 ` Yosry Ahmed
2021-11-24 3:42 ` Mike Kravetz
2021-11-24 21:03 ` Mina Almasry
2021-11-24 20:38 ` [PATCH] mm, hugepages: make memory size variable in hugepage-mremap selftest Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ebcffe2-9513-cbea-a206-15ba927416c7@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=almasrymina@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox