From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D187C004D4 for ; Thu, 19 Jan 2023 10:32:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D06D96B0072; Thu, 19 Jan 2023 05:32:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CB74D6B0073; Thu, 19 Jan 2023 05:32:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA6146B0074; Thu, 19 Jan 2023 05:32:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A77BA6B0072 for ; Thu, 19 Jan 2023 05:32:40 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 708981C56CA for ; Thu, 19 Jan 2023 10:32:40 +0000 (UTC) X-FDA: 80371184880.29.5E57D4F Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf06.hostedemail.com (Postfix) with ESMTP id 7EB7A180003 for ; Thu, 19 Jan 2023 10:32:38 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Es6O2oAV; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZOZTb1xy; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674124358; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tegevk4l6eSAVcZhXnC6lhrFkkCioF18pmZkx/QMwxI=; b=JGPV5FIr+EuehSnDIn8HA7yb9LVTtP/lvJWOV85LNEMgg1JIuuY9TIP5el9+oXsIU+30I3 3mk+dymuX7oZmno5rPM2FXDKBjESTeYanEqzXnXZKg7nByE8Q/3YpAYYv/mXQz0IfyUCm8 AdfCOV7S3w0WbassLqt1EXvzzan64sA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Es6O2oAV; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ZOZTb1xy; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674124358; a=rsa-sha256; cv=none; b=TgDigYHTixyIKiGCHG02oSXcS8UVR5ZyQ2DFdCBg18nTDX4jlxIGDAcDfH/m5U4rnJX+kV AA9oEJytQoEEFsWrwFsUtXDR9xYxqXggPZWP3cYcJxre5HtisaTXk9AnUmfVvumfD9Oyup TdURnCWB9HtnHz4YgRnvYaz3Kc6wnB4= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E584B5CC34; Thu, 19 Jan 2023 10:32:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1674124356; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tegevk4l6eSAVcZhXnC6lhrFkkCioF18pmZkx/QMwxI=; b=Es6O2oAVkAEqFiIdqT+svJN6AueN7ixIB4oXi+Gf4j8u2FQwi8O9dHU20bnTWLOOSgFBpC Px1Oa8a7f6c8HyRHu8X5z9qY0tDXWqhaI5dfS7I+6qAxEDPJKFZoop0kmELlHk/XFJczW3 I+2VpMwQmUsMyrzKqFegwRE6s6UmV/8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1674124356; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tegevk4l6eSAVcZhXnC6lhrFkkCioF18pmZkx/QMwxI=; b=ZOZTb1xywmP4Ivu22dC+fS2VcRg7Epu4N+/9ViuwvDjwkOpVMDQYmEMfg2BcLlmj1gGVad lnvxKCplItVQtfDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BB0D5139ED; Thu, 19 Jan 2023 10:32:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id y59NLEQcyWNRIAAAMHmgww (envelope-from ); Thu, 19 Jan 2023 10:32:36 +0000 Message-ID: <6e9e406a-8a94-4e34-9e5e-f4bb3a321b4e@suse.cz> Date: Thu, 19 Jan 2023 11:32:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCHv4 2/2] mm: use stack_depot_early_init for kmemleak Content-Language: en-US To: "zhaoyang.huang" , Andrew Morton , Catalin Marinas , Nathan Chancellor , Peter Zijlstra , Zhaoyang Huang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com, Mirsad Todorovac References: <1674091345-14799-1-git-send-email-zhaoyang.huang@unisoc.com> <1674091345-14799-2-git-send-email-zhaoyang.huang@unisoc.com> From: Vlastimil Babka In-Reply-To: <1674091345-14799-2-git-send-email-zhaoyang.huang@unisoc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: tj5e1ecgehtjqxkjszme3ryt8urjysqd X-Rspam-User: X-Rspamd-Queue-Id: 7EB7A180003 X-Rspamd-Server: rspam06 X-HE-Tag: 1674124358-766533 X-HE-Meta: U2FsdGVkX1/FrneuW+5rssALfgP59mtWn+mIOQ3k4VJn1RFTG9MQHvcr2MgWckymaG77s88aCWIAF4TnKoS2VgeM1CXk/87/KJzWv6RLZNtnT16Sv97Thy5n3XefZPgN3by4gRCsHL1fQxoZjvoQ8KvIZEkvgeNEmh/PngyviTAWvTDSKR0AbKNH5Fg67sOET7EcQudfwl+TTt9Zf2bWNodsw3afxGYtsbkFd37PvRE7sK+/auXnYmugkLyPBmcq/zChgX8WpazENiVTbTCgPVJIZhQSRZQ5MSLejYxlqsyfWiEXDa7ZUyv68b2IMw70V/yeXboIEhIR283Dd+OPq4wzPSo5ORacLN5a/JrsVHM5Fwa1FP6cMAR29pCr/SzzqYMI7vVqpnPml08bazW44uBf16kQs4K5vFaIE9cQ+yAFLhsbvF2vJ3NIsWjLzxbLsq2foo8RH3nxPiOQ8+OGIJTxN1n7deNvZ/3mzS2rP8aawzrTOq+faKBDCsfcsgr11HKq7Hd+nP/UcodIf0skezsBwZcBCNpBSrY6073cL9+9emCz4qqzbOeeLR8KDmRfb3pukrijQW5ZIZpN9RqM7P/p0/t6XtAg+ps9fGoVWMRQ33Vo4KpFxLWAjRkRIs220/2iwMxi7Gco7REuhH1PMh2VqMnZKnTdemnhWGV+QEIDqhQTuzdcBiemcQirl2JqFDVFt+J+umbYX8+YaPwE76Vv6Z1HgBSuBeVSlPLjRDvNL4piC6UTK2touvQDj816R2svDHxxveWOFZ2Ilo4NgJMZ4fWshzFSTwAelIvCZB0lnxp4TVG+adDvjmNcJR42lkaEEB/ggtt8zVpEpAApAJXLuMbTj2JIsYzcSvo73laVLDu+Su0aPBhyDgdK4j5jej5QqZBp8pAu4aUWSXr6o/ESf94Q2kJwZmxX4daxfPSDyJjW1UHVZGb2Hie0vLY9wlnXdhd0XVcdN9eMn+M zCQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/19/23 02:22, zhaoyang.huang wrote: > From: Zhaoyang Huang > > Mirsad report bellow error which caused by stack_depot_init failed in kvcalloc. > Solve this by having stackdepot use stack_depot_early_init. > > On 1/4/23 17:08, Mirsad Goran Todorovac wrote: > I hate to bring bad news again, but there seems to be a problem with the output of /sys/kernel/debug/kmemleak: > > [root@pc-mtodorov ~]# cat /sys/kernel/debug/kmemleak > unreferenced object 0xffff951c118568b0 (size 16): > comm "kworker/u12:2", pid 56, jiffies 4294893952 (age 4356.548s) > hex dump (first 16 bytes): > 6d 65 6d 73 74 69 63 6b 30 00 00 00 00 00 00 00 memstick0....... > backtrace: > [root@pc-mtodorov ~]# > > Apparently, backtrace of called functions on the stack is no longer printed with the list of memory leaks. > This appeared on Lenovo desktop 10TX000VCR, with AlmaLinux 8.7 and BIOS version M22KT49A (11/10/2022) > and 6.2-rc1 and 6.2-rc2 builds. > This worked on 6.1 with the same CONFIG_KMEMLEAK=y and MGLRU enabled on a vanilla mainstream kernel > from Mr. Torvalds' tree. I don't know if this is deliberate feature for some reason or a bug. > Please find attached the config, lshw and kmemleak output. I think we could replace the full quote of the report with Link: https://lore.kernel.org/all/5272a819-ef74-65ff-be61-4d2d567337de@alu.unizg.hr/ also Fixes: 56a61617dd22 ("mm: use stack_depot for recording kmemleak's backtrace") (Andrew can do that when picking up, no need to send v5) > reported-by: Mirsad Todorovac > suggested-by: Vlastimil Babka > Signed-off-by: Zhaoyang Huang Acked-by: Vlastimil Babka But to be cleaner I'd also suggest Andrew adds the hunk below. The call to stack_depot_init() becomes no-op after this patch so it's not a bug to leave it there, but it's just misleading now. ---8<--- diff --git a/mm/kmemleak.c b/mm/kmemleak.c index 91dda5c2753a..55dc8b8b0616 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -2095,7 +2095,6 @@ void __init kmemleak_init(void) if (kmemleak_error) return; - stack_depot_init(); jiffies_min_age = msecs_to_jiffies(MSECS_MIN_AGE); jiffies_scan_wait = msecs_to_jiffies(SECS_SCAN_WAIT * 1000);