From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB761E7717D for ; Wed, 11 Dec 2024 17:58:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 310086B009A; Wed, 11 Dec 2024 12:58:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C03E6B009C; Wed, 11 Dec 2024 12:58:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 161566B009D; Wed, 11 Dec 2024 12:58:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EC0A46B009A for ; Wed, 11 Dec 2024 12:58:45 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7BC73161102 for ; Wed, 11 Dec 2024 17:58:45 +0000 (UTC) X-FDA: 82883436930.20.16BC1DC Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf12.hostedemail.com (Postfix) with ESMTP id 2923040012 for ; Wed, 11 Dec 2024 17:58:31 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733939907; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VwihD0zxz9/DVF2yhRSHJOvCw8CAC81jgoWBRN9H4Og=; b=eJx4jDd/fWfrjNSbkZSGkO88uxqjR73uczyPr36otiQEnhr+hSkD8KhGfdZDB0VUi475RL K4lN/YwIrRpr3miHA7A1srLqBXdCPgMmFIWIwaDlUPKRu/MofqXYH7BqkDam8UyqrgAo0k jUZ48NHgYe4unkzJje6URu1PtpeiIjk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733939907; a=rsa-sha256; cv=none; b=pJSJUQoQ6/9/4kWo0/gl174hE7sSVOg2qjZj+c953/C4Dspz3O0JUuNFYmH2GBvH46dekI yqIg5a5L3YyXAdWWVkEec4pZvV6oQ5pPIOPlFJ9LVq7LntTOuPfOrefzQYQnp+8qoGpr4U WpRnltQeX5D+J5OoiUpth9pinna57/U= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Y7jtd4XGNz6D8bR; Thu, 12 Dec 2024 01:55:21 +0800 (CST) Received: from frapeml100007.china.huawei.com (unknown [7.182.85.133]) by mail.maildlp.com (Postfix) with ESMTPS id 87E06140442; Thu, 12 Dec 2024 01:58:38 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by frapeml100007.china.huawei.com (7.182.85.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 11 Dec 2024 18:58:38 +0100 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.039; Wed, 11 Dec 2024 18:58:38 +0100 From: Shiju Jose To: Shiju Jose , Dan Williams , "linux-edac@vger.kernel.org" , "linux-cxl@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" CC: "bp@alien8.de" , "tony.luck@intel.com" , "rafael@kernel.org" , "lenb@kernel.org" , "mchehab@kernel.org" , "dave@stgolabs.net" , "Jonathan Cameron" , "dave.jiang@intel.com" , "alison.schofield@intel.com" , "vishal.l.verma@intel.com" , "ira.weiny@intel.com" , "david@redhat.com" , "Vilas.Sridharan@amd.com" , "leo.duran@amd.com" , "Yazen.Ghannam@amd.com" , "rientjes@google.com" , "jiaqiyan@google.com" , "Jon.Grimm@amd.com" , "dave.hansen@linux.intel.com" , "naoya.horiguchi@nec.com" , "james.morse@arm.com" , "jthoughton@google.com" , "somasundaram.a@hpe.com" , "erdemaktas@google.com" , "pgonda@google.com" , "duenwen@google.com" , "gthelen@google.com" , "wschwartz@amperecomputing.com" , "dferguson@amperecomputing.com" , "wbs@os.amperecomputing.com" , "nifan.cxl@gmail.com" , tanxiaofei , "Zengtao (B)" , "Roberto Sassu" , "kangkang.shen@futurewei.com" , wanghuiqiang , Linuxarm Subject: RE: [PATCH v17 05/18] cxl: Add Get Supported Features command for kernel usage Thread-Topic: [PATCH v17 05/18] cxl: Add Get Supported Features command for kernel usage Thread-Index: AQHbPQkFb4DhmQwolUmt5xqDd6N+ZLLZxDuAgAQrVZCAA3+90A== Date: Wed, 11 Dec 2024 17:58:37 +0000 Message-ID: <6e9c128e888c4cacb04b5dd53b1d1b79@huawei.com> References: <20241122180416.1932-1-shiju.jose@huawei.com> <20241122180416.1932-6-shiju.jose@huawei.com> <67536f6987656_10a08329480@dwillia2-xfh.jf.intel.com.notmuch> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.48.159.5] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2923040012 X-Stat-Signature: sp73u1gxcoyjqf6q1q5mmhfecoxxgxme X-Rspam-User: X-HE-Tag: 1733939911-547411 X-HE-Meta: U2FsdGVkX18NCOUvnZIZfv5N6Xn1OJ4TPBeMhVC7atHQUIaX80e50j6rJKI4PT7cyiZEokbnd87Ou4YXsJPxUC7ykWk8bvJKrWCHj9s/ed+yp4SkFCBAwra1+xbPUunT1hI1dKf+Ab43i+bvCoFTg6mggXvdlTG3j7dpb1fN5KjCssrPS8KDJHNqwYUiuqnB3flS8XxCkWX0Kl1StcirnHT5oHc+F3Xv8dnReBZfiKHSkg07+QqyZpBgmREVey6doYnA4tw2I7mrPiRxjIHVNJ4Vp4IxkqkQEihvRpgI0UgS2RNWcAKku4yXvrfcf5Y4oMO6FcgDohJayXTswul1JAqUcCzZUXih3Ks2XUGk90ES5VJm+o4RI9eXqea9Fq9ZDRTvEdjsahfsIH0ghH47FGmmAK5UmSviE+SVxAKjyv/nPSzmAryhJhQTnZsS3/jOC0zYx91tvMoJ7HIyYLGLAZIrNmWKwBlY6FmqHFYWJFcRXXW7mXG8n+pzj9ubOspqEQs3i/pyZdUKXYiBTjwWubtbFbArjYf03hSmR1IjwXPDnn8NnT9wEZNMJzRgRXqhrq3RApyGzE9yhH2yOb5z3y4XFm7izYPv6xMbAo6AvhYd60288PesS1jC8CnwrVJ9Vuen24733/YMg/l7lAXnLO3eW/dJ+xRhxekAeXJWKuopHrQ/IWJEK586P9X6FAfyT/USaLNNGEslJzhgfWlXCjcMOT4cZtISdZ5NkaHa5mNmZPZ3EAwWf++fO/mlM0wSiqtp8LqlnQvy2V3uakHCbttYBJQl0koJCDuLL0aGfH0O3eIaEeaButSuWVZLG4q2LfxD8ETq+msyk+bB4706a2xtltQLllQDWzwodZ3XP2C8CogQKd6T7s7urxo+Hqlr06sod1R+5eBsCw9xKGAFTpgY3sYDznLYf7zspWu8BD0cWQBfOs1RR0uk2galEMRqPlcVj/mtPfsaIG3b615 umg7lNsk 2ylP6RbxldT0AMrGyZAKE6G4wnT66sdGfNamxpmi5dPgUAayHpDv3NpdzZKHK51CoSpf+p/eq5kfywVh6mT9+dUw4JRTVb2ZTHLRquIclP4XdZEzWeCQKiIvzElSc9WKtLld+f+EzSzRPuBoCZk3roqeS9yrMXI7PieFqm//1aWkX1jad2B1sLmA+7sNojY8nNf9uC1pTbpwnbekXpFNLUQwpusunVOhd+vP7S5OQbDE95QS5hUbag1YIOIWc0UEiSr2E5tkw1Uyj8xiv8WssO4VDxVQRAcJ6P4AVfTz2S437nTJqJSr7DPFl+avOojBdsZd8Etz66FHerb+n7MfFgCvwlFRNDUQP0kJWR+/7D3CvW08GfsAvoiDNxZebQl+/qNBab6LdP46IcDs3MeSKlfth+ea9cDcaosvahzvOEaQF6wBDr/uwYxk0ogYUGqzjXXZh08E9+PvUiO4wcXnXMW2xDTNrWVJHSFAgqCwAuqQkVNW/evUXN9ZWaNh64AzWx9iS3Rl5D+MUlsyN5KOuxOmiIiIoheNQqvSE3cW809BXMkMx4F4AwzgZLNKDsjO0u9Ayy7W8cDWPsLxZNDYZbQ1LwWToKSmpA9i16TOWzyI243q4kjeAjccLTZwXqHrwhFyfEdL5QGIaILXn5FXLC1YpP/YZhFSeUPsgKJCdq4h547aHUASv+IjDlX7YLCpJiZPEumWtkiMv8Sq31gno5r/rge7vrVxYLcgi73XJIKlD7RFUotxBw+oAftvGgeYtwody1H1f/XDvkqHkMXbnvtGMsgjrlfR1apTuhtMFf7Cud20tsR3hFXhhyIbuH74j54FuRnAEy4xBjERgIrheG/LV9Mrtuw0xObOLUlzgecQYbZ8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >-----Original Message----- >From: Shiju Jose >Sent: 09 December 2024 14:28 >To: Dan Williams ; linux-edac@vger.kernel.org; >linux-cxl@vger.kernel.org; linux-acpi@vger.kernel.org; linux-mm@kvack.org; >linux-kernel@vger.kernel.org >Cc: bp@alien8.de; tony.luck@intel.com; rafael@kernel.org; lenb@kernel.org; >mchehab@kernel.org; dave@stgolabs.net; Jonathan Cameron >; dave.jiang@intel.com; >alison.schofield@intel.com; vishal.l.verma@intel.com; ira.weiny@intel.com; >david@redhat.com; Vilas.Sridharan@amd.com; leo.duran@amd.com; >Yazen.Ghannam@amd.com; rientjes@google.com; jiaqiyan@google.com; >Jon.Grimm@amd.com; dave.hansen@linux.intel.com; >naoya.horiguchi@nec.com; james.morse@arm.com; jthoughton@google.com; >somasundaram.a@hpe.com; erdemaktas@google.com; pgonda@google.com; >duenwen@google.com; gthelen@google.com; >wschwartz@amperecomputing.com; dferguson@amperecomputing.com; >wbs@os.amperecomputing.com; nifan.cxl@gmail.com; tanxiaofei >; Zengtao (B) ; Roberto >Sassu ; kangkang.shen@futurewei.com; >wanghuiqiang ; Linuxarm > >Subject: RE: [PATCH v17 05/18] cxl: Add Get Supported Features command for >kernel usage > >>-----Original Message----- >>From: Dan Williams >>Sent: 06 December 2024 21:41 >>To: Shiju Jose ; linux-edac@vger.kernel.org; >>linux- cxl@vger.kernel.org; linux-acpi@vger.kernel.org; >>linux-mm@kvack.org; linux- kernel@vger.kernel.org >>Cc: bp@alien8.de; tony.luck@intel.com; rafael@kernel.org; >>lenb@kernel.org; mchehab@kernel.org; dan.j.williams@intel.com; >>dave@stgolabs.net; Jonathan Cameron ; >>dave.jiang@intel.com; alison.schofield@intel.com; >>vishal.l.verma@intel.com; ira.weiny@intel.com; david@redhat.com; >>Vilas.Sridharan@amd.com; leo.duran@amd.com; Yazen.Ghannam@amd.com; >>rientjes@google.com; jiaqiyan@google.com; Jon.Grimm@amd.com; >>dave.hansen@linux.intel.com; naoya.horiguchi@nec.com; >>james.morse@arm.com; jthoughton@google.com; >somasundaram.a@hpe.com; >>erdemaktas@google.com; pgonda@google.com; duenwen@google.com; >>gthelen@google.com; wschwartz@amperecomputing.com; >>dferguson@amperecomputing.com; wbs@os.amperecomputing.com; >>nifan.cxl@gmail.com; tanxiaofei ; Zengtao (B) >>; Roberto Sassu ; >>kangkang.shen@futurewei.com; wanghuiqiang ; >>Linuxarm ; Shiju Jose >>Subject: Re: [PATCH v17 05/18] cxl: Add Get Supported Features command >>for kernel usage >> >>shiju.jose@ wrote: >>> From: Dave Jiang >>> >>> CXL spec r3.1 8.2.9.6.1 Get Supported Features (Opcode 0500h) The >>> command retrieve the list of supported device-specific features >>> (identified by UUID) and general information about each Feature. >>> >>> The driver will retrieve the feature entries in order to make checks >>> and provide information for the Get Feature and Set Feature command. >>> One of the main piece of information retrieved are the effects a Set >>> Feature command would have for a particular feature. >>> >>> Reviewed-by: Jonathan Cameron >>> Signed-off-by: Dave Jiang >>> Co-developed-by: Shiju Jose >>> Signed-off-by: Shiju Jose >>> --- >>> drivers/cxl/core/mbox.c | 179 +++++++++++++++++++++++++++++++++++ >>> drivers/cxl/cxlmem.h | 44 +++++++++ >>> drivers/cxl/pci.c | 4 + >>> include/cxl/mailbox.h | 4 + >>> include/uapi/linux/cxl_mem.h | 1 + >>> 5 files changed, 232 insertions(+) >> >>Hi Shiju, >> >>So I commented yesterday on this patch that is also duplicated in >>Dave's series have a merge order ordering plan to propose. > >Hi Dan, > >Thanks for the suggestions. >I tested your suggestions for CXL features commands in the fwctl series, i= n the >EDAC CXL features setup, as replied. Please find updated patches for your suggestions are shared here. https://github.com/shijujose4/linux/tree/edac-enhancement-ras-features_for_= v18 However next version (v18) of EDAC series will send after receiving feedbac= ks from Borislav=20 on v17 EDAC patches. >> >>> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index [...] > Thanks, Shiju