From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88E24CF6494 for ; Sat, 28 Sep 2024 01:04:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B2936B015C; Fri, 27 Sep 2024 21:04:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 788EC6B015D; Fri, 27 Sep 2024 21:04:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 677336B015E; Fri, 27 Sep 2024 21:04:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 498A86B015C for ; Fri, 27 Sep 2024 21:04:18 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id ABA30120F75 for ; Sat, 28 Sep 2024 01:04:17 +0000 (UTC) X-FDA: 82612350954.09.8C36B6D Received: from outboundhk.mxmail.xiaomi.com (outboundhk.mxmail.xiaomi.com [118.143.206.90]) by imf20.hostedemail.com (Postfix) with ESMTP id 47E3C1C000F for ; Sat, 28 Sep 2024 01:04:13 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of gaoxiang17@xiaomi.com designates 118.143.206.90 as permitted sender) smtp.mailfrom=gaoxiang17@xiaomi.com; dmarc=pass (policy=quarantine) header.from=xiaomi.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727485332; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g3hcTUe5pCw1Z9wv0UR73R/eKJe4qGC1D8QBfG7EoWo=; b=S6vxL+G3uZx9+wqBEphF+9Gd9F1KC1kH661WdMnc3L1IzjxPFRb0YDRb8XOrST28sF1X6c D0c1zWDR+X++i1dZ1mmP3RL2rqDS9nvNffIfeR75zQZDfjPG1h1ipP7p6oxCHxYF7G45ke r9HRlwF0nl5SXjqkpNOsvtujnFFT5Aw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727485332; a=rsa-sha256; cv=none; b=ThJr4/zS43sk5KQSyOnzPy6pbUrb8hIuFIqqx+7RvqfoBgcHOXeBAaGyc2QEEawKRccvqd pQ3ym8O9RaAqjih9t9MOh9c9Cyyvglq6pwxrOKGKwol06/lvidNz9Qb8/pj2oQcfbXb2YV dVVMFjrGUejZI3wW4L0BgiEQzNK8b+E= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of gaoxiang17@xiaomi.com designates 118.143.206.90 as permitted sender) smtp.mailfrom=gaoxiang17@xiaomi.com; dmarc=pass (policy=quarantine) header.from=xiaomi.com X-CSE-ConnectionGUID: iukkHRTBRuWIynRKUoKilQ== X-CSE-MsgGUID: beEzO3XaRpG05oW4GDpxOg== X-IronPort-AV: E=Sophos;i="6.11,160,1725292800"; d="scan'208,217";a="97605916" From: =?gb2312?B?uN/P6A==?= To: David Hildenbrand , Xiang Gao , "akpm@linux-foundation.org" CC: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: =?gb2312?B?tPC4tDogW0V4dGVybmFsIE1haWxdUmU6IFtQQVRDSF0gbW0vY21hOiBwcmlu?= =?gb2312?Q?t_total_and_used_count_in_cma=5Falloc()?= Thread-Topic: [External Mail]Re: [PATCH] mm/cma: print total and used count in cma_alloc() Thread-Index: AQHbENkKq9OkbxVWn0C9z1wBSDrJm7JsYSDr Date: Sat, 28 Sep 2024 01:04:08 +0000 Message-ID: <6e7bc1dfb59d4ee39bbb6a6bb7ed8808@xiaomi.com> References: <20240926120049.321514-1-gxxa03070307@gmail.com>,<755ff53a-2727-4993-92b4-95be668f3b67@redhat.com> In-Reply-To: <755ff53a-2727-4993-92b4-95be668f3b67@redhat.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.237.8.20] Content-Type: multipart/alternative; boundary="_000_6e7bc1dfb59d4ee39bbb6a6bb7ed8808xiaomicom_" MIME-Version: 1.0 X-Stat-Signature: 7dscwyy566krd9qr9ew9j8t5o7gb5dfb X-Rspamd-Queue-Id: 47E3C1C000F X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1727485453-750559 X-HE-Meta: U2FsdGVkX1+acQvg8NqN1uXrvFwrea8a1dQRianWo8RySGue6JrK/8CeDDEBFz5Oc8kFQbyxwSBJJZY7NhDW7V72SOriQd1JuqqEIIsQJeLgxmaWPwJaF0UA0ftv12QEe7mrtQr0hUYvMMYqo8xc4UKIrAGrzKEPM47vRac1a1GAIgIqzdf3WrPc7UsNk9QHs0TYfE/RhJTLJYv9myIge0Mr7D9v0M+MrVx2qpTTLrwDyjoFe7i0eH5/vaIdnFu32L4zPt0VQe6ZFYAmQxLrfo2LmQj4zAwkbmqal6r2JaW58PYKbx1kBQD8/liKgzACMqvs3zoEHdt0+IYvpAK/zZFRk7q+fRhfzRSEBbiZsoOJmPDTWgUtYq3N9OlMxBp3wSunzaDM7t+6IEgNoZkopMME7JKvpdjFBjKuC3iNf6cob5yxGstAaJmVkK0Ur3HYPM+k39HW/EFoQAHNfkiV1j/QZ1Ctl0N91nU5+Jo8yn7ar0eJzFtBHffdUO85eBw1hd1Emm+y4jytPTXjYeRUQUbvl7UJjJ2oYoaCL/XO56mGX4n4x7yZ9IuyaxAg7z1a0mL48acgXtfFNqRQulU8dUkvwN8uPF/Fw9YEdmVmYfdC1LGxiqBJ7nOAZqZvciiCbOScsNx03b3ncKv8D+RyZBRXPs5xIhaaZwQIs84nertBflWbRgsfDh0STJeRqmK+xZKl1gYgddeSF/xei5PUPklY0tI/xLNHOC4WRyl9afrHaOchHf2+xJkmkEdvTcl5arY/3vKyp5Y9srXTKPcWQD3y+iwPEzXCZs5U635duZpbOdxbzrORSyVuPH/UkOtq1xMl5glpWems9hU6USRcrblnnCYlcz4DkaHFdtxQlqkr2zgwA2/VVawYQfqJ674eF7WOZsdy9+1I3u1I/J0AysgeAiIayf8xd8HGcKnspumyqbVpQ0F1MuCDsz6FhO2vyR4kAg3e24ciGzWuKOR 8JkAZNi7 a3/j0GKwRN4+3VBc7KjgDPXJ+N6PWMzcxuCK3SmRbg8rZ89uhRrXRJ3I0W8a+bLt7j6kOVdg56qj2UKObDfAwtyhU7lEzhg/nZ9Srv837Mb/sZSDKo+kEM3oV2P6vZgHYdMQOUTsHVpxf0yo6RldC0JkpdG6o7wH4uAMnDNqbfmUVSDc8pYCzQJCKJrNzKIIGIaVjmiRrn25A5SgbdayrwJ0+xM4RWHu4czIXoZ15Wg0Hyn+bieYZUG5PNIcu3XUKOqcSbwbi1mvIfM4mXiHaWWozmMt79r+JyU8OTEaB8/PFhMkOku05AU3uVZpOtOtc0XJcriapVuNqKye84LNhoqQKjv0c9UALhYtyqgawjFpA2Nt1eD1gKHuSBfBTUGafAlNxRTLcQ9DuTjphTC2aJVSjSqjiIjI9LAHVEnlmTBzOHzc4iz+q/g/rToP+FOXlJKot3YqbR891rziKMrF5T0JUUDOBpDX26K3W3Qk1KqX57WUNMu0miFbjJ9Cd495/gXiDtVGWOyAzkM8PA3KdIu9e4RcuGk5sflllJAV1grbIHhrpc/P1IU0+irDUKWlmZ/zx2XGYzFzPh76f3MulPf/75w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --_000_6e7bc1dfb59d4ee39bbb6a6bb7ed8808xiaomicom_ Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 SSBzZWUuICBJIHRoaW5rIGFkZGluZyAicGFnZXMiIGlzIGJldHRlci4NCg0KRG8gSSBuZWVkIHRv IHNlbmQgYSBuZXcgZW1haWwgd2l0aCBhIG5ldyBwYXRjaD8NCg0KDQoNCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fDQq3orz+yMs6IERhdmlkIEhpbGRlbmJyYW5kIDxkYXZpZEByZWRo YXQuY29tPg0Kt6LLzcqxvOQ6IDIwMjTE6jnUwjI3yNUgMjA6MzA6MTgNCsrVvP7IyzogWGlhbmcg R2FvOyBha3BtQGxpbnV4LWZvdW5kYXRpb24ub3JnDQqzrcvNOiBsaW51eC1tbUBrdmFjay5vcmc7 IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7ILjfz+gNCtb3zOI6IFtFeHRlcm5hbCBNYWls XVJlOiBbUEFUQ0hdIG1tL2NtYTogcHJpbnQgdG90YWwgYW5kIHVzZWQgY291bnQgaW4gY21hX2Fs bG9jKCkNCg0KW83isr/Tyrz+XSC0y9PKvP7AtNS009rQocPXuavLvs3isr+jrMfrvffJ97SmwO2h o8j0ttTTyrz+sLLIq9DUtObSyaOsx+u9q9PKvP7XqreiuPhtaXNlY0B4aWFvbWkuY29tvfjQ0Le0 wKENCg0KT24gMjYuMDkuMjQgMTQ6MDAsIFhpYW5nIEdhbyB3cm90ZToNCj4gRnJvbTogZ2FveGlh bmcxNyA8Z2FveGlhbmcxN0B4aWFvbWkuY29tPg0KPg0KPiBiZWZvcmU6DQo+IFsgICAyNC40MDc4 MTRdIGNtYTogY21hX2FsbG9jKGNtYSAoX19fX3B0cnZhbF9fX18pLCBuYW1lOiByZXNlcnZlZCwg Y291bnQgMSwgYWxpZ24gMCkNCj4gWyAgIDI0LjQxMzM5N10gY21hOiBjbWFfYWxsb2MoY21hIChf X19fcHRydmFsX19fXyksIG5hbWU6IHJlc2VydmVkLCBjb3VudCAxLCBhbGlnbiAwKQ0KPiBbICAg MjQuNDE1ODg2XSBjbWE6IGNtYV9hbGxvYyhjbWEgKF9fX19wdHJ2YWxfX19fKSwgbmFtZTogcmVz ZXJ2ZWQsIGNvdW50IDEsIGFsaWduIDApDQo+DQo+IGFmdGVyOg0KPiBbICAgMjQuMDk3OTg5XSBj bWE6IGNtYV9hbGxvYyhjbWEgKF9fX19wdHJ2YWxfX19fKSwgbmFtZTogcmVzZXJ2ZWQsIHRvdGFs IGNvdW50IDE2Mzg0LCB1c2VkIGNvdW50OiA2NCwgcmVxdWVzdCBjb3VudCAxLCBhbGlnbiAwKQ0K PiBbICAgMjQuMTA0MjYwXSBjbWE6IGNtYV9hbGxvYyhjbWEgKF9fX19wdHJ2YWxfX19fKSwgbmFt ZTogcmVzZXJ2ZWQsIHRvdGFsIGNvdW50IDE2Mzg0LCB1c2VkIGNvdW50OiA2NSwgcmVxdWVzdCBj b3VudCAxLCBhbGlnbiAwKQ0KPiBbICAgMjQuMTA3NTA0XSBjbWE6IGNtYV9hbGxvYyhjbWEgKF9f X19wdHJ2YWxfX19fKSwgbmFtZTogcmVzZXJ2ZWQsIHRvdGFsIGNvdW50IDE2Mzg0LCB1c2VkIGNv dW50OiA2NiwgcmVxdWVzdCBjb3VudCAxLCBhbGlnbiAwKQ0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBn YW94aWFuZzE3IDxnYW94aWFuZzE3QHhpYW9taS5jb20+DQo+IC0tLQ0KPiAgIG1tL2NtYS5jIHwg MTUgKysrKysrKysrKysrKy0tDQo+ICAgMSBmaWxlIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyks IDIgZGVsZXRpb25zKC0pDQo+DQo+IGRpZmYgLS1naXQgYS9tbS9jbWEuYyBiL21tL2NtYS5jDQo+ IGluZGV4IDJkOWZhZTkzOTI4My4uZmMzNWE4NmFhODJmIDEwMDY0NA0KPiAtLS0gYS9tbS9jbWEu Yw0KPiArKysgYi9tbS9jbWEuYw0KPiBAQCAtNDAzLDYgKzQwMywxNyBAQCBzdGF0aWMgdm9pZCBj bWFfZGVidWdfc2hvd19hcmVhcyhzdHJ1Y3QgY21hICpjbWEpDQo+ICAgICAgIHNwaW5fdW5sb2Nr X2lycSgmY21hLT5sb2NrKTsNCj4gICB9DQo+DQo+ICtzdGF0aWMgdW5zaWduZWQgbG9uZyBjbWFf Z2V0X3VzZWQoc3RydWN0IGNtYSAqY21hKQ0KDQpJIHdvdWxkIGNhbGwgaXQgImNtYV9nZXRfdXNl ZF9wYWdlcygpIg0KDQo+ICt7DQo+ICsgICAgIHVuc2lnbmVkIGxvbmcgdXNlZDsNCj4gKw0KPiAr ICAgICBzcGluX2xvY2tfaXJxKCZjbWEtPmxvY2spOw0KPiArICAgICB1c2VkID0gYml0bWFwX3dl aWdodChjbWEtPmJpdG1hcCwgKGludCljbWFfYml0bWFwX21heG5vKGNtYSkpOw0KPiArICAgICBz cGluX3VubG9ja19pcnEoJmNtYS0+bG9jayk7DQo+ICsNCj4gKyAgICAgcmV0dXJuIHVzZWQgPDwg Y21hLT5vcmRlcl9wZXJfYml0Ow0KPiArfQ0KPiArDQo+ICAgc3RhdGljIHN0cnVjdCBwYWdlICpf X2NtYV9hbGxvYyhzdHJ1Y3QgY21hICpjbWEsIHVuc2lnbmVkIGxvbmcgY291bnQsDQo+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBhbGlnbiwgZ2ZwX3QgZ2ZwKQ0K PiAgIHsNCj4gQEAgLTQyMCw4ICs0MzEsOCBAQCBzdGF0aWMgc3RydWN0IHBhZ2UgKl9fY21hX2Fs bG9jKHN0cnVjdCBjbWEgKmNtYSwgdW5zaWduZWQgbG9uZyBjb3VudCwNCj4gICAgICAgaWYgKCFj bWEgfHwgIWNtYS0+Y291bnQgfHwgIWNtYS0+Yml0bWFwKQ0KPiAgICAgICAgICAgICAgIHJldHVy biBwYWdlOw0KPg0KPiAtICAgICBwcl9kZWJ1ZygiJXMoY21hICVwLCBuYW1lOiAlcywgY291bnQg JWx1LCBhbGlnbiAlZClcbiIsIF9fZnVuY19fLA0KPiAtICAgICAgICAgICAgICh2b2lkICopY21h LCBjbWEtPm5hbWUsIGNvdW50LCBhbGlnbik7DQo+ICsgICAgIHByX2RlYnVnKCIlcyhjbWEgJXAs IG5hbWU6ICVzLCB0b3RhbCBjb3VudCAlbHUsIHVzZWQgY291bnQ6ICVsdSwgcmVxdWVzdCBjb3Vu dCAlbHUsIGFsaWduICVkKVxuIiwgX19mdW5jX18sDQoNCkkgd291bGQgc3VnZ2VzdCBkcm9wcGlu ZyB0aGUgImNvdW50Iiwgb3IgdXNpbmcgInBhZ2VzIiBpbnN0ZWFkLiBBbHNvLA0KaW5jb25zaXN0 ZW50IHVzYWdlIG9mICI6Ii4NCg0KRWl0aGVyOg0KDQpwcl9kZWJ1ZygiJXMoY21hICVwLCBuYW1l OiAlcywgdG90YWw6ICVsdSwgdXNlZDogJWx1LCByZXF1ZXN0ZWQ6ICVsdSwgLi4uIg0KDQpvcg0K DQpwcl9kZWJ1ZygiJXMoY21hICVwLCBuYW1lOiAlcywgdG90YWwgcGFnZXM6ICVsdSwgdXNlZCBw YWdlczogJWx1LA0KcmVxdWVzdGVkIHBhZ2VzOiAlbHUsIC4uLiINCg0KPiArICAgICAgICAgICAg ICh2b2lkICopY21hLCBjbWEtPm5hbWUsIGNtYS0+Y291bnQsIGNtYV9nZXRfdXNlZChjbWEpLCBj b3VudCwgYWxpZ24pOw0KPg0KPiAgICAgICBpZiAoIWNvdW50KQ0KPiAgICAgICAgICAgICAgIHJl dHVybiBwYWdlOw0KDQoNCi0tDQpDaGVlcnMsDQoNCkRhdmlkIC8gZGhpbGRlbmINCg0K --_000_6e7bc1dfb59d4ee39bbb6a6bb7ed8808xiaomicom_ Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

I see.  I think ad= ding "pages" is better. 

Do I need to send a new email with a new patch?<= /span>

=B7=A2=BC=FE=C8=CB: David= Hildenbrand <david@redhat.com>
=B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4=EA9=D4=C227=C8=D5 20:30:18
=CA=D5=BC=FE=C8=CB: Xiang Gao; akpm@linux-foundation.org
=B3=AD=CB=CD: linux-mm@kvack.org; linux-kernel@vger.kernel.org; =B8= =DF=CF=E8
=D6=F7=CC=E2: [External Mail]Re: [PATCH] mm/cma: print total and use= d count in cma_alloc()
 
[=CD=E2=B2=BF=D3=CA=BC=FE] =B4=CB=D3=CA=BC=FE=C0= =B4=D4=B4=D3=DA=D0=A1=C3=D7=B9=AB=CB=BE=CD=E2=B2=BF=A3=AC=C7=EB=BD=F7=C9=F7= =B4=A6=C0=ED=A1=A3=C8=F4=B6=D4=D3=CA=BC=FE=B0=B2=C8=AB=D0=D4=B4=E6=D2=C9=A3= =AC=C7=EB=BD=AB=D3=CA=BC=FE=D7=AA=B7=A2=B8=F8misec@xiaomi.com=BD=F8=D0=D0= =B7=B4=C0=A1

On 26.09.24 14:00, Xiang Gao wrote:
> From: gaoxiang17 <gaoxiang17@xiaomi.com>
>
> before:
> [   24.407814] cma: cma_alloc(cma (____ptrval____), name: re= served, count 1, align 0)
> [   24.413397] cma: cma_alloc(cma (____ptrval____), name: re= served, count 1, align 0)
> [   24.415886] cma: cma_alloc(cma (____ptrval____), name: re= served, count 1, align 0)
>
> after:
> [   24.097989] cma: cma_alloc(cma (____ptrval____), name: re= served, total count 16384, used count: 64, request count 1, align 0)
> [   24.104260] cma: cma_alloc(cma (____ptrval____), name: re= served, total count 16384, used count: 65, request count 1, align 0)
> [   24.107504] cma: cma_alloc(cma (____ptrval____), name: re= served, total count 16384, used count: 66, request count 1, align 0)
>
> Signed-off-by: gaoxiang17 <gaoxiang17@xiaomi.com>
> ---
>   mm/cma.c | 15 +++++++++= ;++++--
>   1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/mm/cma.c b/mm/cma.c
> index 2d9fae939283..fc35a86aa82f 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -403,6 +403,17 @@ static void cma_debug_show_areas(struct cma *= cma)
>       spin_unlock_irq(&cma->lock)= ;
>   }
>
> +static unsigned long cma_get_used(struct cma *cma)

I would call it "cma_get_used_pages()"

> +{
> +     unsigned long used;
> +
> +     spin_lock_irq(&cma->lock);
> +     used =3D bitmap_weight(cma->bitmap, (= int)cma_bitmap_maxno(cma));
> +     spin_unlock_irq(&cma->lock);
> +
> +     return used << cma->order_per_b= it;
> +}
> +
>   static struct page *__cma_alloc(struct cma *cma, unsigned = long count,
>            = ;            &n= bsp;      unsigned int align, gfp_t gfp)
>   {
> @@ -420,8 +431,8 @@ static struct page *__cma_alloc(struct cma *cm= a, unsigned long count,
>       if (!cma || !cma->count || !cma= ->bitmap)
>            = ;   return page;
>
> -     pr_debug("%s(cma %p, name: %s, count %l= u, align %d)\n", __func__,
> -           &nb= sp; (void *)cma, cma->name, count, align);
> +     pr_debug("%s(cma %p, name: %s, tota= l count %lu, used count: %lu, request count %lu, align %d)\n", __func_= _,

I would suggest dropping the "count", or using "pages" = instead. Also,
inconsistent usage of ":".

Either:

pr_debug("%s(cma %p, name: %s, total: %lu, used: %lu, requested: %lu, = ..."

or

pr_debug("%s(cma %p, name: %s, total pages: %lu, used pages: %lu,
requested pages: %lu, ..."

> +           = ;  (void *)cma, cma->name, cma->count, cma_get_used(cma), count,= align);
>
>       if (!count)
>            = ;   return page;


--
Cheers,

David / dhildenb

--_000_6e7bc1dfb59d4ee39bbb6a6bb7ed8808xiaomicom_--