From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7F65C369AB for ; Tue, 22 Apr 2025 00:35:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 41E0F6B0005; Mon, 21 Apr 2025 20:35:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F2256B0007; Mon, 21 Apr 2025 20:35:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BBEA6B0008; Mon, 21 Apr 2025 20:35:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0D01C6B0005 for ; Mon, 21 Apr 2025 20:35:24 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6D13F1212F2 for ; Tue, 22 Apr 2025 00:35:23 +0000 (UTC) X-FDA: 83359810926.30.4626FF8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id F19CD80008 for ; Tue, 22 Apr 2025 00:35:20 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NVDCnjCy; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of llong@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=llong@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745282121; a=rsa-sha256; cv=none; b=A3O7tUH493oCNM+JnWkX92rxXVzZ6ta7i1UV7+0Slm023RWCg1j5IY5LEc1nU1+zRgkj3o 6FiLZdvwIep0/ul9wB9F26bgzscuV8EgmgpKEFnais3XP9GeIAhIALgnheTThIzSi6UMwj ClxtpROHVCgnD97D4Yce8MDhxj47jjs= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NVDCnjCy; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of llong@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=llong@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745282121; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3zQBqgp3LCbgCzAboI9XQBdES5DPR7oeFpEx4guOZXE=; b=TQshGZhbGMEcXIebQiNrTy91XOIHj7E87BgUbp7oLBV9pntNQ0ULeUnuPIdSrw31sNuCpD hft7zX1PtMyQ0rJbJWZl5V0qL33NeFKhGb5vlsmR/LjFyogavJzhHju8CTwUVLLqmaRbNl jANuC2QDFZu/o45z4/nqXD/MNyXpFIA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745282120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3zQBqgp3LCbgCzAboI9XQBdES5DPR7oeFpEx4guOZXE=; b=NVDCnjCyxL98r3D5cH7R0Rup0+CP6kk8iyfC33SPqhFK59nFCJau9hq49FMrHAZC5TGaXk WTKxXfTn8xhx0gYdD0XHmjL0DezOqnHdvc1T2Z5dniLGG2yb0/7ngLd01u5FyM23ZoR6A4 w1FBcQXISfd8C4k9XxX0Q0uzjeWrilA= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-410-3h2SADZtORmYfe-Y92Ko-g-1; Mon, 21 Apr 2025 20:35:19 -0400 X-MC-Unique: 3h2SADZtORmYfe-Y92Ko-g-1 X-Mimecast-MFC-AGG-ID: 3h2SADZtORmYfe-Y92Ko-g_1745282118 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4767bab171dso43728361cf.1 for ; Mon, 21 Apr 2025 17:35:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745282118; x=1745886918; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3zQBqgp3LCbgCzAboI9XQBdES5DPR7oeFpEx4guOZXE=; b=kNKAPJJESFyh0q+FnJy8lqMg4cbDPgc4qvEgjtWdoMrDIfG3mi5ChbdMA8HptVoHJp 0ZqY36+9rflJ62VK8Dxt0zgt1MPST8JeXpLSRB+FF0U7Troz2QjANAJd9Jaj9gv98Ahy TSkBc0D4/a2nPeqAOKodnE25Rh/Wzbq8QMt89VH0Y7kZIKdyWl7BC9Zqw11QT5HrlxRn fMwQe8rcsTQHvoEkbyv3BGKOIeIG3axUrfPbHXhWWHbV+1FTPDJ716pq77F8s3C/XW4M Bv/nCpMuxtn4eIAGAE45OZ5NNWYk6E7Br1Pi99r3qlStDItK6VJvpLpqeo2Q7GX0+4L7 lzuQ== X-Forwarded-Encrypted: i=1; AJvYcCUEJda23IS3FpGrhN7kG3Xkv0eb85jpHOsBEwubYXsA6XvKKBT/4S3c4YWvCYW++3oOkbPGabLMQQ==@kvack.org X-Gm-Message-State: AOJu0YwySEbAHPi1gpXyS/0801vWebL+kWH9iMJLvM4c6KHala5/PUiW lPnfBK42zzrJfVXrRFhB0HKyq+GR6nwstmqQGjn32RRNfl/6VnkRad0tsyT+BHTE1MLTbBzrYAU q6+6NWEc1EbJcVOjQr4gxQQORzZyFz4aWRGlgtA30FhIyB0tctu/N4N99 X-Gm-Gg: ASbGnctfYeWEE9t7vawhPWN3m4mEAmMG6K3S2V2mKbC1mAZ7RYITsESa8JaJPbW7oqs 0rchE5wP6Zmv2cxbpOH67HWFx7/RzrT13TQTf51YHdqVUrkTZbd0/E90U4ypxzgjxGoO860Bq+T yBmgTIpDq8yUAxtpvC7ghxRGy5xuUozqyUs3fj8LsCXWXjm7zQq7MliXy5TKQUhCQXUirgfoe3i efwTRhufhJ+jRInpUzjsmDx6McLHrwQ70ha0ibP9kTjurjcw5j5XQQOk29E7WW6FaueCv+/PiWU 8dUN2KVa3Bt7zokfiprjQNlbQgBdZYD3cID2van64v/Kv9y/J6Cq6h5gIg== X-Received: by 2002:ac8:5fca:0:b0:476:75d0:a1e1 with SMTP id d75a77b69052e-47aec393d49mr207680251cf.9.1745282118185; Mon, 21 Apr 2025 17:35:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF3REdENZgnJTaxkrRF1AqZKfhF9AAt5zCkgw2tWo6ZEkKm30J1Vx/N9effiYs8J2qc3GWbLQ== X-Received: by 2002:ac8:5fca:0:b0:476:75d0:a1e1 with SMTP id d75a77b69052e-47aec393d49mr207679981cf.9.1745282117841; Mon, 21 Apr 2025 17:35:17 -0700 (PDT) Received: from ?IPV6:2601:408:c101:1d00:6621:a07c:fed4:cbba? ([2601:408:c101:1d00:6621:a07c:fed4:cbba]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-47ae9cf7357sm48788181cf.66.2025.04.21.17.35.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Apr 2025 17:35:17 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <6e7806a7-9ffd-4c7c-b247-934b206088c7@redhat.com> Date: Mon, 21 Apr 2025 20:35:15 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] vmscan,cgroup: apply mems_effective to reclaim To: Gregory Price , Shakeel Butt Cc: Waiman Long , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, tj@kernel.org, mkoutny@suse.com, akpm@linux-foundation.org References: <20250419053824.1601470-1-gourry@gourry.net> <20250419053824.1601470-3-gourry@gourry.net> <7dtp6v5evpz5sdevwrexhwcdtl5enczssvuepkib2oiaexk3oo@ranij7pskrhe> In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: EPXnepatV2y-jcxrCWk_d7CbuQrabHW32NGaU13rZPw_1745282118 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: F19CD80008 X-Stat-Signature: 8dq7bth3qquepmarfrii7ao7pegnsegs X-Rspam-User: X-HE-Tag: 1745282120-536342 X-HE-Meta: U2FsdGVkX18dXl/GCHsCyCong5OjxL/LNMIZjbVIhfxKFgtw6e+sujwKSltZWwE/BeYCbYCES4G66U49aINab+Oo8u1FO7ZGbF5/y0wZRCRrJIFpyFe0ld0aSoonSMhRbe2SW3TLryiggH0lCKbhFbd02YVvLcbf7oCFAFII3pUrm/bX8jJewfAC/MOwBPmog9oR5boPyhWjZdub4YwFCgYxw+qzxkPubJLtvqP+4iuRCgTWpOdAtaes6+MZDuhfYNr/imTnsZVa5RRaLAbMPGtHTms8pfWwEmsq2+w6Xim/uCtt1xwnMA4GaXaJVc6A5A99yCEDE/TJqhKjz3JxzhxrhoEhVCwWnMjInrNXmE+rxhaD80E/vzbfpWBzKwby6xvcI6tVk28TY26JNaoF1JQq9kyUzipz1yjXyxUMNrfHkZGYWsbvDa3kch+Tvu3qnA5043CVzaKt82vsYJwS9Ui0KRPNgfYxht5J/RvKCtRsiQlqoA1qAtwfwnLT5anx5Ucr2djJN9JfewWy3U37A+Q1QdnYudK0QgRw4lBQybRUt7KznODkHH2/jf97wqeZIFasY41wO09EyZhT51psMw4VgHZlrYo56AIKPaxRHzqwzgDGZoKrJthguu9BfiVvqbd4L08OkXuwFojRtSMOueRlt8D8vAYysgYPF5Z/Yk1npqELFwgQxYc7Yjdw1OLgY0pNHRZcIiHtAS61HuZcQE82QJJQQqvj54UZ2nuDwBo7XSEupJlwladpfDKbrpocANvDFaUE7qM6UjlHjV4Rm07H+fzEqggsrtcFz2yr6E0D/9cgMQQTvdX9AEZz3H4TIxtmHGr6CMWSV0ugmYfOfbRYt0jSmyaVFrYQkKyVUIQH950Gghl1IEhrjQ5+m3CBmpUdS7j9oQeQozSJ18kJocJ9CSo/zYlWbnMsHoCRphnCNV8kkHqd+fhZjjRV+kqGBTlLysImBZniefnAqGP 8XPbikP/ caqKeu7L3Bps/aToke/e6Ssq5TVKAiUbELArjvK6Qkhzay+kMFLt2T5JaUM6KwSG2hXELgnY2S4DY7fmEmLwDqs355N8wmnfFpxPA5JFHI4tnytbgGrXyD0Qz5pvltRWwgNlxFJhY0uEm06NlbUqO4YTSRV2UR+2ClYKReNR6MtaQfyVN7ejCVytBrbwJlkFVq2YIpjwdxWQS7DK1oQlwJEbAmGNibG+fUDF8SAzTkL6IrLCrpV+farDFymEfjReqXw2GCEdnUEMTUDXFKoeZJ7O1HI81gVV2wUxN8wEjJFxClEHBaOXSZBq4LVGoZM7tkzYu2MdBsyApwleVkspaZmmU0bjVRdK2YJXRmWQidnLpL03eZl7JXxHw0KiRijPdgJBJ6rJL7S5RJMpzqw8oC5H5JC3SC3UlPMWGKMY4xcyGn0TRc6YgMesWaSWRQ5rbvW6D/GVzhj9dPxG9vWjDFW4VgRD3jLsA0KR0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/21/25 7:58 PM, Gregory Price wrote: > On Mon, Apr 21, 2025 at 04:15:49PM -0700, Shakeel Butt wrote: >> On Mon, Apr 21, 2025 at 06:59:20PM -0400, Gregory Price wrote: >>> On Mon, Apr 21, 2025 at 10:39:58AM -0700, Shakeel Butt wrote: >>>> On Sat, Apr 19, 2025 at 08:14:29PM -0400, Waiman Long wrote: >>>>> On 4/19/25 2:48 PM, Shakeel Butt wrote: >>>>>> On Sat, Apr 19, 2025 at 01:38:24AM -0400, Gregory Price wrote: >>>>>>> +bool cpuset_node_allowed(struct cgroup *cgroup, int nid) >>>>>>> +{ >>>>>>> + struct cgroup_subsys_state *css; >>>>>>> + unsigned long flags; >>>>>>> + struct cpuset *cs; >>>>>>> + bool allowed; >>>>>>> + >>>>>>> + css = cgroup_get_e_css(cgroup, &cpuset_cgrp_subsys); >>>>>>> + if (!css) >>>>>>> + return true; >>>>>>> + >>>>>>> + cs = container_of(css, struct cpuset, css); >>>>>>> + spin_lock_irqsave(&callback_lock, flags); >>>>>> Do we really need callback_lock here? We are not modifying and I am >>>>>> wondering if simple rcu read lock is enough here (similar to >>>>>> update_nodemasks_hier() where parent's effective_mems is accessed within >>>>>> rcu read lock). >>>>> The callback_lock is required to ensure the stability of the effective_mems >>>>> which may be in the process of being changed if not taken. >>>> Stability in what sense? effective_mems will not get freed under us >>>> here or is there a chance for corrupted read here? node_isset() and >>>> nodes_empty() seems atomic. What's the worst that can happen without >>>> callback_lock? >>> Fairly sure nodes_empty is not atomic, it's a bitmap search. >> For bitmaps smaller than 64 bits, it seems atomic and MAX_NUMNODES seems >> smaller than 64 in all the archs. > Unfortunately, it's config-defined on (NODES_SHIFT) and the max is 1024. Actually, it is nr_node_ids that control how many reads are needed to scan the complete node mask, not CONFIG_NODE_SHIFT. > > Is there an argument here for ignoring v1 and just doing the bit-check > without the lock? Is there an easy ifdef way for us to just return true > if it's v1? Your current patch is ignoring v1 as css will be NULL. It only works for v2 with a unified hierarchy unless some users explicitly force cpuset and memcg v1 to be in the same hierarchy. You can certainly ignore v1 by using cpuset_v2() check. Cheers, Longman ~Gregory