* [PATCH] damon: access_memory_even: remove unused variables
@ 2024-09-03 3:43 Ba Jing
2024-09-23 16:36 ` SeongJae Park
2024-09-23 16:44 ` Shuah Khan
0 siblings, 2 replies; 3+ messages in thread
From: Ba Jing @ 2024-09-03 3:43 UTC (permalink / raw)
To: sj; +Cc: shuah, damon, linux-mm, linux-kselftest, linux-kernel, Ba Jing
These variables are never referenced in the code, just remove it.
Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com>
---
tools/testing/selftests/damon/access_memory_even.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/testing/selftests/damon/access_memory_even.c b/tools/testing/selftests/damon/access_memory_even.c
index 3be121487432..a9f4e9aaf3a9 100644
--- a/tools/testing/selftests/damon/access_memory_even.c
+++ b/tools/testing/selftests/damon/access_memory_even.c
@@ -14,10 +14,8 @@
int main(int argc, char *argv[])
{
char **regions;
- clock_t start_clock;
int nr_regions;
int sz_region;
- int access_time_ms;
int i;
if (argc != 3) {
--
2.33.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] damon: access_memory_even: remove unused variables
2024-09-03 3:43 [PATCH] damon: access_memory_even: remove unused variables Ba Jing
@ 2024-09-23 16:36 ` SeongJae Park
2024-09-23 16:44 ` Shuah Khan
1 sibling, 0 replies; 3+ messages in thread
From: SeongJae Park @ 2024-09-23 16:36 UTC (permalink / raw)
To: Ba Jing
Cc: SeongJae Park, shuah, damon, linux-mm, linux-kselftest, linux-kernel
Hi Ba,
On Tue, 3 Sep 2024 11:43:00 +0800 Ba Jing <bajing@cmss.chinamobile.com> wrote:
> These variables are never referenced in the code, just remove it.
Nice finding, thank you!
I'd prefer having 'selftests/damon/access_memory_even: ' as the commit subject
prefix.
>
> Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com>
Other than the above trivial nitpick,
Reviewed-by: SeongJae Park <sj@kernel.org>
Thanks,
SJ
> ---
> tools/testing/selftests/damon/access_memory_even.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/testing/selftests/damon/access_memory_even.c b/tools/testing/selftests/damon/access_memory_even.c
> index 3be121487432..a9f4e9aaf3a9 100644
> --- a/tools/testing/selftests/damon/access_memory_even.c
> +++ b/tools/testing/selftests/damon/access_memory_even.c
> @@ -14,10 +14,8 @@
> int main(int argc, char *argv[])
> {
> char **regions;
> - clock_t start_clock;
> int nr_regions;
> int sz_region;
> - int access_time_ms;
> int i;
>
> if (argc != 3) {
> --
> 2.33.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] damon: access_memory_even: remove unused variables
2024-09-03 3:43 [PATCH] damon: access_memory_even: remove unused variables Ba Jing
2024-09-23 16:36 ` SeongJae Park
@ 2024-09-23 16:44 ` Shuah Khan
1 sibling, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2024-09-23 16:44 UTC (permalink / raw)
To: Ba Jing, sj
Cc: shuah, damon, linux-mm, linux-kselftest, linux-kernel, Shuah Khan
On 9/2/24 21:43, Ba Jing wrote:
> These variables are never referenced in the code, just remove it.
remove them?
Add details on how you found this problem in the commit log.
Send v2 with these changes.
>
> Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com>
> ---
> tools/testing/selftests/damon/access_memory_even.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/testing/selftests/damon/access_memory_even.c b/tools/testing/selftests/damon/access_memory_even.c
> index 3be121487432..a9f4e9aaf3a9 100644
> --- a/tools/testing/selftests/damon/access_memory_even.c
> +++ b/tools/testing/selftests/damon/access_memory_even.c
> @@ -14,10 +14,8 @@
> int main(int argc, char *argv[])
> {
> char **regions;
> - clock_t start_clock;
> int nr_regions;
> int sz_region;
> - int access_time_ms;
> int i;
>
> if (argc != 3) {
With these changes:
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-23 16:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-03 3:43 [PATCH] damon: access_memory_even: remove unused variables Ba Jing
2024-09-23 16:36 ` SeongJae Park
2024-09-23 16:44 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox