From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 411FECF9C6F for ; Mon, 23 Sep 2024 16:44:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB6FE6B007B; Mon, 23 Sep 2024 12:44:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C66896B0083; Mon, 23 Sep 2024 12:44:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7C5A6B0085; Mon, 23 Sep 2024 12:44:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 98C986B007B for ; Mon, 23 Sep 2024 12:44:49 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4388FAC49A for ; Mon, 23 Sep 2024 16:44:49 +0000 (UTC) X-FDA: 82596577098.03.A673723 Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by imf22.hostedemail.com (Postfix) with ESMTP id 56B8EC000D for ; Mon, 23 Sep 2024 16:44:46 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=JAVt9s+d; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf22.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.53 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727109799; a=rsa-sha256; cv=none; b=D2S21xtunm9rMygM+XfAgbR4QJyelfd4w+x1zqLTIg+vhp9dYwiaHs/0M0WN1CxjaNmBcK it+oBMtoOaPK2sUS/JiLmb+3j69TpFPLloUbsczaCUMKctK5bd2DUSshqWQ9yoDwgGi9e+ DFWMV1Ietf0BThJ7UQkBbwVCD4tgz1g= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=JAVt9s+d; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf22.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.53 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727109799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gjDcu1qjAZXv0N7bHIy/5adY2cLrLfFMbmRWe9h7RCA=; b=1u4IYSlgbUtHl0tJ+aL8KXsX7FLCEUW3GXHdbOAdCMK1iWmn+QYJaIWhfVjrrMuSk2ZsPG F8cDA26hy6ijdhRUbfuMRPSAZho+99tNaamEPo9+3hexTpG2C17leRKa/clGtyc9+nFRGt lpdBoeRc5/k9/HzL4gu+KIfFo7uPDlU= Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-831e62bfa98so227311039f.1 for ; Mon, 23 Sep 2024 09:44:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1727109885; x=1727714685; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gjDcu1qjAZXv0N7bHIy/5adY2cLrLfFMbmRWe9h7RCA=; b=JAVt9s+dXWghgMcXD5HxwVN3mvMlmK8xz9Q7xE6jTdMQZT+lyezMZ0VkXNdIOjj2qg KExEzR+8B4qs8FX/wBRji3OAsphvgoDexuA7VaAiMorw9SwgZ9U6iZgp23oGZVjwn0fL B7d+4PZoGVaRJj3ap5jIS85fVDHg+45S37G/s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727109885; x=1727714685; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gjDcu1qjAZXv0N7bHIy/5adY2cLrLfFMbmRWe9h7RCA=; b=YuDp7dOI82GQPVEFgq0aMZ4Nl9h8gn/Uf6Q75Zjzs0ldwCxxshOtCRneaZjB+kyb3g lfufsnyl67PkY0EvjSM3vYYCLRSOB5V+oUmR5uwWi7ZOdh35zd6dR2EPT5HuGEDmDOt2 jAL0t8ss2Bnqc/69T+BgLhU1+x9T9swP/QpCfHvPIU/bWUE+FbeEmq9Vxu9lw/7mgoXd 6+JndFjRJy3zfFcZCrcgo1I6jVorSqDmK4Fpj3BXrRNXjATTnrZUhdyhoUAbyIVNdJH7 0VEnpuQ7iQiGzI93nx9ML7Zo4JR6BqUsKDQRtPdsE4EryuRYgBIKlzm0AF2E49ijpaP5 8hcg== X-Forwarded-Encrypted: i=1; AJvYcCWSWGz9dp4TeKi7oh2MWnz7rTvpIZozDz9Gz0HShS6wtDkW3wLM3Q0uJDwC5EEAgTEmewrAtwRBjw==@kvack.org X-Gm-Message-State: AOJu0YzjYA8ZbGNdFmesGqwttJpiSbFvWKo8hE2bYbJKewOM977QJGSw DBtJDTZTCCC/slqI4P4dKUCI8jaSOAoSKGIfVjNAjUUPWOhzLrdh1bCnIv9oT8A= X-Google-Smtp-Source: AGHT+IFeE7PSHtYTy6cCbJSWJ5DjlBn+o1h78m0KFuLtOxLv7/WV1afXrTm5YCgUpVC62dLJGRMTmg== X-Received: by 2002:a05:6e02:1a67:b0:3a0:451b:ade3 with SMTP id e9e14a558f8ab-3a0c8c9e4e6mr103481185ab.10.1727109885323; Mon, 23 Sep 2024 09:44:45 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4d37ed597dfsm5222919173.166.2024.09.23.09.44.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Sep 2024 09:44:44 -0700 (PDT) Message-ID: <6e71e7e2-5b69-488d-b3fc-e547d6b4b042@linuxfoundation.org> Date: Mon, 23 Sep 2024 10:44:43 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] damon: access_memory_even: remove unused variables To: Ba Jing , sj@kernel.org Cc: shuah@kernel.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20240903034300.10443-1-bajing@cmss.chinamobile.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240903034300.10443-1-bajing@cmss.chinamobile.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 56B8EC000D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: qq4bkwyf7ftgyhwmp31m3e96zhca4awx X-HE-Tag: 1727109886-2281 X-HE-Meta: U2FsdGVkX1+psDk3MUqVPTNdUnOFQanfuWLPMMqAMWtw+YFWqHDdzZcmUgj4vj+l1MrTg3br8yt4DTkfCt/Zbpd5wzfpWsUd6iN5CNwLC0+xgyO2J4zK/wdER+Ct5Qj5K4qzrogKw8fgglokOPf52p46SdYMscUgPBZJwxk5ek9I2OwrN1IsvIoKCwzCkxhcrOzm3KCXeXAO9FJ9/GiddwMoFXt90l+uFw1tsFm4z0NF3NUGD83KVO8O6kSSn+ixQPHz23+bQaTtgsUbJzXC7l1GWg9DkJBwJTwh6U5XTREJ08WQ9UNuiq09ZLqPnOnvtKy8v0AkDUsEqXng/QAFhlyktmaXnIumeRpiztKj3H6FXpxgFD9szFqAr8jzitNNfAxuwyzymPJrjk1gOpq3V39yXmRD4sm+BhX1+fvCTu6XbOKdCR0wvqC7Ln2+X8bmVgNhVTxMnIYc9hdC9xct0JNBEOsVpmR3TWxDxsVqPsuJshlrCl0hyH71OyU3GrVIYBl0P9u1f0CqTEmtGi+TfYkxGgioAfzCESzhpe8FXgr3fciM7Dez/04m21hkS6mnFG/fOObpbJkWsU2vvkaRTxxJCsvtyGUsiFtxJVvccSj1PDxU3GvPRyKVOWvXMDm8B7ON9IdkL6lunv7qxkstHvjKmJglmIPQhx8jKsl/5xZEL/7iWHQ2LpzKYKwvRlbb4pwpv0j6pon69uPVDQK+nEcmTy0BZoqqP68G/zHPg4DdIAaq+iHVSe0TzL+H0WS7IIrR3LwK7jmJAIXculInOMN8KxXjUq34vjXrccpwZXy7SYeYB/ejFs+b0q5M7xUNm7obsqYGjGIUlKqkF+sEjfP3hgQUjIKiabWwo5Gjsy+FEV+u+zrluxDyIjKgMcd00DrOrvqPkhMc4ZkAz+CvYedASH4fdY7YEVCSFIFyhn1ZgV7rXKchh1zGAwpKUYlrxaKlD8K4jNE76rkofUz e7e+XoGm gxOdRyRz4QaUxz8g5xDD/CGBIwcok/s4UtVNx1nmc2mpKxvhEXsOF7TOY9Dlh3PvTH7oJw0Cp6j4g7mWaup9zwaTqi+LQ1nzXOsRH7YW2+YkNl/S0TPxzOeL3FnlbSBC8nWLpQ/mlQOtZqKcVey40L/ktyVpmP1pEHni+wKeGIVgbL52CKyeLkN4yMeobmBzphjH2MvJN5KPQLx5Faf8bFS8QkZ0LXLT6797xdh2GUtaV8hZKd1Vkg6pPzCUDalwfkWcA043oYEPrITpZiJu8FFgJds5B9hWWKCOxanS6O6yKNkDydcbcTzDoiJ3C8K1XrodFJlIIrzSknktm6J0f5lCm9gZO2yUOgwuyeklQx8Z4yEeEDYrhg+IFK0v/P3LTh4g4XEuz9WFyjbuWKrpCZieLw05p2NenEK9h1eMXKWA6fK3//S8El1ieCcaSFDG+RuvKnLuybzCGWD7r2BPu1laOvki9w7da9P0h X-Bogosity: Ham, tests=bogofilter, spamicity=0.040108, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/2/24 21:43, Ba Jing wrote: > These variables are never referenced in the code, just remove it. remove them? Add details on how you found this problem in the commit log. Send v2 with these changes. > > Signed-off-by: Ba Jing > --- > tools/testing/selftests/damon/access_memory_even.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/testing/selftests/damon/access_memory_even.c b/tools/testing/selftests/damon/access_memory_even.c > index 3be121487432..a9f4e9aaf3a9 100644 > --- a/tools/testing/selftests/damon/access_memory_even.c > +++ b/tools/testing/selftests/damon/access_memory_even.c > @@ -14,10 +14,8 @@ > int main(int argc, char *argv[]) > { > char **regions; > - clock_t start_clock; > int nr_regions; > int sz_region; > - int access_time_ms; > int i; > > if (argc != 3) { With these changes: Reviewed-by: Shuah Khan thanks, -- Shuah