From: "David Hildenbrand (Arm)" <david@kernel.org>
To: "Lorenzo Stoakes (Oracle)" <ljs@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-cxl@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Oscar Salvador <osalvador@suse.de>,
Axel Rasmussen <axelrasmussen@google.com>,
Yuanchu Xie <yuanchu@google.com>, Wei Xu <weixugc@google.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH 14/14] mm/sparse: move memory hotplug bits to sparse-vmemmap.c
Date: Fri, 20 Mar 2026 20:07:34 +0100 [thread overview]
Message-ID: <6e58d40b-d0c2-46cc-9ab6-f3b1fe5ab40b@kernel.org> (raw)
In-Reply-To: <c880bda9-486c-41ab-b8f2-f0329392bbf6@lucifer.local>
On 3/17/26 21:09, Lorenzo Stoakes (Oracle) wrote:
> On Tue, Mar 17, 2026 at 05:56:52PM +0100, David Hildenbrand (Arm) wrote:
>> Let's move all memory hoptplug related code to sparse-vmemmap.c.
>>
>> We only have to expose sparse_index_init(). While at it, drop the
>> definition of sparse_index_init() for !CONFIG_SPARSEMEM, which is unused,
>> and place the declaration in internal.h.
>>
>> Signed-off-by: David Hildenbrand (Arm) <david@kernel.org>
>
> Looking through this it looks like it is just a code move modulo the other bits
> you metion, overall very nice cleanup, so let me hotplug my:
:)
>
> Reviewed-by: Lorenzo Stoakes (Oracle) <ljs@kernel.org>
>
> Into this review!
>
> OK I've actually cringed terribly at the puns here and maybe I'm cured for life
> from doing that again ;)
Never say never ;)
Thanks!
--
Cheers,
David
next prev parent reply other threads:[~2026-03-20 19:07 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 16:56 [PATCH 00/14] mm: memory hot(un)plug and SPARSEMEM cleanups David Hildenbrand (Arm)
2026-03-17 16:56 ` [PATCH 01/14] mm/memory_hotplug: remove for_each_valid_pfn() usage David Hildenbrand (Arm)
2026-03-17 17:19 ` Lorenzo Stoakes (Oracle)
2026-03-17 20:30 ` David Hildenbrand (Arm)
2026-03-18 7:51 ` Mike Rapoport
2026-03-17 16:56 ` [PATCH 02/14] mm/sparse: remove WARN_ONs from (online|offline)_mem_sections() David Hildenbrand (Arm)
2026-03-17 17:21 ` Lorenzo Stoakes (Oracle)
2026-03-18 7:53 ` Mike Rapoport
2026-03-17 16:56 ` [PATCH 03/14] mm/Kconfig: make CONFIG_MEMORY_HOTPLUG depend on CONFIG_SPARSEMEM_VMEMMAP David Hildenbrand (Arm)
2026-03-17 17:22 ` Lorenzo Stoakes (Oracle)
2026-03-18 7:55 ` Mike Rapoport
2026-03-17 16:56 ` [PATCH 04/14] mm/memory_hotplug: simplify check_pfn_span() David Hildenbrand (Arm)
2026-03-17 17:24 ` Lorenzo Stoakes (Oracle)
2026-03-18 7:56 ` Mike Rapoport
2026-03-17 16:56 ` [PATCH 05/14] mm/sparse: remove !CONFIG_SPARSEMEM_VMEMMAP leftovers for CONFIG_MEMORY_HOTPLUG David Hildenbrand (Arm)
2026-03-17 17:54 ` Lorenzo Stoakes (Oracle)
2026-03-18 7:58 ` Mike Rapoport
2026-03-17 16:56 ` [PATCH 06/14] mm/bootmem_info: remove handling for !CONFIG_SPARSEMEM_VMEMMAP David Hildenbrand (Arm)
2026-03-17 17:49 ` Lorenzo Stoakes (Oracle)
2026-03-18 8:15 ` Mike Rapoport
2026-03-20 18:37 ` David Hildenbrand (Arm)
2026-03-17 16:56 ` [PATCH 07/14] mm/bootmem_info: avoid using sparse_decode_mem_map() David Hildenbrand (Arm)
2026-03-17 18:02 ` Lorenzo Stoakes (Oracle)
2026-03-18 8:20 ` Mike Rapoport
2026-03-17 16:56 ` [PATCH 08/14] mm/sparse: remove sparse_decode_mem_map() David Hildenbrand (Arm)
2026-03-17 19:25 ` Lorenzo Stoakes (Oracle)
2026-03-18 8:20 ` Mike Rapoport
2026-03-17 16:56 ` [PATCH 09/14] mm/sparse: remove CONFIG_MEMORY_HOTPLUG-specific usemap allocation handling David Hildenbrand (Arm)
2026-03-17 19:48 ` Lorenzo Stoakes (Oracle)
2026-03-20 18:49 ` David Hildenbrand (Arm)
2026-03-20 18:58 ` David Hildenbrand (Arm)
2026-03-18 8:34 ` Mike Rapoport
2026-03-17 16:56 ` [PATCH 10/14] mm: prepare to move subsection_map_init() to mm/sparse-vmemmap.c David Hildenbrand (Arm)
2026-03-17 19:51 ` Lorenzo Stoakes (Oracle)
2026-03-20 18:59 ` David Hildenbrand (Arm)
2026-03-18 8:46 ` Mike Rapoport
2026-03-20 19:01 ` David Hildenbrand (Arm)
2026-03-17 16:56 ` [PATCH 11/14] mm/sparse: drop set_section_nid() from sparse_add_section() David Hildenbrand (Arm)
2026-03-17 19:55 ` Lorenzo Stoakes (Oracle)
2026-03-18 8:50 ` Mike Rapoport
2026-03-17 16:56 ` [PATCH 12/14] mm/sparse: move sparse_init_one_section() to internal.h David Hildenbrand (Arm)
2026-03-17 20:00 ` Lorenzo Stoakes (Oracle)
2026-03-18 8:54 ` Mike Rapoport
2026-03-17 16:56 ` [PATCH 13/14] mm/sparse: move __section_mark_present() " David Hildenbrand (Arm)
2026-03-17 20:01 ` Lorenzo Stoakes (Oracle)
2026-03-18 8:56 ` Mike Rapoport
2026-03-20 19:06 ` David Hildenbrand (Arm)
2026-03-17 16:56 ` [PATCH 14/14] mm/sparse: move memory hotplug bits to sparse-vmemmap.c David Hildenbrand (Arm)
2026-03-17 20:09 ` Lorenzo Stoakes (Oracle)
2026-03-20 19:07 ` David Hildenbrand (Arm) [this message]
2026-03-18 8:57 ` Mike Rapoport
2026-03-18 19:51 ` [PATCH 00/14] mm: memory hot(un)plug and SPARSEMEM cleanups Andrew Morton
2026-03-18 19:54 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e58d40b-d0c2-46cc-9ab6-f3b1fe5ab40b@kernel.org \
--to=david@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=weixugc@google.com \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox