From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0868BC00140 for ; Wed, 24 Aug 2022 12:36:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59AB3940008; Wed, 24 Aug 2022 08:36:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54A05940007; Wed, 24 Aug 2022 08:36:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 41291940008; Wed, 24 Aug 2022 08:36:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 33694940007 for ; Wed, 24 Aug 2022 08:36:05 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0C9F5A0BF8 for ; Wed, 24 Aug 2022 12:36:05 +0000 (UTC) X-FDA: 79834433490.29.4DCFCEF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 003AE100022 for ; Wed, 24 Aug 2022 12:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661344563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rJuT0qCBRs+JGxRnNUBPV/84rd6u301RNuYVKr9ovFg=; b=DvVYa3Y7NEo6ma9cGymm2il6dwWAiK2ouFrxrrvW9FDc2z3EI/+iOTREilLmc7gv8fZhTy eoHvpjBecl+z7wcQssYmqzkwNqgixPcaITaFEu3To/FZLAxPfssAFRZX66hzBYJpBTmeD3 x48Y71zd8/fDWzjaTOau7g0zZLZMLiE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-458-PBdtFQ8KNLiZW2If-5Zwxg-1; Wed, 24 Aug 2022 08:35:54 -0400 X-MC-Unique: PBdtFQ8KNLiZW2If-5Zwxg-1 Received: by mail-wr1-f72.google.com with SMTP id v19-20020adf8b53000000b00225728573e6so264637wra.21 for ; Wed, 24 Aug 2022 05:35:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=rJuT0qCBRs+JGxRnNUBPV/84rd6u301RNuYVKr9ovFg=; b=erg932mCizO8wFst/hU0b4jzxKjEb3aiCqo+gReNTXmX+GSb28lGWq5pO7p+njvNRu 8Y5MqDv5XeJqBqzsA7sXEI18mYUred+S0P6JJlj/a/KDcl0q7Sejjfc23Zldf67Owe6n vmhRlM4hNb2BDrIJtdBBpw3ZAhgbcAEiQ77BfeV46UFEpbuTQ1HLOOeN2+w6cUMjEwar O9lV0nGvEthi2io4bqLj5L6ziSuSjL8vBRsLVVW3J3AKlsnPrWKdLBH+MyU4Arlo+bwk CrjUVgXQiTuabuMK+KECNNZoHb2KA/EyLKzlsdWMLTU9rQW38+D42dDRP69V0winDhqA I/aw== X-Gm-Message-State: ACgBeo0vleUvPgzdPNU/WwiGD9F8Y6OK/DC08prXfQb3SCArDnNnHjzc EHQTZNkQ3hgcv6IMkNZO/t5Ul/79io9QLDacY8jvQ0fJQdUvL2C+LGt5d3X5hcA6pLNb7jpU2Ey ZA+UDbZw0bGo= X-Received: by 2002:a05:600c:4e8c:b0:3a6:11e:cc08 with SMTP id f12-20020a05600c4e8c00b003a6011ecc08mr5172797wmq.198.1661344553398; Wed, 24 Aug 2022 05:35:53 -0700 (PDT) X-Google-Smtp-Source: AA6agR44DedJ2+TvsAxiP57X1MmAV94j+vDVcHJ2tTdByck/P3U4Aea5bqXN86cTRa0XCN3QFAkAOA== X-Received: by 2002:a05:600c:4e8c:b0:3a6:11e:cc08 with SMTP id f12-20020a05600c4e8c00b003a6011ecc08mr5172777wmq.198.1661344553097; Wed, 24 Aug 2022 05:35:53 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:c500:5445:cf40:2e32:6e73? (p200300cbc707c5005445cf402e326e73.dip0.t-ipconnect.de. [2003:cb:c707:c500:5445:cf40:2e32:6e73]) by smtp.gmail.com with ESMTPSA id a3-20020a056000100300b002254880c049sm11802172wrx.31.2022.08.24.05.35.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Aug 2022 05:35:52 -0700 (PDT) Message-ID: <6e31290a-5b72-ceb6-b11c-f8c1b066beaf@redhat.com> Date: Wed, 24 Aug 2022 14:35:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 1/3] mm/migrate_device.c: Flush TLB while holding PTL To: Alistair Popple Cc: linux-mm@kvack.org, akpm@linux-foundation.org, Peter Xu , Nadav Amit , huang ying , LKML , "Sierra Guiza, Alejandro (Alex)" , Felix Kuehling , Jason Gunthorpe , John Hubbard , Ralph Campbell , Matthew Wilcox , Karol Herbst , Lyude Paul , Ben Skeggs , Logan Gunthorpe , paulus@ozlabs.org, linuxppc-dev@lists.ozlabs.org, stable@vger.kernel.org References: <3b01af093515ce2960ac39bb16ff77473150d179.1661309831.git-series.apopple@nvidia.com> <86b0622d-06eb-cfab-2ff1-8a0eaf823f8a@redhat.com> <87wnaxg6u4.fsf@nvdebian.thelocal> From: David Hildenbrand Organization: Red Hat In-Reply-To: <87wnaxg6u4.fsf@nvdebian.thelocal> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661344564; a=rsa-sha256; cv=none; b=KQDPxcsLFMRzpDoIjUrAu2ZbsXWzscpSQD1RoxVA9sg9AHMfVtH45bvnfalRZkiVXmRHsA 3cg3a2220/hab+7GdNTaFgQurWkJw+29jDfdMCoSoEOhgXw8bez1to4jpofzOFFbv1VnrE yBdT4UVIZnjoSwvQeCNhzKf5D0HggKs= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DvVYa3Y7; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661344564; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rJuT0qCBRs+JGxRnNUBPV/84rd6u301RNuYVKr9ovFg=; b=uUMSANHOqscy6moB/RTuyK1WbsOaEmsEt0u9d8D3HXiZ2J9JUhrnAdfSAT0fvEJhs53cwB 222q2ekg3jspv/UaGUcCmtbc2NxczB2dKKkaA1saLEFYb3QUmHYPj2yM6uQH6uVmD2Fy1z bpni3fkfvw6y0IflUw1kU4zPX434wYw= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 003AE100022 X-Stat-Signature: qjdizt8j9za6gsxs6wq7siup9q936hde Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DvVYa3Y7; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Rspam-User: X-HE-Tag: 1661344563-725271 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 24.08.22 14:26, Alistair Popple wrote: > > David Hildenbrand writes: > >> On 24.08.22 05:03, Alistair Popple wrote: >>> When clearing a PTE the TLB should be flushed whilst still holding the >>> PTL to avoid a potential race with madvise/munmap/etc. For example >>> consider the following sequence: >>> >>> CPU0 CPU1 >>> ---- ---- >>> >>> migrate_vma_collect_pmd() >>> pte_unmap_unlock() >>> madvise(MADV_DONTNEED) >>> -> zap_pte_range() >>> pte_offset_map_lock() >>> [ PTE not present, TLB not flushed ] >>> pte_unmap_unlock() >>> [ page is still accessible via stale TLB ] >>> flush_tlb_range() >>> >>> In this case the page may still be accessed via the stale TLB entry >>> after madvise returns. Fix this by flushing the TLB while holding the >>> PTL. >>> >>> Signed-off-by: Alistair Popple >>> Reported-by: Nadav Amit >>> Fixes: 8c3328f1f36a ("mm/migrate: migrate_vma() unmap page from vma while collecting pages") >>> Cc: stable@vger.kernel.org >>> >>> --- >>> >>> Changes for v3: >>> >>> - New for v3 >>> --- >>> mm/migrate_device.c | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/mm/migrate_device.c b/mm/migrate_device.c >>> index 27fb37d..6a5ef9f 100644 >>> --- a/mm/migrate_device.c >>> +++ b/mm/migrate_device.c >>> @@ -254,13 +254,14 @@ static int migrate_vma_collect_pmd(pmd_t *pmdp, >>> migrate->dst[migrate->npages] = 0; >>> migrate->src[migrate->npages++] = mpfn; >>> } >>> - arch_leave_lazy_mmu_mode(); >>> - pte_unmap_unlock(ptep - 1, ptl); >>> >>> /* Only flush the TLB if we actually modified any entries */ >>> if (unmapped) >>> flush_tlb_range(walk->vma, start, end); >>> >>> + arch_leave_lazy_mmu_mode(); >>> + pte_unmap_unlock(ptep - 1, ptl); >>> + >>> return 0; >>> } >>> >>> >>> base-commit: ffcf9c5700e49c0aee42dcba9a12ba21338e8136 >> >> I'm not a TLB-flushing expert, but this matches my understanding (and a >> TLB flushing Linux documentation I stumbled over some while ago but >> cannot quickly find). >> >> In the ordinary try_to_migrate_one() path, flushing would happen via >> ptep_clear_flush() (just like we do for the anon_exclusive case here as >> well), correct? > > Correct. > Acked-by: David Hildenbrand -- Thanks, David / dhildenb