From: Chen Wandun <chenwandun@huawei.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: <akpm@linux-foundation.org>, <npiggin@gmail.com>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<edumazet@google.com>, <wangkefeng.wang@huawei.com>,
<guohanjun@huawei.com>, <shakeelb@google.com>, <urezki@gmail.com>
Subject: Re: [PATCH v2 1/2] mm/vmalloc: fix numa spreading for large hash tables
Date: Mon, 18 Oct 2021 21:01:01 +0800 [thread overview]
Message-ID: <6e310e59-c0b6-5ba2-f927-7754c3e9e941@huawei.com> (raw)
In-Reply-To: <YW1rEt0u2CSCYgnJ@casper.infradead.org>
在 2021/10/18 20:39, Matthew Wilcox 写道:
> On Mon, Oct 18, 2021 at 08:37:09PM +0800, Chen Wandun wrote:
>> Eric Dumazet reported a strange numa spreading info in [1], and found
>> commit 121e6f3258fe ("mm/vmalloc: hugepage vmalloc mappings") introduced
>> this issue [2].
>
> I think the root problem here is that we have two meanings for
> NUMA_NO_NODE. I tend to read it as "The memory can be allocated from
> any node", but here it's used to mean "The memory should be spread over
> every node". Should we split those out as -1 and -2?
Yes, the intent of NUMA_NO_NODE some time is confused.
Besides，I think NUMA_NO_NODE should consider mempolicy in
most cases in the kernel unless it point out explicitly memory
can be allocated without considering mempolicy.
> .
>
next prev parent reply other threads:[~2021-10-18 13:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 12:37 [PATCH v2 0/2] " Chen Wandun
2021-10-18 12:37 ` [PATCH v2 1/2] mm/vmalloc: " Chen Wandun
2021-10-18 12:39 ` Matthew Wilcox
2021-10-18 13:01 ` Chen Wandun [this message]
2021-10-19 15:53 ` Shakeel Butt
2021-10-19 15:58 ` Eric Dumazet
2021-10-18 14:03 ` Uladzislau Rezki
2021-10-19 15:56 ` Shakeel Butt
2021-10-18 12:37 ` [PATCH v2 2/2] mm/vmalloc: introduce alloc_pages_bulk_array_mempolicy to accelerate memory allocation Chen Wandun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e310e59-c0b6-5ba2-f927-7754c3e9e941@huawei.com \
--to=chenwandun@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=edumazet@google.com \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@gmail.com \
--cc=shakeelb@google.com \
--cc=urezki@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox