From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2540C3DA7F for ; Thu, 15 Aug 2024 10:26:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85EAC6B00BF; Thu, 15 Aug 2024 06:26:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80EF66B00C0; Thu, 15 Aug 2024 06:26:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 688296B00C1; Thu, 15 Aug 2024 06:26:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 450BA6B00BF for ; Thu, 15 Aug 2024 06:26:46 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BAE871C5055 for ; Thu, 15 Aug 2024 10:26:45 +0000 (UTC) X-FDA: 82454101170.17.522D84C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 5F5FEC0022 for ; Thu, 15 Aug 2024 10:26:43 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="a/bTL0B4"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723717549; a=rsa-sha256; cv=none; b=lXk9fHDdhPYyYOoWwlsdQkCD+3Cet1H4B96g/qVQB2loVzAxsOrmx4U8FMGB3vwT/vgTVo G0zF0mXQfQVj/QLNW+dhG9KlpkVVds1UJgc3k56kC8RhYjBbfC6XsAuF/8tXxsM2YEp5yg hfmxY+SPyJ1ASymHsosg6igU0+/XeE8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="a/bTL0B4"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723717549; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UjgqDmjHQjGy0NlycEWk6Xii++ilUVQ2YfrX1Qn0afQ=; b=kNzwYIu1K4YzwsW2AMSlINaE7kbyewUGtuymqk4s6XYJXJBa2u2B6PXtvvThvK9TWqiPaC s1hgV63NVBD98rmEhXpPKWaSf33JZstqcSO6tyNun9mHhUCWk4tm17MIBeoWe0zSrduUof IlItfM6CerxGRJorVy2NhcmdZroINz8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723717602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UjgqDmjHQjGy0NlycEWk6Xii++ilUVQ2YfrX1Qn0afQ=; b=a/bTL0B4V60050FFePljImtbXPCr+ggslRlvCGDc6oIgnkvn/0z5/QhXZBzIPik+Buq1o0 xG8Kf78vPo0xZg7gPfvW5odyAIa6i1SrWADsXiI0xrzMZyecKeLnZuuXJLlH/JgSSc7HZZ 8fCRHx1b/drjVRLm1Fy8HfSvK0uDad0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-218-1K7CQc7vPYyhLLkRXucLKg-1; Thu, 15 Aug 2024 06:26:41 -0400 X-MC-Unique: 1K7CQc7vPYyhLLkRXucLKg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-428040f49f9so5117785e9.0 for ; Thu, 15 Aug 2024 03:26:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723717600; x=1724322400; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=UjgqDmjHQjGy0NlycEWk6Xii++ilUVQ2YfrX1Qn0afQ=; b=HIaOpNpuTca+Y1D0LZs8IQRMJlXxOIR1hUtCJcZ3ssz+4Kpxfu63bkjkKE+a7+wgqw 0fyU1L3urK0NBaxsRgNqgu9gwyraQnMoLzhVLigGDSJ8luDXweSTN7ekFzg3Kl1drF5w 8tcp76c1FAea1LQxBtqt3ehY2Drqq9NVOiReaWBDCfpbHZop2gEDxPH68ApbQgxQ9ZvZ qdbWpOeOLxdQbFezH9KMBTIHmF9J8duIBZFwoAxIVS6VSv/hJOLxeZk5uOK8ivT3/MX4 89rdZOIUjJjSFmktXMUb5uZrwjhOG13wl/H6gC12ItutbTm0g0LzyJPtdkNfHarInyuX 5Z4A== X-Forwarded-Encrypted: i=1; AJvYcCX08e9mIhVHBkZDuH/x/vQgQQM3GWM/4K7aV9XvceMQnPCkNy647tMkuSugomNFWlhPxKYpZAF7fnot2/pgfZ+tbYg= X-Gm-Message-State: AOJu0Ywyj8rYr1WoHw1u64nkulG3jPvj+UX7ePJ7uZT1cktDtcMZxLT4 IHEcnJH8iLgOt2pdgm4Rzt/F9Ih7jR8jmTkVlUHt1JnO0pANh7jLeGEvSvgTa2wkQDHgqM2Uv5w ABpOyUv03z37E2BEjriRpPzm/zfocubs3j4ah7Aq7bPqbVCck X-Received: by 2002:a05:600c:354b:b0:427:ff3b:7a20 with SMTP id 5b1f17b1804b1-429dd260171mr42399335e9.27.1723717599926; Thu, 15 Aug 2024 03:26:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF9Kwy0jjRo3DEmgpacSzyWFZaRkaLE0CXZhm38D5h5NaOhy9dlCteuFe2EH3rtpT7lQgqVOg== X-Received: by 2002:a05:600c:354b:b0:427:ff3b:7a20 with SMTP id 5b1f17b1804b1-429dd260171mr42399165e9.27.1723717599474; Thu, 15 Aug 2024 03:26:39 -0700 (PDT) Received: from ?IPV6:2003:cb:c717:6d00:aebb:127d:2c1a:7f3a? (p200300cbc7176d00aebb127d2c1a7f3a.dip0.t-ipconnect.de. [2003:cb:c717:6d00:aebb:127d:2c1a:7f3a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429ded292f8sm44073745e9.14.2024.08.15.03.26.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Aug 2024 03:26:39 -0700 (PDT) Message-ID: <6e23c705-3d67-419b-b085-f19f5101124c@redhat.com> Date: Thu, 15 Aug 2024 12:26:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] mm: Override mTHP "enabled" defaults at kernel cmdline To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, baohua@kernel.org, baolin.wang@linux.alibaba.com, corbet@lwn.net, ioworker0@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ryan.roberts@arm.com, v-songbaohua@oppo.com References: <20240814085409.124466-1-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240814085409.124466-1-21cnbao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 5F5FEC0022 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 3c3s3jo771ji1ijab8knryai1gepypjh X-HE-Tag: 1723717603-715016 X-HE-Meta: U2FsdGVkX1+cmrs7wybqSeg32v9lbdsmuYL9qWP+R566JEIAxZ4ScAZR832ooHd94VyW/g6lGKNucU1kjKdAuL4kCghPX3pBUjr11pI6hMt9/sZY2uilwDLAGH0IwAjCfvFbEmzryV1u8vDcMy3WSsdipw0pHzEwiCKW2DhcUODGPTZi7qrm5IJ7YVM/PzVYuDkwq2QQ6k0eDbvAOFwLbuCg/OwoZK1ynWCGqlIWwzasoFNUttgXjBQGSlfzuIF4HT7aevG3JeauUtz2JQC8hc765RmuK0buOUVtkv2PO/R/4vjHUA7ik2cqDmTf9riNzKiJC81RqkTn5WlQYxodrORE3HbhBCV2fQkFVoZ/STXuW3C02VeAgYEjjX2f1TKaFOihjNXkFYAnsw1MzGYyKaAwCNO9Vq8RSD8Bft6gyz8kOW7zx+Q000uiU3Z6vj9lCtwO0CCmNrl7EMJ24uwucy1B3WgKVps8FGR9bkmUULRYRrAxa7MSbqq9idkquLPboZdsvFdk89pABYksHjcWz4jonro4rThl+73pWxt/aNLPhGJ/Q/sdfrLpbjVlWqz1MWB+T/t8EJ4ldEKAnJyWAXZJtXBCtvBYr/kiPYrZ1W2+KJhJf1cKI54eY+/CjdYVQtPGSDbPq09ad5e5M9bAKizzX2s5n0fdC1QBuw2+6rPPUTxRYhu0Gx76HQWNI2i9zZqvLKcYaz0WVnYCYwd5o0hxFK0Cy00nRK/3SEIHIi7KsQhnytcBF766RleMKFxQeDkfNljPiMIjgRdR/QxpW2svM7ub9SLctgimJvxT0U2eBYWI/cuRn99FgRQ02PAUWe2HnCWsahVcaM9hcFEyxA2t0IiFUR4Ojv65OGP4HKulLLmKddyXBEivvgFNaMkelQo1N3OKHJOoOL9yqblnGB4GJijMl/XfEXwsogujeyrhMiTvm3Ex4eepHilmxe/mr1CO7WFUXatjxCBmpla 9IIG8KTh 8gPJtH48V4ERMr2TjTl83ELJ+0/2ttBr+yCwN2BwwmW1Hp0i4FdExf2AyfirwvIix+9Q/lM7BV59qFgt/DH0uakROzprO+amReKrCTrgmZ751I3NZKFJ5BtgSJQ2XWouRxx9L2ekB1LF5o9WVNJ62rF0eLb/Mo8encqKDaFJO3asXi8nZWLWa6K9L6npAC8xltbeRCFS5rvGjPRiYgpxgywnYiG9j/UTXQ6xhfUbSXIoPJOj2htk0sF18iRmSKJfSE17RhrxkzgV6b11K3nx3GuEJEY7Ib6aObNkuy3NjKzMM96G7cwMBEQQcZ3mEdQEmQ6nXH91OYvnZ8sYm9ePLRGwqKw0V2vjWLKBthTmJWvaL8SW9+iaq60IuPscoIPl+VwzLyc0WgUHgTQWv7fv/9xx4MIp7yERHUWYZ/Yq+VhiuZqiWswvWlAGlBQZobMS++enyG6xsEVPm29TN140OibovcJWQSj6Ma0/QNc1a59UkSUs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>> +static inline int get_order_from_str(const char *size_str) >>> +{ >>> +     unsigned long size; >>> +     char *endptr; >>> +     int order; >>> + >>> +     size = memparse(size_str, &endptr); >> >> Do we have to also test if is_power_of_2(), and refuse if not? For >> example, what if someone would pass 3K, would the existing check catch it? > > no, the existing check can't catch it. > > I passed thp_anon=15K-64K:always, then I got 16K enabled: > > / # cat /sys/kernel/mm/transparent_hugepage/hugepages-16kB/enabled > [always] inherit madvise never > Okay, so we should document then that start/end of the range must be valid THP sizes. > I can actually check that by: > > static inline int get_order_from_str(const char *size_str) > { > unsigned long size; > char *endptr; > int order; > > size = memparse(size_str, &endptr); > > if (!is_power_of_2(size >> PAGE_SHIFT)) No need for the shift. if (!is_power_of_2(size)) Is likely even more correct if someone would manage to pass something stupid like 16385 (16K + 1) > goto err; > order = get_order(size); > if ((1 << order) & ~THP_ORDERS_ALL_ANON) > goto err; > > return order; > err: > pr_err("invalid size %s in thp_anon boot parameter\n", size_str); > return -EINVAL; > } > >> >>> +     order = fls(size >> PAGE_SHIFT) - 1; >> >> Is this a fancy way of writing >> >> order = log2(size >> PAGE_SHIFT); >> >> ? :) > > I think ilog2 is implemented by fls ? Yes, so we should have used that instead. But get_order() is even better. > >> >> Anyhow, if get_order() wraps that, all good. > > I guess it doesn't check power of 2? > >> >>> +     if ((1 << order) & ~THP_ORDERS_ALL_ANON) { >>> +             pr_err("invalid size %s(order %d) in thp_anon boot parameter\n", >>> +                     size_str, order); >>> +             return -EINVAL; >>> +     } >>> + >>> +     return order; >>> +} >> >> Apart from that, nothing jumped at me. > > Please take a look at the new get_order_from_str() before I > send v5 :-) Besides the shift for is_power_of_2(), LGTM, thanks! -- Cheers, David / dhildenb