From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37EC3C0219D for ; Thu, 13 Feb 2025 11:49:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2B4A6B0089; Thu, 13 Feb 2025 06:49:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AB2F36B008A; Thu, 13 Feb 2025 06:49:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 953C96B008C; Thu, 13 Feb 2025 06:49:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 747166B0089 for ; Thu, 13 Feb 2025 06:49:25 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 18F07B0DA4 for ; Thu, 13 Feb 2025 11:49:25 +0000 (UTC) X-FDA: 83114751090.08.EE119A3 Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf19.hostedemail.com (Postfix) with ESMTP id DB2221A0011 for ; Thu, 13 Feb 2025 11:49:22 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu; dmarc=pass (policy=quarantine) header.from=csgroup.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739447363; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1eKzHTfVsvv4VqfZuGsvTfL3QS0OJu501gC76LrrrV4=; b=QQVFfEN62KQCksNORW67MgYAyr+8VrMzYZ4F4peC8pPzRgjJQStkYgzj/RhtE7d8ZaB4JG R9OxGAQc++kZVIVUY+1F73/pB2F9sWI5eJX2/BYYNoZnQyVxgGqMgfGn328/JeKsTWHpxv EJk8/mjeljODyAHEv5Y0ozsJq/la/rA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu; dmarc=pass (policy=quarantine) header.from=csgroup.eu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739447363; a=rsa-sha256; cv=none; b=8CkLsILERxDpwVTUT2NYo+Xf5AZ8IdBeeTrSRwAZ5bqjj+r+jeBASjkp284rXKGcMweBQG TzRoC1TUu92cclI/pMCuWI51q93oP7FOgV3/vBAx7K2XYTPAdrTFioDiCxDdBvpIaAgvsj U2kHp+MrpGZs8Z7fVDyFCoxEp/S41VI= Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Yttkn0dgsz9sSd; Thu, 13 Feb 2025 12:49:21 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ULQcwcXgFYio; Thu, 13 Feb 2025 12:49:20 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Yttkm6p6Zz9sSL; Thu, 13 Feb 2025 12:49:20 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id D2E088B770; Thu, 13 Feb 2025 12:49:20 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id TnojPLtBnGgu; Thu, 13 Feb 2025 12:49:20 +0100 (CET) Received: from [192.168.235.99] (unknown [192.168.235.99]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 8115F8B763; Thu, 13 Feb 2025 12:49:19 +0100 (CET) Message-ID: <6e1201a1-60c1-40a3-951f-d603b6341a11@csgroup.eu> Date: Thu, 13 Feb 2025 12:49:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/4] mm: Rename GENERIC_PTDUMP and PTDUMP_CORE To: Steven Price , Anshuman Khandual , linux-mm@kvack.org Cc: Catalin Marinas , Will Deacon , Jonathan Corbet , Marc Zyngier , Michael Ellerman , Nicholas Piggin , Paul Walmsley , Palmer Dabbelt , Heiko Carstens , Vasily Gorbik , Thomas Gleixner , Ingo Molnar , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org References: <20250213040934.3245750-1-anshuman.khandual@arm.com> <20250213040934.3245750-5-anshuman.khandual@arm.com> <8e75c5ff-a97b-4a6f-9c8b-ac2598eafe60@arm.com> Content-Language: fr-FR From: Christophe Leroy In-Reply-To: <8e75c5ff-a97b-4a6f-9c8b-ac2598eafe60@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: DB2221A0011 X-Stat-Signature: earegtq9fdpjupqjpdnmw7xbqa7ib9y7 X-HE-Tag: 1739447362-667472 X-HE-Meta: U2FsdGVkX1+C90fyHoAPrHjkqMsdoBifj8umZM3OQCh/6F0xOyxGui54cp32AZ2sg6KcowoiOuWaRW08fW49WKutlJFWriLiwwAWQMn1z4ZP3gVpMPv3mq2qzaRF0XcKTpkCh9NVJq1JbkM3dAd0QGPMISGaYfa+gW0u12t/a2uqD/KQf6lmd5Arhdii58xMfZ9hXZBgYdC6K2lSHCt3YPOfawXOr0PxXQRQbB1O4FEoEEjVM9FgafaM7dQYrp63exGkf/sq2MPaZHACrUfCqqSAppvc2s/PRA20T4yTjcYGoKlCNbhW9asK9K0X9WiAHqlYSuS7N7K4VbPvbfPzimv1V1CmvsLNT4uoES5WK6V0lXZ2z43VxeB/z0m1oY51SzkdZDP9Dqbue5eAPgP/xNpxNbg5t2goD18d56yrDITWYc7io726mCPwrwAzoYUcsRpENhceL7tu0KNo3maAHtQhMAzrbwGs5TKjvW8ch37Bm2a6wqQAbnMgzGDU1rYjo4GPreU7waTfzJFVXoPkhJElL1adU1wwvDYZazKn6lnB1u7YHqn3lZr5/3VzUMWYyqqghw32CW3C/r2ykmf4QPbux+SzpLLDSgw2BaTyNAo+H9uEhlkKCduSwhFDnzIZb9o6PHtUtCo6vBpR+5Bm5omjKkex9anMSUSj/k8xKKSZASXNWmN5AmlVEz/rTLedMgqhQ82Bi83CV7u/Letf9xIDfzpXX7sXd6Pv3bzo15PntUeIzv0woe4m4wPQPaEzSPugm75DOVoKZZ2pDgzrCfRDox8lEBKaEPFgIeEEUVVyjm+ChY4wdYJiK8yA7iDY8w0PRbdtJVEzwiaRgHzsDQJK7rJg7Yt16aoPKx4brRCpBpb0dIcVV/kn7mpIrDrBIl4Idg7YrNNo1k5SLRZX1+I5G4efjNR/OVa/tUgLSIS4tBR7+xJGjkrk77LmUOiMSlMjnL4OOrY5UNTy6wO RWa6u+9D jhwFqDmrDYwRdmTdVZ6CSaCXqd6zQKcBmdUAwOw6lKDRP28aTcM7tOomug1XyZ4NupYufH7QM7XIfOt27/ks4zwaGAE1fyDMAxXRT+jfXy+2EqqHWyJcKvd2oyn0gdnuBJR000G6sYhIc64bMXengmOA63FWgcMAONcIIdn2wXQLeP/Y/Cna2e5UBsFnSlLeoSVhkpMpgXyqGTTscg/gpXbaqlHiq3BowpVwqX1WA5kK41mk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Le 13/02/2025 à 12:23, Steven Price a écrit : > On 13/02/2025 04:09, Anshuman Khandual wrote: >> Platforms subscribe into generic ptdump implementation via GENERIC_PTDUMP. >> But generic ptdump gets enabled via PTDUMP_CORE. These configs combination >> is confusing as they sound very similar and does not differentiate between >> platform's feature subscription and feature enablement for ptdump. Rename >> the configs as ARCH_HAS_PTDUMP and PTDUMP making it more clear and improve >> readability. > > [...] >> diff --git a/arch/powerpc/configs/mpc885_ads_defconfig b/arch/powerpc/configs/mpc885_ads_defconfig >> index 77306be62e9e..db005618690b 100644 >> --- a/arch/powerpc/configs/mpc885_ads_defconfig >> +++ b/arch/powerpc/configs/mpc885_ads_defconfig >> @@ -78,4 +78,4 @@ CONFIG_DEBUG_VM_PGTABLE=y >> CONFIG_DETECT_HUNG_TASK=y >> CONFIG_BDI_SWITCH=y >> CONFIG_PPC_EARLY_DEBUG=y >> -CONFIG_GENERIC_PTDUMP=y >> +CONFIG_PTDUMP=y > > I'd suggest dropp this from the defconfig too, just like patch 1 dropped > it from debug.config. > Thanks for spotting that. That one is wrong. Was introduced by commit d210ee3fdfe8 ("powerpc/configs: Update config files for removed/renamed symbols") which aimed at fixing commit e084728393a5 ("powerpc/ptdump: Convert powerpc to GENERIC_PTDUMP") but it did it wrong. It is CONFIG_PTDUMP_DEBUGFS that is wanted.