From: Donet Tom <donettom@linux.ibm.com>
To: "David Hildenbrand (Arm)" <david@kernel.org>,
Muchun Song <muchun.song@linux.dev>
Cc: Muchun Song <songmuchun@bytedance.com>,
Andrew Morton <akpm@linux-foundation.org>,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@kernel.org>,
Mike Rapoport <rppt@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
Michal Hocko <mhocko@suse.com>,
Frank van der Linden <fvdl@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/sparse: fix preinited section_mem_map clobbering on failure path
Date: Thu, 2 Apr 2026 17:42:06 +0530 [thread overview]
Message-ID: <6e0878d5-878d-4f8f-a980-8e21564c681b@linux.ibm.com> (raw)
In-Reply-To: <877d3988-57f3-4f87-8836-85aad5454879@kernel.org>
On 4/2/26 1:26 PM, David Hildenbrand (Arm) wrote:
> On 4/2/26 09:37, Donet Tom wrote:
>> On 4/1/26 12:55 PM, David Hildenbrand (Arm) wrote:
>>> On 4/1/26 04:41, Muchun Song wrote:
>>>> Thanks.
>>>>
>>>> It's truly a coincidence — I also have a piece of code locally
>>>> that does something similar. Since allocation failure would also
>>>> affect subsequent startup processes, I simply made it panic when
>>>> allocation fails.
>>> Don't use BUG_ON, use actual panic(). :)
>>
>> Apologies if I’m missing something, but would it make sense to check the
>> section validity in memmap_init() instead of panicking? Is there a
>> reason this is avoided?
> Not sure I understand your question, but trying to handle memmap
> allocations during early boot should be removed. If that ever happens
> something is fundamentally flawed.
Thank you for the clarification—I understand now.
-Donet
>
prev parent reply other threads:[~2026-04-02 12:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 11:37 Muchun Song
2026-03-31 18:34 ` Donet Tom
2026-04-01 2:28 ` Muchun Song
2026-04-02 6:42 ` Donet Tom
2026-03-31 20:10 ` Andrew Morton
2026-03-31 21:06 ` David Hildenbrand (Arm)
2026-04-01 2:37 ` Muchun Song
2026-03-31 20:42 ` David Hildenbrand (Arm)
2026-04-01 2:41 ` Muchun Song
2026-04-01 7:25 ` David Hildenbrand (Arm)
2026-04-01 7:28 ` Muchun Song
2026-04-02 7:37 ` Donet Tom
2026-04-02 7:56 ` David Hildenbrand (Arm)
2026-04-02 12:12 ` Donet Tom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e0878d5-878d-4f8f-a980-8e21564c681b@linux.ibm.com \
--to=donettom@linux.ibm.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=fvdl@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=rppt@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox