From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F71AEE14B9 for ; Wed, 6 Sep 2023 17:17:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F37488E0012; Wed, 6 Sep 2023 13:17:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE6F88D0005; Wed, 6 Sep 2023 13:17:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D61C38E0012; Wed, 6 Sep 2023 13:17:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C41DE8D0005 for ; Wed, 6 Sep 2023 13:17:10 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 96166120E29 for ; Wed, 6 Sep 2023 17:17:10 +0000 (UTC) X-FDA: 81206828220.26.407B053 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 286A7140006 for ; Wed, 6 Sep 2023 17:17:07 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MWn+GNBm; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694020628; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CR3YynKXaKiiQJdEERaEXmnpbVzEvFa9RLxlNGmAE/M=; b=kHTWQ07CiBGxhl0sYVRDWus+G6JNto1rP1yciKAjFJ2EzNzbmWdUZr4M0pF4GeDpQ3jqwa bGRoBf5lqmtwYJuF6MAEhNpFS+zw0DmffM16hRU5m7n+a30ZiRaYebAVS9QCyqVldUZzNv ZwOLyHyzbHb2w5/pGtN9CQfH1iijFtc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MWn+GNBm; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694020628; a=rsa-sha256; cv=none; b=wuvlxs7++KIqqXAzthmVPmdJaVqJaDGj+MKbWTbYE412q/8REmH2hWGyuhdVqlH7uHIcBR YikH/7F1DnkHjLJWcvhd+baHwJunOePhQs0yCl09E8TnFBZ1Vc4dR95P5qCmiehfCw4+AD lVCzjwiyR+w9jD78wz7q7njUDThEfK4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694020627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CR3YynKXaKiiQJdEERaEXmnpbVzEvFa9RLxlNGmAE/M=; b=MWn+GNBmF71fN6BK4qRyTd7YH1rgZEnTx4hUBLEqpw8B1GUn+WAUJ0tNJ5ljTidUZQsBnC epyB0nnowsdAN6tSJ1RX2n1/xoXz+bNqhN3zHt0jLsn/on83AfawTjtNDfHQObmK1UP74n blM3/jGbAAsFwY5J5ebzqiayTpy9dwU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-629-E8oXMv53MxatBCJ7zpFDpQ-1; Wed, 06 Sep 2023 13:17:06 -0400 X-MC-Unique: E8oXMv53MxatBCJ7zpFDpQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4005f0a53c5so931755e9.3 for ; Wed, 06 Sep 2023 10:17:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694020625; x=1694625425; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CR3YynKXaKiiQJdEERaEXmnpbVzEvFa9RLxlNGmAE/M=; b=QIhRtPVgvgRuWJdxdI56ZmUeDkxXX4dsXXU3pOlGwm4Rl0uNdlRmHJ9ahBs/ec8+MY MYQsJn8VYow6H3aI0AAmKYGf9TC+Xh2FxYB145gTNwMa0hVsFH54GK99FM0UCpKCEi7U RUZJhtk1eRvMEjcKEiFacLH1AVMQ5O3As4DDJTPOhEdocg32jlmzUgBUHUJdSgdmAXaW XGzOeha3EVbhHTctaiQ/mdxhRx1LxAQMr8w57xiTc0YNe8CIVt1nUWde3Wens0PjGVP0 Uz0zb66BmLj3FUzM7u0zX6f9UVOK+vw0yPZgzL7gntsksngxo7cBCDYKvdLoOiBKOHl9 T0tA== X-Gm-Message-State: AOJu0YxhcPkqscf4YVPHRVU+GQCyTrGA/dxqJytk8mDJ8sZ5I8g4i5yT wpDtvrrTotuzHMfJFsOBledkYnY9P6nbyxgMuTzM8RNG+0BSOi/1iM1Zctmw5ELrBlEJuRsWi0/ Ilmj4/FKWUSg= X-Received: by 2002:a7b:c4ce:0:b0:401:23fc:1f92 with SMTP id g14-20020a7bc4ce000000b0040123fc1f92mr2809017wmk.25.1694020624812; Wed, 06 Sep 2023 10:17:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGG4o9bck5/tiQkiMkWZdjBFcs77pyDT3CLH5B1kIaOGxIvv2R5B5SW/T3zGzGf0a1B9aicQQ== X-Received: by 2002:a7b:c4ce:0:b0:401:23fc:1f92 with SMTP id g14-20020a7bc4ce000000b0040123fc1f92mr2808989wmk.25.1694020624418; Wed, 06 Sep 2023 10:17:04 -0700 (PDT) Received: from ?IPV6:2003:cb:c70c:6c00:92a4:6f8:ff7e:6853? (p200300cbc70c6c0092a406f8ff7e6853.dip0.t-ipconnect.de. [2003:cb:c70c:6c00:92a4:6f8:ff7e:6853]) by smtp.gmail.com with ESMTPSA id x3-20020a1c7c03000000b003fefaf299b6sm88234wmc.38.2023.09.06.10.17.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Sep 2023 10:17:03 -0700 (PDT) Message-ID: <6dfbc043-c969-f78d-1e56-5434026246ea@redhat.com> Date: Wed, 6 Sep 2023 19:17:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 3/5] mm/memory_hotplug: use nth_page() in place of direct struct page manipulation. To: Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Cc: Andrew Morton , Thomas Bogendoerfer , "Matthew Wilcox (Oracle)" , Mike Kravetz , Muchun Song , "Mike Rapoport (IBM)" , stable@vger.kernel.org, Muchun Song References: <20230906150309.114360-1-zi.yan@sent.com> <20230906150309.114360-4-zi.yan@sent.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230906150309.114360-4-zi.yan@sent.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 674rays4bb3k9c53xq8zp4h7a7cwkr8q X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 286A7140006 X-HE-Tag: 1694020627-996076 X-HE-Meta: U2FsdGVkX1/Yp5SBJquV8Gbv8LFS0M8s/d7Tp7RyLVVVmDnK6yh0YQw/MpP6T17olfVBBQawCZB0D21aaRyFmnhNUKl/XIbiluJHyd/xaFk+DIpAJaxvEuvdoxlB4UmWr/gb0TBmRYbL+TUl8sV1Bojwa6ztzlS6jiH0XSUXoxUkzdktRBalSLnmm5AI2Tlug0vSQTY9PshBB9/vydhOzBCm4xxQQOfrot2LL/BKHLBgMVQTvI+tch3RagNiDkU7D0tgT4m2aRJHvss23inmc0OkyE7Ce0GOYw4pjML3SchROnGsrQj1R0ick4OJOWNO+20kKomkKOo14CswGDbxG4yQk0mVj89BANJEn39lcZTY4msIbrz+0mB0FUXtZAn/i0jYz1fdzR7+hYy9fCxCPpGoUpu0Zbno7fn6tck4QVNeeiZhD9UEpCuHnRzexxw9wgEHfvUnH0+I9ycz6apA0mYWTveQ/FDDUBgzgxBHCs9U2QggJ9gYk6iCuU/YGW5992ZBFFtVl/a1WjeFY1Y+9aBG42n4dnSIECvdykJzHkkycZRVZQ3WoHUg/jU8sWwz1ObByZK5FP98AQrShro0oU4u1H3GHndG65scOHdPErIjKdY5ikz1tFHcOl11FUF2C5GvTqUut8+6de31XhE0hTXZYihv/7v4FvqHm6SRNiqZ0j9FEZtsUtkZRiMPBaS8DaO8ZinzNkiQ/qCMPzqHfcp+drB2ZVl95osaYovqPkNS6JRd+3u1lfVyLfrX+WMkQYwepgcV2XZDyvR8DH/mosWbJaQYc5e+YgFe6C58ohkd0iIWhcQECMlwSmkbp+eREPaxEKRxx1AlmO01UOrwRv8vluPe86TVhLJEgMdPL/N9XGxo4HTscw/WaN5J7wDM23/+ELTfyb4lWGeejXr9gkwLCs4R2JvexNvB0XGRtO/dDYEcOQjeSzoZrTuFc+BsedQxcxvFuF4BvpFIH9Y mnOl3dvh WsRw71vZ87EabMNoHBXWLr3a3kDYjHzi117JK6hWOfnEbj8bz4x/WrcUpezp0WncwWi2nbI+/JwASsbdX8RbR0EeM0nP++NliS0M5JyxiaFaARAgiHZMLUvlmY6yIJgIxjS/6jhbFQNFis6/4KzrLPlRKVmLc9kQrHrbgc7TZbC3tKzfd/pB6gbWp9QwsSah+0DiL4tfUWTEuZA1a1aO0gVuC+Yj4/3T66AVMzOAuuZNgkpMr/4i0Az4wGNx2wRbo5EHXAzNwZqRqI06urK0MqiJY0KQazvi/tkOKdnt70luZB7xCR4RprFBS6lUUTsrHbX++F569SUfyYqou/xvJ92n2QqQnFjEkPqIS+uwI3HtJPQ5c4lVKXx7h2ImpyBTs7FhrPuB8ziMlGGuUPMwtI0uwBelPNTK8wi4DEsik8dP+Vcm0JXlgnvgvi9H2O4Uq4rSwCDsPbPqTTHrgOZD7OPL0X+524wUrZ6YXi+L1Lv/Gd7lrQWOjCapK84zLuCLCE/ECnu2mFwrBPiZ3ZZ6m9DV1Lm3nBjQ4x8gh6oFwFyIk6Na4uczxk5BpXiYJl0hrTdYNwVLcSxz0nqirc2A9jdj/JA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06.09.23 17:03, Zi Yan wrote: > From: Zi Yan Subject talks about "nth_page()" but that's not what this patch does. > > When dealing with hugetlb pages, manipulating struct page pointers > directly can get to wrong struct page, since struct page is not guaranteed > to be contiguous on SPARSEMEM without VMEMMAP. Use nth_page() to handle > it properly. ^ dito > > Fixes: eeb0efd071d8 ("mm,memory_hotplug: fix scan_movable_pages() for gigantic hugepages") > Cc: > Signed-off-by: Zi Yan > Reviewed-by: Muchun Song > --- > mm/memory_hotplug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 1b03f4ec6fd2..3b301c4023ff 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1689,7 +1689,7 @@ static int scan_movable_pages(unsigned long start, unsigned long end, > */ > if (HPageMigratable(head)) > goto found; > - skip = compound_nr(head) - (page - head); > + skip = compound_nr(head) - (pfn - page_to_pfn(head)); > pfn += skip - 1; > } > return -ENOENT; I suspect systems without VMEMMAP also don't usually support gigantic pages AND hotunplug :) With the subject+description fixed Acked-by: David Hildenbrand -- Cheers, David / dhildenb