From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98656C4320A for ; Mon, 9 Aug 2021 09:22:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3749B60C51 for ; Mon, 9 Aug 2021 09:22:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3749B60C51 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 61A598D000D; Mon, 9 Aug 2021 05:22:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CA5D8D0003; Mon, 9 Aug 2021 05:22:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B9038D000D; Mon, 9 Aug 2021 05:22:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0032.hostedemail.com [216.40.44.32]) by kanga.kvack.org (Postfix) with ESMTP id 31E208D0003 for ; Mon, 9 Aug 2021 05:22:25 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id DB6FC8249980 for ; Mon, 9 Aug 2021 09:22:24 +0000 (UTC) X-FDA: 78455001408.33.01223F0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 62517300F426 for ; Mon, 9 Aug 2021 09:22:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628500943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d2MQnKwZsGRoAzDpeTtcqLkuwneJdVDfIOk31bAzcPs=; b=Hge9oQ3WSmRayYAl5Kad/VxTib3o529kGw3tDgaTrvDavDPVUJ01ieo5mK9uPmTWgtYPAz tc7AYMAnJxhwzSlj6DqaGQAoutDFkE0jaXFgSHtgqLZz833qXDmECbJG8kIoB1P1Az8NWA /vq1iTNv8RMnqttnovFaUk9IJj/vB1s= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-472-ozIztDyZNe2qAC__VKLFnw-1; Mon, 09 Aug 2021 05:22:22 -0400 X-MC-Unique: ozIztDyZNe2qAC__VKLFnw-1 Received: by mail-wm1-f71.google.com with SMTP id u14-20020a7bcb0e0000b0290248831d46e4so4414700wmj.6 for ; Mon, 09 Aug 2021 02:22:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=d2MQnKwZsGRoAzDpeTtcqLkuwneJdVDfIOk31bAzcPs=; b=CK3FhR7BcFs++dckYyBrAsOApfLs+KONbOB8V/S/u0ATW74gVF9ZFK3LA1Tbgz4r35 DFPaLuqsp/cmPCPuTPWABjBd+ZQiiNOS/EcuaBX9oEzlCRgY3po94CJ1x+SL1/hYUz5n 9jELCWmO/EiZIUTVYIl5UJrKUlP4BWObpolIYi7J2Wej7JJhFPTFfdXzHMb1KklDxToD XKiaxcU5tHMn2NmP7nSUucrtzTBVPTSJKhfT92ObbdxN/Tn7thLnBqkVmReP8ehrj3Bm PSgDIzrJ/FHmkA0qckX1n0XZKSmBlJqWSjsimDeU41kmD/xuNVCZyhN/lXxYuuxuqAYW aRAw== X-Gm-Message-State: AOAM531UTRpc4zp8jhGPT3T9m+sGinpMaNCwvkQLZDzVfSGMWvueRDAP gy5+GerLf2h+LxTqe2bX08LuBox2d4gM7w5IY03trO7Etnet8nEVdRmpKv2W15PlssmaP8rw+LW cyg8zjA70Llg= X-Received: by 2002:a1c:2255:: with SMTP id i82mr15568883wmi.146.1628500940832; Mon, 09 Aug 2021 02:22:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRiBjgZvz6ATDRHvOY/FjWvVBU9kMu4H51Dz3FkVdvGcOuXfEcRnOCziQgNF6kZGWFBbLPQg== X-Received: by 2002:a1c:2255:: with SMTP id i82mr15568864wmi.146.1628500940697; Mon, 09 Aug 2021 02:22:20 -0700 (PDT) Received: from ?IPv6:2003:d8:2f0a:7f00:fad7:3bc9:69d:31f? (p200300d82f0a7f00fad73bc9069d031f.dip0.t-ipconnect.de. [2003:d8:2f0a:7f00:fad7:3bc9:69d:31f]) by smtp.gmail.com with ESMTPSA id k1sm19352793wrz.61.2021.08.09.02.22.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Aug 2021 02:22:20 -0700 (PDT) Subject: Re: [PATCH 2/5] mm: gup: remove unneed local variable orig_refs To: Miaohe Lin , akpm@linux-foundation.org Cc: imbrenda@linux.ibm.com, kirill.shutemov@linux.intel.com, jack@suse.cz, jhubbard@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210807093620.21347-1-linmiaohe@huawei.com> <20210807093620.21347-3-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat Message-ID: <6deed9a0-a1fc-161d-b6f7-b1116212fbde@redhat.com> Date: Mon, 9 Aug 2021 11:22:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210807093620.21347-3-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hge9oQ3W; spf=none (imf09.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 62517300F426 X-Stat-Signature: gtmocuixf8j6auku3ws8ngorwpkxju64 X-HE-Tag: 1628500944-240910 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.08.21 11:36, Miaohe Lin wrote: > Remove unneed local variable orig_refs since refs is unchanged now. > > Signed-off-by: Miaohe Lin > --- > mm/gup.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 430495cb1b91..d6056dcab02c 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -117,8 +117,6 @@ __maybe_unused struct page *try_grab_compound_head(struct page *page, > if (flags & FOLL_GET) > return try_get_compound_head(page, refs); > else if (flags & FOLL_PIN) { > - int orig_refs = refs; > - > /* > * Can't do FOLL_LONGTERM + FOLL_PIN gup fast path if not in a > * right zone, so fail and let the caller fall back to the slow > @@ -150,7 +148,7 @@ __maybe_unused struct page *try_grab_compound_head(struct page *page, > page_ref_add(page, refs * (GUP_PIN_COUNTING_BIAS - 1)); > > mod_node_page_state(page_pgdat(page), NR_FOLL_PIN_ACQUIRED, > - orig_refs); > + refs); > > return page; > } > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb