From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 860CAC3DA7A for ; Mon, 2 Jan 2023 12:00:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F37B68E0002; Mon, 2 Jan 2023 07:00:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EC0B38E0001; Mon, 2 Jan 2023 07:00:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D88DC8E0002; Mon, 2 Jan 2023 07:00:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C16668E0001 for ; Mon, 2 Jan 2023 07:00:44 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 99F451207AB for ; Mon, 2 Jan 2023 12:00:44 +0000 (UTC) X-FDA: 80309717208.06.4B7678C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 8E5E5180011 for ; Mon, 2 Jan 2023 12:00:41 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O2daqLDN; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672660841; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DcpgJX30wscykTQ9ii4gKeBqfxvD6fUqo095Fyay8SQ=; b=c6Qa5cDG/4F+a7BnJ9CpENT+e/kfgMkf16iTZFox2XWZ9Vy7+5uMDsU9US4l2dPnkgE5RZ 4WKJB6fzidzkDQJURZqrH/FulPVdSlyrWygV/1YH2Rzd3b0FW+5SKdp6OzvV6YI0eiYLqg cx+XF080ho+9lOww2F/Yv4mNqaZkDJE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O2daqLDN; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672660841; a=rsa-sha256; cv=none; b=VqIlbNK87514iq0k9WrXUhj1iyDnkQAVrVULJqKuq1jsc6Jl6/jnfCDU1JOT5j5fKttvIF P7nPXaUMRealslIVwo1UVfnrpzzhJsBEMJ+0/WNc8QKVa4Gfp64x4MnW10QrXGyQ6OJmft KwHhszGdKfTIBkzgu7fnB+6Cw1RTkPw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672660840; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DcpgJX30wscykTQ9ii4gKeBqfxvD6fUqo095Fyay8SQ=; b=O2daqLDN+3gcL0mc70iRERTc63glq7BSjzvetkF0zDlVrOCINl/SomFFg0AMGN+4neL37N 0gwvx/jw8lLcx3g//k89gd1eNPb6UNhY4uJfvmsvbypVhh+jh9YENSUJoV7Ch1ZKh/7Qxq IaM1jRoKAtt4y2F7fUezAR+u+11PxPk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-307-XMupxgdlMQ-SV0XxHKAeAA-1; Mon, 02 Jan 2023 07:00:39 -0500 X-MC-Unique: XMupxgdlMQ-SV0XxHKAeAA-1 Received: by mail-wr1-f71.google.com with SMTP id k11-20020adfb34b000000b0027811695ca6so2059796wrd.16 for ; Mon, 02 Jan 2023 04:00:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DcpgJX30wscykTQ9ii4gKeBqfxvD6fUqo095Fyay8SQ=; b=A4yIh9+Ngk4IP3ztRytAMny8wZKsmBNYJaU/lZNzyNijwnX53JAzRKzkGTP+W98RY7 zLMJBnbu+tItMBw3vyhbaRMcweNGuG38STGCUanpwqkFEJQyBO1C2saMlK+HiCwXBA2F vTvfKRHUbiNtW2R6Ka337Jnjzdb/4z979ddaor2mMTscmXG62AyDchlEfDnH6JxvaSq3 n530mKe4y1i+cSqv5O72kGDliTOKRCFy+vRJ27Q+Sxpr/tXCnfh2vclbYsrJKyINg1wl 5f3QHQJqGbVeEW+REucRo8tXHoyGl2gcjeObWT0Me/I64+0frTxM8Eo0+nzRyd9S0R2T YStg== X-Gm-Message-State: AFqh2krujq8ZIN22T2Vn7G5bdEv6RkiEcAY878tYAm4Abqzcbty+jpKA 4K5NpT9Z7MD25mkzBBBC/0e5SP6wHsBTS/yCrIqG5wJIkQJ740JYz6b2oESGMme9bZFPR/KXgNB x7d1Cl3OaOtg= X-Received: by 2002:a05:600c:358e:b0:3d9:9755:d659 with SMTP id p14-20020a05600c358e00b003d99755d659mr11087418wmq.22.1672660838562; Mon, 02 Jan 2023 04:00:38 -0800 (PST) X-Google-Smtp-Source: AMrXdXsIJE0L73xRyosk2B5P5nocn3N827sBpnbPLGg2GCquluuPM084Hu2VzkaNzcO0cHEpOqxkvg== X-Received: by 2002:a05:600c:358e:b0:3d9:9755:d659 with SMTP id p14-20020a05600c358e00b003d99755d659mr11087392wmq.22.1672660838265; Mon, 02 Jan 2023 04:00:38 -0800 (PST) Received: from ?IPV6:2003:cb:c703:500:9382:2e5a:fea:8889? (p200300cbc703050093822e5a0fea8889.dip0.t-ipconnect.de. [2003:cb:c703:500:9382:2e5a:fea:8889]) by smtp.gmail.com with ESMTPSA id a1-20020a05600c348100b003b47b80cec3sm42766964wmq.42.2023.01.02.04.00.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Jan 2023 04:00:37 -0800 (PST) Message-ID: <6ddb468a-3771-92a1-deb1-b07a954293a3@redhat.com> Date: Mon, 2 Jan 2023 13:00:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 1/1] mm: fix vma->anon_name memory leak for anonymous shmem VMAs To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: hughd@google.com, hannes@cmpxchg.org, vincent.whitchurch@axis.com, seanjc@google.com, rppt@kernel.org, shy828301@gmail.com, pasha.tatashin@soleen.com, paul.gortmaker@windriver.com, peterx@redhat.com, vbabka@suse.cz, Liam.Howlett@Oracle.com, ccross@google.com, willy@infradead.org, arnd@arndb.de, cgel.zte@gmail.com, yuzhao@google.com, bagasdotme@gmail.com, suleiman@google.com, steven@liquorix.net, heftig@archlinux.org, cuigaosheng1@huawei.com, kirill@shutemov.name, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, syzbot+91edf9178386a07d06a7@syzkaller.appspotmail.com References: <20221228194249.170354-1-surenb@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20221228194249.170354-1-surenb@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8E5E5180011 X-Stat-Signature: 6bfgfoj1j7bwoncf83d6chc7k5jwd5wg X-Rspam-User: X-HE-Tag: 1672660841-657481 X-HE-Meta: U2FsdGVkX1/ftC/z343CtDH2YCEL9Wx97Q9kfmUm4pA+2yWRbBc463inTNfXfZE7O/H/RHNRAhfubJRtNcsegCW7mFMgJ5GfhbOMnHOvO2x5kN0KUzavetixUrrYbh+hL3zkzFNHido9VVZJJJzOTrU8J1BDgxa1tjKXXUv/7bILwhMdFNqjRGy6l+lwW7aljeYiQFHcXAOuA/h5Ly2bjRZ8MXT82QrufOFB8lI4Uwutkfp4hPahyjO4F+Ht+XP3oq6/1Crszx3abH9mVB9yVjU2xXg6hRCsKzy7ME6CfKiLaHLboKeiOWzi8ystM2yP1WMt+Vhx4SSAOMwcryPTtKSGBcnDmQEPC9MqYUZSDDQxzX2wAeJa7XKsJ02hiI/XtzLqtCiFsIjbxfMleiUB+nlSHJYFe4orUrWlQ7GJQpOzNFk71GvJNbLJreO6qAd9OTu6h+r6qauBzser6t4XvAu4MnvG+/caBtFOGJe0n0M/41t/GtWQDiO+H7vl0FA9esG6oVMKqbgNYSVNaPvHf9DPgKB/Mqo7rTQTyEaOLJ3TkaBrhZE52uyO5MkX1vYSjA3DrBNcnoRyLTUvm4uc+XraRGubU0vUzNnZT1cBCKqEJAvCnySVmj5UcscgzEO4XzQAEobfaGJ2UTA2NKHpXsO6jc3hsregDxzijAELQPbMKvXCkjV3TW9JUayyjpkX98DkYNHzZvNCpsTJtiHzMuBkHZKltYqL3B4FfSsDtNEAIbuAh7zOqwtHdKV7PXNuZIEohfuzPMZQDx2ot5FEnYbAtphfKpE/hQzIj0aOlcfl89LQucwNaKfs+Kmh3lcG0M1Xo9Sm5KNVdP8bDdVUw1Rmz/IZMDkg0+RgpAOTHQKhgYfkSDmoYFTwMUfny5Bf1w48nARpWJ/pfUOR0Ewh5BojrZ8ELxS1qxbusnQsm6Vvx06/AWcOQHg17xi4FYY0wOxgDRyVMWKY+2iqOwi Z+qibwrU W+y9IlMtXSotqf0NPFTikqVzOUcPveDA5HC4043W3qedBm36Hjr9JngIAscddluFnrEhDg3t6qtjbP40ynimu4toMZ307Z/w81sQ8BmkrrEc58HCUyq3DWX1Rnv/J0IRDiuy+SNlUFKRigi/j+swGWviKKlx3LS2bI6s5DSLVF9GCSBM/B7lCQ3RdarpDMzkNuW06qODFivx71uHQ9ircYCMtLOma603oXznUp7kDsClLkkmyyv5u6g+c86MPzQVr0BmkhlEkXiG5GTlo5mBh1Vjnb+ENrkQpI313 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28.12.22 20:42, Suren Baghdasaryan wrote: > free_anon_vma_name() is missing a check for anonymous shmem VMA which > leads to a memory leak due to refcount not being dropped. Fix this by > adding the missing check. > > Fixes: d09e8ca6cb93 ("mm: anonymous shared memory naming") > Reported-by: syzbot+91edf9178386a07d06a7@syzkaller.appspotmail.com > Signed-off-by: Suren Baghdasaryan > --- > include/linux/mm_inline.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h > index e8ed225d8f7c..d650ca2c5d29 100644 > --- a/include/linux/mm_inline.h > +++ b/include/linux/mm_inline.h > @@ -413,7 +413,7 @@ static inline void free_anon_vma_name(struct vm_area_struct *vma) > * Not using anon_vma_name because it generates a warning if mmap_lock > * is not held, which might be the case here. > */ > - if (!vma->vm_file) > + if (!vma->vm_file || vma_is_anon_shmem(vma)) > anon_vma_name_put(vma->anon_name); Wouldn't it be me more consistent to check for "vma->anon_name"? That's what dup_anon_vma_name() checks. And it's safe now because anon_name is no longer overloaded in vm_area_struct. -- Thanks, David / dhildenb