From: Vlastimil Babka <vbabka@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>,
wangjianxing <wangjianxing@loongson.cn>
Cc: Matthew Wilcox <willy@infradead.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] mm/page_alloc: add scheduling point to free_unref_page_list
Date: Thu, 10 Mar 2022 10:11:43 +0100 [thread overview]
Message-ID: <6dd8965e-3dd5-895b-641c-a04fa2b1115e@suse.cz> (raw)
In-Reply-To: <20220309192947.0b4c8c875c492de09c1ab632@linux-foundation.org>
On 3/10/22 04:29, Andrew Morton wrote:
> On Thu, 10 Mar 2022 10:48:41 +0800 wangjianxing <wangjianxing@loongson.cn> wrote:
>
>> spin_lock will preempt_disable(), interrupt context will
>> __irq_enter/local_bh_disable and also add preempt count with offset.
>>
>> cond_resched check whether if preempt_count == 0 in first and won't
>> schedule in previous context.
>>
>> Is this right?
>>
>>
>> With another way, could we add some condition to avoid call cond_resched
>> in interrupt context or spin_lock()?
>>
>> + if (preemptible())
>> + cond_resched();
>>
>
> None of this works with CONFIG_PREEMPTION=n.
Yeah I think we have at least two options.
1) check all callers, maybe realize all have enabled interrupts anyway,
rewrite the locking to only assume those
2) find out how long the tlb batches actually are and make them smaller
next prev parent reply other threads:[~2022-03-10 9:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 1:38 wangjianxing
2022-03-02 23:34 ` Andrew Morton
2022-03-03 2:02 ` wangjianxing
2022-03-08 16:04 ` Vlastimil Babka
2022-03-08 16:05 ` Vlastimil Babka
2022-03-08 16:19 ` Matthew Wilcox
2022-03-10 1:05 ` Andrew Morton
2022-03-10 2:48 ` wangjianxing
2022-03-10 3:29 ` Andrew Morton
2022-03-10 9:11 ` Vlastimil Babka [this message]
2022-03-11 3:22 ` wangjianxing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dd8965e-3dd5-895b-641c-a04fa2b1115e@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wangjianxing@loongson.cn \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox