From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48193C74A5B for ; Tue, 21 Mar 2023 14:19:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B87B96B007B; Tue, 21 Mar 2023 10:19:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B38516B007D; Tue, 21 Mar 2023 10:19:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FF856B007E; Tue, 21 Mar 2023 10:19:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 91ED66B007B for ; Tue, 21 Mar 2023 10:19:30 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 661CBAC5B3 for ; Tue, 21 Mar 2023 14:19:30 +0000 (UTC) X-FDA: 80593113300.25.EB766E9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 1B6DEA0016 for ; Tue, 21 Mar 2023 14:19:27 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h7aK16F3; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679408368; a=rsa-sha256; cv=none; b=tJwHPO8l+nbzQZjdUAVyUjZmEwoTIlAh9R9j7dR7pWCl9RWPrInfP+hcCB26px9Nr64D1D DLHJ3Go8FHYhw/KS1g8dUA35RKwXnASeig53aUY6I4MoOhvszN7WoV2+7P0RW5F+rqBYU+ FB/AiDAl5do5Jbep8fsk5x342ki2kiY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=h7aK16F3; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679408368; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DfF4q7w/qUi23bHADegaGOCt7dfjqjwQEqjxl6FkQCg=; b=CKZufWYt6GlTBKSBxZaOhv31DgJFfzx20lV4p5aDUDFtVrDE41kty/LJJsfa8T/5hfQ/0y ybci839vYDQ2y/CENGJvOiae0UweBIZ7ar7cPzp8aMk76m/nKKDWFnawPISVk8m9Q316w9 vw4JDPeIuaxRoWJbbt2YOGO/sXAuYok= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679408367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DfF4q7w/qUi23bHADegaGOCt7dfjqjwQEqjxl6FkQCg=; b=h7aK16F3i+cMYTYyHhXYCkIuVZHpmlEpQNg0mymnkP5k7yRK2KW9O7jroJHEItb0vJtWy/ 6G5jK/rBTmpRaARVx0FfbgHbtlDVdtaBbTm+rTi172XW8yvGYBzjzLeffA9LUwe0A63NtF UXWGMS63QNwJHLHMDXmG1n9G6nloTJI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-329-49lqcYD3MYa3-PgY_7_kaA-1; Tue, 21 Mar 2023 10:19:22 -0400 X-MC-Unique: 49lqcYD3MYa3-PgY_7_kaA-1 Received: by mail-wm1-f69.google.com with SMTP id k18-20020a05600c1c9200b003ed2a3f101fso10065769wms.9 for ; Tue, 21 Mar 2023 07:19:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679408360; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DfF4q7w/qUi23bHADegaGOCt7dfjqjwQEqjxl6FkQCg=; b=llV06ZE46mD7XM84mLmX49giXEjRtQoGT7zpM2D2KAcmfmF/lcD3h+pgcO6YyByDuL ULDqG5o3vW6pz/UfxNeS2fq5wcOBwzIpT6Hga5vLtc0qiIZvsDeOOsKABWwkNb9nAJki F/z1qBaF2x9O9FtemA8yv4KsL5xgzFOK0aZOwvnsDQt/iKlEvxtwJNw8XAZI80xZ1lQj ZpcAAJlksRZi2n1lCNTYSuOb0vGM1bLWcf13cqj699/ogzVRu+XgAMtcghnIP0yLsVkR xBbsa6E60ZywdOCDa2ohAm/Xy3xegpC6V86Kx30X//80Xo14UaBl+pF1dOTrIe62/3RL bSaw== X-Gm-Message-State: AO0yUKUaxfgzhBMPtnxr4NMtowF4DLvtz0DV9mwS48R6Oi8QqCXK8vxT XWqWfVrWKLpMoW9+mLiTHW2CPszWkoRJzPr1DPPCGMAHUmH88zAzbt3ZRjxz1jtq/+8PSZ9RKNI HFmkfva4ONU0= X-Received: by 2002:adf:ef8c:0:b0:2cf:ef5d:4ee7 with SMTP id d12-20020adfef8c000000b002cfef5d4ee7mr2284166wro.69.1679408360347; Tue, 21 Mar 2023 07:19:20 -0700 (PDT) X-Google-Smtp-Source: AK7set8r+wjArG2eiSUDSwdivLHTtwScJEk6/GrYHLxiYkOPw4OOFqg1RnVEDt4CmfyN70KsX2Jgsg== X-Received: by 2002:adf:ef8c:0:b0:2cf:ef5d:4ee7 with SMTP id d12-20020adfef8c000000b002cfef5d4ee7mr2284148wro.69.1679408360051; Tue, 21 Mar 2023 07:19:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:7f00:8245:d031:7f8b:e004? (p200300cbc7057f008245d0317f8be004.dip0.t-ipconnect.de. [2003:cb:c705:7f00:8245:d031:7f8b:e004]) by smtp.gmail.com with ESMTPSA id k6-20020a5d6d46000000b002c5598c14acsm11597587wri.6.2023.03.21.07.19.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Mar 2023 07:19:19 -0700 (PDT) Message-ID: <6dd844f7-d43b-c744-f295-9f14c68d3928@redhat.com> Date: Tue, 21 Mar 2023 15:19:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 1/4] mm/mlock: return EINVAL if len overflows for mlock/munlock To: mawupeng , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kuleshovmail@gmail.com, aneesh.kumar@linux.ibm.com References: <20230320024739.224850-1-mawupeng1@huawei.com> <20230320024739.224850-2-mawupeng1@huawei.com> <27b9cb5b-0118-f989-80c2-6a143a4232af@redhat.com> <3ef9520c-6713-527a-0214-ac7a8bb2d49c@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <3ef9520c-6713-527a-0214-ac7a8bb2d49c@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 1B6DEA0016 X-Rspamd-Server: rspam01 X-Stat-Signature: zkhnsnshk8ui4rn48bcgypiub3ozsxdk X-HE-Tag: 1679408367-500715 X-HE-Meta: U2FsdGVkX1/wqIf/pbyIuCZJA+tPCxBmLu9kHvVlUU/L8rTdV6nH+InBRyKfJKYTfo2jgdQUpyvlibcVLqu7aZQjhw4lN01tUuCbK4jiFqY/SdXkJqYkCQuW7g9Taf+SftWMeCPQq1nhJgU9EEP8N5fZ7IlHaq/2te5/aPRAHMTOW2LjY+MXLP77ts/Qp9ZfProSxJ4BPbpz3xhAkdGIAKtWmV0WfR46/Que9M5TtHtcCtqwOeFic7N3WSjcOFg626FJgY9Ikg0xQ0PB/9qG3rDVcQTfK6RRu8wPAXBDvqjqVnnzX1Uo+Fg7Tni6h9xncftVH+L+oDo1pWxLdtaMjhMqzsrF9Ctxf9XoYIorjrm+sJFm/2ovTD/LPVzQ5oPUiV5At3bmLkUaqgeKrd9PhVC6mX0JBxuqp9+9+aRJx31b2JeZ+tpP3H2npj9dyhqMBOSh+pVGEQ+dWy8s2CRjSIg0RtcQDoKVIxka4hKQ2Jf9zLwcO59z/7h5XktC3pBMjvDlgc23En4RaCIDOVoakdJ1MY28ewFSuLKma9jSOPN+Rmsq7Bd+HnYAkmQqrfmKiR2if5C/k44e6P3BETpoq+mXdntETOjl0xFfZKxmJRuKzfLCHVU6tsvG1DkPDUk9leBc35P3b/4MgPRy0cGDv85FkornW5PipFGOAWtRoLdCNEIj5MPHeW2qxnZo9Ozxg+mkh92tflxZWtc/yVWK6z1UWwpxgoDiIQyeaHMILvnKtMFE2g/ggAQm4UTUsp2diryCbPH4XWWOHrI9DECihM9E69Z3FcA8JcarbK2ANVW6+YC5tVkjY78U1tn+EWF+O254XDmTPqzGD/JMheBQ82l1YcB5UH1Fimts5dBaMbswORBEkpZzb03FrUJ4hCvk03Sd8LRr/ta+pb0YC1c8CcZ/3iE5/iCh6lCYijQBDVaJ/JvQvMRyXslknH6QGfEt9hpQumgH7t3WMASB6wH Zsetviar VWEyYvFM0Iyaslnq9IgetvWs/qENajO1lUCWAnTR8N6qYQ5A+Gs7WWigghywaKtKA+Y+SJ9rVTUpFSCVyvQjDrMext/ECumfGGzm3xizEtgLS62hr/G5f/+C5+TpMvmSkczAEQSgcO6J1KwAWtafd1EXqX2gdij9SxTYPxi6ciwEqxszQuKI8vI0eRfSmwkNslYobOcPwqr9SRYE/2PwNM+jZnmY8RqsRLQT/lZRPlYGewYbd45lNufNvmb10/d/GVfZscPnzTc11doV/tx2xaSGylDkTTsUKQZPun1wI6adb4KgfSx5L4w9adW25MsUw2IswNWEf317heQVWAAuUYBjsv2iZhtPriyOgD3rgwZTCsWpI9Cz1Enz/2NKULFZIn9iCfvh2wMJiB3+7bPmUo8CWPtTki6baaRn32GhaE5cEbL4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.03.23 08:44, mawupeng wrote: > > > On 2023/3/20 18:54, David Hildenbrand wrote: >> On 20.03.23 03:47, Wupeng Ma wrote: >>> From: Ma Wupeng >>> >>> While testing mlock, we have a problem if the len of mlock is ULONG_MAX. >>> The return value of mlock is zero. But nothing will be locked since the >>> len in do_mlock overflows to zero due to the following code in mlock: >>> >>>    len = PAGE_ALIGN(len + (offset_in_page(start))); >>> >>> The same problem happens in munlock. >>> >>> Add new check and return -EINVAL to fix this overflowing scenarios since >>> they are absolutely wrong. >> >> Thinking again, wouldn't we reject mlock(0, ULONG_MAX) now as well? > > mlock will return 0 if len is zero which is the same w/o this patchset. > Here is the calltrace if len is zero. > > mlock(len == 0) > do_mlock(len == 0) > if (!len) > return 0 > I was asking about addr=0, len=ULONG_MAX. IIUC, that used to work but could now fail? I haven't played with it, though. -- Thanks, David / dhildenb