From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8745C433DF for ; Tue, 20 Oct 2020 04:13:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 080F6223B0 for ; Tue, 20 Oct 2020 04:13:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="DWqlnzfl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 080F6223B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E603C6B005C; Tue, 20 Oct 2020 00:13:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E11B16B0062; Tue, 20 Oct 2020 00:13:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D00256B0068; Tue, 20 Oct 2020 00:13:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id A38BC6B005C for ; Tue, 20 Oct 2020 00:13:43 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3BEBE3628 for ; Tue, 20 Oct 2020 04:13:43 +0000 (UTC) X-FDA: 77390985126.22.mom96_4b05f4d2723c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 187D618038E60 for ; Tue, 20 Oct 2020 04:13:43 +0000 (UTC) X-HE-Tag: mom96_4b05f4d2723c X-Filterd-Recvd-Size: 4743 Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Tue, 20 Oct 2020 04:13:42 +0000 (UTC) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 19 Oct 2020 21:12:54 -0700 Received: from [10.2.55.194] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 20 Oct 2020 04:13:40 +0000 Subject: Re: [patch 16/40] selftests/vm: use a common gup_test.h From: John Hubbard To: Linus Torvalds CC: Matthew Wilcox , Andrew Morton , Jonathan Corbet , Jerome Glisse , Linux-MM , , Ralph Campbell , "Shuah Khan" , Jason Gary Gunthorpe References: <20201017161314.88890b87fae7446ccc13c902@linux-foundation.org> <20201017231425.0OZYgQdDr%akpm@linux-foundation.org> <20201018190327.GN20115@casper.infradead.org> <9eaf122b-e877-e104-6175-13d48c13ac85@nvidia.com> <59c6b448-039a-e56b-1ec6-9f92e316acb0@nvidia.com> Message-ID: <6dd0e8ea-3b86-8289-473d-3ffef99805ba@nvidia.com> Date: Mon, 19 Oct 2020 21:13:40 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <59c6b448-039a-e56b-1ec6-9f92e316acb0@nvidia.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603167174; bh=lVh/vaGG8dHOokivB6KlF009W9SoMfTC23JW2tNbXLo=; h=Subject:From:To:CC:References:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=DWqlnzflBpRNlRptH7LhjCLKxq2KugxrmjlqkFr2erFIP0NZ8S2OQGP8wwtwtUaxq z+p4GDtSSTYxTH7Mk0XEHyd4yzVAu8qyyVwbnM9Pny+Zm065M3ax7/HOQ3FtBLZtYW r0gDzBS561sOOJ8ArS65TrPQWabGIOIFdwBN5k3G72GmYpeig8Rx5JQfHj7kJ+UUAY V56goXeed0xVn+Fi/dtcoFzmgsO2qOgNCaQEF82wSonI7GWht9Fw7s+Xm/mCX9s3Av TdwdMqSDLFVn6UZfzQjr6rmnTc24dIW0cK3KMMyzDebpZ7IK/aDJBKjY36xKae1qpQ JtG/c8brLuADw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/18/20 12:48 PM, John Hubbard wrote: > On 10/18/20 12:33 PM, Linus Torvalds wrote: >> On Sun, Oct 18, 2020 at 12:13 PM John Hubbard wrot= e: > ... >=20 >> Guys, you're looking at the wrong thing. >> >> Inside the *tools* subdirectory, that "../../.." thing makes sense. >> You're in tools/testing/selftests/vm, and those crazy ".." paths are >> ok. Ugly, but ok. >> >> But the thing I objected to wasn't that tools directory ugliness. >> >> Let me repeat what I found completely and utterly unacceptable, and >> what you don't seem to have noticed, and what your patch didn't fix or >> touch: >> >> +++ a/mm/gup_test.c >> +#include "../../../../mm/gup_test.h" >> >> Notice what directory it is in? Notice how "../../.." etc is >> COMPLETELY UNACCEPTABLE GARBAGE. >> >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Linus >> >=20 > aha, yes. yuck. So can we please just fix it up like this? A quick compil= e > test shows that it does build as expected: >=20 > diff --git a/mm/gup_test.c b/mm/gup_test.c > index 32770656cc32..e4c396146e90 100644 > --- a/mm/gup_test.c > +++ b/mm/gup_test.c > @@ -4,7 +4,7 @@ > =C2=A0#include > =C2=A0#include > =C2=A0#include > -#include "../../../../mm/gup_test.h" > +#include "gup_test.h" >=20 > =C2=A0static void put_back_pages(unsigned int cmd, struct page **pages, > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 unsigned long nr_pages, unsigned int gup_test_flags) >=20 >=20 Also, if there is anything I can do to unblock this, such as sending a form= al patch, or an updated patch or patchset, please let me know. I realize that this is a low-priority area, but it would still be nice to get it merged and behind us. thanks, --=20 John Hubbard NVIDIA