From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96452C7618B for ; Thu, 25 Jul 2019 13:05:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5AC7E21951 for ; Thu, 25 Jul 2019 13:05:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AC7E21951 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EA01E8E0073; Thu, 25 Jul 2019 09:05:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E01BC8E0059; Thu, 25 Jul 2019 09:05:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7B498E0073; Thu, 25 Jul 2019 09:05:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by kanga.kvack.org (Postfix) with ESMTP id 9CB5D8E0059 for ; Thu, 25 Jul 2019 09:05:08 -0400 (EDT) Received: by mail-qk1-f200.google.com with SMTP id x17so42316842qkf.14 for ; Thu, 25 Jul 2019 06:05:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:subject:to:cc :references:from:openpgp:autocrypt:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2/XDWIENTrK82hBmD4TRlYXae2uD9Be9AlV5D8OTldU=; b=CTRPQ8RCbOjTFd2hHQmmOems6cuLcDmtSSlo5JjJimlOT/JJl0ASt3DztpdcEqVeh7 QCeDCbjsYJ2t3Ar6rrVtEKKZrMD/k30aC5CrLW+SNGWi24sKeCBiFFUrW7I/kDvBSycd d/Q1RlpqaqEHNgb4lH3zv0cc6ox40L7JHWZrNYypiRukSTNaoGrzij7+agiloAiYco8l +SB562J6XtYkH5H7ZsA+vHRsRr1gwSKrjhFScBQINwhC713x+VJYkclC5t+6s0WC8QcH 3pVUTpE/x+JblO6gyG4vdZ0KhZobnb6uO/9Svsatm2XFqWGdyFeyl1J4XcSI+Adxrajv LEPQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Gm-Message-State: APjAAAUvB5EU9Mw3iAQEr97h39Gjt+iCKDWKP5I6UVItu7QfrIy/hL1K DQ7Jn9+ckr1a3TM3wxSiJD2qH9SpxxKl/PTpO0nFn3eXETDZxesuNuDDZ2M1wF2iEjBCCRINC+d 5I8Wb4OkcE0Qcg/7MN0ulKRfIIuRQye1DjaEZYrExjSPSxExwwHlXZaoGMoiBGnxKUg== X-Received: by 2002:ae9:ec0d:: with SMTP id h13mr58330235qkg.26.1564059908396; Thu, 25 Jul 2019 06:05:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqy9Uwp5Ak5FORmnwJiLFDercN/+tIZSyOGrC4HUeZNm+Tifita0S4FtNEdJXj8kVFnoi22A X-Received: by 2002:ae9:ec0d:: with SMTP id h13mr58330183qkg.26.1564059907791; Thu, 25 Jul 2019 06:05:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564059907; cv=none; d=google.com; s=arc-20160816; b=fQg9flQcm7vbDDEl3n12smRMflAnIyr/rzD6qzz6ffhRCnrnoR9TMWWQAY7vIklilc NieNDVEl888FmI4tEqzbwm0oYhmsrCoDqV3Fsd1tz7+BrXmHZfhVi+r+0YEaL1z+X69u 8RL18F6ztYBL/xbdFVxBY98IvhCYTRzPslZp3FRqkjHrTgI/M1N4nU96sblfHFotJO8V 9AT+irkMWJiT7fUbGuiFfZeWRAEobTeaaAHoa/9+Sx/Cp1C8RIWeO3h09yyrZGmK8o7t pi8kWKsEZHIDJguArxSYP9yelPZ0Cip5OmNAjRZRqUjN4bwP5NwrwOXulTnel6oFsxxv COWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:organization:autocrypt:openpgp:from :references:cc:to:subject; bh=2/XDWIENTrK82hBmD4TRlYXae2uD9Be9AlV5D8OTldU=; b=S5kfr/i0n8E530teyXofQJnh8MQulRbBpXVwu7C+38QEszJwmPP2fywJCgODwpJPkc jQ6CaOt2gaslXtUR61ACU1z1tHupsIoVmazLghnYs+CX8sjdRyiL/1WZw7pxHQEDJnVs DLy0ua+36he6qW6ogVCSDUmc1e4Xe0Zo+Q9xoK+ZFw8OrYpMrlbTYLDig5hagvlINi2p 1AqZVj7rUk4P5MYAdpluZPmeS/CleBnXdjosHXCeZ/deQG3RP1MRg76ERpEb7lCNkfaT my2f296b8odkyMnItqPsML/7fKbUHa8PdxaEK94Qm5TW30D+HOQBI8fgqtHnSF0S7Rig Tvvw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id w64si29790244qkb.254.2019.07.25.06.05.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jul 2019 06:05:07 -0700 (PDT) Received-SPF: pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of david@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 540C5319D1C3; Thu, 25 Jul 2019 13:05:05 +0000 (UTC) Received: from [10.36.117.70] (ovpn-117-70.ams2.redhat.com [10.36.117.70]) by smtp.corp.redhat.com (Postfix) with ESMTP id B0E6B1001281; Thu, 25 Jul 2019 13:05:03 +0000 (UTC) Subject: Re: [PATCH v1] ACPI / scan: Acquire device_hotplug_lock in acpi_scan_init() To: Michal Hocko Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-acpi@vger.kernel.org, "Rafael J. Wysocki" , Andrew Morton , Oscar Salvador References: <20190724143017.12841-1-david@redhat.com> <20190725125636.GA3582@dhcp22.suse.cz> From: David Hildenbrand Openpgp: preference=signencrypt Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwX4EEwECACgFAljj9eoCGwMFCQlmAYAGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEE3eEPcA/4Na5IIP/3T/FIQMxIfNzZshIq687qgG 8UbspuE/YSUDdv7r5szYTK6KPTlqN8NAcSfheywbuYD9A4ZeSBWD3/NAVUdrCaRP2IvFyELj xoMvfJccbq45BxzgEspg/bVahNbyuBpLBVjVWwRtFCUEXkyazksSv8pdTMAs9IucChvFmmq3 jJ2vlaz9lYt/lxN246fIVceckPMiUveimngvXZw21VOAhfQ+/sofXF8JCFv2mFcBDoa7eYob s0FLpmqFaeNRHAlzMWgSsP80qx5nWWEvRLdKWi533N2vC/EyunN3HcBwVrXH4hxRBMco3jvM m8VKLKao9wKj82qSivUnkPIwsAGNPdFoPbgghCQiBjBe6A75Z2xHFrzo7t1jg7nQfIyNC7ez MZBJ59sqA9EDMEJPlLNIeJmqslXPjmMFnE7Mby/+335WJYDulsRybN+W5rLT5aMvhC6x6POK z55fMNKrMASCzBJum2Fwjf/VnuGRYkhKCqqZ8gJ3OvmR50tInDV2jZ1DQgc3i550T5JDpToh dPBxZocIhzg+MBSRDXcJmHOx/7nQm3iQ6iLuwmXsRC6f5FbFefk9EjuTKcLMvBsEx+2DEx0E UnmJ4hVg7u1PQ+2Oy+Lh/opK/BDiqlQ8Pz2jiXv5xkECvr/3Sv59hlOCZMOaiLTTjtOIU7Tq 7ut6OL64oAq+zsFNBFXLn5EBEADn1959INH2cwYJv0tsxf5MUCghCj/CA/lc/LMthqQ773ga uB9mN+F1rE9cyyXb6jyOGn+GUjMbnq1o121Vm0+neKHUCBtHyseBfDXHA6m4B3mUTWo13nid 0e4AM71r0DS8+KYh6zvweLX/LL5kQS9GQeT+QNroXcC1NzWbitts6TZ+IrPOwT1hfB4WNC+X 2n4AzDqp3+ILiVST2DT4VBc11Gz6jijpC/KI5Al8ZDhRwG47LUiuQmt3yqrmN63V9wzaPhC+ xbwIsNZlLUvuRnmBPkTJwwrFRZvwu5GPHNndBjVpAfaSTOfppyKBTccu2AXJXWAE1Xjh6GOC 8mlFjZwLxWFqdPHR1n2aPVgoiTLk34LR/bXO+e0GpzFXT7enwyvFFFyAS0Nk1q/7EChPcbRb hJqEBpRNZemxmg55zC3GLvgLKd5A09MOM2BrMea+l0FUR+PuTenh2YmnmLRTro6eZ/qYwWkC u8FFIw4pT0OUDMyLgi+GI1aMpVogTZJ70FgV0pUAlpmrzk/bLbRkF3TwgucpyPtcpmQtTkWS gDS50QG9DR/1As3LLLcNkwJBZzBG6PWbvcOyrwMQUF1nl4SSPV0LLH63+BrrHasfJzxKXzqg rW28CTAE2x8qi7e/6M/+XXhrsMYG+uaViM7n2je3qKe7ofum3s4vq7oFCPsOgwARAQABwsFl BBgBAgAPBQJVy5+RAhsMBQkJZgGAAAoJEE3eEPcA/4NagOsP/jPoIBb/iXVbM+fmSHOjEshl KMwEl/m5iLj3iHnHPVLBUWrXPdS7iQijJA/VLxjnFknhaS60hkUNWexDMxVVP/6lbOrs4bDZ NEWDMktAeqJaFtxackPszlcpRVkAs6Msn9tu8hlvB517pyUgvuD7ZS9gGOMmYwFQDyytpepo YApVV00P0u3AaE0Cj/o71STqGJKZxcVhPaZ+LR+UCBZOyKfEyq+ZN311VpOJZ1IvTExf+S/5 lqnciDtbO3I4Wq0ArLX1gs1q1XlXLaVaA3yVqeC8E7kOchDNinD3hJS4OX0e1gdsx/e6COvy qNg5aL5n0Kl4fcVqM0LdIhsubVs4eiNCa5XMSYpXmVi3HAuFyg9dN+x8thSwI836FoMASwOl C7tHsTjnSGufB+D7F7ZBT61BffNBBIm1KdMxcxqLUVXpBQHHlGkbwI+3Ye+nE6HmZH7IwLwV W+Ajl7oYF+jeKaH4DZFtgLYGLtZ1LDwKPjX7VAsa4Yx7S5+EBAaZGxK510MjIx6SGrZWBrrV TEvdV00F2MnQoeXKzD7O4WFbL55hhyGgfWTHwZ457iN9SgYi1JLPqWkZB0JRXIEtjd4JEQcx +8Umfre0Xt4713VxMygW0PnQt5aSQdMD58jHFxTk092mU+yIHj5LeYgvwSgZN4airXk5yRXl SE+xAvmumFBY Organization: Red Hat GmbH Message-ID: <6dc566c2-faf6-565d-4ef1-2ac3a366bc76@redhat.com> Date: Thu, 25 Jul 2019 15:05:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190725125636.GA3582@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Thu, 25 Jul 2019 13:05:05 +0000 (UTC) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25.07.19 14:56, Michal Hocko wrote: > On Wed 24-07-19 16:30:17, David Hildenbrand wrote: >> We end up calling __add_memory() without the device hotplug lock held. >> (I used a local patch to assert in __add_memory() that the >> device_hotplug_lock is held - I might upstream that as well soon) >> >> [ 26.771684] create_memory_block_devices+0xa4/0x140 >> [ 26.772952] add_memory_resource+0xde/0x200 >> [ 26.773987] __add_memory+0x6e/0xa0 >> [ 26.775161] acpi_memory_device_add+0x149/0x2b0 >> [ 26.776263] acpi_bus_attach+0xf1/0x1f0 >> [ 26.777247] acpi_bus_attach+0x66/0x1f0 >> [ 26.778268] acpi_bus_attach+0x66/0x1f0 >> [ 26.779073] acpi_bus_attach+0x66/0x1f0 >> [ 26.780143] acpi_bus_scan+0x3e/0x90 >> [ 26.780844] acpi_scan_init+0x109/0x257 >> [ 26.781638] acpi_init+0x2ab/0x30d >> [ 26.782248] do_one_initcall+0x58/0x2cf >> [ 26.783181] kernel_init_freeable+0x1bd/0x247 >> [ 26.784345] kernel_init+0x5/0xf1 >> [ 26.785314] ret_from_fork+0x3a/0x50 >> >> So perform the locking just like in acpi_device_hotplug(). > > While playing with the device_hotplug_lock, can we actually document > what it is protecting please? I have a bad feeling that we are adding > this lock just because some other code path does rather than with a good > idea why it is needed. This patch just confirms that. What exactly does > the lock protect from here in an early boot stage. We have plenty of documentation already mm/memory_hotplug.c git grep -C5 device_hotplug mm/memory_hotplug.c Also see Documentation/core-api/memory-hotplug.rst Regarding the early stage: primarily lockdep as I mentioned. -- Thanks, David / dhildenb