From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51556E784AC for ; Mon, 2 Oct 2023 12:38:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7B556B0145; Mon, 2 Oct 2023 08:38:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2B6B6B0146; Mon, 2 Oct 2023 08:38:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A19D96B0147; Mon, 2 Oct 2023 08:38:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 92A6A6B0145 for ; Mon, 2 Oct 2023 08:38:36 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 54DC24022C for ; Mon, 2 Oct 2023 12:38:36 +0000 (UTC) X-FDA: 81300475032.21.7A4C5C4 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf21.hostedemail.com (Postfix) with ESMTP id 231431C0023 for ; Mon, 2 Oct 2023 12:38:33 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Z7smfT6g; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=iiVZps1K; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696250314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D3WQVSuM8f1XKbYHPZOprGX2nORQUomt4Hm5zfLQyVg=; b=SgqCGL2JU62nuYX2ZF+3CGy5z1gkDUfocyEmOYHh+5GLJz6QmzQFUJEfP11THnutR7Qt1W oBibangiyXBF7vUuYJ6kPRCm7oYkBQdxVYb/Aztd5JH+f51B2gBS5u/3JSjI+I4Z9A8NSd LCRtujSptWEqQGr/0/zxGXeJkXYS9Rg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696250314; a=rsa-sha256; cv=none; b=e6XZOY4d7CkdWFP3lip3Ercq8kdcl2hKeE50JxiCiaj6nv2l4OsNKtkZOvO14V+0ZtXatB 7om5ovza7QMT3e9PEuwALgDlyeXuoy5SPupa56JJkr5zQGmg40mc96a34VLR8snrDTQLd8 rw7SyB9DaqEK5bppDgVx/BmgW2PfHAI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Z7smfT6g; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=iiVZps1K; spf=pass (imf21.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 71A89211C3; Mon, 2 Oct 2023 12:38:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1696250312; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D3WQVSuM8f1XKbYHPZOprGX2nORQUomt4Hm5zfLQyVg=; b=Z7smfT6g59C4upjye0xt6u0/aK1cLq9ILbqv5RwmfJnLc2dAvUoFFrgZzeK7ynfLDzH7RX 0ErjM0PVt0nknn1mUeXOdWO+ee0SXt9MnZfRyRDvqnfBLYd7q/NI852F9w4tTHCG9mYGr4 naepL3oSC9E9AZr7MQ+jNzJyEHaZSvc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1696250312; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D3WQVSuM8f1XKbYHPZOprGX2nORQUomt4Hm5zfLQyVg=; b=iiVZps1Ki1Eb1u/undkL7t8OFyhHIfHeRIFXaSuEWWbJN7ylxqW2VrrgMU6fJySMg5Iovz RIYjDuwniXAWqaBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4703F13434; Mon, 2 Oct 2023 12:38:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 70lyEMi5GmWgKwAAMHmgww (envelope-from ); Mon, 02 Oct 2023 12:38:32 +0000 Message-ID: <6db4338b-279e-acc6-9e95-17e0f2716f0c@suse.cz> Date: Mon, 2 Oct 2023 14:38:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 0/4] SLUB: calculate_order() cleanups To: jaypatel@linux.ibm.com, David Rientjes , Christoph Lameter , Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Roman Gushchin , Pekka Enberg , Joonsoo Kim , linux-mm@kvack.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org References: <20230908145302.30320-6-vbabka@suse.cz> <5c933e2b06ab9090d9190bac41ebbc175b0a9357.camel@linux.ibm.com> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <5c933e2b06ab9090d9190bac41ebbc175b0a9357.camel@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 231431C0023 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: rridzte8fwznr8m4xsz7dmja4i4jimnb X-HE-Tag: 1696250313-72884 X-HE-Meta: U2FsdGVkX18TwI/TrC/ulvAhdhgXrMDmq699mkUTOBBSEX618Q+9fpKXuUanp9ry872CZHNBlIKUKiItRaSrNcPdOUIyOcfVbtXCURi6R0L5ygNEz+glB+fIGGFskc8XaDwkEaKwW/em9Kb7G77zo5TTQ08P7cbmjOoAsN/hkGxU9+4ggywJk7EsRY5QTsKQuOn1NxIt6y/ZgDGfZUNBlPAwIlGH8Dc5O/TPsKzswnaH/zWb7WQ8AsyOk7LO0QPqbcAlsowNQzFJTvrPy1uUZVxKVp30sUOV9waa7VbU5nhZBCbN50/e8aGVGJc9vDDgdUwzZWFNDTQWt1fRxJ5UPuO+mraupyyUnLkXq9E1ejnD98Z1EhKye2n4tB67dnmBLSqMvCC1qwHEHpU9nVDuphAnnnW3Sf2mA+cdLH5dB3sRB214khE/YCyh5YR91dpM+REW/1EILLWivR/QGykYG/2BmhAOpau71ZtZ1RMYTIzXClc3pwCkUYqTmYU3tggNM/GNvVRQ9ZPDXoXR7sfi/SiNBbhsE5luxpQNLBy7xyzX+B1GeNTbWf1x9OuDm2JXuBPuzKFztNLp0WH15XnxHYCnN+SzNEJcqQLdXIZKzvBRBbTZlXCscSF/2GfvkUz+YoIyJsajIaZ8oD4a8e9/LJszF8+QpHVY4TOePBCwmKkTAyXrkvFcPByQ1zoFXnh8OrqgKlAWG015BPd+zTgvPgd+iN5AO+ir3AHt09TwSNHlff+7/Rn1a/zmdTOIYRxnKmzk7k6DcCgDNJycJFaSAH25Hi1HMGF8kOPBmaVg3LIbFAJ25IUn2DP+RKqsXJgxiNmHd+Yn5wkDnDgcVvdlg7XnhOhOe9nzH+Yl6OqKsPfuUG6JE2/U6opWzep27Lr2C8mumPbaQjG2iFhYQQ3+cA63vs22RtoDRiY5+tG2u4ySfy1OkwK7OizFHeflQvwzVwvm4h4or/mXk3qF6/6 HQLsUq04 zRNMBPyLKlT9vhRgpBCeI2i+UTkwdx3Y6vWAKqlqKKNGnq8Eht3kKPEfPhBAKOEV96KIFsMeCJ/qKPtoZB9y83cBcHW98eVR3htvpGMMIp0MsUHk1VD/uSPiaR9bsa2zTfsX62qyBILDBnurRrQHKbIknsfqwaCerYfDycx6Pz3Ls7ZlG/LMwnsrN81RfAx6bilhNgkXQ5m4goiaEPUQNON6BvwatMdVc/aFjpvWMubmHMzNdr66pUTpA9ezX2QB+FOCDmZABaUxZsE6F1y9ifYjuO3uhlG/ie0ixCNQa+tS30Wo5q6SC/48UI6mgu12RCfaqRCadAX2B2LtYbIr2lOT7ew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/28/23 06:46, Jay Patel wrote: > On Fri, 2023-09-08 at 16:53 +0200, Vlastimil Babka wrote: >> Since reviewing recent patches made me finally dig into these >> functions >> in details for the first time, I've also noticed some opportunities >> for >> cleanups that should make them simpler and also deliver more >> consistent >> results for some corner case object sizes (probably not seen in >> practice). Thus patch 3 can increase slab orders somewhere, but only >> in >> the way that was already intended. Otherwise it's almost no >> functional >> changes. >> > Hi Vlastimil, Hi, Jay! > This cleanup patchset looks promising. > I've conducted test > on PowerPC with 16 CPUs and a 64K page size, and here are the results. > > S > lub Memory Usage > > +-------------------+--------+------------+ > | | Normal | With Patch | > +-------------------+--------+------------+ > | Total Slub Memory | 476992 | 478464 | > | Wastage | 431 | 451 | > +-------------------+--------+------------+ > > Also, I have not detected any changes in the page order for slub caches > across all objects with 64K page size. As expected. Which should mean any benchmark differences should be noise and not caused by the patches. > Hackbench Results > > +-------+----+---------+------------+----------+ > | > | | Normal | With Patch | | > +-------+----+---------+----- > -------+----------+ > | Amean | 1 | 1.1530 | 1.1347 | ( 1.59%) | > | > Amean | 4 | 3.9220 | 3.8240 | ( 2.50%) | > | Amean | 7 | 6.7943 | > 6.6300 | ( 2.42%) | > | Amean | 12 | 11.7067 | 11.4423 | ( 2.26%) | > | Amean | 21 | 20.6617 | 20.1680 | ( 2.39%) | > | Amean | 30 | 29.4200 > | 28.6460 | ( 2.63%) | > | Amean | 48 | 47.2797 | 46.2820 | ( 2.11%) > | > | Amean | 64 | 63.4680 | 62.1813 | ( 2.03%) | > +-------+----+------ > ---+------------+----------+ > > > Reviewed-by: Jay Patel > > Tested-by: Jay Patel Thanks! Applied your Reviewed-and-tested-by: > Th > ank You > Jay Patel >> Vlastimil Babka (4): >> mm/slub: simplify the last resort slab order calculation >> mm/slub: remove min_objects loop from calculate_order() >> mm/slub: attempt to find layouts up to 1/2 waste in >> calculate_order() >> mm/slub: refactor calculate_order() and calc_slab_order() >> >> mm/slub.c | 63 ++++++++++++++++++++++++----------------------------- >> -- >> 1 file changed, 27 insertions(+), 36 deletions(-) >> >