From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06007C48BC4 for ; Tue, 20 Feb 2024 06:28:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AA0C6B0081; Tue, 20 Feb 2024 01:28:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8597A6B0082; Tue, 20 Feb 2024 01:28:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 749216B0083; Tue, 20 Feb 2024 01:28:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6689E6B0081 for ; Tue, 20 Feb 2024 01:28:21 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 180DEA05B0 for ; Tue, 20 Feb 2024 06:28:21 +0000 (UTC) X-FDA: 81811202802.10.61F6449 Received: from out30-124.freemail.mail.aliyun.com (out30-124.freemail.mail.aliyun.com [115.124.30.124]) by imf26.hostedemail.com (Postfix) with ESMTP id A40C8140012 for ; Tue, 20 Feb 2024 06:28:17 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=aPz21Wt2; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf26.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708410499; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=puMJdMhcnkjp6kkrLK0SxE7fWXoN3haERSGZVmMXdyk=; b=wX7T5051zmyhKXvknVRhIFXh26P/+dFrVYsf6Q8jtFy8MF/+Fp1tdWnQAJvvyzyi+pmz3I /oOlyzdTG7BMnJR2jR+bM1wO6OnOwAeRxzAWTW34CiwzEv2n9lfnmKXnlaz1kM0IhZO06I MxhaoFmG9Srf3KoJeJh7yGawF+sIaTM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=aPz21Wt2; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf26.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708410499; a=rsa-sha256; cv=none; b=4ByRiAx8GA7I62CBbv1QDS0ztzi3GUyOcjcMhRM9eD56DJB2+NQMdAxOtHxkCN1bNeuon+ ffKEbDNLw0gIzZTkrtf6tQBzI/8oaqw4ZBK1vJONGhUITm1Q8GqyiYckXyItutt5vqdyF0 uim5sHRMhj8QWFUi4MFNw2cSm3mI/8E= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1708410494; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=puMJdMhcnkjp6kkrLK0SxE7fWXoN3haERSGZVmMXdyk=; b=aPz21Wt28Y+2VU2UQZlxQqv/jtxe0cGkAPvccFjbxXmaUz3nwQffzvw8Bk6d1Jcz6Su6pvHNzKCJROvooA1+hxgEvDeUCh4dv9wjLGoxuW2vJ6fjqX7eiROtXzDeE7A81LnLmYz/O5TnQtcczDbpekMx6vTEwKa1yXxbIYvyokI= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R771e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0W0veSm2_1708410491; Received: from 30.97.56.48(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W0veSm2_1708410491) by smtp.aliyun-inc.com; Tue, 20 Feb 2024 14:28:12 +0800 Message-ID: <6da5c282-a522-4732-ad3c-73f6790c073e@linux.alibaba.com> Date: Tue, 20 Feb 2024 14:28:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 0/4] Enable >0 order folio memory compaction To: Andrew Morton Cc: Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Huang, Ying" , Ryan Roberts , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" References: <20240216170432.1268753-1-zi.yan@sent.com> <20240219180617.89a0daaba45ce124ef01be50@linux-foundation.org> <9E3E6CD6-45DD-4E7F-B6DC-0897F38D5E81@nvidia.com> <4f0b3586-25e2-4d21-bbb6-41f644d3d77f@linux.alibaba.com> <20240219193048.cbd010579aa3d2c790f6e2b9@linux-foundation.org> From: Baolin Wang In-Reply-To: <20240219193048.cbd010579aa3d2c790f6e2b9@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A40C8140012 X-Stat-Signature: 1q8qorh1gq5m75wcc4chx9iau7um7rh3 X-Rspam-User: X-HE-Tag: 1708410497-101007 X-HE-Meta: U2FsdGVkX19DCCpQMSCQzzu+7UJDpW3P5plZBpEyW4zqPZMuPn19MFwHodPVESHQzxOOu2qNmZPqab8DYOLtuQGjTncrexuzy/c8leWsxxK2zxJpVt9CQcXQhNsjrlCkj3sVovH6jfghGhvlo6hThY35ip14aXiuRJQ/REZWSZvcpQQgkVjJ3h6SsQgvJeEXinmiCBLux3rERaFcH42q9axpgGRTKRAzZgK+GETxFQkYWgHOTeqR1iICUACXgdyCnSctTUgB1Xf2EvOD+sANOC2eB76kF5BXeymWIqCK3HfUEnYJimMCC+Hhjk8i4AktFTntassf/IxvFeJXaixXKsmliZGN+t/pS+QwMEzgzFBsRs1sJfa4WnVfSW+OT+J+yv8fkYiTvL5MjulMhAQuKZEjdTLvxa13eLMBZEDyZ7axR6SOY7lMmH80PqpEmn8GbNf52suAc/E6BYH74MXlq+0YMQTkmJd1Lg3xe0O07ROC4SldSl67QXZU0BeQIigXCTM7jnUJQBjNfKuvoLE1cVrKqP8oBx7UU2EA/HwRvbODqN2CpMvVXy99khaGRAwKkI/gCeePCP3VTmaDtoFYBVIOV+xX2s3E2XlThGnjugTsoTpK0KkhgYVKaVMYznCB59p9eRG3UuaYcA/QOwrPA7uyMDXDJZMtA50uiJjAzD8E6ynEZ30I6go2PiIH2SJiB3FRNnFfBnSRxdnaMuipp0pPo8f4uRnHASFUh+79IrMpB/3rZQSlfC0s+BNbG6KVzKURlDhOu/87hPFYg7G5DWqG3Qk0JlGUT9oA/ZiJdMWoVvru5LbSA5/qREAvXNO8glXOsA6hw66aDSBtG5fYzd8BlmX4q1LCyizNcjxfyKtzI4hUVOTPvHSR5WPNBOgAQFNMy2/y+qHtNIYTk4Pn1VXETQ44rZiih4af+BiRF5Z4Lkva55OKmDm7eBl250udx3fpaw8wBUQZ51OSz3c yQoEVwf3 rPVZeMRDJ133hJQg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/2/20 11:30, Andrew Morton wrote: > On Tue, 20 Feb 2024 11:00:39 +0800 Baolin Wang wrote: > >>> The patch was based on top of my early version of this patchset, thus >>> uses "cc->nr_migratepages -= 1 << order;" and >>> "cc->nr_migratepages += 1 << order;", but now it is applied before >>> mine. The change should be "cc->nr_migratepages--;" and >>> "cc->nr_migratepages++;", respectively. >>> >>>> >>>>> on nr_migratepages was based on this one, a better fixup >>>>> for it might be below. Since before my patchset, compaction only deals with >>>>> order-0 pages. >>>> >>>> I don't understand what this means. The patchset you sent applies OK >>>> to mm-unstable so what else is there to do? >>> >>> Your above fixup to Baolin's patch needs to be changed to the patch below >>> and my "mm/compaction: add support for >0 order folio memory compaction" will >>> need to be adjusted accordingly to be applied on top. >>> >>> Let me know if anything is unclear. >> >> Hi Andrew, >> >> To avoid conflicts, you can drop these two patches, and I will send a >> new version with fixing the issue pointed by Vlastimilb on top of >> "mm/compaction: add support for >0 order folio memory compaction". >> >> https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-everything-2024-02-16-01-35&id=97f749c7c82f677f89bbf4f10de7816ce9b071fe >> >> https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-everything-2024-02-16-01-35&id=ea87b0558293a5ad597bea606fe261f7b2650cda > > Well I thought I'd fixed everything up 10 minutes ago. Please take a > look at next mm-unstable. Sure. And I found a minor rebase error in the compaction_alloc() function while Zi Yan's original patch is correct. + cc->nr_freepages -= 1 << order; cc->nr_migratepages--; - - return dst; + return page_rmappable_folio(&dst->page); } should change to be: cc->nr_migratepages -= 1 << order;