linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Hamish Martin <Hamish.Martin@alliedtelesis.co.nz>
To: "mika.westerberg@linux.intel.com"
	<mika.westerberg@linux.intel.com>,
	"wsa-dev@sang-engineering.com" <wsa-dev@sang-engineering.com>,
	"andi.shyti@kernel.org" <andi.shyti@kernel.org>
Cc: "naresh.kamboju@linaro.org" <naresh.kamboju@linaro.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"llvm@lists.linux.dev" <llvm@lists.linux.dev>,
	"oe-kbuild-all@lists.linux.dev" <oe-kbuild-all@lists.linux.dev>,
	"lkp@intel.com" <lkp@intel.com>, "arnd@arndb.de" <arnd@arndb.de>
Subject: Re: [linux-next:master 11602/11963] ERROR: modpost: "acpi_device_notify_remove" [drivers/i2c/i2c-core.ko] undefined!
Date: Tue, 5 Mar 2024 22:27:07 +0000	[thread overview]
Message-ID: <6da20a8cf84d358841068e7eff3323b6d61e014b.camel@alliedtelesis.co.nz> (raw)
In-Reply-To: <202403052102.hlG8I44z-lkp@intel.com>

On Tue, 2024-03-05 at 21:15 +0800, kernel test robot wrote:
> 
> > > ERROR: modpost: "acpi_device_notify_remove" [drivers/i2c/i2c-
> > > core.ko] undefined!
> 

My recent change introduced a build failure when building as a module.

ERROR: modpost: "acpi_device_notify_remove" [drivers/i2c/i2c-core.ko]
undefined!

I think the issue is that I called acpi_device_notify_remove() which is
not exported (i.e. no EXPORT_SYMBOL_GPL).

I'm not sure if the correct fix is to mark acpi_device_notify_remove()
as exported (my gut says no), or to instead modify my new code to call
the already exported acpi_unbind_one() - acpi_unbind_one() is already
exported. 
I was only calling acpi_device_notify_remove() to trigger
acpi_unbind_one() anyway, so that seems like what I should do.

Please let me know which fix is preferred and I will prepare a fix to
the original patch.

Thanks,
Hamish M

  reply	other threads:[~2024-03-05 22:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-05 13:15 kernel test robot
2024-03-05 22:27 ` Hamish Martin [this message]
2024-03-05 22:35   ` wsa-dev
2024-03-07  8:21   ` wsa-dev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6da20a8cf84d358841068e7eff3323b6d61e014b.camel@alliedtelesis.co.nz \
    --to=hamish.martin@alliedtelesis.co.nz \
    --cc=andi.shyti@kernel.org \
    --cc=arnd@arndb.de \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=mika.westerberg@linux.intel.com \
    --cc=naresh.kamboju@linaro.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=wsa-dev@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox