From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EEE0C369A2 for ; Fri, 11 Apr 2025 21:08:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF3A2680025; Fri, 11 Apr 2025 17:08:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA2EA680024; Fri, 11 Apr 2025 17:08:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B91D6680025; Fri, 11 Apr 2025 17:08:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 95119680024 for ; Fri, 11 Apr 2025 17:08:39 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1FE871C9E4F for ; Fri, 11 Apr 2025 21:08:40 +0000 (UTC) X-FDA: 83323002000.14.7E5D10F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id BE04E20010 for ; Fri, 11 Apr 2025 21:08:37 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FiifFGTY; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of llong@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=llong@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744405717; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3W9KclZfqlYgP7Iz+t99weLE980bndnAhFOf+DRnuYg=; b=dMpVcRpUMm+GsHbQ93p43Ayl6K0FW82a4fePMovErjRhq+Mu823Bqg+EK1vcJ0g0ncJWf/ 9wJrETquvd/dJwLmwRiMs/xwVvfjege9+9YZAGumXJXtj0ZH+56Wk3gqNtI5DJ9iw+RqPl W7TcoNXY4e3AVqs4NqQxq6Ie3Pgj5TI= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FiifFGTY; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of llong@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=llong@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744405717; a=rsa-sha256; cv=none; b=1LAPoR7KM7FFFsBwZ9aChb0IQYmbj+5MK3eQbQm6kWkEefYG56do66CeHQiVXP6EvDlKSy f4G1+BYdrTkPRSnD7T79yp5ADmeJI6Ou77soPT8rBXxbM9AK8jnAY5NLFt4s2Ls9lmhTQc qJ/jhszA6AQq8Pveu03HDeDh6bFz34U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744405717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3W9KclZfqlYgP7Iz+t99weLE980bndnAhFOf+DRnuYg=; b=FiifFGTYVMTvqCqyEuj1/z/PkO4mSzU5fZRPLhoXC+w5zoRHWxxpCQXYQxGRP5imsSMKA9 iSR87vjOhxxJfjos8vFut2E2PSp6NqukD0TDeJ2vH2heUARbZBZC3793rcTgILM+c9NmPj 4Q0EfMn2DnHWTA3YkkZ52gR147oMjOY= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-olN7_MVEOjeVkvPsRL6pSw-1; Fri, 11 Apr 2025 17:08:35 -0400 X-MC-Unique: olN7_MVEOjeVkvPsRL6pSw-1 X-Mimecast-MFC-AGG-ID: olN7_MVEOjeVkvPsRL6pSw_1744405715 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-47779dbdb62so81372011cf.2 for ; Fri, 11 Apr 2025 14:08:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744405715; x=1745010515; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3W9KclZfqlYgP7Iz+t99weLE980bndnAhFOf+DRnuYg=; b=fFF76zBI+UXbRz74pzEH9+7Z/SPKlapFL+u6jMQ+a73ySZlckj1Jp9xwZy3/SZRdQV ww4DPMWTfzQfGJlBtQDlb6h+uItWp9tiDHkw5QM9orHlSJIm5imtBmL03g5gogHsD10S N9O3PItZ83cz8tFneZj6CgH4eYBysTal59zhM6nY02OQVUxyVb0rA8qZnmKz+2z2Q2dm 6HNuve7J5vmKEVCKORwxYZ0GhU9JS1E8rUrGu3OcpdAL+nO8uEGEF016yTO955JQv9PB E+luxFL4lyzWLeR2XsUCm6IFvM/prhRP1LS27VTP/AnN0QWLAIXu7gqxrhUBdsT8ue32 Qf5A== X-Forwarded-Encrypted: i=1; AJvYcCW1U47/QarJ3juf9Uk13hzvXOcRyCOXLJcohB+47QvqXYfyUvK8m656ty3x26caTnmEiITW7cv4lg==@kvack.org X-Gm-Message-State: AOJu0YzvadMnWiJvlJntKj77oCZm1GZ4PQZLgQ73h1HiKsZOK1yzTAwL 5fTm3jT6tZBjbzbJjBMZAEOwDRuMMgMHAFbJ55isMkUNlEENPp91WbsAwp6CwlHduzifnwvw6TN 2OkPUr2NA4ww6wPZMeFfE/XHntO2r4AjbTD3n0wNMKiLlgzJz X-Gm-Gg: ASbGnctrTslvNwE8GR+l70zRTqiyfMoqf1bIUFwh2EnXU/Fifk0jPxr8w5Ar3137iWu G0XS0THUnNbF1rCt+CQAmxpLzt2kp5qNJVoCiBxSJhJueWuef7qFtOmoYlZVwgNzGWzHFAthQFl 6LQ2OdhPcxaWxn2l1BSEifHPmjTQZucXM2CtBvr76FvvmgS9SYKKQHgavsj5g4zD+MGIDjSfV+W G3qw8vpbqfJxVSJaIxnl5c3pqVK5I1k9FkDk1vGn+hCHvMZ9EPC+6/KgtL/QrmaZH1U8LcfSj3d qwURp/zNS981zbkgZCefcmpscjlpWGHHuw42/wyDwGQ9gb3FRKWBr18LMA== X-Received: by 2002:a05:622a:178e:b0:476:6a3d:de44 with SMTP id d75a77b69052e-4797753b8ecmr60226561cf.18.1744405715390; Fri, 11 Apr 2025 14:08:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE0y+vSo6hGThZEztK8iK0sDkq82eXR0S+/0TDkk0ytOKTiwg9dU/ESnAPHOzVuad6BuHXsiQ== X-Received: by 2002:a05:622a:178e:b0:476:6a3d:de44 with SMTP id d75a77b69052e-4797753b8ecmr60226251cf.18.1744405715042; Fri, 11 Apr 2025 14:08:35 -0700 (PDT) Received: from ?IPV6:2601:188:c100:5710:315f:57b3:b997:5fca? ([2601:188:c100:5710:315f:57b3:b997:5fca]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4796eb2c07fsm31907501cf.44.2025.04.11.14.08.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Apr 2025 14:08:34 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <6d81d576-7e94-4523-af9a-d43298ea64ba@redhat.com> Date: Fri, 11 Apr 2025 17:08:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/2] mm/vmscan: Skip memcg with !usage in shrink_node_memcgs() To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Tejun Heo , Shuah Khan , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20250407014159.1291785-1-longman@redhat.com> <20250407014159.1291785-2-longman@redhat.com> In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: C3CElIlKoqpafNDI84N7FYu3Nx8JEkweMvFtdZj3EDs_1744405715 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam01 X-Stat-Signature: dbz7bbdbautf5g4otamgu8q93s8g6p5r X-Rspam-User: X-Rspamd-Queue-Id: BE04E20010 X-HE-Tag: 1744405717-763849 X-HE-Meta: U2FsdGVkX19z+XMf76nmIrXyulicVNsjy6YdxYi6dR/wlqNF8/Ws/R2T2Pk/QkL5pJitpcX2foXh30mK1fFTSvMi9f46nMYeK+0Dj4RvdBIjGhnf64jcp5kjbxPgC6EDBOv5dkhXoTr6n+Mr6mgiq7Gc3gCTE4MwmKFfdyoACAtqVjBNdnAvhTHtqw92B7u2IOrZUv1hVbSK12qGX1hJC7+iNU2RSoAGkQYZV3rQtnj12gRTd8chRZBWL+Z0Px6V5fKV9r5Pz6J8bojxrBJMTl8u7aW3ggpGLzIf22WQsVoDp712haVx2EW/ITkVBzVxZql0v2U6E3gXAE14dUqrQYdEQ5LptULwXjLCLvLqsZjdsFyXvvWQMayw8lDtp7SpOIHGxFjvVxaQB4uXlpxGv7BNvWp6jzrCtPDLnUtjknIzClPlZ4dK3XBzLIjcwRF5/fTLqcLzeWIQ3RlrD9+hVL7JQQwOUH+81sQ/8fvjV8B9zdnuI8N+sgDMyRnFlKsgfJYJDuaWd9g2321AyLlmQt7e8yX2RIrMoDGt9Z3ZFW3k9LJpoFEcGu3IHxsn4IpPgyPVAMekGDzp6P3vWVnOMZR9TrMZQwEs2zbsiAwxYKMBw5mVkYVBKZuAomUT5JMVLY1/oaM1GbKISnvnzdK7htxbAGhH1s7/WJ+6L0een305oVvzk6TEweaMVVrZ3jW6ZcJq/4MALVcq9MXMQVhuOiwK5jUBOER7HAUYIvaA/C78OEPfTAQ3zmaK+drDgOP4u0hWa555ly0hn0qpJ1uIUliXjvwkIlZTzEiPoVFJbXQ38S47w5CBftYW6rYEZ0TT0lMFEN+WHk39jwDvUtG9859fsy+2lGeih29Smja7NcO1REAcKeXZS3pdXEjssqAr4ZxwiGniiwYg7Xkkb0T29V8L//NtJeHeeW6TS8cDaZGh8VBT1Gx0YLA1P8KkXIjQHNVbAaEv4jVNIaLc6zW xsUvaKyp QP3WJc1SIiQJOQskOe/YTSl9pISsD1VycyV+hkt5yBBnaAAcjnJr+ARs3iBlvIL/p7aoQAr7+DPs0UKBrInstzOCUz4eEZ2s9DFYGU1fWVtEEG591hfxTh1AQBxqAqlIatMC5tUjrln1mjS+Df0lAaLbzaKz1uh5K8W9H+uCGuyCRU99XB0hFVpNbGvLKLqfF6M2EJgK5sgGKAs0QDDlT+28ju42mylpnFLiIjpCMweGAr3ieM1RRDoQxGtiQ2r52NLM9uJgkMCTKB/vnlM/PpdpNDGBX69jQ3yOMIXEG93K1z/E6o6rPvpSqxGJbV22HcsZ5B0sMSU9Knj9w+wNmE/nfBeRsm2K9KN8Bs9iseEIA63F5Wp91KHV+6VaT+23Pg2l04cL9f5xAGiJNfhacYA1p5CGsgty8wQTN8hvyKT5Nk2Kvikrj1qGMcpetBOcMKQz6rZLfwk7zCnhs8II7V6Dmlknv9fHATG+GSHoLL22HBXHoi1IzyP1ECvNg4/No3dl5njZqusxJWVWSHB32y7hP2g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/7/25 11:25 AM, Michal Koutný wrote: > Hi Waiman. > > On Sun, Apr 06, 2025 at 09:41:58PM -0400, Waiman Long wrote: > ... >> diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c >> index 16f5d74ae762..bab826b6b7b0 100644 >> --- a/tools/testing/selftests/cgroup/test_memcontrol.c >> +++ b/tools/testing/selftests/cgroup/test_memcontrol.c > I'd suggest updating also the header of the test for clarity and then > exempt the Child 2 ('E') conditionally from comparisons, something like: > > @@ -380,10 +380,10 @@ static bool reclaim_until(const char *memcg, long goal); > * > * Then it checks actual memory usages and expects that: > * A/B memory.current ~= 50M > - * A/B/C memory.current ~= 29M > - * A/B/D memory.current ~= 21M > - * A/B/E memory.current ~= 0 > - * A/B/F memory.current = 0 > + * A/B/C memory.current ~= 29M, memory.events:low > 0 > + * A/B/D memory.current ~= 21M, memory.events:low > 0 > + * A/B/E memory.current ~= 0, memory.events:low not specified (==0 w/out memory_recursiveprot) > + * A/B/F memory.current = 0, memory.events:low == 0 > * (for origin of the numbers, see model in memcg_protection.m.) Sorry for the late reply. I think it is a good idea to update the header as well. This function is actually used by both test_memcg_low and test_memcg.min. So I will use low/min instead. Cheers, Longman > * > * After that it tries to allocate more than there is > @@ -527,6 +527,7 @@ static int test_memcg_protection(const char *root, bool min) > > for (i = 0; i < ARRAY_SIZE(children); i++) { > int no_low_events_index = 1; > + int ignore_low_events_index = has_recursiveprot ? 2 : -1; > long low, oom; > > oom = cg_read_key_long(children[i], "memory.events", "oom "); > @@ -534,6 +535,8 @@ static int test_memcg_protection(const char *root, bool min) > > if (oom) > goto cleanup; > + if (i == ignore_low_events_index) > + continue; > if (i <= no_low_events_index && low <= 0) > goto cleanup; > if (i > no_low_events_index && low)