From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87749C5AD49 for ; Tue, 3 Jun 2025 12:16:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E5F76B0424; Tue, 3 Jun 2025 08:16:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BD2B6B0426; Tue, 3 Jun 2025 08:16:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F15446B0427; Tue, 3 Jun 2025 08:16:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D4F606B0424 for ; Tue, 3 Jun 2025 08:16:48 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 854A5160765 for ; Tue, 3 Jun 2025 12:16:48 +0000 (UTC) X-FDA: 83513988096.26.219323C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id D028E140014 for ; Tue, 3 Jun 2025 12:16:45 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MZrJj7h5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748953006; a=rsa-sha256; cv=none; b=bQ2EXc9IqQ1/NxmoriOkniL1q8qwwmKs0TxI8dXsJpDIgg91dZonAtO8LgHALm//DvbfYU TWs4NpZ8E0P7+nQdmXF71T6vUyQ6cbFD6qU1usN8WGU89Vls8J9kMC5Do6Foe+KgD04S2v makbseBomo0wkc7r6sCyshSSs7xHxZU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MZrJj7h5; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748953006; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zFkVskIoPLKZci5KmRyw1Ujf2GM9YO/6k18+0dJGRXI=; b=ncr5QlVhUtsBInzgPLy7sztJZOmuz1cgln7HP1/RYZLIprbrhYh0DNSYG6qj1UorIG2u7y OyrpAGlpe3EvueYI9cwxhP4qj3zUOL24Hp7ZlX93FMCWoCgP2Jy0MO2XrWcnX8HxzFd/R4 JAiReOnpPfwx/hFuL6YgKn7sjMnC9h0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748953004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=zFkVskIoPLKZci5KmRyw1Ujf2GM9YO/6k18+0dJGRXI=; b=MZrJj7h51FIB0VBzafVBezEyV7rNbkCR22tzXfsIzNIYda9jgaArMnEqNpFq1YT7+vvwKh Sq/ihlZoFAQz2QB37oP9PttMCiD0wDWfXPRhUOgGMG1mlDL78tIPg1GVtrp6aQvxQnyEz0 acswk6+2bwmWzxACV/KXGrzSWdIqgYw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-418-m0ApAQa6PRCGb7YOuKrCJA-1; Tue, 03 Jun 2025 08:16:41 -0400 X-MC-Unique: m0ApAQa6PRCGb7YOuKrCJA-1 X-Mimecast-MFC-AGG-ID: m0ApAQa6PRCGb7YOuKrCJA_1748953000 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-450cf229025so15453965e9.1 for ; Tue, 03 Jun 2025 05:16:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748953000; x=1749557800; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=zFkVskIoPLKZci5KmRyw1Ujf2GM9YO/6k18+0dJGRXI=; b=LVzKKjj99n6mKt5YfEYDMvkbBt6Cy6jFhJMHBWbgXHcqAVnP3B/Z2QTNmEVKUTBKSP DeiGNTe7RMugLPDZlzYjverpCusfZuN0B00unrdIDariMRCR9VG2HYTpLMHVBaEgJbbw 9A7pmAwtYbbTjbPFdXzC4xEtEexC9uXI2hPWakXGKWxal5Y6BL2G4wLQnWLj7fLcHhsJ AqaNpRR88SrurMT7VyikwSFrg+bDPf6tVDLJrdbWFbTukksCWn4R8HuDeOMeKOAwL2tA iqqMEq7ugP3pBLfiuS6uBJbwPyeR9d+x2+Td8cW8cSIcgC1ORxdhy+vD0hg3U08KIG9w PC6w== X-Forwarded-Encrypted: i=1; AJvYcCXfBBcP98xsqp0H1EtNOc0UCokvfEebAXkN2mAE7HFgXAIj/Sl8XtpsAuW4Qlv+0oZD7D4/9w9fmQ==@kvack.org X-Gm-Message-State: AOJu0YzKduhbfK8EoCndzl+/XLJqvCZBMExyNMh71ca2es16X2vYh0ml BBkhp5RohqgLjQU6iWwt4GpOdzasHK21iX3kttNhtShffBCj1AR1JUnpjO7Gx1dC5nCwAcWl55Y X7gpGZaMCHHLzvR7XDIvZRio8Zp5WnQDdpoqhC5AKRsvVk0fwMpeB X-Gm-Gg: ASbGncs7vmYG8sYtTtkHMeza2NXneeeuTR5jjLGwHVVth0Eea6+8heiqYy/InawYHML NQYEJBjOH9zoXUSjFc215D6nYwo2x85jcbrYGcGexEyi8S/dLhS+ZXQv+FlrjgQRuvyZ7xC8YOW t/TXXuOg3MNRHlV8R1FsDBadDigon4y/COQOK2OAtqxHPnxtf10O/FoFx1M3Z/tf6wLV3hGWhwy qhUf/7eJJV4So/LStvfrfh9VZ0cOw8R2rLovrqQE7Fklvap8qrRi9PT0oD3b55GHjxpJcGVFMsY iM8fAOpfUA6ZFenZHUxkOOp3t21M7wkzP+QDbVKDLdptQiDtNf0ISWrcjDq/yIu7kub2Cw80N2A nuPNc1Y7phCK32d9UCyih5yer6urKwV8ri+gMFeM= X-Received: by 2002:a05:600c:6219:b0:43c:ec97:75db with SMTP id 5b1f17b1804b1-4511ecc3e06mr108883695e9.11.1748952999755; Tue, 03 Jun 2025 05:16:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGS1DnA0XkpW31VCHiq9SeAcnd5vAQKnQl/rGx7fh5/gtTlrZFw/1Wvm8mBkCINymrUlGLFLQ== X-Received: by 2002:a05:600c:6219:b0:43c:ec97:75db with SMTP id 5b1f17b1804b1-4511ecc3e06mr108883385e9.11.1748952999325; Tue, 03 Jun 2025 05:16:39 -0700 (PDT) Received: from ?IPV6:2003:d8:2f0d:f000:eec9:2b8d:4913:f32a? (p200300d82f0df000eec92b8d4913f32a.dip0.t-ipconnect.de. [2003:d8:2f0d:f000:eec9:2b8d:4913:f32a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d7f8edebsm158198345e9.6.2025.06.03.05.16.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jun 2025 05:16:38 -0700 (PDT) Message-ID: <6d7c2cd2-061e-4295-8e9a-832cd0185d8c@redhat.com> Date: Tue, 3 Jun 2025 14:16:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/4] mm: Fix uprobe pte be overwritten when expanding vma To: Lorenzo Stoakes Cc: Pu Lehui , mhiramat@kernel.org, oleg@redhat.com, peterz@infradead.org, akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, pulehui@huawei.com References: <20250529155650.4017699-1-pulehui@huaweicloud.com> <20250529155650.4017699-2-pulehui@huaweicloud.com> <962c6be7-e37a-4990-8952-bf8b17f6467d@redhat.com> <009fe1d5-9d98-45f1-89f0-04e2ee8f0ade@lucifer.local> <6dd3af08-b3be-4a68-af3d-1fc1b79f4279@redhat.com> <117e92c1-d514-4661-a04b-abe663a72995@lucifer.local> <702d4035-281f-4045-aaa7-3d6c3f7bdb68@redhat.com> <86b7cfb9-65d2-4737-a84d-e151702895f1@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <86b7cfb9-65d2-4737-a84d-e151702895f1@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 4pQ4b5ZP721_vtQl5ackDlb8q6ah7lZGTqgBANf29m4_1748953000 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D028E140014 X-Stat-Signature: 8wx3wri1qz7r137ipk4qjq4zctjfgpwi X-Rspam-User: X-HE-Tag: 1748953005-399450 X-HE-Meta: U2FsdGVkX1/TJ2sufRr91dLfpNnpJ4IKhTtgT4teYBRMu8OQqkn4HPistBpyRDWaRq73gElNSZlgDgM0+u4B98IDkqVopVVms9QlIK4/lEvaDI6rYFivV/toHJocArgdXPhfIThB0YWUxEByFY0x6vTE0anblwmWxNcBFxaGDX542nB0J/x0+PhSybTl7v9ynYd7uIyE4b1XFAuP7w0fB7MfzVSftb8OqenIGdtsXois2p+cbpyy2YmEmNjoUBTXjey8qgeHBLDbh/HAuGsnWswD9mWb7+d72f6xEQ07x+rhh02x8xWVLWub4mbTMxFghgPnSf9yNhDI//RM0OW3eG8ySGiHD618PhEoBapEgJXJlPuliUEPmcRfUd/FFMpnftaGDQprB/ic4uSvrkxAH7N713lxcbOmoPWTysKa8uKvWtrvut4LGeHsRduO32b9pve1qS9qSuXEFnOXyQ/SuNVnexPYaWJP1zPwJK4GugUFFTGBuEKPj0MhqTSwmOt7ZLL8G1rw5wW9D10juyQvNwCiQesBPB+xfhdcuM/HaVGrz8xAPxQVH0CyuPwgv2VmTfPg3yVTYM4ybcy+97paSmEf1AIlG259igSpO6Ed2VPG8nn0MebqqsLW71nxiIKaIl1WYVhZw/Y9jKU/CbNQD2BolerNJoNT1DzjKnVi8f+0eYG6Od/0lqnv13HZin7KSHuizXjZzSBqVYueviLAxxxAwdeJyXgW+fmKSW51Xh+KP+fwAkYTvM8iaBqz17SPSQblr5Fj9Vw8Y0xgoTywMoKUykaujRv527qQlG99JQK1kWaqRAbhlN98uAz+YioZgHaxl1/L/IJHQN4Go0XS4iOqmtQUjyF+2Z607gVBHcjrdGui0VFHOssb6nLxYNa7C47necbkM/I20mYG3txsR6306U1xsBsJxHggK5c6vAAs+paKv4iXjSi0XM59AarpWUd3L1ot1fsVVbWN0Yx yLLlbqGN BBTi8QBHKsqCrVS2VsdMLeT6STWmn5wdPgvNbN7BBfNqQK2hjYjxPYZXpZeUcevrz3I8d2xvlOZN2ruFyddvFRNKSyWvOAMQrSfV2faMzmZOKdR5RRX8Npj0eMAPp+ut6PDjGJ/K4gyTWpRfpNI6B3qpUvM4AbijHm1BKQz27m6Gzv1Sf3D+YKX7un1PPenpShqWlRRtjGTYLGUZN6Nl83YMmJ8g/WQxEKV0UhI16/ranGBfy1wDA0SE817+tbdqfbj+jr3U7W7lp26Nef708Yd9Chl+Us4ALVSqlserIqujLbxZbMY8AXMzzcPNQ/L6MuIZ70m/9nVROWkBUuPkZRssuIllWv01EJdRQqwts0qhCEGCoyloiI5KmynZpdvPdsg0WRNdyacBKg079PN9sZa6wJEbIROa5Ya9Y419rMTpxPCo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.06.25 19:01, Lorenzo Stoakes wrote: > On Mon, Jun 02, 2025 at 06:28:58PM +0200, David Hildenbrand wrote: >> On 02.06.25 15:26, Lorenzo Stoakes wrote: >>> On Mon, Jun 02, 2025 at 02:26:21PM +0200, David Hildenbrand wrote: >>>> On 02.06.25 13:55, Lorenzo Stoakes wrote: >>>>> On Fri, May 30, 2025 at 08:51:14PM +0200, David Hildenbrand wrote: >>>>>>> if (vp->remove) { >>>>>>> @@ -1823,6 +1829,14 @@ struct vm_area_struct *copy_vma(struct vm_area_struct **vmap, >>>>>>> faulted_in_anon_vma = false; >>>>>>> } >>>>>>> + /* >>>>>>> + * If the VMA we are copying might contain a uprobe PTE, ensure >>>>>>> + * that we do not establish one upon merge. Otherwise, when mremap() >>>>>>> + * moves page tables, it will orphan the newly created PTE. >>>>>>> + */ >>>>>>> + if (vma->vm_file) >>>>>>> + vmg.skip_vma_uprobe = true; >>>>>>> + >>>>>> >>>>>> Assuming we extend the VMA on the way (not merge), would we handle that >>>>>> properly? >>>>>> >>>>>> Or is that not possible on this code path or already broken either way? >>>>> >>>>> I'm not sure in what context you mean expand, vma_merge_new_range() calls >>>>> vma_expand() so we call an expand a merge here, and this flag will be >>>>> obeyed. >>>> >>>> Essentially, an mremap() that grows an existing mapping while moving it. >>>> >>>> Assume we have >>>> >>>> [ VMA 0 ] [ VMA X] >>>> >>>> And want to grow VMA 0 by 1 page. >>>> >>>> We cannot grow in-place, so we'll have to copy VMA 0 to another VMA, and >>>> while at it, expand it by 1 page. >>>> >>>> expand_vma()->move_vma()->copy_vma_and_data()->copy_vma() >>> >>> OK so in that case you'd not have a merge at all, you'd have a new VMA and all >>> would be well and beautiful :) or I mean hopefully. Maybe? >> >> I'm really not sure. :) >> >> Could there be some very odd cases like >> >> [VMA 0 ][ VMA 1 ][ VMA X] >> >> and when we mremap() [ VMA 1 ] to grow, we would place it before [VMA 0 ], >> and just by pure lick end up merging with that if the ranges match? > > When we invoke copy_vma() we pass vrm->new_addr and vrm->new_len so this would > trigger a merge and the correct uprobe handling. > > Since we just don't trigger the breakpoint install in this situation, we'd > correctly move over the breakpoint to the right position, and overwrite anything > we expanded into. > > I do want to do a mremap doc actually to cover all the weird cases, because > there's some weird stuff in there and it's worth covering off stuff for users > and stuff for kernel people :) > >> >> We're in the corner cases now, ... so this might not be relevant. But I hope >> we can clean up that uprobe mmap call later ... > > Yeah with this initial fix in we can obviously revisit as needed! As Andrew was asking off-list: Acked-by: David Hildenbrand :) -- Cheers, David / dhildenb