From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08CF7CFB440 for ; Mon, 7 Oct 2024 11:20:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D9C16B00F1; Mon, 7 Oct 2024 07:20:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 889606B00F2; Mon, 7 Oct 2024 07:20:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 750856B00F6; Mon, 7 Oct 2024 07:20:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5678E6B00F1 for ; Mon, 7 Oct 2024 07:20:30 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F1790141624 for ; Mon, 7 Oct 2024 11:20:29 +0000 (UTC) X-FDA: 82646562978.14.A5B42FB Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf04.hostedemail.com (Postfix) with ESMTP id 34D254001A for ; Mon, 7 Oct 2024 11:20:27 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728299850; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+Hmc2YEz6vncIOHjalZwhbfxIKjFR4jJwB2rRYU/pzM=; b=UlqvtmL2WX/kKyNRU4EDbE1KYO1rnW5k2eHTopKUVbr0tHnXxsQQkBq31oSF0g8eBRXOYQ NYF+GvAO953Imb0cXeyUZYA2LSzfIG338UF10ScbOcgUDfzOH2PWoOuxmrAgTgYHWWddFV nL1qLBbS2UwuFtddIhb55Gk3LKx8Q7c= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728299850; a=rsa-sha256; cv=none; b=F/Kr1vrbdMODxYD4lmsGi78KAY2GPROasQyni7iK3xF0N8hKCQyeoJ9no06qIgjpcn1vle 3UhjhKE2anhNG7d4xj0GHjdyuPZQXqeVcp956PTvuIgENxNdjkn7EQxhIMDfim+wYIOXvy 7dWdju8SEbCuuIp2PYVGGHl2IlffOMs= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D8279FEC; Mon, 7 Oct 2024 04:20:56 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 102613F640; Mon, 7 Oct 2024 04:20:24 -0700 (PDT) Message-ID: <6d79c86d-601b-46b9-a06e-6ab78b6d3e8a@arm.com> Date: Mon, 7 Oct 2024 12:20:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h To: Arnd Bergmann , linux-kernel@vger.kernel.org, Linux-Arch , linux-mm@kvack.org Cc: Andy Lutomirski , Thomas Gleixner , "Jason A . Donenfeld" , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Theodore Ts'o , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers References: <20241003152910.3287259-1-vincenzo.frascino@arm.com> <20241003152910.3287259-3-vincenzo.frascino@arm.com> <423e571b-3ef6-4e80-ba81-bf42589a4ba8@app.fastmail.com> <850cdc2a-a336-4dab-bc7a-d9bcae3fb3cf@arm.com> <140c4244-1bb2-404c-8372-1e68963eeea5@app.fastmail.com> Content-Language: en-US From: Vincenzo Frascino In-Reply-To: <140c4244-1bb2-404c-8372-1e68963eeea5@app.fastmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 34D254001A X-Stat-Signature: mde7edudhtnrd19eabac7nynykk4y61b X-Rspam-User: X-HE-Tag: 1728300027-732 X-HE-Meta: U2FsdGVkX184juGB1vnd/1nZonrnchkD1xVnRCzpuIXtDoRTDbNySMIyKg2m+nnS6xWFQ/jDBDMgq5XPtX1TJnEZsPwT6JfQu12FqvzsM9UPf8i6wK8XZnM7dzE09wMKdUsnIw5+nRDvvF56rDQPcc3sosD/6YWGtLASGt9Bkq8dPajHICX2G4Gjf1B+UF60BvWY3luVU5nRYHClsGEcJm8tZGyRS0yeGkNajiJdwNNuPSZIkttp6yl3/MmH1wJU/xa3+hV2MM6oYKTXWJSC+dCIH0yB/mcg9lTgEc+oGLOR0JjLjHKxqFaUekkE5/gQHKEvrTp9abicZothytSzlihrWvhQ3FSOpuAlaF7d7e37RG+FI9fm1Fq6YvuYxsjQq9FF3vKWOz2wQyOwXN3WDujfJsaBKm7C3f02q/oCbcovfcMLBodSVt6KPB8kE+XxKSmvubchpulViukDUX1mAeBCSDzzAewxcG4ynQo9+GMTDzsMczfnmwxhhqwKkuNis5PJIK24pBgvL8jA0Y5M5anWENt1O6p5DJTMzdn6CbbzFwI66wBk+dsIZeVWdndNsucdQQCInO1ErzD0xE89WC6RkvqSWdAs8/oiDQA6ROnITUnhLZw+l8wOouMdFDDrERShStPLeQwyHjkM4hXweSWHQeEEtSzQKQRCt6BrRhQgV082bTCQxCN6gSOU8FpAzIU+/a37NsfF74ZqRfbEeQU/U6z9s+9XYCd+nDS/DyLGCv0pFLTq33zBS3aqK9xIy56uA34mH4wxeu4RrpNATJV3KVODKjmLQmd5kI5oUR++ekmUICE4tAW+fMlz4wJFMmFxBicDvnFJlphoatOXAk2tcd16Xq4IaCvEY2crBg7D9IBsUIq9yHAjTPmhKUam219mECP+fhiyfYM0+4t5f7H5UJcBmzKSXhQunToPvMkQpJe8xeDf7Lo079FwFp+6fEr9QxKjIRObDHjSuwO j/FPMYx1 wPorhrQ2i5Yx5d7aO54H99js2oC4K/81CLlyssXRgfmMY12RikuQsGkUrs+f8exrcQV8lYdApGXyoqp3t1eoesIaUg4HgmAFAdScMBHMJVsN/yz3qLGN7GVkfbx5lVskimhyXIjqd8jX6jqp2tk3q2FO9Dw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07/10/2024 12:06, Arnd Bergmann wrote: > On Mon, Oct 7, 2024, at 11:01, Vincenzo Frascino wrote: >> On 04/10/2024 14:13, Arnd Bergmann wrote: > >> >> It seemed harmless from the tests I did. But adding an '&& >> defined(CONFIG_32BIT)' makes it logically correct. I will add a comment as well >> in the next version. > > To clarify: this has to be "!defined(CONFIG_64BIT)", as most > 32-bit architectures don't define the CONFIG_32BIT symbol > (but all 64-bit ones define CONFIG_64BIT). > You are right, it seemed that every 32-bit architectures with a 64-bit phys_addr_t had CONFIG_32BIT but this is not the case. > Arnd -- Regards, Vincenzo