From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94BBEE7E654 for ; Tue, 26 Sep 2023 18:26:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1FDED6B019F; Tue, 26 Sep 2023 14:26:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 187766B01A1; Tue, 26 Sep 2023 14:26:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1BE06B01A2; Tue, 26 Sep 2023 14:26:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DA7766B019F for ; Tue, 26 Sep 2023 14:26:37 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 998B31407BC for ; Tue, 26 Sep 2023 18:26:37 +0000 (UTC) X-FDA: 81279579234.01.50A23D8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 55D3C100028 for ; Tue, 26 Sep 2023 18:26:35 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=idylMkx8; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695752795; a=rsa-sha256; cv=none; b=Kwrm6XDwDV55akZL4IRo/F71wfMR6RIEcFxGpQNZGamj+MlG44pfs91smygfN/noLpSjCy DM9gR9ybAJ/f87KP3y9ZUkLuz5FQckC4tHdy2NWVbuHLuKqSoBY7F8GxMWs4zLjCJ1mDDO wxttLeeqPjNn1MbqUZPYati4j1P/doM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=idylMkx8; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695752795; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DwoJum8k/RXgXp7ZcjN7+B18vLt7LwKv/JIHveYVL1M=; b=mgwYgRcEINWj9gsGLQnhpZ0qdLI3P6t8ukLSITKjmps9JKszNMX9EQX5jkxIT7598zKYZq yX4JJt9WZJ/ZD/jTZx61RKGzCaz9yp6Xjwmjp07vYzh7sjfkDL1swNraLNIzt31GvRsevj 7xQnFHYG8XKEBjNctkMQRgcAfSMA2m8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695752794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DwoJum8k/RXgXp7ZcjN7+B18vLt7LwKv/JIHveYVL1M=; b=idylMkx8xX7jGvY7FU+IjPojUOD2qlHgMQFIBVbpXluGwkbF99aufAk7w8Zb7wG5s4gNiL kv6APlJTLSzHuoiMYDrF1ygkbCwX6bXuBoJ/oHjePlTaSvMg8D7FNn4ipNFrvx+r+aRdE1 5Ik799Fd5Q1dOj4fx+7y7J0KbbLV4+Y= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-616-l3MULG_GMQqf1GkXZPn5pQ-1; Tue, 26 Sep 2023 14:26:33 -0400 X-MC-Unique: l3MULG_GMQqf1GkXZPn5pQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3f42bcef2acso80258605e9.2 for ; Tue, 26 Sep 2023 11:26:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695752792; x=1696357592; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DwoJum8k/RXgXp7ZcjN7+B18vLt7LwKv/JIHveYVL1M=; b=eiH1wk8bcfbfhWmhHiTgyJSIOfxXr4chor0j8CMWV0XAI5G2DFBviN7yR63/qmwBuT demwRXsRHd2HPdjlIarHlHCUmBsv43A9GMzrb8Z+GSb9jYnmjFl2aJCpUiMeej3t5hmT 5z5B4Kdol2OYmaARY+SacoMx2CofLgRiUlc5EutG2rw/7XZw8214GHcqdWvOQ8DNzOLW su/gfAbibBm1do3u17ASgkGatHs1xj96xeqdelKuwTUnp+c/TpZhDPV7hHu0sx91WExc ySU5P9wE+GVE3/lHVLpvbZSBNeGdK8efx4NqGwApoXwWCsY32mbXJBxVaMKIy8MnjTnH 094A== X-Gm-Message-State: AOJu0Yw1nO6pwFFLB+rzIZ1mVXlxybf6nFdspOXSX8d/W2kKGADdKPt7 wcqECD+WtPR2xuOz/ygWfpYZj2m2P+VhzvCNAaJYXrsjS9La2F9tJB9NFbCWnITjtv9V4Z4BXwZ ufz64fwOG7Vw= X-Received: by 2002:adf:e4c4:0:b0:31f:a718:4cb6 with SMTP id v4-20020adfe4c4000000b0031fa7184cb6mr8986985wrm.46.1695752791865; Tue, 26 Sep 2023 11:26:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHxGu3NBaGTZom26sGQSBfnWf9Q1H2+RqueTFtCy03SOf47ck4RKAjAX0vxHkytm6r2Im2mpA== X-Received: by 2002:adf:e4c4:0:b0:31f:a718:4cb6 with SMTP id v4-20020adfe4c4000000b0031fa7184cb6mr8986976wrm.46.1695752791475; Tue, 26 Sep 2023 11:26:31 -0700 (PDT) Received: from ?IPV6:2003:cb:c73f:600:933b:ca69:5a80:230d? (p200300cbc73f0600933bca695a80230d.dip0.t-ipconnect.de. [2003:cb:c73f:600:933b:ca69:5a80:230d]) by smtp.gmail.com with ESMTPSA id k22-20020a05600c0b5600b003fe601a7d46sm18721342wmr.45.2023.09.26.11.26.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Sep 2023 11:26:30 -0700 (PDT) Message-ID: <6d732e97-ccc0-2195-d767-387692d43f25@redhat.com> Date: Tue, 26 Sep 2023 20:26:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: ANON_LARGE_FOLIOS meeting follow-up & refined proposal To: Ryan Roberts , Matthew Wilcox , Yang Shi , "Yin, Fengwei" , Yu Zhao , Zi Yan , David Rientjes , Andrew Morton , Vlastimil Babka , John Hubbard , "Kirill A. Shutemov" Cc: Linux-MM References: <4966f496-9f71-460c-b2ab-8661384ce626@arm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <4966f496-9f71-460c-b2ab-8661384ce626@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 55D3C100028 X-Stat-Signature: 3h5xz377k3ysre9od61w3i1yza6t61xh X-Rspam-User: X-HE-Tag: 1695752795-996532 X-HE-Meta: U2FsdGVkX1+U7e5QJKP4x4zZTDmxjR0QwBoCluS8QyGmv1mblTzmtvm7sYBlcaBi7XkhLjSVx27BVU3apYc5AXI3vc5pVMFPUck6DT2UIZ6MWp2wEzIMsF/s0ub4cydRlsz//QpkabkYNDs8+jaB/hvaTaoGU7Q7Zr5FScIzxfK2X/r4k1baFx7ShXc+nUikFtfr+FxzdBXngOdm64RqJxCZb0H+7qyr8VK6nm4KR4u5LjyqEzGXI4kdJEL7MUS+xFty8SgdQ1HybXsU4QjNdQ9Df2D8rFQKFyTvLWTxZ0dunkTpS5sAqT60BPUHitaso85EloMeu6fbotiWuoeduDn0k/R5NjQintYRquW8/Cy2KL8x04yGWjKAUd9Df56QKk45saZJhZc+j2nTvTuBsszfKAbG0/cOtQaq/4LQOB489ZFlASQAAI/8dsKsNwpVASTp2U33RKEeOuzEOQapGawo65loAPj9zEtV7g0utyiO49KBcIMM7ixcI5pm1obdTG/CgquH4Bosn71UoAnlyEp9qqT3oSzCjGHa/NXQMSINdkOnerwwdiI8RmLDOfoYK2S63HrSVnmS06H1hI3NdEwf2Vqz/w7Jfczlc1kzQvkD1MQt7oibzaovIZQy4Gc9ZTZ8wUMPwhl7kyVQCpRvbhJbqqpnzuSSwbv1CaGP8Gl9OLHM3k1h7ZEzkvs/VBsJcO+DzIl9qOraeFtCJChRBv9LTP5+VTDemzHc3mQk4W4FUY1qdXLB8OPKEffLtOi+Abxen2Rrq7g3RCUdXR7LwbUP0weWpyqZUjTHtg0mPEHQ4MgRMwbHj7mL66Zzdt6je307MWAY2+EA7XS73EaNv4oDzcio/A6KHDdtZ1487MZbpLIr7ysJgVU/HCcFrSEjPtcQR6YkfL3ILU/LYcOIsV5hdybvPL/tpo1dBbYfNZ/ZbFIdmLyUasX+f1nLPZai4YtjOu1zMF6gHo1zj7e E4L4CYm6 fbPQb53y4hnyELWagf4UJGXWhDf0p6cPehV5NABX/oKTnccAAeA2JqbzU6qLfhVjcMbXDl2qflKaqjhIaKZocX3hvnRgf2Mp6+mQ3yscLXtQtvCM6M3g6uOCXW75Iihq1phZLUtMp5QQm+gCjFsUk32eyK5Rk9rAfGEK430EqiRFqOZjAEfVhBByANCi13ZCcTD374SX0/Ddti4h4t7TRyTsXXs0C6ZjRn63p7qlVNZeV/S/+lo1oYfoXuLfgI9IIuY9m9fKZVnJ05EePT02ZLQ1VblgBMK9BluTgPwPuHEBz9yW7GRHmlQa52aNOzIbU9r60VNeA+98t1762Wa03Syfb9aC/+q8IQx0xEVII5UkAqgm4BwoermbiWER7CiN5sFrXcqKOPEW6skXFRvCHnWkWqW9G0RvlqP4GZEqEBt6F7po= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: [sorry, busy with 100 different things] > > DavidR suggested adding ability to set a VMA-specific LAF order, using > process_madvise(): > - Optionally accept LAF order through flags param of > process_madvise(MADV_LARGEFOLIO) > - When no LAF order passed, (or called with madvise()) use global LAF order > > Personally, I would prefer to avoid vma-specific laf order for an initial > submission and instead defer the addition until clear need is identified. > Thoughts? Yes, let's start with the simple cases. > > > Stats > ----- > > meminfo:AnonHugePages, smaps:AnonHugePages and memory.stat:anon_thp will > continue to account THP only. Agreed. One concern that was brought up that existing users associate "huge" with "pmd-size". So any thp toggles/stats should control/express exactly that for now. > > I plan to add meminfo:AnonLargeFolio, smaps:AnonLargeFolio and > memory.stat:anon_large_folio to account LAFs. > > Do I need to add counters to vmstat also? (e.g. large_folio_fault_alloc, > large_folio_fault_fallback, etc) - would need to think about which counters and > what they mean if so. Can probably be added later. -- Cheers, David / dhildenb