linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Ryan Roberts <ryan.roberts@arm.com>,
	Matthew Wilcox <willy@infradead.org>,
	Yang Shi <shy828301@gmail.com>,
	"Yin, Fengwei" <fengwei.yin@intel.com>,
	Yu Zhao <yuzhao@google.com>, Zi Yan <ziy@nvidia.com>,
	David Rientjes <rientjes@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	John Hubbard <jhubbard@nvidia.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Linux-MM <linux-mm@kvack.org>
Subject: Re: ANON_LARGE_FOLIOS meeting follow-up & refined proposal
Date: Tue, 26 Sep 2023 20:26:29 +0200	[thread overview]
Message-ID: <6d732e97-ccc0-2195-d767-387692d43f25@redhat.com> (raw)
In-Reply-To: <4966f496-9f71-460c-b2ab-8661384ce626@arm.com>

[sorry, busy with 100 different things]

> 
> DavidR suggested adding ability to set a VMA-specific LAF order, using
> process_madvise():
>      - Optionally accept LAF order through flags param of
>        process_madvise(MADV_LARGEFOLIO)
>      - When no LAF order passed, (or called with madvise()) use global LAF order
> 
> Personally, I would prefer to avoid vma-specific laf order for an initial
> submission and instead defer the addition until clear need is identified.
> Thoughts?

Yes, let's start with the simple cases.

> 
> 
> Stats
> -----
> 
> meminfo:AnonHugePages, smaps:AnonHugePages and memory.stat:anon_thp will
> continue to account THP only.

Agreed. One concern that was brought up that existing users associate 
"huge" with "pmd-size". So any thp toggles/stats should control/express 
exactly that for now.

> 
> I plan to add meminfo:AnonLargeFolio, smaps:AnonLargeFolio and
> memory.stat:anon_large_folio to account LAFs.
> 
> Do I need to add counters to vmstat also? (e.g. large_folio_fault_alloc,
> large_folio_fault_fallback, etc) - would need to think about which counters and
> what they mean if so.

Can probably be added later.

-- 
Cheers,

David / dhildenb



      parent reply	other threads:[~2023-09-26 18:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-14  8:16 Ryan Roberts
2023-09-22 15:48 ` Ryan Roberts
2023-09-23  0:33   ` John Hubbard
2023-09-25  8:51     ` Ryan Roberts
2023-09-26 18:31       ` David Hildenbrand
2023-09-27  7:23         ` Ryan Roberts
2023-09-27 15:32           ` David Hildenbrand
2023-09-27 19:04             ` Ryan Roberts
2023-10-02 12:58               ` David Hildenbrand
2023-10-05  7:37                 ` Ryan Roberts
     [not found]                   ` <c60321ef-8596-8fa0-7367-f43e69e1d894@redhat.com>
2023-10-05  9:46                     ` Ryan Roberts
2023-10-06 11:53                       ` David Hildenbrand
2023-09-26 18:34       ` David Hildenbrand
2023-09-26  8:13   ` Kirill A. Shutemov
2023-09-26 18:29   ` David Hildenbrand
2023-09-26 18:26 ` David Hildenbrand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6d732e97-ccc0-2195-d767-387692d43f25@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=fengwei.yin@intel.com \
    --cc=jhubbard@nvidia.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    --cc=ryan.roberts@arm.com \
    --cc=shy828301@gmail.com \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    --cc=yuzhao@google.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox