From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by wr-out-0506.google.com with SMTP id i31so453827wra for ; Fri, 19 Jan 2007 07:40:21 -0800 (PST) Message-ID: <6d6a94c50701190740v6da25151kb9ddcf358ab2957@mail.gmail.com> Date: Fri, 19 Jan 2007 23:40:20 +0800 From: "Aubrey Li" Subject: Re: [RPC][PATCH 2.6.20-rc5] limit total vfs page cache In-Reply-To: <45B0D967.8090607@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <6d6a94c50701171923g48c8652ayd281a10d1cb5dd95@mail.gmail.com> <45B0D967.8090607@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org Return-Path: To: Vaidyanathan Srinivasan Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Andrew Morton , Nick Piggin , "linux-os (Dick Johnson)" , Robin Getz List-ID: On 1/19/07, Vaidyanathan Srinivasan wrote: > > Hi Aubrey, > > I used your patch on my PPC64 box and I do not get expected > behavior. As you had requested, I am attaching zoneinfo and meminfo > dumps: > > Please let me know if you need any further data to help me out with > the test/experiment. > Although I have no PPC64 box in hand, I think the logic should be the same. get_page_from_freelist() is called 5 times in __alloc_pages(). 1) alloc_flags = ALLOC_WMARK_LOW | ALLOC_PAGECACHE; 2) alloc_flags = ALLOC_WMARK_MIN | ALLOC_PAGECACHE; We should have the same result on the first two times get_page_from_freelist(). 3) if (((p->flags & PF_MEMALLOC) || unlikely(test_thread_flag(TIF_MEMDIE))) && !in_interrupt()) alloc_flags = ALLOC_NO_WATERMARKS The case on my platform will never enter this branch. If the branch occurs on your side, The limit will be omitted. Because NO watermark, zone_watermark_ok() will not be checked. memory will be allocated directly. 4)if (likely(did_some_progress)) { alloc_flags should include ALLOC_PAGECACHE. So we should have the same result on this call. 5) } else if ((gfp_mask & __GFP_FS) && !(gfp_mask & __GFP_NORETRY)) { alloc_flags = ALLOC_WMARK_HIGH, without ALLOC_PAGECACHE This branch will not hit on my case. You may need to check it. If 3) or 5) occurs on your platform, I think you can easily fix it. Please confirm it and let me know the result. Thanks, -Aubrey -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org