From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 561E8C67861 for ; Mon, 8 Apr 2024 13:38:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE8086B0085; Mon, 8 Apr 2024 09:38:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B97216B0087; Mon, 8 Apr 2024 09:38:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A85056B0088; Mon, 8 Apr 2024 09:38:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8AA886B0085 for ; Mon, 8 Apr 2024 09:38:13 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 06BEDA09E7 for ; Mon, 8 Apr 2024 13:38:13 +0000 (UTC) X-FDA: 81986468466.20.E529F49 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf18.hostedemail.com (Postfix) with ESMTP id 2688C1C0011 for ; Mon, 8 Apr 2024 13:38:08 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712583490; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WO1WT3gByOZ15CrJ9+rZZI9wL8+ZGQ0ifCU4EuYnEYA=; b=cKPUDQtMxShmKPs5caMnYuCZp1wRClGeDP3ltc2IpfpNZpAjgLcSH/POyOMWSiochsaKaJ 4CcQ/eBiZzONNEMh1UeUkAEUEZeAlkDdJRCCSESb2dS23k9HwciBr8nlG4mNaydQMLr8aE rWa24y31NRYEKNxa/oRAIBTo6s/LrrI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712583490; a=rsa-sha256; cv=none; b=uF0cyxr5UurK99xJfepSRmOFpJDHO9Au+VKwWpJyCpKsoJa3QNTT1J4vcnDPyW3teNW+KM E6ydTBpqB1dF+6uWc5WAIrKpieAyVWwP6BDXj5ecfLtiBcaGkdE0T/2Xh1ggEOvqQduvIM 2Cs8VWCqab1VrFEwW9X+507+j5u8Fm8= Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4VCqpV4yC6z1hwMm; Mon, 8 Apr 2024 21:35:14 +0800 (CST) Received: from dggpemm500005.china.huawei.com (unknown [7.185.36.74]) by mail.maildlp.com (Postfix) with ESMTPS id BC7621A0172; Mon, 8 Apr 2024 21:38:04 +0800 (CST) Received: from [10.69.30.204] (10.69.30.204) by dggpemm500005.china.huawei.com (7.185.36.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 8 Apr 2024 21:38:04 +0800 Subject: Re: [PATCH net-next v1 01/12] mm: Move the page fragment allocator from page_alloc into its own file To: Alexander H Duyck , , , CC: , , David Howells , Andrew Morton , References: <20240407130850.19625-1-linyunsheng@huawei.com> <20240407130850.19625-2-linyunsheng@huawei.com> <30a6635dedf305e23e623c501e614e55bca1ab41.camel@gmail.com> From: Yunsheng Lin Message-ID: <6d6a5225-3c4c-7071-7a9b-8b3706cbdeff@huawei.com> Date: Mon, 8 Apr 2024 21:38:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <30a6635dedf305e23e623c501e614e55bca1ab41.camel@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.30.204] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500005.china.huawei.com (7.185.36.74) X-Rspamd-Queue-Id: 2688C1C0011 X-Rspam-User: X-Stat-Signature: fub43gd1y6nft4zhdig73kna17zaciep X-Rspamd-Server: rspam01 X-HE-Tag: 1712583488-594220 X-HE-Meta: U2FsdGVkX19wabOyIjZ4yi4sPULx0vHQScluiYzKqasebXPbF7+3x3aQZ2skm1vcMJrZcwQYbGA5fbb4RPKDfMRsXftcCfdaAkE55ENG6GlQ+kiCrXjVp/McjIXzC0QFWFtBnscrgxKv8GNEYs/69mUSCFEDsxj+46zumQhxS9KyRDnF+OtjqPmfLgZR7lX6wWFTGzmN/COj07JEefaxIYcn0AWvJdqBaQDd3ENgg0fBLOUwNC5J4N3bHLkwsPT80KS41mZAdQAzGOd8gY8+QMTRrT76zjn1mUonHWdmqTw47i7BpwqBQGpCAsNLOMw8guaHqHaiWGeLwuskMIsE8qTZfrMLfs86F2/t7BaesylJZK7WVBtInEiYd6keyNP0jOR1PpMq4tjfN9RnkNRFf8TkHbRfRTs9BgeH0482nvxK8Ze95wgGaaCVIWo6MJFMWs0iAV6/C0gMB3L8B1jVl8yAPGrHmv+JEti2ge9EoFgEXpZ/jUZf6SQ6J4DjB2u0+bRCnShZ7yagVJ/sjX++JUGPqLZE/oWEAT8D+njwiQJI3+qphFAoT5wiZ92KsO/KpKiWUoq0sTzdVj15Euksk3dbqGvRdv9o7pLQi1mxM3QVGrG9tJ0c+93aV5FyXlLTiHuQKnFGGJTp+p8SL0LBU2wziV4Wg4TWziRw+8ktMiI5qHJVis2/3YG8aPLfJge+pEsm/jWLkY0kCcgZQS4lh2KUlqeQLUq/uViUBF1RIK+QroXkJRxgnFY0yjn6oM085ppM8boEligDTEEIc2pb4syQedywcjhwSMkGjEH2GoOsXXztorG5T62hC6+MolEjFXOSnVeEGWG1kuwhL6yQVPFDf5gG8+Xe8GHEnK9ZtOndfSBVNm09bRkNg6osSZiVSaTwVSSKhEY1d/mvvWTnOhO5soccbG1JVn1ViPaLJcuc2cQXKnOHwbtYiiv66ajM+BchyTJia5gEYbQyscA 69CXdRYl EK0QRuiqqX4typDT2PTc7BXHTz5syKs+2fDi73jhVyXmCFjQSU9lVKsSzdEDerBoTkreyU/885QB9jIKXlMqBlIHxtD+FNE9d67S9IATAVN00n0+D89GVy9ob3SDvmVeZKs4M++4+B+V9LD50KICkx7LSq/2J6YyZHcBbnqw0rpNm5yFB+lWpyHopA5OTBYr9zhVDHCz0yqwlgzRjWwbOyVdIFs9pC9yVIB358P/KcHCsz6Bm5xaDguOZ5Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/8 1:42, Alexander H Duyck wrote: > On Sun, 2024-04-07 at 21:08 +0800, Yunsheng Lin wrote: >> Inspired by [1], but use free_unref_page() to replace free_the_page() >> instead of __free_pages(), use VM_BUG_ON() to catch that we can use >> free_unref_page() directly, also add its own header file. > > Instead of doing this all as one patch it would be better to split this > into 2. Make the refactor first, and then move the code. Don't do it > all in one patch. Sure, will split this into 2 patches, thanks.